[Koha-bugs] [Bug 27034] $c->objects->search shouldn't use path parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #45 from Jonathan Druart --- Sorry, found a bug. Merge is broken, there are elements sharing the same id (in this case #merge). To recreate, have 2 open invoices, select them, click merge You get "You must select at least two invoices to merge."... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #44 from Jonathan Druart --- We would have certainly saved time, lines of code, readability and maintainability with only one table and correct filters. [un]select all links are missing, not considering blocker however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22773] Bulk close invoices and filter invoice view (open/closed)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #43 from Jonathan Druart --- Created attachment 116010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116010=edit Bug 22773: Assign different id to checkboxes Otherwise clicking the label does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 --- Comment #8 from Jonathan Druart --- Created attachment 116009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116009=edit Bug 27486: Replace one missing occurrence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mazen.i.khal...@gmail.com |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #13 from Jonathan Druart --- David, can you retry with the last patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27066] Implement Hooks for patron's updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066 Maryse Simard changed: What|Removed |Added Text to go in the||Adds a new plugin hook release notes||`after_patron_action` which ||is called after creation, ||modification or deletion of ||a patron. CC||maryse.sim...@inlibro.com Assignee|koha-b...@lists.koha-commun |maryse.sim...@inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #11 from Jonathan Druart --- This patch is not ready, at least tests are missing. But I really would like to get early feedbacks on it to know if I continue working on it. To understand a bit more the method and how I wrote this patch, I think it may be easier to read the step by step approach I've pushed remotely: https://gitlab.com/joubu/Koha/-/commits/bug_27526_dirty If we all agree it's the way to go, we could then extend the code (and so make it even more flexible) to other areas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27066] Implement Hooks for patron's updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066 --- Comment #3 from Maryse Simard --- Created attachment 116008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116008=edit Bug 27066: Unit tests for after_patron_action hook Adds unit tests for the new hook. To test: prove -v t/db_dependent/Koha/Plugins/Patron.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27066] Implement Hooks for patron's updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066 --- Comment #2 from Maryse Simard --- Created attachment 116007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116007=edit Bug 27066: Add plugin hook after_patron_action The hook is called after patron manipulations. The value of the 'action' parameter can be 'create', 'modify' or 'delete'. To test: 1. Write a simple plugin that implements at least the new after_patron_action hook. 2. Install the plugin and enable it. 3. Create, modify or delete a patron and verify that the plugin method for the hook has been called with the right parameters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What|Removed |Added Blocks||27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Depends on||8976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 [Bug 8976] Default sequence of subfields in cataloguing editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #10 from Jonathan Druart --- Created attachment 116006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116006=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27568] Add "Edit your search"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27568 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27564] Add a hint to patron records that still use the self registration patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27564 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27540] Allow local definition of gender options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #15 from Lucas Gass --- Created attachment 116005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116005=edit Bug 27403: Possible item search fix 1. Submit an item search that will return multiple results. 2. After the results have loaded, click the "Edit search" button. 3. As you scroll down, the toolbar sticks to the top of the browser window but then the table header jumps into view before the table of results has scrolled into view. 4. Apply this patch and try again, the table header should not act weird. 5. Make sure all the dataTable controls still work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #14 from Lucas Gass --- (In reply to Jonathan Druart from comment #12) > Thanks for the follow-up, Owen! > > I have no idea about what's happening on the item search view so I am > suggesting to simply disable fixedHeader on this page. I think why this acts weird is because when you 'Edit search' we show the #item-search-block but the DataTable still thinks it is in the original location even though it has moved down on the page. You can use destory(), I think to make this work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 Lucas Gass changed: What|Removed |Added Attachment #115324|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 116004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116004=edit Bug 27403: (follow-up) Make basket toolbar and table header work together The fixed header option for DataTables does the same thing that the hcSticky jQuery plugin does for us on toolbars, so I've gone through the templates looking for places they might conflict. On the acquisitions basket page we can add a special class, "fh-fixedHeader," to the sticky toolbar to tell DataTables that the table header should float *below* the toolbar. To test, apply the patch and go to Acquisitions. - Locate a vendor and a basket for that vendor with multiple orders. - Adjust the browse window height if necessary to trigger vertical scrolling. - Confirm that as you scroll down the toolbar (with buttons "Add to basket," "Edit basket," etc) sticks to the top of the browser window. - Confirm that as you continue to scroll, the table header sticks below the floating toolbar. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27572] New: Should OpacLocationBranchToDisplay be replaced by table settings?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27572 Bug ID: 27572 Summary: Should OpacLocationBranchToDisplay be replaced by table settings? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The OpacLocationBranchToDisplay system preference essentially serves the purpose of hiding or showing columns in the items table in the record details page on the OPAC, namely the home library column and the current library column. Since we now have Administration > Table settings that we can use to show or hide columns, is this system preference still useful? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27571] "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27571 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27571] New: "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27571 Bug ID: 27571 Summary: "Add to lists" on MARC and ISBD view of OPAC detail page doesn't open in new window Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When adding a record to a list from the MARC or ISBD view, the add to list functionality doesn't open in a new window, but the page is reloaded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #15 from Katrin Fischer --- Hi Tomas, as the current expert on OpacHiddenItems - could you have an additional look here? I did 2 small follow-ups, testing so far everything works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #14 from Katrin Fischer --- Created attachment 116003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116003=edit Bug 18989: (QA follow-up) Have new preference default to current behaviour At the moments the records are hidden when all items are hidden, so we need to make sure that we keep this behaviour when the preference is added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #12 from Katrin Fischer --- Created attachment 116001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116001=edit Bug 18989: Add atomic update Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #13 from Katrin Fischer --- Created attachment 116002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116002=edit Bug 18989: (QA follow-up) Terminology fixes and linking the system preference in pref description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer changed: What|Removed |Added Attachment #109656|0 |1 is obsolete|| Attachment #114738|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 116000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116000=edit Bug 18989: Allow displaying biblios with all items hidden by OpacHiddenItems Bug 10584 made Koha hide biblios for which all items match some criteria (in OpacHiddenItems) so they are hidden. Add syspref OpacHiddenItemsHidesRecord controlling this behaviour. Test plan : 1) 1.1) Create some biblio records with one item having damaged=1 1.2) Define system preference OpacHiddenItems = damaged: 1 2) 2.1) Set system preference OpacHiddenItemsHidesRecord to 'don't hide' 2.2) At OPAC : perform a search showing those records and some more 2.3) Check you see the all the records 2.4) For a record with hidden item check you don't get HTTP 404 for : normal view, ISBD view, MARC view 2.5) Check you can had tags on this record 2.6) Add record to basket, check you see it in basket 3) 3.1) Set system preference OpacHiddenItemsHidesRecord to 'hide' 3.2) At OPAC : perform a search showing those records and some more 3.3) Check you don't see the records with hidden item 3.4) For a record with hidden item check you get HTTP 404 for : normal view, ISBD view, MARC view 3.5) Show basket, check you see the records with hidden item Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26708] Add SQL popup when hovering over name of report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- I wonder if this should not replace the "View" which does the same as the "Preview" now. Is there a reason to keep both? Can you please also adjust the bug description as this has now been solved a little differently than initially suggested? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #115834|0 |1 is obsolete|| --- Comment #13 from wainuiwitikap...@catalyst.net.nz --- Created attachment 115999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115999=edit Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. Signed-off-by: Wainui Witika-Park -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Attachment #115443|0 |1 is obsolete|| --- Comment #12 from wainuiwitikap...@catalyst.net.nz --- Created attachment 115998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115998=edit Bug 27497: Display Koha version in header under logo in staff interface Can be very useful to know on any page of staff interface Koha version. I made a plugin : https://github.com/biblibre/koha-plugin-intranet-version-in-header But seems better to provide a patch. This patch created a new include logo.inc that contains the logo and version, called in all header includes. It adds a div with id "header_logo" to be able to set float on the parent of logo and version. So h1#logo must be replaced in all CSS files. It removes in staff-global.scss rules about h1#logo since they all are in #logo. Test plan: 1) Go to staff interface 2) Check you see Koha version YY.MM.XX under logo 3) Check it is responsive 4) Check it is not displayed when printing home page 4) Check it is not displayed when printing receipt invoice 5) Check all modules home page 6) Check right-to-left display Signed-off-by: Wainui Witika-Park -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27570] New: Allow the ability to alter what a Lost Charge displays for the Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27570 Bug ID: 27570 Summary: Allow the ability to alter what a Lost Charge displays for the Patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A library would like the ability to alter the Lost terminology for their patron's accounting when they are marking something Lost. They had a value of damage to the Lost Status and would like to see Koha bill a patron for a "damaged" book. Currently, Koha will always use the word "Lost" in the Accounting/Fine portion of the patron's record- regardless of what Lost status the library is marking the item as. This could introduce a lot more flexibility when working with libraries and their billing procedures. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27294] Error when deleting claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Owen, I have trouble replicating the bug without the patch. What I do: - Check out item - Claim returned - Resolve - Delete - The issue disappears from the claims list. Watching the console the whole time, there were no errors or warns related to these actions. Can you please double check on current master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi Owen, I am a little confused by the following 2 warnings, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc OK filters FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 50) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 90) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 --- Comment #7 from Katrin Fischer --- Created attachment 115997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115997=edit Bug 27486: (QA follow-up) Fix occurence in aqplan.pl There was another mention of the old system preference name in the budget planning code. This patch replaces it with the new name. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 Katrin Fischer changed: What|Removed |Added Attachment #115742|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 115996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115996=edit Bug 27486: Rename system preference delimiter to CSVDelimiter Test Plan: 1. Go to Administration 2. Go to System Preferences 3. Find 'delimiter' (note the name) 4. Apply patch 5. Repeat step 1 and 2 6. Find 'CSVDelimiter' (note the name) Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 --- Comment #59 from David Cook --- (In reply to Martin Renvoize from comment #58) > Mmmm, I've often wondered that... history.. Though I note that lib seems to > have had a bunch of fixes recently.. so it wasn't perfect.. might be better > now. I think in the past we were using a different library. It was DateTime::Format::DateParse which is super old and unmaintained. DateTime::Format::Strptime, on the other hand, is well maintained. I have an application that deals a lot with time and I love DateTime::Format::Strptime for it heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27487] Rename system preference reviewson to OPACComments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer changed: What|Removed |Added Text to go in the||This renames the existing release notes||system preference ||'reviewson' to ||'OPACComments' which better ||reflects its use. Keywords|Academy |Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27487] Rename system preference reviewson to OPACComments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer changed: What|Removed |Added Attachment #115713|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 115995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115995=edit Bug 27487: Rename system preference reviewson to OPACComments This patch renames the reviewson system pref to OPACComments Test Plan: 1. In Koha Administration, search for the reviewson system preferance 2. Note the presence of the reviewson system preferance 3. Apply the patch and run updatedatabase.pl 4. Repeat steps 1 and 2. The reviewson preferenace should be gone 5. Seach for and note the OPACComments system preferance 6. Ensure that the OPACComments system preferance operates correctly, as if it were reviewson Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=27484 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27487] Rename system preference reviewson to OPACComments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #115988|0 |1 is obsolete|| --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 115994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115994=edit Bug 26298: Don't set too_many_items_to_process if equal to limit In the code we prepare items for display if less than or equal to the pref, but we don't allow the edit if greater than or equal to the pref. The second case should be only 'greater than' To test: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." 8- Apply patch 9- Restart all the things 10- Run the report again and display 1000 rows 11- Click on "Batch operations with 1000 visible records" > Batch item modification 12 - Sucess! Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What|Removed |Added Attachment #115803|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 Martin Renvoize changed: What|Removed |Added Attachment #115804|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 --- Comment #3 from Martin Renvoize --- Created attachment 115993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115993=edit Bug 26272: Add ajax driven cashup modal to library page This patch adds an ajax driven cashup summary modal to the library registers summary page. Test plan 1/ Enable UseCashRegisters in the system preferences 2/ Add at least one cash register to your library 3/ Make some payments of various types (Cash, Card) against the cash register 4/ View the register transactions details page 5/ Make a refund against a payment 6/ Cashup 7/ View the cashup summary by clicking on the 'Summary' link on the register page. 8/ Navigate to the 'libraries' summary page 9/ View the cashup summary by clicking on the 'Summary' link in the registers table. 10/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #5 from Martin Renvoize --- Created attachment 115992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115992=edit Bug 26274: Update register.tt to use the API This patch updates the existing register details page to utilise the new api routes to gather the summary details on demand. Test plan 1/ Enable cash registers 2/ Add some transactions 3/ Perform a cashup 4/ Click 'Summary' next to the last cashup date 5/ Note the modal appears as it did prior to the patch being applied. 6/ Check the print option still works 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 --- Comment #4 from Martin Renvoize --- Created attachment 115991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115991=edit Bug 26274: Add cashups api routes This patch creates a Koha::Cash::Register::Cashup(s) class pair which subclass Koha::Cash::Register::Action(s) and moves the cashup specific code into these new classes to improve code separation. We then introduce API routes based on these classes to allow fetching a list of cashups associated to a cash register and a full cashup with emeddable summary for individual cashups. Test plan 1/ Run the updated unit tests. t/db_dependent/Koha/Cash/Register/Action.t t/db_dependent/Koha/Cash/Register/Cashup.t 2/ Run the incuded api tests. t/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #216 from Tomás Cohen Arazi --- (In reply to Nicolas Legrand from comment #215) > Thank you everyone! We binge watched this one like the trendiest series with > plot twists and cliffhangers. We were hooked like on a soap opera, with > signed off, passed QA and failed QA in places of affairs and divorces. Great > suspense, great results, we're thrilled! Thank you all a lot for this > incredible work! Acquisitions, REST API, rewriting Koha. It's a good mix for a soap opera haha. The cool thing is it didn't end up being just a stand-up :-D. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 115990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115990=edit Bug 23830: Adapt callers This patch is the result of making the same changes we did on the t/db_dependent/AuthorisedValues.t file (replacing the calls to Koha::AuthorisedValues->search with the tricky branchcode param, and call ->search_with_library_limits, with the library_id as a third parameter. What I did was: $ git grep 'Koha::AuthorisedValues\->search' and then revisited each of the grep results to check if they added the 'branchcode' parameter to the filters. This patch changes the calls to ->search, for ->search_with_library_limits in all the places that require it in the current codebase [1]. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Charges/Sales.t \ t/db_dependent/Ill* 3. Verify the batchmod.pl script is working and filtering the authorised values keeps working [1] Some places like the Koha/Template/Plugin/AuthorisedValues.pm plugin don't seem to be tested, at first glance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23830] Koha::AuthorisedValues should use Koha::Objects::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23830 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 115989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115989=edit Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library This patch makes Koha::AuthorisedValues inherit the 'search_with_library_limits' method from Koha::Objects::Limit::Library. This was left out of the original implementation and this patch makes this library have a similar implementation to that of Koha::ItemTypes, etc. To test: 1. Run: $ kshell k$ prove t/db_dependent/AuthorisedValues.t => SUCCESS: Tests pass! 2. Apply this patch 3. Notice Koha::AuthorisedValues now inherits this new library 4. Notice the overloaded ->search method is removed 5. Repeat (1) => SUCCESS: The behavior of the newly used method on the tests is the same as before. We only changed the method name and how we pass the library_id. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #215 from Nicolas Legrand --- Thank you everyone! We binge watched this one like the trendiest series with plot twists and cliffhangers. We were hooked like on a soap opera, with signed off, passed QA and failed QA in places of affairs and divorces. Great suspense, great results, we're thrilled! Thank you all a lot for this incredible work! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26274] Expose cash register cashup summaries via an API route.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Is there a test plan, or some way to test? 8-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Nick Clemens changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Nick Clemens changed: What|Removed |Added Attachment #115047|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Nick Clemens changed: What|Removed |Added Attachment #115085|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Nick Clemens changed: What|Removed |Added Attachment #115084|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27380] Add option for taking a list parameter in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27380 Nick Clemens changed: What|Removed |Added Attachment #115048|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27569] marc-framework import function doesn't accept LibreOffice csv/ods file formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 braun.kami...@web.de changed: What|Removed |Added Severity|blocker |critical Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27569] New: marc-framework import function doesn't accept LibreOffice csv/ods file formats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27569 Bug ID: 27569 Summary: marc-framework import function doesn't accept LibreOffice csv/ods file formats Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: braun.kami...@web.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The biblographic marc-framework import function does not except any of the ods-file format standards (i.e. 1.0/1.1; 1.2; 1.2 extended (compatibility-mode); 1.2 extended) used by LibreOffice. The csv-format stored by LibreOffice is also not usable. This makes the marc-framework export/import functions unusable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 --- Comment #3 from Nick Clemens --- Created attachment 115988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115988=edit Bug 26298: Don't set too_many_items_to_process if equal to limit In the code we prepare items for display if less than or equal to the pref, but we don't allow the edit if greater than or equal to the pref. The second case should be only 'greater than' To test: 1- Set MaxItemsToProcessForBatchMod to 1000 2- Go to Reports 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items) 4- Save and run the report 5- In "Rows per page", choose 1000 6- Click on "Batch operations with 1000 visible records" > Batch item modification 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch." 8- Apply patch 9- Restart all the things 10- Run the report again and display 1000 rows 11- Click on "Batch operations with 1000 visible records" > Batch item modification 12 - Sucess! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall changed: What|Removed |Added Attachment #114142|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 115987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115987=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20238] Show description of ITEMTYPECAT instead of code in itemtypes summary table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20238 David Nind changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21851] Improve style of sidebar forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851 David Nind changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27568] Add "Edit your search"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27568 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27568] New: Add "Edit your search"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27568 Bug ID: 27568 Summary: Add "Edit your search" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: heather_hernan...@nps.gov QA Contact: testo...@bugs.koha-community.org When looking at search results, sometimes one realizes that using the "Refine your search" options aren't ideal, and that it would be best to change some or all of the original search parameters to expand or change the results set. It would be nice to have something like "Edit your search," perhaps on the OPAC between "Home" and "Results of search for '...'" and on the staff client, perhaps to the right of the bread crumbs, "Home > Catalog > Search for ..." This "Edit your search" link could take one to the Advanced Search screen with the previously used search terms/parameters prefilled and ready for easy editing/changing. It would be similar to how it's used on other sites--for example, on alibris.com, if you do this search: https://www.alibris.com/booksearch?mtype=B=shuri+comics=0=0 After looking at the results, you may realize that you really want all the comics written by Nnedi Okorafor, so you can select the link (on the lower left), "Advanced search" which takes you to a pre-filled advanced search screen, and you can easily change "Shuri" to "Okorafor," or edit your search however you'd like, without having to retype what you don't want to retype. Of course, this Alibris example is with a small search set, with small results, but it can be played around with as an example of this function on another site. I'm thinking that this "Edit your search" feature in Koha would be useful when one has constructed a search with a lot of terms, and one or a few of those terms/parameters needs changing, to expand or change the search results without a lot of retyping. (Rather than using facets to narrow down/limit the results.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #214 from Tomás Cohen Arazi --- Thank you all, this was an important piece of teamwork. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #129 from Andrew Isherwood --- Rebased so I can rebase the dependent bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114915|0 |1 is obsolete|| --- Comment #128 from Andrew Isherwood --- Created attachment 115986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115986=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114914|0 |1 is obsolete|| --- Comment #127 from Andrew Isherwood --- Created attachment 115985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115985=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114913|0 |1 is obsolete|| --- Comment #126 from Andrew Isherwood --- Created attachment 115984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115984=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114912|0 |1 is obsolete|| --- Comment #125 from Andrew Isherwood --- Created attachment 115983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115983=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114911|0 |1 is obsolete|| --- Comment #124 from Andrew Isherwood --- Created attachment 115982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115982=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114910|0 |1 is obsolete|| --- Comment #123 from Andrew Isherwood --- Created attachment 115981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115981=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114909|0 |1 is obsolete|| --- Comment #122 from Andrew Isherwood --- Created attachment 115980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115980=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114908|0 |1 is obsolete|| --- Comment #121 from Andrew Isherwood --- Created attachment 115979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115979=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114907|0 |1 is obsolete|| --- Comment #120 from Andrew Isherwood --- Created attachment 115978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115978=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114906|0 |1 is obsolete|| --- Comment #119 from Andrew Isherwood --- Created attachment 115977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115977=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #114905|0 |1 is obsolete|| --- Comment #118 from Andrew Isherwood --- Created attachment 115976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115976=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27566] CSS rule not applying to HTML select / option - displays with serif font ignoring rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 --- Comment #1 from Owen Leonard --- Created attachment 115975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115975=edit Bug 27566: Add generic font family to prevent unstyled select tags This patch adds a default font family "sans-serif" to the OPAC CSS as a workaround for this Firefox bug: font-family isn't honored in `` element within `` dropdown https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the OPAC main page in Firefox. - Click the search type dropdown. The options should be styled using your system's default sans-serif font rather than a serif font. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27566] CSS rule not applying to HTML select / option - displays with serif font ignoring rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27566 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26687] Add a Font Awesome icon for superlibrarian patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26534] Add a Font Awesome icon to help identify staff patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26534 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27440] Improve structure and style of result toolbars in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27440 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27567] New: Cleanup database with --del-exp-selfreg deletes patrons who are guarantors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27567 Bug ID: 27567 Summary: Cleanup database with --del-exp-selfreg deletes patrons who are guarantors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When running cleanup_database.pl with the --del-exp-selfreg flag to delete selfref patrons, Koha will delete a patron who is a guarantor. It should prevent this, as it does when batch deleting patrons from the staff interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26708] Add SQL popup when hovering over name of report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26708 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Barbara Johnson --- I really like this popup for previewing the SQL and that it includes all of the different actions right from the popup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3194] Hide records in the OPAC if all items are lost and "hidelostitems" is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
