[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

   Assignee|charles.far...@inlibro.com  |maryse.sim...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115511|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115509|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115508|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
 Attachment #115506|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115510|0   |1
is obsolete||

--- Comment #245 from Maryse Simard  ---
Created attachment 118559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118559=edit
Bug 17015: Automatically update calendar when creating or deleting a branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115507|0   |1
is obsolete||

--- Comment #244 from Maryse Simard  ---
Created attachment 118558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118558=edit
Bug 17015: When using book drop mode, set check in time as closing hours

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115505|0   |1
is obsolete||

--- Comment #243 from Maryse Simard  ---
Created attachment 118557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118557=edit
Bug 17015: Tests for DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115504|0   |1
is obsolete||

--- Comment #242 from Maryse Simard  ---
Created attachment 118556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118556=edit
Bug 17015: Schema file for new discrete_calendar table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115503|0   |1
is obsolete||

--- Comment #241 from Maryse Simard  ---
Created attachment 118555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118555=edit
Bug 17015: Install scripts for DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #115502|0   |1
is obsolete||

--- Comment #240 from Maryse Simard  ---
Created attachment 118554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118554=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23678] Cancel Holds in bulk

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

--- Comment #11 from Agustín Moyano  ---
(In reply to Barbara Johnson from comment #7)
> Hi Agustín - I tested this and it works great.  However, the functionality
> is tied to cancelling holds on a queue for an individual title.  I actually
> just submitted a bug for that - #27922.
> 
> This bug states that it should allow cancellation of selected holds via
> checkboxes from the 'holds waiting over xx days' tab on waitingreserves.pl. 
> So while the patch works great I don't think it address the original
> intention of this bug.

Hi Barbara, could you please try once again?

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23678] Cancel Holds in bulk

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #118338|0   |1
is obsolete||

--- Comment #10 from Agustín Moyano  ---
Created attachment 118553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118553=edit
Bug 23678: Allow cancel holds in bulk

This patch allows staff patrons to cancel multiple holds in bulk.

To test:
1. Apply this patch
2. restart_all
3. In cataloge go to a book and place many holds
CHECK => Holds table shows a column of checkboxes
4. Play with checkboxes (have some fun ;-P)
CHECK => When you manually check all checkboxes, the checkbox in the
header also gets checked.
  => When you uncheck one of the checkboxes, the one in the header also
gets unchecked.
  => If no checkbox is checked and you check the one in the header,
all checkboxes get checked.
  => If there are some checkboxes that are checked and others are
not, when you click on the checkbox in the header all checkboxes get
unchecked.
  => If all checkboxes are checked, when you uncheck the one in the
header, all checkboxes get unchecked.
  => Every time you play with checkboxes, the number in the button
"Cancel selected" changes.
5. Check some of the checkboxes and click on cancel selected.
SUCCESS => A background job gets fired to cancel all selected holds.
=> A message should appear with a link to the job.
6. Wait a few seconds and click on the link
SUCCESS => A message appears with the report of the execution of the
background job.
7. Grab a patron and search to hold
8. Select multiple biblios and click on "place hold for "
CHECK => After holds are confirmed, multiple holds table are shown.. one for
   each record. Checkboxes work exactly the same as before, but scoped
for each individual table. Checkboxes from one table will not affect
checkboxes from other tables.
9. Repeat steps 4 to 6.
10. Check In some of the items so the get in Waiting state.
11. Update expirationdate os some of those holds and set it to
ReservesMaxPickUpDelay + 1 days earlier
NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update
would be
 => update reserves set expirationdate = date_sub(expirationdate, interval
8 day) where reserve_id in (...)
12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

--- Comment #6 from Heather  ---
(In reply to David Cook from comment #5)
> Actually, in retrospect, could this be handled by a "Borrower Attributes"
> field?

Yes, it certainly could, but if there were a supplied Pronoun field for the
patron to fill in, I think that's a step towards inclusiveness.  In my opinion,
it should be an optional field, but the fact that it would be there--a Pronoun
field to allow free text to be filled in, should the patron feel comfortable
and wish to share their pronouns with library staff--would be a statement about
inclusiveness and respect in the catalog design.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26705] System preference NoticeBcc not working

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26705

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

--- Comment #3 from Michael Kuhn  ---
According to the setting in Koha system preference "NoticeBcc" all
notices should be sent to the given e-mail address. But after the update from
Koha 19.11.05 to 20.11.03 this stopped working and no e-mails to the
BCC-address were created or sent anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

--- Comment #19 from Nick Clemens  ---
Created attachment 118552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118552=edit
Bug 23929: [20.05.x] Invoice adjustments should filter inactive funds

Looking at invoice details, this makes the Adjustments Fund dropdown act
exactly like the Shipping Fund dropdown above, with a Show inactive
checkbox to help filter (by default) the inactive funds out of the list.

Test plan:
0) requires a database with inactive (old) funds along with active ones.
1) Go to invoice details page
2) Click "Add adjustment"
3) Open the drop down beside the Fund label, you should see EVERY fund in
database.
4) Compare with behavior of Shipping fund dropdown above.  Not every fund is
listed there
5) Apply patch
6) Now behavior is the same, only active fund are listed by default.
7) click "Show inactive" checkbox and see all the funds in the dropdown.

Signed-off-by: Sonia BOUIS 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25719] Add system preference for logged in patrons to display only the patron's first name

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25719

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips checks

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28009


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28009
[Bug 28009] Provide better feedback on import
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28009] Provide better feedback on import

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28009

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||27857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857
[Bug 27857] Koha::Patron->extended_attributes skips checks
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28009] New: Provide better feedback on import

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28009

Bug ID: 28009
   Summary: Provide better feedback on import
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There's a FIXME about extended attributes exception handling. With the work
from bug 27857 and friends, we should be able to remove that FIXME and provide
better feedback to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #48 from Nick Clemens  ---
I still don't like that there are columns not tracked. If the full object
cannot be logged, then I would like to see modifications that create no tracked
change are not logged, some of these are confusing:
 - I can change a budget name, or lock/unlock the budget and a modification
with no changes is logged
 - Changing the fund for an order logs a modification but not the change

When receiving an order the bookfund is coming through blank. I am not a huge
fan of the name 'bookfund' - we could be ordering anything here, I would stick
with fund. It looks like this comes from the fact that not changing the fund on
receipt sends the value ""

Several of the reports caused ISEs for me - I tested by simply checking the
action logs full contents

Adding an order to a basket logs a basket modification, but I cannot see what
changes

This is a super cool feature, I just think it needs a bit more to be production
ready

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This development adds
  release notes||parameters to the extended
   ||attributes-related
   ||exceptions. This allows
   ||better handling.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin Somers  ---
Depends on Bug 26274 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28008] New: Patron Clubs Bulk Enrollment

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28008

Bug ID: 28008
   Summary: Patron Clubs Bulk Enrollment
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org

With Patron Clubs, there is not a way to add a group/list/multiple patrons to a
club.  Patrons have to be added individually.

It would be helpful to be able to a list of patrons to a club, and be able to
add patrons to a club from a patron search.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||28005

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27934] Table sorting using title-string option is obsolete

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934

Owen Leonard  changed:

   What|Removed |Added

 Depends on||28007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28007
[Bug 28007] Replace obsolete title-string sorting: Tools templates
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28007] New: Replace obsolete title-string sorting: Tools templates

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28007

Bug ID: 28007
   Summary: Replace obsolete title-string sorting: Tools templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 27934

This patch will modify the following templates to replace the old
"title-string" DataTables sorting method with the built-in method using
"data-order" attributes.

  intranet-tmpl/prog/en/modules/tools/access_files.tt
  intranet-tmpl/prog/en/modules/tools/holidays.tt
  intranet-tmpl/prog/en/modules/tools/inventory.tt
  intranet-tmpl/prog/en/modules/tools/koha-news.tt
  intranet-tmpl/prog/en/modules/tools/letter.tt
  intranet-tmpl/prog/en/modules/tools/modborrowers.tt
  intranet-tmpl/prog/en/modules/tools/problem-reports.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934
[Bug 27934] Table sorting using title-string option is obsolete
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26869] Enable batch record modification to create 952/item on existing bibs

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26869

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27998] Replace obsolete title-string sorting: Serials templates

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998

--- Comment #1 from Owen Leonard  ---
Created attachment 118551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118551=edit
Bug 27998: Replace obsolete title-string sorting: Serials templates

This patch modifies several serials  templates to replace the use of
the "title-string" DataTables sorting method with the newer "data-order"
attribute.

To test, apply the patch and view the following pages to confirm that
columns containing dates sort correctly when using any setting of the
"dateformat" system preference:

- With the Mana service configured in system preferences, go to Serials
  -> New subscription and add a subscription for a bibliographic record
  which will match titles in Mana. In the Mana search results, the "Last
  import" column should sort correctly.
- Serials -> Claims
- Serials -> Search
- Serials -> Subscription details
  - The affected table is "Acquisition details," so your subscription
must have orders associated with it (I eyeballed this change, so
could use extra help testing this area).
- Serials -> Subscription details -> Serial collection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27998] Replace obsolete title-string sorting: Serials templates

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28006] New: Restore "Additional fields" on navigation menu

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28006

Bug ID: 28006
   Summary: Restore "Additional fields" on navigation menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

In previous versions of Koha (at least 18.05) was displayed a link "Add
subscription fields" on the navigation side bar.
It has dispared in Master, probaby because of creation of the "Additional
fields" menu, but it was a useful link for users with the
'manage_additionnal_fields' permission.
It could be great to add it on the Acquisitions module too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #72 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28004] New: Incomplete breadcrumbs in authorized valued

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28004

Bug ID: 28004
   Summary: Incomplete breadcrumbs in authorized valued
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

The 'Authorized values for category xxx' page is missing the current page in
the breadcrumb when the category has no value.

To reproduce :
 - go to a category with at least one value, see the complete breadcrumb "Home
› Administration › Authorized values › Authorized values for category" with
link on the 3 first menus
 - create a new category / go to an empty category ; see the incomplete
breadcrumb "Home › Administration › Authorized values" with link only on the 2
first menus

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|27833   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833
[Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|23666   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666
[Bug 23666] Add API route for additional patron attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27939] Update yarn.lock file

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27939

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Should we backport this ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27858] Make Koha::Patron::Attribute->store raise an exception on invalid type/code

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27858

Martin Renvoize  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27860] Bad KohaAdminEmailAddress breaks patron self registration and password reset feature

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27860

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.04
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #17 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27597] Searching "kw:term" does not work with Elasticsearch

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27597

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.05.00|21.05.00,20.11.04
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #16 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #33 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 118550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118550=edit
Bug 23666: (QA follow-up) Fix wrong required permissions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003

--- Comment #1 from Nick Clemens  ---
Created attachment 118549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118549=edit
Bug 28003: Invoice adjustments using inactive budgets do not indicate that
status

This patch affects the display of existing invoice adjustments to indicate when
using an inactive budget

To recreate
1 - In acquisitions go to a vendor
2 - Click 'Receive'
3 - Create an invoice
4 - Finish receiving
5 - Go to Admin->budgets
6 - Duplicate your current budget
7 - Mark the original budget inactive
8 - View the invoice you created
9 - No indication the budget is inactive
10 - Apply patch
11 - Reload the page
12 - The fund shows '(inactive)'
13 - The dropdown to edit the funds also indicates which funds are inactive

Note that adding new adjustments does show only the active budget unless you
request to see inactive.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28003] Invoice adjustments using inactive budgets do not indicate that status

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28003] New: Invoice adjustments using inactive budgets do not indicate that status

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28003

Bug ID: 28003
   Summary: Invoice adjustments using inactive budgets do not
indicate that status
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

This issue affects library who have nultiple budgets. If a library rolls over
their budget and has duplicated funds when viewing old invoices they adjust
will appear as if they are using the current funds

To recreate
1 - In acquisitions go to a vendor
2 - Click 'Receive'
3 - Create an invoice
4 - Finish receiving
5 - Go to Admin->budgets
6 - Duplicate your current budget
7 - Mark the original budget inactive
8 - View the invoice you created
9 - No indication the budget is inactive

Note that adding new adjustments does show only the active budget unless you
request to see inactive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704

--- Comment #2 from Martin Renvoize  ---
This had completely slipped off my radar until I started digging into similar
message passing for Koha::Account::Line->apply improvements.

So.. I've quickly updated the code here to utilise the Koha::Object::Message
handling code.

CC's Nick and Kyle in case they weren't aware of these improvements to the
Koha::Object system.. I can see them being helpful more widely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704

Martin Renvoize  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704

--- Comment #1 from Martin Renvoize  ---
Created attachment 118548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118548=edit
Bug 26704: Update Koha::Item to use Koha::Object::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #58 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930

--- Comment #7 from Fridolin Somers  ---
Ah but _escape_* methods have been added by Bug 20212 not backported, that why
there is a "stable" patch.
OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||27930


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930
[Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in receiving in acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Hmm, I had a go at rebasing this one.. and it didn't appear too bad.. but my
rebased set had all the unit tests failing.

Going to ask Andrew for a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28001] delete_patrons.pl requires category but does not mention this in POD

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28001

--- Comment #2 from Nick Clemens  ---
(In reply to Magnus Enger from comment #1)
> Is this error triggered if you do a "dry run" (without -c|--confirm)? I have
> been doing some dry runs on 20.05.08 and I have not seen this error.

I believe caused by 27050 - so not affecting 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050

Nick Clemens  changed:

   What|Removed |Added

 Blocks||28001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28001
[Bug 28001] delete_patrons.pl requires category but does not mention this in
POD
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28001] delete_patrons.pl requires category but does not mention this in POD

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28001

Nick Clemens  changed:

   What|Removed |Added

 Depends on||27050


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050
[Bug 27050] Allow multiple category_codes in delete_patrons.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Joonas Kylmälä from comment #13)
> The patch set didn't apply so I had a bit hard time understanding what was
> going on. But now even more reading of the code and the patches from bug
> 27857 which this depends on I see that the deletion of attributes and adding
> of the new ones is all in one transaction in the
> Koha::Patron::extended_attributes() function so actually it works all just
> fine because throwing the exception would trigger the rollback. Sorry for
> the noise.

27833
27858
27857
23666

^^ that's what I have on my branch, in that order.

> > I think I found a place in which is was possible to see the attributes 
> > without much permissions.
> 
> Please let us know if there is such a place. I couldn't find and it would be
> super scary if that was the case because these contain patron specific info
> which should be private (ie. borrowers permission required)!

Yeah, I cannot find that. I thought it was moremember.pl but it isn't.

> Tomás, I'm moving this to assigned?

Yes, I will adjust those permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27930] Move _escape_* functions from acq/parcel.tt to be re-usable

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27930

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
(In reply to Jonathan Druart from comment #5)
> RMaints, I would recommend you to pick this one to anticipate a call to a
> missing function when backporting a patch.

Good point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #73 from Fridolin Somers  ---
New feature not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8426] Map ︡a to a and t︠ to t for searching (Non-ICU)

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #17 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614

Martin Renvoize  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22614] Request migration from one backend to another should not create new request

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22614

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #4 from Martin Renvoize  ---
Still applies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27813] Purchase suggestions should sort by suggesteddate rather than title

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.05.00|21.05.00,20.11.04
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #18 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27815] "Remove" in point of sale untranslatable

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27815

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #5 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #16 from Martin Renvoize  ---
Created attachment 118547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118547=edit
Bug 22435: Fix CREATE offset amounts

Updateing the tests highlighted a mistake in the original code.. the
offsets for the cancel and reduce creation lines were incorrectly
signed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #15 from Martin Renvoize  ---
Created attachment 118546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118546=edit
Bug 22435: Update unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #14 from Martin Renvoize  ---
Created attachment 118545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118545=edit
Bug 22435: ->apply() should always use 'APPLY' for offset_type

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #13 from Martin Renvoize  ---
Created attachment 118544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118544=edit
Bug 22435: Add 'APPLY' to account_offset_types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #12 from Martin Renvoize  ---
Created attachment 118543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118543=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account::Line

This patch updates the Koha::Account::Line methods that result in new account
lines to use the 'CREATE' offset type for the creation record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #11 from Martin Renvoize  ---
Created attachment 118542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118542=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account

This patch updates the Koha::Account methods for adding debits and
credits to use the 'CREATE' offset type for the creation record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #10 from Martin Renvoize  ---
Created attachment 118541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118541=edit
Bug 22435: Update CREATE offset types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #13 from Joonas Kylmälä  ---
The patch set didn't apply so I had a bit hard time understanding what was
going on. But now even more reading of the code and the patches from bug 27857
which this depends on I see that the deletion of attributes and adding of the
new ones is all in one transaction in the Koha::Patron::extended_attributes()
function so actually it works all just fine because throwing the exception
would trigger the rollback. Sorry for the noise.

> I think I found a place in which is was possible to see the attributes 
> without much permissions.

Please let us know if there is such a place. I couldn't find and it would be
super scary if that was the case because these contain patron specific info
which should be private (ie. borrowers permission required)!

Tomás, I'm moving this to assigned?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28001] delete_patrons.pl requires category but does not mention this in POD

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28001

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #1 from Magnus Enger  ---
Is this error triggered if you do a "dry run" (without -c|--confirm)? I have
been doing some dry runs on 20.05.08 and I have not seen this error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #12 from Tomás Cohen Arazi  ---
(In reply to Joonas Kylmälä from comment #10)
> (In reply to Joonas Kylmälä from comment #9)
> > I noticed there is no update() function for patron attribute. This would be
> > useful in case there is mandatory attributes defined for patrons. Now having
> > to use the overwrite method adds additional processing for the client a)
> > they need to download all attributes and then b) upload all of them
> > modified. I think it is not a blocker however, just a note that we should
> > implement it in future.
> 
> Actually, we cannot user overwrite() even for changing those attributes that
> are mandatory because the code deletes first all the attributes and then
> re-adds them! This also showed that we have no exception thrown when trying
> to delete mandatory attribute.

Good point. But worth its own bug. This is mostly a controller method calling
underlying implementations. Maybe this overwrite all route is not worth in the
end, as it is replicating some current behavior (in the forms, passing all the
attributes back and forth). The solution is to expose a PUT method.

I will add a PUT for individual attributes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Joonas Kylmälä from comment #8)
> Comment on attachment 118509 [details] [review]
> Bug 23666: Add spec
> 
> Review of attachment 118509 [details] [review]:
> -
> 
> ::: api/v1/swagger/paths/patrons_extended_attributes.json
> @@ +78,5 @@
> > +}
> > +  },
> > +  "x-koha-authorization": {
> > +"permissions": {
> > +  "catalogue": "1"
> 
> Shouldn't this be borrowers ?

I don't remember now why I picked just staff access (catalogue). You are
probably right. I think I found a place in which is was possible to see the
attributes without much permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #9 from Fridolin Somers  ---
Small useful enhancement, I choose to backport.

Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #10 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #9)
> I noticed there is no update() function for patron attribute. This would be
> useful in case there is mandatory attributes defined for patrons. Now having
> to use the overwrite method adds additional processing for the client a)
> they need to download all attributes and then b) upload all of them
> modified. I think it is not a blocker however, just a note that we should
> implement it in future.

Actually, we cannot user overwrite() even for changing those attributes that
are mandatory because the code deletes first all the attributes and then
re-adds them! This also showed that we have no exception thrown when trying to
delete mandatory attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin Somers  ---
Even if it is sort of a bug, I prefer not backport this change of behavior to
stable 20.11.x.

Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

--- Comment #2 from Martin Renvoize  ---
Created attachment 118540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118540=edit
Bug 27993: Add handling for datecancelled in in_transit

This patch adds handling for the datecancelled field in the in_transit
method.

Test plan
1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27993] Koha::Item::Transfer->in_transit should not count cancelled transfers

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27993

--- Comment #1 from Martin Renvoize  ---
Created attachment 118539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118539=edit
Bug 27993: Add unit tests

This patch adds a unit test to check that 'in_transit' takes
datecancelled into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27652] Offer selections for preferences which ask for patron categories

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27652

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #13 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27766] Hide expired news items by default

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27766

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
I like that.

Should we consider backport to 20.11.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #9 from Joonas Kylmälä  ---
I noticed there is no update() function for patron attribute. This would be
useful in case there is mandatory attributes defined for patrons. Now having to
use the overwrite method adds additional processing for the client a) they need
to download all attributes and then b) upload all of them modified. I think it
is not a blocker however, just a note that we should implement it in future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27751] Phase out jquery.cookie.js: Batch item modifications

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27751

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27699] Add cash register information to responsive staff interface header menu

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27699

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27999] Display the description of authorized values category

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27999

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Séverine Queune  ---
Looks great for me, thanks Owen !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27999] Display the description of authorized values category

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27999

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #118537|0   |1
is obsolete||

--- Comment #3 from PTFS Europe Sandboxes  ---
Created attachment 118538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118538=edit
Bug 27999: Display the description of authorized values category

This patch corrects a parameter in the authorized values template so
that the right value is passed for displaying the description of an
authorized value category.

To test, apply the patch and go to Administration -> Authorized values.

- In the table of authorized values, click on one which has a
  description in the "Description" column.
- On the page titled "Authorized values for category XXX," you should
  see that description under the heading.
- Use the "Show category" dropdown to try some other categories.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #8 from Joonas Kylmälä  ---
Comment on attachment 118509
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118509
Bug 23666: Add spec

Review of attachment 118509:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23666=118509)
-

::: api/v1/swagger/paths/patrons_extended_attributes.json
@@ +78,5 @@
> +}
> +  },
> +  "x-koha-authorization": {
> +"permissions": {
> +  "catalogue": "1"

Shouldn't this be borrowers ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27855] Allow embedding extended_attributes on /patrons routes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27855

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002
[Bug 28002] Add optional extended_attributes param to POST /patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2021-03-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28002
[Bug 28002] Add optional extended_attributes param to POST /patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >