[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #84 from Tomás Cohen Arazi --- The following failures remain: - t/db_dependent/Circulation.t - t/db_dependent/Reserves.t I'm too sleepy to continue. Bug 28744 is related to id => hold_id. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #83 from Tomás Cohen Arazi --- Created attachment 123080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123080=edit Bug 25260: (follow-up) Remove warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 123079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123079=edit Bug 25260: (QA follow-up) Rename id => hold_id The guidelines clearly specify this is how the primary key needs to be named. https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL7:_Primary_keys Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 123078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123078=edit Bug 25260: ILSDI is tied to old DB structure for holds Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 123077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123077=edit Bug 25260: (QA follow-up) Fix any bad dates prior to migration Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 123076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123076=edit Bug 25260: Adapt all the things This patch adapts many pm and test files to work with unified holds table. To test: 1. Remove all previous holds in reserves and old_reserves tables. 2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and another in transit. CHECK => "select reserve_id, found from reserves" query in mysql should return 3 rows, where in found column should find 'W', 'T' and another with null values. => "select reserve_id, found from old_reserves" query in mysql should return 3 rows, where in found column you should find 2 with 'C', and one with 'F' values. 3. in mysql change reserve_id to the value of a hold in reserve table. 4. apply patches 5. updatedatabase SUCCESS => you should get the following warning "There were 1 old reserves that could not be moved, please check '_old_reserves'" => "select id, status, completed from holds" query in mysql should return 5 rows. => The hold that had null value in found column, now should have 'placed' status and 0 in completed. => The one that had 'W' in found column, now should have 'waiting' status and 0 in completed. => The one that had 'T' in found column, now should have 'in_transit' status and 0 in completed. => The one that had 'F' in found column, now should have 'fulfilled' status and 1 in completed. => The unmodified cancelled hold, now should have 'cancelled' status and 1 in completed. => "select * from _old_reserves" should give you one row with the modified hold. 6. in staff interface create, cancel, modify priorities, etc and everything should work exactly as before. # Run every test that has reserve and hold word wihtin # check that you are in main koha directory # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL environment variables # check plack is up and running.. tests will use selenium # prepare yourself a mug of coffe/te or take a nap.. this will take a while 7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$") # finally 8. Sign off Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 123075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123075=edit Bug 25260: Sane TestBuilder defaults This patch sets some sane defaults for TestBuilder. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 123074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123074=edit Bug 25260: Schema files Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 123073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123073=edit Bug 25260: Adapt Koha::Hold(s) The new table structure aligns the 'holds' table with the terminology that's been agreed, and also makes some design changes, like having an ENUM status field, that cover all the current options for the hold lifecycle. This requires changing the Koha::Hold(s) classes to this new situation. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 123072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123072=edit Bug 25260: Add a 'holds' table This patch introduces a new table for holds. It also creates views for reseves and oldreserves to retain the current behaviour. This views will not be used in the codebase, but kept for backwards compatibility in reports. Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 123071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123071=edit Bug 25260: Atomic update Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122983|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122982|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122981|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122980|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122979|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122978|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122977|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Tomás Cohen Arazi changed: What|Removed |Added CC||da...@davidnind.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 123070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123070=edit Bug 28744: Better handling of undefined to_api_mapping We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. This patch makes a small change so this method always returns an empty hashref. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Test fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123069=edit Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25260 Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] New: Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Bug ID: 28744 Summary: Class with empty/no to_api_mapping should generate an empty from_api_mapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28737] Unwanted and Mandatory borrower fields should be enforced consistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28737 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24342] Self check needs on screen keyboard for login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Owen Leonard from comment #1) > Isn't this a hardware/OS issue? Sounds like it to me -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which library can edit a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- The title of this report doesn't make sense. Bibliographic records don't belong to library branches. Also, blocking based on homebranch of items that belong to the record doesn't make sense. You'd block modifications of bib records as soon as an item is added for another branch. Branch A might add the bib record, but then if Branch B adds an item, Branch A won't be able to edit the bib record that they added. I could see that being frustrating. But I can also see it being frustrating to have a different branch change a bib record that you're using. Hmm... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15516 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15565 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28742] OAI.xslt has hardcoded metadataPrefix = oai_dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Michael Hafen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #1 from Michael Hafen --- Created attachment 123068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123068=edit Proposed fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which library can edit a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Michael Hafen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28743 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Michael Hafen changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10263 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] New: With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Bug ID: 28743 Summary: With IndependentBranches block changes to biblio records shared with other libraries Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: michael.ha...@washk12.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24342] Self check needs on screen keyboard for login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 Hannah Co changed: What|Removed |Added CC||hannah...@northwestu.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #19 from Aleisha Amohia --- Created attachment 123067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123067=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266
--- Comment #18 from Aleisha Amohia ---
(In reply to Martin Renvoize from comment #17)
> Comment on attachment 123026 [details] [review]
> Bug 27266: Move GetMarcAuthors to Koha namespace
>
> Review of attachment 123026 [details] [review]:
> -
>
> ::: Koha/Biblio.pm
> @@ +870,5 @@
> > +# tagslib useful only for UNIMARC author responsibilities
> > +my $tagslib;
> > +if ( $marcflavour eq "UNIMARC" ) {
> > +# FIXME : we don't have the framework available, we take the
> > default framework. May be buggy on some setups, will be usually correct.
> > +$tagslib = C4::Biblio::GetMarcStructure( 1, '', { unsafe => 1 });
>
> I wonder if we aught to fix the FIXME here?
>
> $tagslib = C4::Biblio::GetMarcStructure( 1, $self->frameworkcode, { unsafe
> => 1 });
True, may as well. Follow-up on it's way.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 David Nind changed: What|Removed |Added Attachment #123063|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 123066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123066=edit Bug 28741: Fix use of resumption token params TO test: 1 - Enable OAI-PMH server in Koha 2 - Set OAI-PMH:MaxCount to 5 3 - Define 6 sets in Admin->OAI sets configuration Can setSpec and setName to 1,2,3 4 - Browse to: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets 5 - Click 'Show more' 6 - Keep seeing the same 5 - note the page says 'Results fetched -4-0' 7 - Apply patch 8 - Restart all the things 9 - Reload the ListSets URL above 10 - Click 'Show more' 11 - See the 6th set and note no 'Show more' 12 - Set OAI-PMH:MaxCount to 1 13 - Go to the base ListSets url again 14 - Confirm you can 'Show more' until you reach the end Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|21.11.00,21.05.02,20.11.08 |21.11.00,21.05.02,20.11.08, released in||20.05.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.11.00,21.05.02,20.11.08 |21.11.00,21.05.02,20.11.08, released in||20.05.14 --- Comment #10 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123064|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123065=edit Bug 28733: Correct position of desks link in admin menu This patch moves the "Desks" link from the "Basic parameters" section to the "Patrons and circulation" section, matching the category of the link on the Administration home page. To test, apply the patch and go to an administration page which includes the left-hand navigation sidebar, e.g. Administration -> Libraries. In the sidebar, the "Desks" link should be in the "Patrons and circulation" section, under "Item circulation alterts," matching its position on the Administration home page. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 --- Comment #1 from Owen Leonard --- Created attachment 123064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123064=edit Bug 28733: Correct position of desks link in admin menu This patch moves the "Desks" link from the "Basic parameters" section to the "Patrons and circulation" section, matching the category of the link on the Administration home page. To test, apply the patch and go to an administration page which includes the left-hand navigation sidebar, e.g. Administration -> Libraries. In the sidebar, the "Desks" link should be in the "Patrons and circulation" section, under "Item circulation alterts," matching its position on the Administration home page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Component|Staff Client|Templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738
--- Comment #5 from Katrin Fischer ---
OK, adding another parentNode here, seems to do the trick:
var subfields =
whichfield.parentNode.parentNode.parentNode.getElementsByTagName('input');
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Nick Clemens changed: What|Removed |Added Blocks||28742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742 [Bug 28742] OAI.xslt has hardcoded metadataPrefix = oai_dc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28742] OAI.xslt has hardcoded metadataPrefix = oai_dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742 Nick Clemens changed: What|Removed |Added Depends on||15527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 [Bug 15527] OAI-PMH should have a stylesheet to aid usability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28742] OAI.xslt has hardcoded metadataPrefix = oai_dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi, ||tomasco...@gmail.com Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28742] New: OAI.xslt has hardcoded metadataPrefix = oai_dc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28742 Bug ID: 28742 Summary: OAI.xslt has hardcoded metadataPrefix = oai_dc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When viewing the pages on the web there are many places where oai_dc is hardcoded - there should be an option in config/sets for the default prefix to use in the template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Nick Clemens changed: What|Removed |Added Blocks||28741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 [Bug 28741] OAI ListSets does not correctly build resumption token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi, ||tomasco...@gmail.com Assignee|oleon...@myacpl.org |n...@bywatersolutions.com Depends on||27584 --- Comment #2 from Nick Clemens --- Caused by bug 27584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 [Bug 27584] Improve OAI-PMH provider performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 --- Comment #1 from Nick Clemens --- Created attachment 123063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123063=edit Bug 28741: Fix use of resumption token params TO test: 1 - Enable OAI-PMH server in Koha 2 - Set OAI-PMH:MaxCount to 5 3 - Define 6 sets in Admin->OAI sets configuration Can setSpec and setName to 1,2,3 4 - Browse to: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets 5 - Click 'Show more' 6 - Keep seeing the same 5 - note the page says 'Results fetched -4-0' 7 - Apply patch 8 - Restart all the things 9 - Reload the ListSets URL above 10 - Click 'Show more' 11 - See the 6th set and note no 'Show more' 12 - Set OAI-PMH:MaxCount to 1 13 - Go to the base ListSets url again 14 - Confirm you can 'Show more' until you reach the end -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28741] New: OAI ListSets does not correctly build resumption token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28741 Bug ID: 28741 Summary: OAI ListSets does not correctly build resumption token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If you perform a list sets, you always get a resumption token, and it points to the same url always: http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets Turns out we are sending the wrong params to build the token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #174 from Joonas Kylmälä --- I also get the following test failure: > root@kohadevbox:koha(master)$ prove t/db_dependent/Koha/Item.t > t/db_dependent/Koha/Item.t .. # No tests run! > t/db_dependent/Koha/Item.t .. 1/12 > # Failed test 'No tests run for subtest "tracked_links relationship"' > # at t/db_dependent/Koha/Item.t line 56. > Can't locate object method "_new_from_dbic" via package "Koha::TrackedLinks" > (perhaps you forgot to load "Koha::TrackedLinks"?) at > /kohadevbox/koha/Koha/Item.pm line 1220. > # Looks like your test exited with 255 just after 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 --- Comment #4 from Katrin Fischer --- I fixed the JavaScript error, but still no luck. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28740] New: Delete old ILL requests with cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28740 Bug ID: 28740 Summary: Delete old ILL requests with cleanup_database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz, tomasco...@gmail.com We should teach cleanup_database to delete old ILL requests after a given period. Over in bug 23391, we introduced a syspref in which one can define statuses for which to hide ILL requests. Following that same idea of allowing whatever statuses a given back-end may use, the cron should take a number of days and a status and delete any request with that status that is more than that many days old. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Joonas Kylmälä changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #173 from Joonas Kylmälä --- Koha::Items::move_to_biblio only re-indexing the last item's biblio and not all of them, this was not spotted probably in testing because all the items were in the same biblio. Working on a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #73 from Jonathan Druart --- (In reply to Jonathan Druart from comment #72) > % git grep -c '_on`' installer/data/mysql/kohastructure.sql > installer/data/mysql/kohastructure.sql:29 > % git grep -c '_date`' installer/data/mysql/kohastructure.sql > installer/data/mysql/kohastructure.sql:4 git grep -c 'date`' installer/data/mysql/kohastructure.sql [17:35:36] installer/data/mysql/kohastructure.sql:65 ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #72 from Jonathan Druart --- % git grep -c '_on`' installer/data/mysql/kohastructure.sql installer/data/mysql/kohastructure.sql:29 % git grep -c '_date`' installer/data/mysql/kohastructure.sql installer/data/mysql/kohastructure.sql:4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #71 from Jonathan Druart --- From 2015, bug 10459 from comment 30. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #70 from Jonathan Druart --- > my vote would be for 'action_date' as opposed to 'action_on' Well, ok but we need to be consistent over the years :D I am pretty sure we all agreed on *_on when we discussed it and we have been enforcing this rule for a couple of years already :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738
--- Comment #3 from Katrin Fischer ---
There is a syntax error in the plugin pop up shown in the console:
Uncaught SyntaxError: expected expression, got '%'
function finish() {
opener.document.f.field_value[[ % index % ]].value =
document.f_pop.result.value;
self.close();
return false;
}
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 --- Comment #2 from Katrin Fischer --- Ok, another revelation: If I like it to $a and there is an author, the author will be filled in. But $t with the title remains empty. So the issue appears to be related to filling in multiple subfields from one plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 --- Comment #1 from Katrin Fischer --- Sometimes the additional window closes, but no information is transferred to the framework fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #172 from Martin Renvoize --- Thanks for catching that Joonas :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28738] New: Value builder marc21_linking_section.pl for creating 77x is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28738 Bug ID: 28738 Summary: Value builder marc21_linking_section.pl for creating 77x is broken Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl This is quite a neat plugin to create links between records that usually works on all 7xx. But in latest 20.11 (and possibly higher up as my research turned up no changes), this is broken. To test: * link marc21_linking_section.pl as value builder to 773 a or another 77x subfield. * Make sure some of the important subfields like a, t, w, etc. are visible in your framework * Create a new record within that framework within the standard editor * Look for your 7xx subfield with the plugin and click the plugin icon * Search for the record to link * Click on choose * Verify a new window opens and the subfields are not filled in the framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.08 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Victor Grousset/tuxayo --- Hi, Fridolin impostor here: Backported: Pushed to 20.11.x branch for 20.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|21.11.00,21.05.02 |21.11.00,21.05.02,20.11.08 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Victor Grousset/tuxayo --- Hi, Fridolin impostor here. Backported: Pushed to 20.11.x branch for 20.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #171 from Joonas Kylmälä --- Created attachment 123062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123062=edit Bug 22690: (QA follow-up) Correct variable name The $from_biblio variable name doesn't exists after a refactoring that happened. Here we need to re-index both the $self biblio and $to_biblio biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Joonas Kylmälä changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #170 from Joonas Kylmälä --- In Koha::Items::move_to_biblio the variable $from_biblio should be $to_biblio, now it produces error because there is no such variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #520 from Joonas Kylmälä --- Created attachment 123061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123061=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #519 from Joonas Kylmälä --- Created attachment 123060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123060=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #518 from Joonas Kylmälä --- Created attachment 123059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123059=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #517 from Joonas Kylmälä --- Created attachment 123058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123058=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #516 from Joonas Kylmälä --- Created attachment 123057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123057=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #515 from Joonas Kylmälä --- Created attachment 123056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123056=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä changed: What|Removed |Added Attachment #123048|0 |1 is obsolete|| Attachment #123049|0 |1 is obsolete|| Attachment #123050|0 |1 is obsolete|| Attachment #123051|0 |1 is obsolete|| Attachment #123052|0 |1 is obsolete|| Attachment #123053|0 |1 is obsolete|| Attachment #123054|0 |1 is obsolete|| --- Comment #514 from Joonas Kylmälä --- Created attachment 123055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123055=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #513 from Joonas Kylmälä --- Created attachment 123054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123054=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #512 from Joonas Kylmälä --- Created attachment 123053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123053=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #511 from Joonas Kylmälä --- Created attachment 123052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123052=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #510 from Joonas Kylmälä --- Created attachment 123051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123051=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #509 from Joonas Kylmälä --- Created attachment 123050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123050=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #508 from Joonas Kylmälä --- Created attachment 123049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123049=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #507 from Joonas Kylmälä --- Created attachment 123048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123048=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä changed: What|Removed |Added Attachment #123047|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä changed: What|Removed |Added Attachment #122891|0 |1 is obsolete|| Attachment #122892|0 |1 is obsolete|| Attachment #122893|0 |1 is obsolete|| Attachment #122894|0 |1 is obsolete|| Attachment #122895|0 |1 is obsolete|| Attachment #122896|0 |1 is obsolete|| Attachment #122897|0 |1 is obsolete|| --- Comment #506 from Joonas Kylmälä --- Created attachment 123047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123047=edit Bug 22690: (QA follow-up) Add TrackedLink classes and use them This patch adds Koha::TrackedLink(s) classes based on Koha::Object(s) and then adds the relationship accessor to Koha::Item and uses it within the move_to_biblio method. Tests for new relationship also added to t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #69 from Martin Renvoize --- I can't find a guideline for DB field names (other than the tablename_id one.. which I wasn't aware of before.. I far prefer just 'id' for primary key and 'tablename_id' for relations.. as for me that makes it much clearer (and it makes dbic much happier when auto-building schema's.. you don't end up with a relation that has the same name as the field accessor). I kinda like the idea of sticking to the API field guidelines for new tables where we can.. but I'm not hugely worried.. I just think it's clearer if we can be consistent as much as possible: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4:_mapping So.. my vote would be for 'action_date' as opposed to 'action_on'.. and perhaps adding a DB Guidelines to say 'Where creating new, DB fields should match the API field name guidelines' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #32 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #31) > (In reply to Martin Renvoize from comment #29) > > Well.. I deliberately didn't set it as a hard dependency yet.. the follow-up > > was meant as a hint to where we might want to go with this having discussed > > it with Tomas :). > > Still seems to me that the idea of Agustin on its own is simpler. Perhaps it > needs a bit of attention (checks). But adding a credit and let the cronjob > reconcile the balance somehow, whats actually wrong with that? Seems that what I implemented did not took into account some cases, for example, what happens when a patron pays a part of what was owed. Besides, it seems reasonable for the logic of adding a credit to be inside of cancel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
