[Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #123404|0 |1
is obsolete||
--- Comment #4 from Victor Grousset/tuxayo ---
Created attachment 123985
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123985=edit
Bug 28736: fix requirements for the correct error message to show up
There is existing error message in the code stating:
"Unable to understand your search query, please rephrase and try again."
which fits perfectly but because it looks for "ParseException" in the
warning output it doesn't show up on this page as it's actually
"parse_exception".
This patch makes that it's also checked if "parse_exception" is present
in the warning output.
To reproduce:
1) using ES search for something like "// ^ ! { } [ ] .. , <>" that
will for sure break the syntax of ES.
2) after the search query fails note that the error is
"Unable to perform your search. Please try again."
3) apply the patch
4) search for the same thing again
5) error message should be "Unable to understand your search query,
please rephrase and try again." now.
Signed-off-by: David Nind
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #70 from Victor Grousset/tuxayo --- (In reply to Andrew Nugged from comment #61) > Victor, please can you again give-this-a-go? > i.e. Re-Sign-off this ticket again according to that so we now might have > proper "error messages" for the wrong syntax in ES requests (bug 28736), if > that comforts you? test result: my signoffs still hold on top of bug 28736 :) Last two patches still not tested. - I don't know how QueryRegexEscapeOptions works - comment 41 about the last patch But thanks to Alex we have these covered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #69 from Victor Grousset/tuxayo --- (In reply to Peter Vashchuk from comment #58) > I think search query like that should never work as it will always cause ES > syntax error, ElasticSearch is a mini-language after all and has it's own > syntax and it will die on something like that. Yes it makes sense. > Though we do need to notify the user, in cases like that, that the search > query is incorrect and that they need to correct it and search with it > again. I will make a ticket for it a bit later if. Thanks for bug 28736 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 --- Comment #5 from Fridolin Somers --- There is a strange thing in the patch. Some blocks are moving (for example field Heading). Looks like the export sorts by MARC type marc21->unimarc->normarc. But for me export sorts by MARC type alphabetical : marc21->normarc->unimarc. This is in patch : Bug 23204: Fix ordering of fields in exported file o_O -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #6 from Hannah Co --- I don't believe this patch catches items in "processing" that should end up with no shelving location. I have a freshly updated 21.05, with this patch included. My system pref UpdateItemLocationOnCheckin contains "PROC: _PERM_". Check-in does not make any changes to a record with "PROC" location and no other shelving location assigned. New items are automatically created with location AND permanent_location both set as PROC. It seems that "PROC" and "CART" should never populate permanent_location. Can we prevent "PROC" from populating the permanent_location? Or, can we handle the situation where "PROC" exists in both permanent_location AND location, so the location is completely removed and replaced with NULL? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What|Removed |Added Attachment #123870|0 |1 is obsolete|| --- Comment #7 from Fridolin Somers --- Created attachment 123984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123984=edit Bug 28149: (follow-up) Add string for job status "new" Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149
Fridolin Somers changed:
What|Removed |Added
Attachment #123672|0 |1
is obsolete||
--- Comment #6 from Fridolin Somers ---
Created attachment 123983
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123983=edit
Bug 28149: Improve internationalization and formatting on background jobs page
This patch adds some logic to the background jobs template in order to
make job status and job type translatable. Output of dates has been
changed to use the KohaDates plugin, using the "with_hours" flag.
This patch also modifies the page title and breadcrumbs so that if one
is viewing the details of a background job the page title and
breadcrumbs reflect this.
I've also added inclusion of the preferences search form in the header,
the default for administration pages which don't have their own search.
To test, apply the patch and go to Administration -> Background jobs.
- If there are no background jobs listed, submit at least one batch of
bibliograhpic records and at least one batch of authorty records for
modification (Tools -> Batch record modification).
- In the table of background jobs, the status should be shown
correctly. If you see it capitalized ("Finished") you're seeing the
new string in the template which will be used for translation.
- In the "Type" column, you should see either "Batch authority record
modification" or "Batch bibliographic record modification"
- In the "Queued," "Started," and "Ended" columns the date should be
formatted according to your system's dateformat system preference,
including the time.
- View the details of a background job. The same changes to status and
type should be seen on this page, as well as the date formatting of
the date fields.
- In the breadcrumbs, confirm that it shows a link to the
background jobs page followed by "Details if job #X".
Signed-off-by: Fridolin Somers
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28149] Improve internationalization and formatting on background jobs page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > How do you recreate that? Is it a random failure? Good question. I haven't removed any plugins for a long time, so I'm not sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28868] Masthead.inc is missing class name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Bug 28679 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28193] OpacLoginInstructions news block broken by Bug 20168
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Bug 28193 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27881] Markup error in masthead-langmenu.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug 27881 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27200] "Browse search" is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Bug 27200 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Bug 27072 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26810] OpacCustomSearch is no longer a system preference, we must use the template variable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810 Bug 26810 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26758] Correct OPAC ILL requests page markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758 Bug 26758 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26752] OPAC list download button broken by Bootstrap 4 upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Bug 26752 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26735] Overdrive login modal broken in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26735 Bug 26735 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26749] Correct dropdown markup in OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749 Bug 26749 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26720] OPAC lists - button display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26720 Bug 26720 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Bug 26665 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26519] Clean up OPAC buttons with incorrect classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519 Bug 26519 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26505] Suspend hold modal broken in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26505 Bug 26505 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26512] Display issue with buttons for OPAC checkout note
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512 Bug 26512 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26478] Display issue with buttons on the self checkout screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26478 Bug 26478 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26465] Generated RTL CSS files should be committed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26465 Bug 26465 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26419] Replace OPAC Koha logo with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26419 Bug 26419 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26164] Replace OPAC table sort icons with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26164 Bug 26164 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25775] Add DataTables controls to user's checkouts table in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775 Bug 25775 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771 Bug 25771 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28868] Masthead.inc is missing class name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868 Bug 28868 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27814] Improve responsive behavior of the user page in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814 Bug 27814 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27545] NewItemsDefaultLocation is only used from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27545 Hannah Co changed: What|Removed |Added CC||hannah...@northwestu.edu --- Comment #11 from Hannah Co --- Edit Item adds the NewItemsDefaultLocation, if the existing item has a blank shelving location. Our library expects that the Edit Item function would preserve the blank shelving location, while Add Item would fill in NewItemsDefaultLocation. Is filling in NewItemsDefaultLocation expected on item edit, or does the editing behavior need to be reviewed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123966|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 123982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123982=edit Bug 28832: Don't batch modify fields that we don't update In bug 27837 we made sure to always pass through the permanent_location if it was passed in unlike other fields which are not passed if they have no value. During batch mod, however, fields that aren't editied have no value, so forcing permanent_location to pass through forces blanking it. This patch alters the script to only pass thgouhr for edit the fields that have been updated or cleared. To test: 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor 2 - In mappings map that subfield to items.permanent_location 3 - Set an item to have differing shelving location and permanent_location 4 - This saves correctly for an individual item 5 - Edit the item using Tools->batch item modification, updating the note field 6 - Note the permanet_location is removed 7 - Check the DB, the field is set to NULL 8 - Apply patch 9 - Repeat 10 - Permanent location is not cleared 11 - Verify that clearing fields works as before, including permanent_location Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Deb Stephenson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||dstep...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What|Removed |Added Attachment #123977|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 123981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123981=edit Bug 28883: Make Koha::Objects->_new_from_dbic honour list context This patch makes the _new_from_dbic method return a list in list context. It does so by leveraging on the existing Koha::Objects->_wrap internal method that _does the right thing_. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Boo! Tests fail! The list is not empty, and it contains... a resultset intead of empty or individual items. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Things work as expected! 5. Run: k$ probe t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! It uses the chaining: $biblio->items->as_list and doesn't break. It implies that the change won't break any Koha place in which ->as_list is being used on a resultset created by _new_from_dbic 6. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What|Removed |Added Attachment #123976|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 123980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123980=edit Bug 28883: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 David Nind changed: What|Removed |Added Attachment #123969|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 123979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123979=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28888] New: Add option for field to include with export.pl tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Bug ID: 2 Summary: Add option for field to include with export.pl tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: bibli...@gmail.com QA Contact: testo...@bugs.koha-community.org The current tool includes an option, "Don't export fields". There are over 200 MARC fields, and perhaps 20-25 that are heavily used. So I think it would be far more useful to be able to specify which specific fields to *include* when exporting records. Lately, for example, we've wanted to export records w/ just a handful of fields (leader, title, author, isbn, etc.) Propose a new option, "Fields to include". Thank you, Cab Vinton Plaistow Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 --- Comment #1 from Kyle M Hall --- Created attachment 123978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123978=edit Bug 28885: Skip invalid biblios for OpacBrowseResults If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. Test Plan: 1) Use zebra for searching 2) Disable koha-indexer 3) Enable OpacBrowseResults 4) Perform a search 5) Delete an item in the search results 6) View on of the remaining items in the search results 7) Note the error 8) Apply this patch 9) Restart plack 10) Reload the page 11) The error should be gone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28887] Enhance ILL request creation / display to extend functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28887 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28887] New: Enhance ILL request creation / display to extend functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28887 Bug ID: 28887 Summary: Enhance ILL request creation / display to extend functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com This bug will make small enhancements to the ILL, specifically the request creation and display. This work was prompted by requirements that came to light during creation of the RapidILL backend. Improvements such as the following will be included: - Allow the conditional display of certain metadata properties when displaying a request's metadata in the OPAC, the suppression list will be specified by the backend responsible for creating the request. - Allow the linking of a local request to a request made with a third party based on the backend responsible for creating the request. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What|Removed |Added Blocks||28886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 [Bug 28886] Remove uses of ->as_list from the codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28886] Remove uses of ->as_list from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Tomás Cohen Arazi changed: What|Removed |Added Depends on||28883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28886] New: Remove uses of ->as_list from the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Bug ID: 28886 Summary: Remove uses of ->as_list from the codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org It seems that instead of fixing it (bug 28883) we've been using Koha::Objects->as_list to workaround the wrong behavior. We should fix this, globally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28885] OpacBrowseResults can cause errors with bad search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Kyle M Hall changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28885] New: OpacBrowseResults can cause errors with bad search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28885 Bug ID: 28885 Summary: OpacBrowseResults can cause errors with bad search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 123977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123977=edit Bug 28883: Make Koha::Objects->_new_from_dbic honour list context This patch makes the _new_from_dbic method return a list in list context. It does so by leveraging on the existing Koha::Objects->_wrap internal method that _does the right thing_. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Boo! Tests fail! The list is not empty, and it contains... a resultset intead of empty or individual items. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Things work as expected! 5. Run: k$ probe t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! It uses the chaining: $biblio->items->as_list and doesn't break. It implies that the change won't break any Koha place in which ->as_list is being used on a resultset created by _new_from_dbic 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 123976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123976=edit Bug 28883: Regression tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #9 from Marcel de Rooy --- For the record noting here that we are using as default pipe chars in the country field. MARC specs say: Three fill characters (|||) may be used in place of a valid code, but their use in 008/15-17 is discouraged. If we want to change that too, please open up a new report ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Bug 27296 depends on bug 27294, which changed state. Bug 27294 Summary: Error when deleting claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27294] Error when deleting claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 --- Comment #3 from Marcel de Rooy --- Work to be done: Login with a non-superlibrarian user Edit permissions for a superlibrarian user => You can remove it, then cannot add it back Should we allow removal of superlibrarian permission by non-superlibrarian user? No, I definitely think that a non-superlib should not be able to remove perms from a superlib. That would be kind of a security hole imo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] New: ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Bug ID: 28884 Summary: ElasticSearch: Question mark in title search returns no results Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: jyo...@equinoxinitiative.org When searching for a title with a question mark, Who's Afraid of Virginia Woolf? for example, Koha returns no results with ElasticSearch. Removing the question mark or escaping it retrieves results, as does enclosing the entire title with the question mark in quotes. Since ? is a wildcard for ElasticSearch, this may be expected behavior (I'm not sure that it is or isn't), but explaining to patrons that they need to change their search behavior can be a big ask for libraries. Not sure what the best option is. Perhaps a system preference to automatically escape ? and not treat it as a wildcard for those libraries who would prefer that? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #8 from Marcel de Rooy --- Created attachment 123975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123975=edit Bug 27461: Right pad with default elements for too short 008s Note that we treat the elements 18-34 as one block of elements, since its subdivision may vary. E.g. if you pass 24 characters to the form, it will use the first 18 chars (until the last complete element) and pad with default elements from position 18-39. Test plan: [1] Go to addbiblio. Make sure that 008 is connected to the plugin. [2] Backspace field 008 a bit, click on the plugin button. [3] Verify that the last elements come from the default. [4] Repeat for a few different lengths. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #7 from Marcel de Rooy --- Created attachment 123974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123974=edit Bug 27461: Add tests for biblio_008 Test plan: Run t/db_dependent/FrameworkPlugin.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What|Removed |Added Attachment #115248|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 123973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123973=edit Bug 27461: Move hardcoded value to module Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27461] Fix field 008 length below 40 positions in cataloguing plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27461 --- Comment #5 from Marcel de Rooy --- (In reply to Phil Ringnalda from comment #4) > Inconveniently, you can't just pad with either pipes or the remaining > characters from our default blindly, since filling position 35-39 with pipes > is just fine, but filling position 36-39 is invalid, since "e||" is not a > valid language code. So it's an awkward case of length 6-7 you can pad, 8-11 > you have to truncate to 7 and pad, 12 you can pad, 13-15 you have to > truncate to 12 and pad, etc. Phil. I added a proposal to right pad with characters from the default from the last complete data element onwards. Viewing block 18-34 as one element, since it depends on material type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28883 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28871 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] New: Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Bug ID: 28883 Summary: Koha::Objects->_new_from_dbic doesn't work correctly in list context Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org It will always return a resultset, it should return a list in list context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion CC||katrin.fisc...@bsz-bw.de, ||m.de.r...@rijksmuseum.nl, ||oleon...@myacpl.org --- Comment #2 from Jonathan Druart --- Can you have a look at the "work to be done" in the last patch please? What's your opinion? Did we discuss it already? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 --- Comment #1 from Jonathan Druart --- Created attachment 123972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123972=edit Bug 28882: permission UI allows selection of superlibrarian permission With bug 20100 and 22150 we allow to select all the permissions but the superlibrarian permission, to ease the selection. And we also forbid a non-superlibrarian user to add superlibrarian permission. However there is something wrong in the JS code and it's possible to add the superlibrarian permission. The user is getting an ugly 500 and so the permission change is not done, but the UI checks must be fixed. To recreate: Login with a non-superlibrarian user Edit permission Clear all => You can select the "superlibrarian" permission Test plan: Login with a non-superlibrarian user Try to set the superlibrarian permissions to a user => not possible Try the select all/clear all => still cannot set the superlibrarian permission Work to be done: Login with a non-superlibrarian user Edit permissions for a superlibrarian user => You can remove it, then cannot add it back Should we allow removal of superlibrarian permission by non-superlibrarian user? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22150] Make it easier to unselect one member permission after selecting all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 Jonathan Druart changed: What|Removed |Added Blocks||28882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 [Bug 28882] Incorrect permissions check client-side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart changed: What|Removed |Added Blocks||28882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 [Bug 28882] Incorrect permissions check client-side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Jonathan Druart changed: What|Removed |Added Depends on||20100, 22150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22150 [Bug 22150] Make it easier to unselect one member permission after selecting all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28882] New: Incorrect permissions check client-side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28882 Bug ID: 28882 Summary: Incorrect permissions check client-side Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What|Removed |Added Attachment #123918|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What|Removed |Added Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28454] Add Koha version number to database schema link in reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454 Owen Leonard changed: What|Removed |Added Attachment #123917|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 --- Comment #5 from Owen Leonard --- Created attachment 123971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123971=edit Bug 28720: (follow-up) Improve string translation This patch fixes the following issues raised by QA: - It modifies the markup so that "Add note" and "Edit note" can be translated more easily. - It adds display of existing notes back to the table of checkouts. - It adds to the table configuration so that a "plain" view of the notes (without buttons) is shown in print view and in CSV export. - It improves handling of notes containing quotation marks which would previously have broken some edit interactions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7919] Display of values depending on the connexion library (authorised values, patron categories, extended attributes)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What|Removed |Added Blocks||11750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 [Bug 11750] Overdue report does not limit patron attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on||7919 CC||jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 [Bug 7919] Display of values depending on the connexion library (authorised values, patron categories, extended attributes) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #1 from Jonathan Druart --- Created attachment 123970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123970=edit Bug 11750: Hide patron's attributes on overdue list if needed If a patron's attributes is limited to some libraries, we must apply this limit on the overdue list view. Test plan: 1. Create the following patron attributes: A that is not searchable B is searchable and does not have library limitation C is searchable and is limited to another library than yours 2. On the right part of the overdue list view you must see B only Without this patch C is displayed as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9941] with Plack, Web installer should not die with stacktrace when database does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9941 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #15 from Jonathan Druart --- In 2021, with dev_install=0, if the DB does not exist the client get a standard 500 "Internal Server Error". No stacktrace displayed. Closing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25550] Koha/Plugins/Plugins.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25550 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25604 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25604 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=25550 |?id=21670 --- Comment #1 from Jonathan Druart --- How do you recreate that? Is it a random failure? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart changed: What|Removed |Added CC||nicolas.legr...@bulac.fr, ||severine.que...@bulac.fr --- Comment #1 from Jonathan Druart --- Looks like we need an additional link between the 2 tables aqorders and suggestions to achieve that. That would make sense, especially when looking at such code: SELECT suggestions.*, U1.surname AS surnamesuggestedby, U1.firstnameAS firstnamesuggestedby, U1.borrowernumber AS borrnumsuggestedby FROM suggestions LEFT JOIN borrowers AS U1 ON suggestedby=U1.borrowernumber WHERE biblionumber=? LIMIT 1 in GetSuggestionInfoFromBiblionumber. It is wrong if there are several suggestions on the same bib. Hard to know it won't break existing workflows however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28844 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28881 CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5346] Linking suggestions & orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 Jonathan Druart changed: What|Removed |Added Blocks||28881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 [Bug 28881] Suggestion not displayed on the order receive page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What|Removed |Added Depends on||5346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5346 [Bug 5346] Linking suggestions & orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 --- Comment #1 from Jonathan Druart --- Created attachment 123969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123969=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23376] Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 Jonathan Druart changed: What|Removed |Added Blocks||28881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 [Bug 28881] Suggestion not displayed on the order receive page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
