[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #4 from Victor Grousset/tuxayo --- ES8 is coming. So is ES6 actual EOL. Is turns out the EOL ES page is wrong. As 6.8.x still gets updates. But the 1st ES8 alpha has been published [2]. So we should expect ES6 to EOL in around 6 months [3]. https://github.com/elastic/elasticsearch/tags https://discuss.elastic.co/t/elasticsearch-8-release-date/202759/2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 --- Comment #13 from Martin Renvoize --- (In reply to Fridolin Somers from comment #12) > Is this a duplicate of Bug 28554 ? Looks like it could be.. it's been a while since I wrote this patch though so would need to investigate a little deeper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28902] Grey color should be on label for record metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28902 Fridolin Somers changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 --- Comment #9 from Fridolin Somers --- (In reply to pierre.genty from comment #7) > Fridolin, I added this code in IntranetUserJS but it changes nothing for me > (still have to click on the menu or hit Enter). Are you OK with test plan ? For me it is the wanted behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What|Removed |Added CC||alexis.ripe...@inlibro.com Attachment #85923|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What|Removed |Added Depends on||28228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 [Bug 28228] Warns from plugins when metadata value not defined for key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28228] Warns from plugins when metadata value not defined for key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Blocks||25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #28 from Alexis Ripetti --- Created attachment 124201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124201=edit Bug 19336: (QA follow-up) Using CirculationRules instead of IssuingRules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #27 from Alexis Ripetti --- Created attachment 124200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124200=edit Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after changes on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What|Removed |Added Attachment #85922|0 |1 is obsolete|| --- Comment #26 from Alexis Ripetti --- Created attachment 124199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124199=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What|Removed |Added Attachment #85921|0 |1 is obsolete|| --- Comment #25 from Alexis Ripetti --- Created attachment 124198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124198=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What|Removed |Added Attachment #85920|0 |1 is obsolete|| --- Comment #24 from Alexis Ripetti --- Created attachment 124197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124197=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alexis Ripetti changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27565 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28554 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27565] Dropdowns in Item Search should be sorted alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27565 --- Comment #12 from Fridolin Somers --- Is this a duplicate of Bug 28554 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 --- Comment #25 from Fridolin Somers --- None are in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26205] News changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 Fridolin Somers changed: What|Removed |Added Blocks||28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Fridolin Somers changed: What|Removed |Added Blocks||28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14233] Add logging support to notices and slips management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Fridolin Somers changed: What|Removed |Added Blocks||28872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872 Fridolin Somers changed: What|Removed |Added Depends on||23971, 26205, 14233 CC||fridolin.som...@biblibre.co ||m --- Comment #24 from Fridolin Somers --- Those preferences are recent : AcquisitionLog Bug 23971 NewsLogBug Bug 26205 NoticesLog Bug 14233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 [Bug 14233] Add logging support to notices and slips management https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205 [Bug 26205] News changes aren't logged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28861] Item type column always hidden in holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28861 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28873] Incorrect age displayed in db_dependent/Koha/Patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28873 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.10 Note that 20.11 does not contain Bug 21958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26852 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin Somers --- Bug 21958 as impacted C4::Heading::MARC21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] New: MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Bug ID: 28915 Summary: MARC Modification Templates should allow specification of a position or range within a control field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When dealing with the MARC Leader, 008, and other fixed length control fields, it would be nice to be able to make the modification templates look at, match on, and alter only a specific position or range. For example, suppose I have several records in which I want to change the 008 position 33 (Literary form) from a 0 to a 1 (nonfiction to fiction). Currently I could tell my modification template to update the 008 of every record I point it at where the character in position 33 is a 0 (using regex to match only that specific character). But then there's no way to change ONLY that character and preserve the rest of the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #1 from Fridolin Somers --- Created attachment 124196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124196=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] New: Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Bug ID: 28914 Summary: Wording in authentication forms is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl semicolon are missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #12 from Andrew Fuerste-Henry --- Also running into issues with auto-renew notices, probably due to changes made in bug 18532. That added messaging preferences for auto-renew notices. Might that mean we should remove them from this bug? Since now patrons/libraries are more explicitly choosing how they want auto-renews sent? With the patch applied right now, I have FallbackToSMSIfNoEmail turned off, my patron has an SMS number but no email address, and their messaging prefs say to send auto-renew as an email only. When I run the cron, my patron gets an SMS. So that's not right. For what it's worth, the acq and membership expiry notices worked as described. I didn't test the list share. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||and...@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry --- I got a couple of small merge errors here. I managed to apply the patches, but something in pendingreseves is still mad. I get this error when I try to go to Holds to Pull as part of your Test plan for amendment to circ/pendingreserves.pl: Could not compile /kohadevbox/koha/circ/pendingreserves.pl: Global symbol "$admin_email_address" requires explicit package name (did you forget to declare "my $admin_email_address"?) at /kohadevbox/koha/circ/pendingreserves.pl line 95. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/circ/pendingreserves.pl line 315. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 124194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124194=edit Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||28913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 [Bug 28913] Automatic checkin setting in item type setup should note required cronjob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28913] New: Automatic checkin setting in item type setup should note required cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Bug ID: 28913 Summary: Automatic checkin setting in item type setup should note required cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: and...@bywatersolutions.com Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: bwsdo...@gmail.com, gmcha...@gmail.com, ke...@bywatersolutions.com, sbr...@bywatersolutions.com Depends on: 23207 The automatic checkin feature introduced in bug 23207 requires a cron job. We should note that in item type setup so users don't expect the feature to start working simply because they checked the box. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 [Bug 23207] Allow automatic checkin/return at end of circulation period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #6 from Owen Leonard --- Created attachment 124193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124193=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124187|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 124192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124192=edit Bug 28912: Remove duplicated warnings on the about page Bad conflict resolution Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124186|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 124191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124191=edit Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set If Pseudonymization is set but the bcrypt_settings config used by the feature is not set, then there is an ugly 500 on checking out. bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116. However it's pretty hard to handle correctly this exception (and that's why it hasn't be done initially). However we could prevent the pref to be turned on if the config entry is not present. Test plan: Remove the bcrypt_settings from the config Try to turn the syspref on Add the config Try to turn the syspref on/off Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Jessie Zairo changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Jonathan Druart changed: What|Removed |Added Attachment #124162|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 124190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124190=edit Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD amended patch: remove uneeded commented lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 Jonathan Druart changed: What|Removed |Added Attachment #124163|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 124189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124189=edit Bug 28744: Better handling of undefined to_api_mapping We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. This patch makes a small change so this method always returns an empty hashref. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Test fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy JD amended patch: remove uneeded commented lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, m...@kohaaloha.com --- Comment #1 from Jonathan Druart --- Mason, is it something we could do? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #198 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #5 from JaTara Barnes --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 JaTara Barnes changed: What|Removed |Added CC||jenday...@gmail.com --- Comment #4 from JaTara Barnes --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #197 from Jonathan Druart --- Created attachment 124188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124188=edit Bug 22690: Add koha_object[s]_class to fix TestBuilder.t 'Can't locate object method "_new_from_dbic" via package "Koha::Linktracker" (perhaps you forgot to load "Koha::Linktracker"?) at /kohadevbox/koha/Koha/Object.pm line 334. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12998] Option to exclude withdrawn items when exporting records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12998 --- Comment #2 from JaTara Barnes --- Still not resolved in 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Blocks||28912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on||24151 CC||jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 --- Comment #2 from Jonathan Druart --- Created attachment 124187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124187=edit Bug 28912: Remove duplicated warnings on the about page Bad conflict resolution -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 --- Comment #1 from Jonathan Druart --- Created attachment 124186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124186=edit Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set If Pseudonymization is set but the bcrypt_settings config used by the feature is not set, then there is an ugly 500 on checking out. bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116. However it's pretty hard to handle correctly this exception (and that's why it hasn't be done initially). However we could prevent the pref to be turned on if the config entry is not present. Test plan: Remove the bcrypt_settings from the config Try to turn the syspref on Add the config Try to turn the syspref on/off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28912 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28911 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28912] New: Pseudonymization should display a nice error message when brcypt_settings are not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Bug ID: 28912 Summary: Pseudonymization should display a nice error message when brcypt_settings are not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently we cause an ISE when bcrypt_settings are missing We should throw/catch an exception and display a nicer error message To recreate: 1 - edit koha-conf, remove 'bcrypt_settings' 2 - Enable pseudonymization 3 - Attempt a checkout 4 - Boom! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #18 from Martin Renvoize --- (In reply to Jonathan Druart from comment #17) > The easy way here is actually to keep the existent patches and replace > "INVALID_EMAIL" by "UNKNOWN_ERROR", and we follow-up on a separate bug > reports with the different exceptions/errors possible. > > What do you think? Seems reasonable to me.. I think.. Must admit though, my brain has moved on a bit since I wrote this.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #17 from Jonathan Druart --- The easy way here is actually to keep the existent patches and replace "INVALID_EMAIL" by "UNKNOWN_ERROR", and we follow-up on a separate bug reports with the different exceptions/errors possible. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Nick Clemens changed: What|Removed |Added Blocks||28911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Nick Clemens changed: What|Removed |Added Depends on||24151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 [Bug 24151] Add a pseudonymization process for patrons and transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28911] New: Bcrypt settings are required for pseudonymization but are not set on upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Bug ID: 28911 Summary: Bcrypt settings are required for pseudonymization but are not set on upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 24151 added a way to pseudonymize patron transactions. It added a new config to koha-conf This is added for new installs, but not for upgraded sites, and there are no instructions on the syspref or elsewhere for adding To recreate: 1 - Spin up a 20.05 (checkout 20.05.x and reset_all in kohadevbox) 2 - Upgrade to master (checkout master, updatedatabase) 3 - Enable pseudonymization 4 - Attempt a checkout 5 - boom you can manually add the settings by running the command below: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' And pasting the results into in the config -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #25 from Jonathan Druart --- Created attachment 124185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124185=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #24 from Jonathan Druart --- Created attachment 124184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124184=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Attachment #124178|0 |1 is obsolete|| Attachment #124179|0 |1 is obsolete|| Attachment #124180|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 124183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124183=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Blocks||28803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Jonathan Druart changed: What|Removed |Added Depends on||28870 Status|Passed QA |Failed QA --- Comment #16 from Jonathan Druart --- IMO we should base this on top of bug 28870 and provide a separate simple patch for backporting. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26223] The OPAC ISBD view does not display item information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26223 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25619] Updating an expiration date for a waiting hold won't save
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #196 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #22 from Jonathan Druart --- Ulrich, can we get your signoff on those patches please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #22 from Jonathan Druart --- If we need consistency, then should we adjust all the other methods? Koha::UploadedFiles->getCategories? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #21 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #19) > $template->param( > outstanding_debits => scalar $patron->account->outstanding_debits, > items => scalar $biblio->items, > ); I'd personally prefer to not have to forget the "scalar" (and almost always use iterator) and explicitly ask for the list when I need it (->as_list). Not blocking, just expressing my opinion :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #20 from Jonathan Druart --- I have found only one problematic occurrence but I'd like another QA stamp with that in mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124177|0 |1 is obsolete|| --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 124182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124182=edit Bug 16446: Add ability to add patrons to list by borrowernumber AddPatronsToList already took a borrowernumber parameter, however, it did not check if those were valid numbers. This patch expands the search to apply to cardnumber or borrowernumbers in the subroutine. Template and script are adjusted to allow choosing borrowernumbers or cardnumbers To test: 1 - Apply patch 2 - Browse to Tools->Patron lists 3 - Create a list, or choose Actions->Add patrons for an existing list 4 - Click 'Add multiple patrons' 5 - Cardnumbers is preselected 6 - Enter a list of cardnumbers, ensure you test: Cardnumber already in list Cardnumber not in list Non-existent cardnumber 7 - Patrons should be added/errors reported correctly 8 - Repeat with borowernumbers Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron lists by borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #19 from Tomás Cohen Arazi --- I get it, but consistency will always be a good thing! Right now we need: $template->param( outstanding_debits => scalar $patron->account->outstanding_debits, items => $biblio->items, ); Because we are not consistent (i.e. outstanding_debits does a return $smth->search) I'd prefer $template->param( outstanding_debits => scalar $patron->account->outstanding_debits, items => scalar $biblio->items, ); The motivation for this bug was to find consensus on a predictable way of coding to lower amount of bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23792] Send borrowernumbers from report to batch modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23792 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #18 from Jonathan Druart --- Created attachment 124181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124181=edit Bug 28883: Fix wrong list context calls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #17 from Jonathan Druart --- I don't know, did you check the hundreds occurrences we have in the code? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124119|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 124180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124180=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124118|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 124179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124179=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124117|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 124178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124178=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > Wow, no! This is not as trivial as it looks like. > > We must force scalar context actually. I am expecting lot of side-effects > with this change. I get that, but isn't it the case already? We already force scalar context when passing things to the templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
