[Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #13 from Martin Morris --- Good afternoon I've just upgraded to 21.11.02 and this problem has returned. Can I just reapply the patches which I previously applied for 21.11.01? Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer --- This is blocked by the dependent patch still awaiting sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What|Removed |Added Attachment #130236|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 130542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130542=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30091] New: Sending an empty simple search results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30091 Bug ID: 30091 Summary: Sending an empty simple search results in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org In master, with a fresh ktd sample database, sending an empty simple search results in: Template process failed: undef error - The method Koha::Library::Groups->id is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What|Removed |Added Summary|if branchcode is included |If branch is mandatory on |in |patron self registration |PatronSelfRegistrationBorro |form, the pull down should |werMandatoryField it should |default to empty |default to an empty value | Text to go in the|Creates an empty value and |Creates an empty value and release notes|defaults to it when |defaults to it when |PatronSelfRegistrationBorro |PatronSelfRegistrationBorro |werMandatoryField includes |werMandatoryField includes |branchcode. This forces |branchcode. This forces |self registering users to |self registering users to |make a choice for |make a choice for the |branchcode. |library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29760] Show patron category in Holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What|Removed |Added Attachment #129414|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 130541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130541=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29760] Show patron category in Holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29760] Show patron category in Holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What|Removed |Added Text to go in the|Adds the patron category to |Adds the patron category as release notes|the holds queue on |a new column to Circulation |view_holdsqueue.tt |> Holds queue. Summary|Show patron category in |Show patron category in |Holds Queue |Holds queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This looks all good, but I think we might need to fix tests: t/db_dependent/Search.t .. # Failed test 'Built composed implicit-and CCL keyword query' # at t/db_dependent/Search.t line 423. # 'kw,wrdl=(rk=(salud)) AND kw,wrdl=(rk=(higiene)) ' # doesn't match '(?^u:kw\W.*salud\W.*and.*kw\W.*higiene)' # Looks like you failed 1 test of 90. t/db_dependent/Search.t .. 1/3 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 906. t/db_dependent/Search.t .. 2/3 # Looks like you failed 1 test of 3. t/db_dependent/Search.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/Search.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30081] Display item type in patron's holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #9 from Katrin Fischer --- *** Bug 29982 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Katrin Fischer changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Katrin Fischer --- This looks like a perfect duplicate of bug 30081 - can you please check? *** This bug has been marked as a duplicate of bug 30081 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging MARC records for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- I am sorry, but while this works for A-z and therefor for English, it doesn't work for other languages like German with Umlauts or French with accents/diacritics. If you enter for example a description starting with Á, it will sort at the end, instead of as A. I think we need to use a sort that accounts for that and that we already have that in Koha - using cmp instead of >? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30081] Display item type in patron's holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #8 from Katrin Fischer --- (In reply to Lari Taskula from comment #5) > That has to be the quickest sign-off I've seen in all these years :D Maybe fastest QA too? The wonder of small changes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30081] Display item type in patron's holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What|Removed |Added Attachment #130494|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 130540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130540=edit Bug 30081: Use itemtype description instead of itemtype code To test: 1. Use same plan as previous patch, but observe full item type description instead of item type code Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30081] Display item type in patron's holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What|Removed |Added Attachment #130493|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 130539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130539=edit Bug 30081: Add item type column to holds table Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. To test: 1. Apply patch 2. Place a hold and confirm it 3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with borrowernumber being the id of your patron 4. Click "1 Hold(s)" tab 5. Observe new column "Item type" 6. Confirm the item type is correct 7. Go to moremember.pl?borrowernumber=1 with borrowernumber being the id of your patron 8. Repeat steps 4-6 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30081] Display item type in patron's holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Katrin Fischer changed: What|Removed |Added Attachment #130496|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 130538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130538=edit Bug 29579: Show saved SQL report ID in database query When trying to figure out which saved SQL report caused too much load, it's useful to have the report id show in the mysql process list. This patch adds the saved SQL ID number as a comment line in front of the SQL before passing it to the database. To test: 1) Run a saved report that takes long enough time, so you can: 2) Connect to the database with your preferred client, and use "show processlist;" to list all the running mysql processes. 3) The running saved SQL report should show up with "-- saved_sql.id=123" in the process info field. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer changed: What|Removed |Added Attachment #130530|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 130537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130537=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Katrin Fischer changed: What|Removed |Added Attachment #130351|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 130536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130536=edit Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13952] Import and export of authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #161 from Katrin Fischer ---
We'll need a small fix here:
1) QA test tools
FAIL admin/import_export_authtype.pl
FAIL critic
Subroutine "new" called using indirect syntax at line 36,
column 13. See page 349 of PBP.
2) Text
+Export all the information of a MARC or Authority Type Framework to an excel
"xml" file, comma separated values "csv" file or OpenDocument SpreadSheet "ods"
file.
As the authority types are also MARC... maybe we could make this read:
Export all information of a bibliographic or authority MARC framework to an
Excel "xml" file, comma separated values "csv" or OpenDocument SpreadSheet
"ods".
3) Unit tests
The unit tests pass, but there is 'tons' of these with the patches, while the
output without the patches is clean:
Use of uninitialized value $frameworktype in string eq at
/kohadevbox/koha/C4/ImportExportFramework.pm line 1004, <$dom> line 21.
Use of uninitialized value $frameworktype in string eq at
/kohadevbox/koha/C4/ImportExportFramework.pm line 678.
4) Translatability
In .js files you need to use a double undescore for making things translatable:
alert(_("Error importing the authority type
%s").format(decodeURIComponent(matches[1])));
Should be: __("Error...
5) First import/export test looks great :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #26 from Katrin Fischer --- There is an issue with the depending bug needing some more work, but this also doesn't apply cleanly on top: Bug 28974 Depends on bug 28966 (Signed Off) Follow? [(y)es, (n)o] y Bug 28966 - Holds queue viewer too slow to load for large numbers of holds 125377 - Bug 28966: Prefetch patron data for holds queue viewer Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28966: Prefetch patron data for holds queue viewer Bug 28974 - Add pagination to holds queue viewer 125424 - Bug 28974: Add pagination to holds queue viewer 125425 - Bug 28974: Start at first page when change number of results per page 125426 - Bug 28974: Hard code page = 1 instead of using javascript 126277 - Bug 28974: (follow-up) Pass total number of items instead of count per page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28974: Add pagination to holds queue viewer error: sha1 information is lacking or useless (C4/HoldsQueue.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28974: Add pagination to holds queue viewer hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28974-Add-pagination-to-holds-queue-viewer-HdA_x4.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I gather from the discussion that this should be changed to use DBIC/Koha::Object instead of SQL. Moving to Failed QA for now to trigger action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer --- As I can't test Overdrive I am a bit hesitant to try my hands on the rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29845: add IDs to overdrive results action buttons Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js error: Failed to merge in the changes. Patch failed at 0001 Bug 29845: add IDs to overdrive results action buttons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23352] Define serial's collection code in the subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #31 from Katrin Fischer ---
Hi Alex,
can you please make a couple fixes?
1) QA test tools
FAIL
installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl
FAIL file permissions
File must have the exec flag
FAIL valid
Useless use of anonymous hash ({}) in void context
2) Handling of default on existing items
I am in doubt about these lines:
+if ( $itemrecord and $defaultvalues and not
$itemrecord->subfield($tag,$subfield->{subfield}) ) {
+# if the item record exists, only use default value if
the item has no ccode
+$defaultvalue = $defaultvalues->{ccode};
I believe that would affect what happens if an item is edited from the serials
module?
If the item has been created without a collection, we should not 'force' it
later. The rule is that if it was emptied out intentionally it should remain
empty.
3) Terminology
Collection code:
[% IF ( ccode ) %]Collection code: [% ccode |
html %][% END %]
As we always display the descriptions and not the codes, we have updated the
GUI to always say "Collection".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik changed: What|Removed |Added Assignee|ldjami...@marywood.edu |janik.hil...@icloud.com Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 --- Comment #10 from Katrin Fischer --- I am testing this with LibreOffice, but all amounts export with 00.00 for FR for me :( Not sure if this is because I am running my laptop with English default language or because LibreOffice is not Excel... could someone else give this a go? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30090] Don't export action buttons from patron results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30090 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30090] New: Don't export action buttons from patron results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30090 Bug ID: 30090 Summary: Don't export action buttons from patron results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The checkout and Edit buttons should not export (Exel, Print) on the patron search result list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30089] New: Placing holds on OPAC broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30089 Bug ID: 30089 Summary: Placing holds on OPAC broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When trying to place a hold in the OPAC, either multi hold or a single hold, the page explodes with: The method Koha::AuthorisedValues->authorised_value is not covered by tests! I am using ktd, the sample database and my search term is 'perl'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What|Removed |Added Summary|Add author info to the |Add author info to the |holds page |holds page in the staff |(reserve/request.pl)|interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #21 from Katrin Fischer --- (In reply to Jonathan Druart from comment #18) > Do we want to display the author for the multi-holds view as well? Yes, but you've already done it :) I have updated George's sign-off line: Signed-off-by: AUTHORNAME Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What|Removed |Added Attachment #130337|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 130535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130535=edit Bug 28405: Add author for multi holds view Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What|Removed |Added Attachment #130244|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 130534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130534=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #6 from Katrin Fischer --- Please remember guidelines for commit messages :) Do we need to worry about potentially doubled up entries? I recently managed to do that with SQL manipulations, but haven't seen it happen from within Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Katrin Fischer changed: What|Removed |Added Attachment #130360|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 130533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130533=edit Bug 30060: Add primary key to user_permissions table Without primary key DBIC is failing with something like: GET /api/v1/suggestions/managers: unhandled exception (DBIx::Class::Exception)< user_permissions chain): fetch more unique non-nullable columns at /kohadevbox/koha/Koha/Objects.pm line 394>> Koha::REST::Plugin::Exceptions::__ANON__ / kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) Test plan: Execute the atomic update and confirm that the new PK has been added to the user_permissions table. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #37 from Katrin Fischer --- Hi Thibaud, 1) Commit message Please make sure to run the QA test tools on your patches - they can highlight things like mistakes with the commit message and give other helpful hints. In this case there is an extra space that needs to be removed: Bug : should be Bug : 2) b/installer/data/mysql/mandatory/sysprefs.sql This file is sorted alphabetically, as you are dealing with librarians here, we take this seriously :) 3) Database update For some time we are using a new format for database updates, see here: https://wiki.koha-community.org/wiki/Database_updates That's for next time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #36 from Katrin Fischer --- Created attachment 130532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130532=edit Bug 20398: (QA follow-up) Fix alphabetical order in sysprefs.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Katrin Fischer changed: What|Removed |Added Attachment #130450|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 130531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130531=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "StaffHighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). Signed-off-by: ManuB Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #24 from Katrin Fischer ---
There is 2 small things so far:
* When an order is added, there is a column "supplier report" in the basket
summary table that I think should also be removed with the pref set to off.
* The doubled description here doesn't look right:
('EasyAnalyticalRecords','0','','If on, display in the catalogue screens tools
to easily setup analytical record relationships','YesNo'),
+('Edifact','0','Enables edifact acquisitions functions','Enables use of
Edifact electronic message exchange for acquisitions','YesNo'),
* There is now an EDIFACT heading on the acq syspref page, so I think we should
move the pref there :)
* Spelling: EDIFACT is an abbreviation and we should spell it as such. Edifact
for the syspref name makes sense, but in the descriptions we should use EDIFACT
consistently (updatedatabase, syspref.sql, acquisitions.pref)
Rest looks great as far as I can tell!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30088] Forgotten password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30088 --- Comment #1 from Katrin Fischer --- I think the idea is that the user can pick what they know/have on hand, which varies with different use cases. The email AND the login are only required if there are users with the same email address. I think often it's easier for users to give their institutional email than a cardnumber/userid. For your second question I am not sure: the user is always emailed in this process? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19814] Batch Check-in function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
