[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|Adds the ability to Save &  |Adds the ability to save &
  release notes|continue when working with  |continue when working with
   |either News or HTML |either News or HTML
   |customizations in   |customization editors.
   |additional_contents.|
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Signed Off  |Failed QA
Summary|Add 'save and continue' |Add 'save and continue'
   |functionality to news   |functionality to news and
   |editor  |HTML customizations

--- Comment #11 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #7)
> Another little bug:
> The save and continue changes your form from "additional contents" to "news"
> with the bug mentioned above.

I am sorry, but I am still seeing this bug:

1) Add a new HTML customization
2) Leave title empty
3) Save and continue
4) Breadcrumbs and headings have changed to news

This might relate to some other bugs we have in this area - adding Joubu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #129986|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 132271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132271=edit
Bug 29228: Use Flatpickr on offline circulation page

This patch replaces the use of jQueryUI datepicker on the built-in
offline circulation page, where it was used for the "Specify due date"
date-time picker as well as for formatting datetime values for display.

To test, apply the patch and go to Circulation -> Built-in offline
circulation interface.

 - Click "Synchronize."
 - Click "Download records."
 - Submit a card number for a patron who has multiple items checked out.
 - In the table of previous checkouts, confirm that dates in the "Date
   due" and "Checked out on" columns are formatted according to your
   TimeFormat and DateFormat system preferences.
 - When checking out to a patron with fines, open the fines tab and
   submit an amount in payment. The table of payments should include a
   correctly-formatted datetime.
 - Test that the "Specify due date" date picker works correctly and that
   checkouts show the correct date.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228

--- Comment #5 from Katrin Fischer  ---
The download records step only works with turned off strict SQL mode, I've
filed: 
Bug 30369 - Downloading records for inbuilt offline circulation fails with
strict SQL setting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30370] New: Offline circulation shows false warnings about lost card/address in doubt

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30370

Bug ID: 30370
   Summary: Offline circulation shows false warnings about lost
card/address in doubt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Found testing bug 29228, so stealing a part of the test plan. Offline
ciculation first needs to be activated in the system preferences.

- Click "Synchronize."
- Click "Download records."
- Submit a card number for a patron who has multiple items checked out.
  I used 42.

The checkout page shows 2 warnings:

Patron's address is in doubt (proceeding anyway)
Patron's card is lost

But when checking the patron account, both are set to 'No'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||30369


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30369
[Bug 30369] Downloading records for inbuilt offline circulation fails with
strict SQL setting
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30369] New: Downloading records for inbuilt offline circulation fails with strict SQL setting

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30369

Bug ID: 30369
   Summary: Downloading records for inbuilt offline circulation
fails with strict SQL setting
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 17258

To test:
* Activate offline circulation in system preferences
* Go to Circulation > Inbuilt offline circulation
* Synchronize
* Download records

The page is stuck downloading forever.

With the developer tools you can see:

CGI::Compile::ROOT::kohadevbox_koha_offline_circ_download_2epl::get_data(): DBI
Exception: DBD::mysql::st execute failed: 'koha_kohadev.borrowers.cardnumber'
isn't in GROUP BY at /kohadevbox/koha/offline_circ/download.pl line 84
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993

--- Comment #12 from Katrin Fischer  ---
Hi Victor, we applied this manually to our 20.11.16 branch, it's working and
needed. Just had to move it a little as there was a tiny conflict with some
additional code in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #9)
> OK, I'll try to add that alternative patch later today.. got a couple of
> meetings first so bear with ;)

Martin, do you still plan to provide an alternative patch or should we move on
with what we have here?

As there seems to be a need for a pref, I'll set to failed QA for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30368] Add ability to use a macro in MARC modification template

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30368

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #1 from AspenCat Team  ---
It would be nice to be able to run a macro as an action in MARC modification
template.  Then it could be used for batch record modification.  Another
approach would be able to apply a macro in batch record modification.  Ideally
user could choose either or both.  It would allow changes that are usually done
in marcedit (with export and then import) to be accomplished entirely within
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #130052|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 132270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132270=edit
Bug 11083: Add sample XSLT for UNIMARC authorities

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #130051|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 132269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132269=edit
Bug 11083: Add ability to generate authority summary using XSLT

This patch only affects authority search results in the staff interface.
It adds a new system preference AuthorityXSLTResultsDisplay. If set,
each authority search result MARCXML will be transformed using the XSLT
at the given filename or URL. The output will be displayed in place of
the default summary.
If errors occur, the XSLT is ignored and the default summary is
displayed.

The syspref value can contain {langcode} and {authtypecode} which will
be replaced by the appropriate value (resp. current language and
authority type code)

Test plan:
1. Apply patch and run updatedatabase
2. Verify that authority search results are not affected yet.
3. Create an XSLT file (for instance in
/home/koha/xslt/en/GEOGR_NAME.xsl)
4. Set AuthorityXSLTResultsDisplay syspref value to
/home/koha/xslt/{langcode}/{authtypecode}.xsl
5. Do an authority search that returns GEOGR_NAME results. Verify that
the summary matches what you expect from your XSLT
6. Do an authority search that returns authorities of other types.
Verify that the default summary is displayed.

Example of a minimal XSLT:


http://www.loc.gov/MARC21/slim;
 xmlns:xsl="http://www.w3.org/1999/XSL/Transform;>
  
  

  
authority-summary
  
  

  


Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Katrin Fischer  changed:

   What|Removed |Added

Summary|Authority Search Result |Authority search result
   |Display should be XSLT  |display in staff interface
   |Driven  |should be XSLT driven

--- Comment #11 from Katrin Fischer  ---
Nice release notes :)

I notice that unlike other prefs the new pref has no "default" option that
prefills the input field although there is a UNIMARC file submitted with this
patch. Should we add one with a note that this is currently for UNIMARC only?

But not a blocker for me. I think this works nicely and gives a good base for
more improvements later.

Do you plan to also make this available for the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30296] Correct path for cookie bibs_selected

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30296

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldoldstable
 Version(s)|19.11.28|19.11.28,20.11.17
released in||

--- Comment #7 from Victor Grousset/tuxayo  ---
> How should this be tested?

Doesn't sound too risky. So:
Backported: Pushed to 20.11.x branch for 20.11.17

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30368] New: Add ability to use a macro in MARC modification template

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30368

Bug ID: 30368
   Summary: Add ability to use a macro in MARC modification
template
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aspencatt...@clicweb.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|22.05.00,21.11.4,21.05.13   |22.05.00,21.11.04,21.05.13
released in||
 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||vic...@tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to oldstable |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #21 from Katrin Fischer  ---
The patch doesn't apply, I believe the fix is probably simple but don't want to
mess with it:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query
Using index info to reconstruct a base tree...
M   cataloguing/value_builder/unimarc_field_4XX.pl
Falling back to patching base and 3-way merge...
Auto-merging cataloguing/value_builder/unimarc_field_4XX.pl
CONFLICT (content): Merge conflict in
cataloguing/value_builder/unimarc_field_4XX.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to
make query
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-26537-use-QueryBuilder-in-unimarcfield4XX-plug-sBlXav.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add street type to fields which can be copied from guarantor to guarantee

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add street type to fields which can be copied from guarantor to guarantee

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

--- Comment #5 from Katrin Fischer  ---
Created attachment 132268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132268=edit
Bug 29576: (QA follow-up) Rename road type to street type to match patron form

This changes the pref description so the field name matches what
we use in the patron form.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add street type to fields which can be copied from guarantor to guarantee

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #129197|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 132267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132267=edit
Bug 34874: Add streettype and B_streettype to PrefillGuaranteeField

To test :
 1) modify PrefillGuaranteeField system preference
 2) road type for main and alternate addresses aren't in the list
 3) Apply patch
 4) Redo 1, now they are

https://bugs.koha-community.org/show_bug.cgi?id=29576
Signed-off-by: The Minh Luong 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add street type to fields which can be copied from guarantor to guarantee

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add street type to fields which can be copied from guarantor to guarantee

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add streetype  to fields|Add street type to fields
   |which can be copied from|which can be copied from
   |guarantor to guarantee  |guarantor to guarantee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #33 from Katrin Fischer  ---
Hi Emmi, patches no longer apply, could you please rebase?

The script notes some trailing whitespace also, maybe worth checking. 

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16223: Automatically remove any borrower debarments after a
payment
.git/rebase-apply/patch:28: trailing whitespace.

.git/rebase-apply/patch:160: trailing whitespace.
 - 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   Koha/Account.pm
M   Koha/Patron/Debarments.pm
M   installer/data/mysql/mandatory/sysprefs.sql
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
M   t/db_dependent/Patron/Borrower_Debarments.t
.git/rebase-apply/patch:28: trailing whitespace.

.git/rebase-apply/patch:160: trailing whitespace.
 - 
warning: 2 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Patron/Borrower_Debarments.t
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
Auto-merging Koha/Patron/Debarments.pm
CONFLICT (content): Merge conflict in Koha/Patron/Debarments.pm
Auto-merging Koha/Account.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 16223: Automatically remove any borrower debarments
after a payment
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-16223-Automatically-remove-any-borrower-debarm-iuWbtz.p

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29787] Add plugin version to plugin search results

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #129649|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 132266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132266=edit
Bug 29787: Add plugin version to plugin search results

This patch adds a new column to plugins search results: 'Latest
version'.

It takes the tag_name in both GitHub and GitLab cases and passes it to
the template.

To test:
1. Have this on your koha-conf.xml file:

 

ByWater Solutions
bywatersolutions
github


Theke Solutions
thekesolutions
gitlab


PTFS Europe
ptfs-europe
github

 

2. Restart all services:
   $ restart_all
3. Search for the term 'barclaycard'
=> SUCCESS: You get results from PTFS Europe (Github)
=> FAIL: They don't include plugin version
4. Search for the term 'innreach'
=> SUCCESS: You get results from Theke (Gitlab)
=> FAIL: They don't include plugin version
5. Apply this patch
6. Repeat 2-4
=> SUCCESS: Results show up
=> SUCCESS: Results include the plugin version
7. Sign off :-D

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29787] Add plugin version to plugin search results

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29787] Add plugin version to plugin search results

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787

--- Comment #7 from Katrin Fischer  ---
Ok, I realize, this is an error before and after the patch... so no blocker.

I've filed a new bug: 
Bug 30367 - Plugins: Search explodes in error when searching for specific
keywords

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30367] New: Plugins: Search explodes in error when searching for specific keywords

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30367

Bug ID: 30367
   Summary: Plugins: Search explodes in error when searching for
specific keywords
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

This was found testing bug 29787 so I'll copy part of the test plan here:


To test:
1. Have this on your koha-conf.xml file:

 

ByWater Solutions
bywatersolutions
github


Theke Solutions
thekesolutions
gitlab


PTFS Europe
ptfs-europe
github

 

2. Restart all services:
   $ restart_all
3. Search for the term 'barclaycard'

The search will give an error:

malformed JSON string, neither tag, array, object, number, string or atom, at
character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line
190

It might be an issue with the plugin, but we should catch errors in a nicer way
for the users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29787] Add plugin version to plugin search results

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Katrin Fischer  ---
I've followed the steps of the test plan and I quite like it - I hadn't seen
the 'search for plugins' feature yet!

But following the test plan also lead me to an issue:

1) Search for barclaycard

malformed JSON string, neither tag, array, object, number, string or atom, at
character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line
190

2) Search for innreach
Results show nicely

3) Search for gibberish
No results show as expected.

4) Search for patron
Get a longer result list as expected.

So we are really close!

I assume 1) could be a problem with this specific plugin, but can we catch the
problem in a better way so we don't explode?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Some parsing errors in the QA test tools:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
   FAIL   filters
missing_filter at line 82 ([%- this_biblio_href %][%
biblionumber | url -%])

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
   FAIL   valid_template
parse error -
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
line 158: unexpected end of input

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
   FAIL   valid_template
parse error -
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt
line 88: unexpected token (ELSE)
  [% ELSE %]

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc
   FAIL   filters
missing_filter at line 34 ([%- this_biblio_href %][%
biblionumber | url -%])

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #129481|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 132265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132265=edit
Bug 22827: Add age dependency on other fields than dateaccessioned

A new agefield has been added to the 'Automatic item modifications by
age' tool. The options for the agefield are: replacementpricedate,
datelastborrowed,
datelastseen, damaged_on, itemlost_on, withdrawn_on

If no option is selected then Koha will default to saving 'agefield' =
items.dateaccessioned

Similarly, if a Koha instance has an old item rule without 'agefield'
defined then Koha will default to using 'items.dateaccessioned'.
This is confirmed by the AutomaticItemModificationByAge.t unit test.

Test plan:

1. Go to: Tools > Catalog > Automatic item modifications by age
2. Observe there is a new 'Age field' dropdown in the rule form.
3. Create a rule, set the values:
- 'Age in days' = 20
- Leave 'Age field' = 'Choose an age field'
- 'Substitutions': 'items.barcode' = 'test'
- Save the rule
4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age
field' column
5. Add another rule:
- 'Age in days' = 2
- 'Age field' = 'items.datelastseen'
- 'Substitutions': 'items.barcode' = 'test2'
- Save the rule
6. Confirm the 'List of rules' page displays 'items.datelastseen' in
the 'Age field' column for that second rule
7. Add some more rules and confirm you can delete them
8. Edit a record:
- Make the items.dateaccessioned = 3 day ago (so rule 1 is false)
- Make the items.datelastseen = 3 days ago (so rule 2 is true)
9. Run the automatic_items_modification_by_age.pl:
- sudo koha-shell 
- cd misc/cronjobs
- ./automatic_item_modification_by_age.pl -v -c
10. Confirm the item has it's barcode set to 'test2'
11. Run unit tests:
- sudo koha-shell 
- prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v

Sponsored-By: Catalyst IT

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827

--- Comment #13 from Katrin Fischer  ---
I was wondering about the fallback instead of updating the rules, until I
realized that the rules are stored in a system preference:
automatic_item_modification_by_age_configuration 

Also filed a new bug for a warning that exists before and after the patches are
applied: Bug 30366 - Warn when running automatic_item_modification_by_age.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30366] New: Warn when running automatic_item_modification_by_age.pl

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366

Bug ID: 30366
   Summary: Warn when running
automatic_item_modification_by_age.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Blocks: 25790

When using the ./misc/cronjobs/automatic_item_modification_by_age.pl -v after
setting up rules under tools > Automatic item modifications by age the script
outputs several lines of warnings:

With patch from 22827:
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Items.pm line
1856.

Master as of today:
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Items.pm line
1852.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
[Bug 25790] [OMNIBUS] warnings removal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||30366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30366
[Bug 30366] Warn when running automatic_item_modification_by_age.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29964] SMTP server list not populating

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964

--- Comment #30 from Tomás Cohen Arazi  ---
(In reply to Father Vlasie from comment #28)
> Yes I have restarted the whole server.
> 
> JSON::Validator (3.14)5.05
> Mojolicious (8.12)9.22
> Mojolicious::Plugin::OpenAPI (2.16)   5.02
> 
> The api-error.log is empty.
> 
> Thank you!

You need to remove the libraries you manually installed using cpanm now that
the right ones are pulled from the updated repository (i.e. now you added the
stretch keyword)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using HTTPS

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791

Katrin Fischer  changed:

   What|Removed |Added

Summary|KohaOpacLanguage cookie |KohaOpacLanguage cookie
   |should set the secure flag  |should set the secure flag
   |if using https  |if using HTTPS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6815] Capture member photo via webcam

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

--- Comment #102 from Katrin Fischer  ---
Bit early to be thinking of release notes.. but might make a nice highlight as
"new feature"? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30356] Author facets for names with single quotes (') don't work

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30356

--- Comment #2 from Katrin Fischer  ---
Zebra in 20.11. I'll check for the record later, but it should be ok to
manually catalog the authority for a person with that name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Katrin Fischer  changed:

   What|Removed |Added

Summary|cleanup bulkmarcimport.pl   |Cleanup bulkmarcimport.pl

--- Comment #5 from Katrin Fischer  ---
Don't forget to switch to "Needs sign-off" once this is ready for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29964] SMTP server list not populating

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30347

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30347] Library List not Showing

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30347

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29964

--- Comment #1 from Katrin Fischer  ---
The list of libraries is now pulled via the API. So this error points to an
installation problem where the API doesn't work/respond correctly. 

For a starting point, please see bug 29964 and the comments there - it's the
same problem, just showing in a different way.

If the notes there won't help, please bring this up on the mailing list or on
IRC where more people will be reading and be able to help you.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30338] AUTO_RENEWALS and AUTO_RENEWALS_DGST notices cannot access branch information

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30338

--- Comment #3 from Katrin Fischer  ---
Hm ok, answering my own question... for the DGST the branches might be
different... so that object would not work unless we make it the library
patrons home branch as in other DGST notices?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30338] AUTO_RENEWALS and AUTO_RENEWALS_DGST notices cannot access branch information

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30338

--- Comment #2 from Katrin Fischer  ---
(In reply to Lucas Gass from comment #1)
> Marking this as resolved because I learned you can use:
> 
> [% checkout.library.branchname %]

I wonder where we could document this. At the moment these kind of things make
it hard to have libraries modify the TT templates. Maybe it would still be nice
to be able to access the branch or library object directly for more
consistency?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30334] error 500 in advanced editor

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30334

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Katrin Fischer  ---
Hi Mohammad, 

as the advanced editor appears to work in general, this would be more a support
request than a bug and should better be asked on the mailing list:
https://koha-community.org/support/koha-mailing-lists/

Or in the IRC chat:
https://koha-community.org/get-involved/irc/

For a first step, it might be good to check the logs to see if there are any
errors in them that might give more of a clue of what's going on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

--- Comment #11 from Katrin Fischer  ---
(In reply to Aleisha Amohia from comment #10)
> (In reply to Katrin Fischer from comment #6)
> > I feel this needs additional clean-up of the CSS to go with it. The colors
> > in the top navigation bar are off on the fonts and mouse overs and not the
> > same as on the front page. Overall I think the style doesn't work so well
> > here because the sco pages haven't been restyled. At the moment, there are
> > also issues with readabillity and contrast beside it not being so pretty -
> > so I think we need to fix those at least. (Please compare toolbar on top
> > with language switcher before and after change)
> 
> Can you please provide some examples or screenshots of what you mean?

I am not sure the comments still apply since then some work probably has been
done on the pages. And even back then I might have been missing something. I'd
have to check again, but the patches don't apply now :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812

--- Comment #38 from Katrin Fischer  ---
(In reply to Kyle M Hall from comment #37)
> Pushed to 21.11.x for 21.11.05

It's a big change for stable - bit worried libraires using the feature might be
too surprised it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30334] error 500 in advanced editor

2022-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30334

--- Comment #1 from mohammad  ---
any solution please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/