[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #24 from Katrin Fischer --- Owen had showed a screenshot on IRC using the 'filter' icon, that I liked better than the question mark, but not sure if he was going to provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27619] Remove fr-FR installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #3 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #2) > This did not move recently. > On bug I want to remove auth_subfield_structure.frameworkcode. > That gives a lot of changes in especially the fr-FR SQL files. > Would you support doing that first ? Hi Marcel, easy to miss, but there is actually some very recent movement here: This was waiting for the new UNIMARC frameworks (dependency bug 30373). The patches were provided just in time before the hackfest and tests have begun. Once this is solved, it should be relatively easy to resolve this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29129] The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #1 from Andrew Fuerste-Henry --- +! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Katrin Fischer changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #25 from Katrin Fischer --- Same for damaged - that something is damaged doesn't equal unavailable in a lot of libraries. It might just be so that when the item is checked out the patron is not blamed for pre-existing damage. Maybe we do need to have some configuration options here? If I could pick, I'd pick lost, withdrawn and on loan as unavailable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #24 from Katrin Fischer --- I wonder if 'not "notforloan"' should not only be for on order items that have not yet arrived at the library. As it is now we exclude all reference items as 'not available' which is not true usually. A lot of special libraries have large collections that are not for loan but can still be consulted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 132874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132874=edit Sample UNIMARC install po file with fr-FR translations After creation of new language xx-YY but before installing it, replace xx-YY-installer-UNIMARC.po with this file, populated with strings from fr-FR sql files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 --- Comment #9 from Bernardo Gonzalez Kriegel --- (In reply to Thibault Keromnès from comment #8) > Tested with Arthur's git on a sandbox. > First tests (comments #1, #2 and #3) worked well (we have Default, ACQ, FA > and Authorities frameworks) > > Test on comment #4 failed, we couldn't install a new language. > "misc/translation/translate create xx-YY" didn't create > "misc/translation/po/xx-YY-installer-UNIMARC.po" It's strange, new po file creation depends on the last patch, and that is present in the biblibre repo. I just tried and I have not found problems. I'll attach a sample xx-YY-installer-UNIMARC.po with french translations. > On the default framework itself it looks really good, we just think it'd be > better not to collapse the following fields : > 001 > 010$d > 020 > 021 > 106 > 3XX > 4XX > 5XX > 8XX > 9XX > We imported all authorities types, it's great, thanks a lot. About visibility of fields/subfields, I'll gladly follow any advice, as in the case of mandatory values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 --- Comment #1 from Lucas Gass --- Created attachment 132873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132873=edit Bug 30438: Add select all/clear all buttons to invoices.tt To test: 1. Apply patch 2. Have a bunch of invoices, some open and some closed. 3. Go to Home > Acquisitions > Invoices and do a search that will return you many of those invoices, some open and some closed. 4. Notice the 'Select all' and 'Clear all' buttons. 5. Try clicking 'Select all' on the Open invoices tab. All Open invoices should become checked. 6. Try clicking 'Clear all' on the Open invoices tab. All open invoices should become unchecked. 7. Try 5 - 6 again but on the Closed invoices tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt open and closed tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30438] New: Add select all/clear buttons to invoices.tt open and closed tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438 Bug ID: 30438 Summary: Add select all/clear buttons to invoices.tt open and closed tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some librarians would find it handy to have "Select all" and "Clear all" buttons on the on invoices.tt which selected, or cleared, each of the checkboxes for open or closed invoices. This would include sepearate select all/clear all buttons for the open and closed invoice tables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Arthur Suzuki changed: What|Removed |Added Attachment #132864|0 |1 is obsolete|| --- Comment #3 from Arthur Suzuki --- Created attachment 132872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132872=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 --- Comment #1 from Lucas Gass --- Created attachment 132871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132871=edit Bug 30437: Add SVG loader to pendingreserves.pl To test: 1. Try to have a bunch of holds in your test system so pendingreserves.pl takes several seconds to load 2. Apply patch 3. Regenerate the staff CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface 4. Go to Home > Circulation 5. Click on "Holds to Pull" 6. As the page is loading you should notice some 'Loading page...' text with a spinning SVG loader. 7. Nothing else should change with the functionality of the "Holds to Pull" report This uses a very nice free to use SVG loader from Sam Herbert. https://samherbert.net/svg-loaders/ Credit and link are included in the SVG file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30437] Add an SVG loader to Koha pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 --- Comment #1 from Owen Leonard --- Created attachment 132870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132870=edit Bug 30436: Convert article requests tabs to Bootstrap This patch converts the jQuery tabs on the article requests page to Bootstrap. To test you should have the "ArticleRequests" system preference enabled. If necessary, create some article requests and mark some "Pending," some "Processing," and leave some new. - Apply the patch and go to Circulation -> Article requests. - The page should show three tabs: New, Pending, and Processing. - The tabs should look correct and work correctly. - The DataTables under each tab should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30436] Convert article requests tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30437] New: Add an SVG loader to Koha pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30437 Bug ID: 30437 Summary: Add an SVG loader to Koha pendingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some pages in Koha can take a long time to load in Koha. One that often can take some time is pendingreserves.pl If a library has a lot of holds this page can take a pretty long time to load and sometimes users don't realize that. It is easy to think the page is broken or not loading properly, causing users to continually click on the pendingreserves.pl link. Clicking over and over again can be problematic as i causes pendingreserves.pl to begin loading again and again. A SVG loader that gives a visual indication that the page is loading/working could help prevent users from clicking the link multiple times while the page is still loading. pendingreserves.pl is one example, so it might be nice to have an SVG loader that can be applied to any link within Koha that takes a long time to load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30436] New: Convert article requests tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 Bug ID: 30436 Summary: Convert article requests tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the article requests template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30436 [Bug 30436] Convert article requests tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435 --- Comment #1 from Owen Leonard --- Created attachment 132869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132869=edit Bug 30435: Remove unused MACLES cataloging plugin This patch removes the files associated with the MACLES cataloging plugin. The feature is unmaintained. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30435] Remove unused MACLES cataloging plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30435] New: Remove unused MACLES cataloging plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30435 Bug ID: 30435 Summary: Remove unused MACLES cataloging plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I wrote this to the Koha mailing list in December 2017: There is a plugin for the MARC edit form called macles.pl, "Gestion des index MACLES" I'm assuming it's specific to UNIMARC. Does anyone know if this is still in use? It's been broken since I think version 16.05, so I'm curious whether it can be removed. We keep updating the associated files to keep up with standards, but I think it might be wasted work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch QA Contact||vic...@tuxayo.net CC||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 --- Comment #1 from Owen Leonard --- Created attachment 132868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132868=edit Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30350] Do not hardcode job types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #6 from Tomás Cohen Arazi --- I would like to take this out of the RM queue for now, as work on bug 27783 might make this require some changes. If someone (including me) finds this is still relevant, let's make it PQA again. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #72 from David Gustafsson --- (_get_record_for_export is still called to fetch the other records though, so no functionality has been removed there, but reading what it does don't se how most of the same operations should not work also on deleted biblios) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #71 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #62)
> -my $record = _get_record_for_export( { %$params, record_id =>
> $record_id } );
>
> +for my $record (@records, @deleted_records) {
> +print MARC::File::XML::record($record);
>
> Noting that get_record_for_export does a lot more and we seem to loose that
> now?
Yes, right now I can't think of any reason why deleted records should not be a
new record type in _get_record_for_export and processed in the same way as the
others (authorities and biblios). I will look into this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #70 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #61)
> +my ($record_type) = @_;
>
> +my $validator = $encoding_validator->('Record');
>
> +$validator = $encoding_validator->('Deleted record');
>
> Deleted flag ?
I don't think I understand. The string is correct, but looking at the code I
wonder why creating a closure instead of just providing the argument further
down, I should probably change this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #69 from David Gustafsson --- Sorry, the last comment was meant to be a response to: > And functionally: why not deleted records in csv ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #68 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #59)
> sub export
>
> binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
> } else {
> binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
>
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
>
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );
marc2csv uses GetMarcBiblio to load biblios that does not support loading
deleted biblios which resides in another table. marc2csv would have to be
carefully reviewed and refactored to ensure it can handle deleted biblios, this
would increase the scope of this patch and I just did not think it was worth
the effort. A separate issues could perhaps be created in case there is an
interest implementing support for this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #67 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #59)
> sub export
>
> binmode $fh, ':encoding(UTF-8)' unless $format eq 'csv';
> } else {
> binmode STDOUT, ':encoding(UTF-8)' unless $format eq 'csv';
>
> What happens if we choose csv? Are we not doing UTF-8 ?
> Later we do:
>
> print marc2csv( $record_ids, $csv_profile_id, $itemnumbers );
I had a look at this and don't think this block is part of the patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #66 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #57)
> +my $marc_flavour = C4::Context->preference('marcflavour');
> +my $biblio_metadata = $resultset->find({
> +'biblionumber' => $biblionumber,
> +'format' => 'marcxml',
> +'marcflavour' => $marc_flavour
> +});
> +my $marc_xml = $biblio_metadata->metadata;
> +$marc_xml = StripNonXmlChars($marc_xml);
> +
> +my $record = eval {
> +MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +};
> +if (!$record) {
>
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..
Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.(In reply to Marcel de Rooy from comment #58)
> +return unless (@{$record_ids} || @{$deleted_record_ids} && $format ne
> 'csv');
>
> Parentheses here would be more helpful inside. The outer ones are not needed.
> But in order to read easier, you could do A || ( B && C )
Yes,they could be removed. Personally I think it's more confusing, or at least
a bit unsightly, to use parenthesis for anything else than changing operator
precedence. At least with "||" and "&&" where there really should be no
confusion.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #65 from David Gustafsson ---
(In reply to Marcel de Rooy from comment #57)
> +my $marc_flavour = C4::Context->preference('marcflavour');
> +my $biblio_metadata = $resultset->find({
> +'biblionumber' => $biblionumber,
> +'format' => 'marcxml',
> +'marcflavour' => $marc_flavour
> +});
> +my $marc_xml = $biblio_metadata->metadata;
> +$marc_xml = StripNonXmlChars($marc_xml);
> +
> +my $record = eval {
> +MARC::Record::new_from_xml($marc_xml, 'UTF-8', $marc_flavour)
> +};
> +if (!$record) {
>
> You test $record, but you should have tested $biblio_metadata too ?
> Otherwise you already crash on ->metadata..
Hi, thanks for the feedback. There is no definite right or wrong, but
personally try to avoid defensive programming where things are very unlikely to
fail. Ids should be valid since have been previously fetched from database, in
case of the XML-decoding it's highly unlikely to go wrong, but I can imagine
cases where it could.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 [Bug 30434] Convert catalog merge page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30434] New: Convert catalog merge page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Bug ID: 30434 Summary: Convert catalog merge page tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the catalog merge template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 --- Comment #1 from Owen Leonard --- Created attachment 132867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132867=edit Bug 30433: Convert advanced search tabs to Bootstrap This patch updates the advanced search page in the staff interface to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and test the advanced search interface. The tabs should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 [Bug 30433] Convert advanced search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Owen Leonard changed: What|Removed |Added Blocks||30433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 [Bug 30433] Convert advanced search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] New: Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Bug ID: 30433 Summary: Convert advanced search tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30424 Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the advanced catalog search template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 [Bug 30424] Reindent advanced search template in the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 --- Comment #2 from Owen Leonard --- Created attachment 132866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132866=edit Bug 30424: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 --- Comment #1 from Owen Leonard --- Created attachment 132865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132865=edit Bug 30424: Reindent advanced search template in the staff interface This patch reindents the advanced search template. Some lines have been split to make the markup more readable. To test, apply the patch and test the advanced search page in the staff interface. Everything should work as normal. Be sure to test both the "More options" and "Fewer options" views. When viewing the diff for this change, ignore whitespace. The only visible changes should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 François Pichenot changed: What|Removed |Added Attachment #132842|0 |1 is obsolete|| --- Comment #2 from François Pichenot --- Created attachment 132864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132864=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #2 from Nick Clemens --- Created attachment 132863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132863=edit Bug 30432: Specify 'me' for biblionumber when limiting items To test: 1 - Apply only unit tests 2 - prove t/db_dependent/Koha/Holds.t 3 - It fails 4 - Apply this patch 5 - prove t/db_dependent/Koha/Holds.t 6 - It passes! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 --- Comment #1 from Nick Clemens --- Created attachment 132862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132862=edit Bug 30432: Unit test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30432] get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22347] Translatability of ILSDI results for getavaibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347 Kyle M Hall changed: What|Removed |Added Attachment #132550|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 132861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132861=edit Bug 22347: Translatability of ILSDI GetAvailability Some discovery tools can't translate ISL-DI results, it would be useful if we can get ISL-DI output already translate. This patch add an optional parameter language to GetAvailability, and make GetAvailability results translatable. If no parameter is given the output language is the language of the cookies is present or the first language in the opac language list. Test plan: 1. Enable the ILS-DI system preference 2. Locate a record 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[BIBLIONUMBER]_type=biblio=[LANGUAGE] and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability=[ITEMNUMBER]_type=item=[LANGUAGE] (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice, [LANGUAGE] is a language code ex: 'en' or 'fr-FR') 6. The results should now be in the requested langugage Sponsored-by: University Lyon 3 Signed-off-by: Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22347] Translatability of ILSDI results for getavaibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30432] New: get_items_that_can_fill needs to specify table for biblionumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30432 Bug ID: 30432 Summary: get_items_that_can_fill needs to specify table for biblionumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When not using item_level-itypes i.e. it is set to 'bibliographic record', we join to biblioitems to get the itemtype This causes ambiguity in the 'filter_by_for_hold' call in 'get_items_that_can_fill' as we only specify 'biblionumber' in our bibs_or_items variable The error is: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 --- Comment #9 from Kyle M Hall --- Created attachment 132860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132860=edit Bug 30398: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Kyle M Hall changed: What|Removed |Added Attachment #132788|0 |1 is obsolete|| Attachment #132789|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 132859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132859=edit Bug 30398: Reindent invoices template This patch updates the invoices template so that the indentation is consistent. To test, apply the patch and go to Acquisitions. - Locate a vendor which has multiple invoices associated with it. - View the vendor details, and click the "Invoices" link in the sidebar. - The display of invoices should look correct. The DataTable should work correctly. - Test the search filters in the sidebar to confirm that they work too. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30398] Reindent invoices template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30398 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic library transfer limit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417 Kyle M Hall changed: What|Removed |Added Attachment #132826|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 132858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132858=edit Bug 30417: Switch to Bootstrap tabs on the basic library transfer limit page This patch updates the basic library transfer limits page to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Administraion -> Library transfer limits. Test that the tabs look correct and work correctly. The functionality of the page should be unchanged. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic library transfer limit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30417] Switch to Bootstrap tabs on the basic library transfer limit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30417 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30350] Do not hardcode job types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350
Kyle M Hall changed:
What|Removed |Added
Attachment #132298|0 |1
is obsolete||
--- Comment #5 from Kyle M Hall ---
Created attachment 132857
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132857=edit
Bug 30350: Avoid hardcoding job types in background_jobs_worker.pl
Currently, background_jobs_worker.pl has a hardcoded list of jobs it can
process. Koha::BackgroundJob already has a method that can be used to
extract such list. Using it would avoid having to maintain two lists,
and it would also make it easier to inject plugin tasks as well.
To test:
1. Apply the patch
2. Restart the koha-worker
3. Run one of the batch operations that make use of the background jobs
(I used batch item delete)
=> SUCCESS: Things work, no change
4. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
JD amended patch
-my @job_types = keys %{Koha::BackgroundJob::type_to_class_mapping};
+my @job_types = keys %{Koha::BackgroundJob::type_to_class_mapping()};
To remove the following error:
Ambiguous use of %{Koha::BackgroundJob::type_to_class_mapping} resolved to
%Koha::BackgroundJob::type_to_class_mapping
Signed-off-by: Jonathan Druart
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30350] Do not hardcode job types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30350] Do not hardcode job types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30350 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378 Kyle M Hall changed: What|Removed |Added Attachment #132820|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 132856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132856=edit Bug 30378: Convert about page tabs to Bootstrap This patch updates the about page to use Bootstrap tabs instead of jQueryUI. The patch also makes a minor HTML correction for validity. To test, apply the patch and go to the about page in the staff interface. Test that the tabs look correct and work correctly. Signed-off-by: Séverine Queune Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30378] Convert about page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30378 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 --- Comment #8 from Thibault Keromnès --- Tested with Arthur's git on a sandbox. First tests (comments #1, #2 and #3) worked well (we have Default, ACQ, FA and Authorities frameworks) Test on comment #4 failed, we couldn't install a new language. "misc/translation/translate create xx-YY" didn't create "misc/translation/po/xx-YY-installer-UNIMARC.po" On the default framework itself it looks really good, we just think it'd be better not to collapse the following fields : 001 010$d 020 021 106 3XX 4XX 5XX 8XX 9XX We imported all authorities types, it's great, thanks a lot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #23 from Kyle M Hall --- Created attachment 132855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132855=edit Bug 29066: (follow-up) add aria-label and aria-hidden on icons Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Kyle M Hall changed: What|Removed |Added Attachment #132376|0 |1 is obsolete|| Attachment #132377|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall --- Created attachment 132854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132854=edit Bug 29066: Remove text in OPAC search form and use Font Awesome icons In modern front-end websites, first think you see in header region is an large input text with a search icon. No need to say it is a search form. We still tell it in 'title' attribut for accessibility. This patch removes 'Search' text. If 'my library first' feature is enabled, shows a text in title of a question mark icon. In submit button, replaces 'Go' with a seach icon and add title 'Search'. Test plan : 1) 1.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Add' SearchMyLibraryFirst to 'Don't limit' 1.2) Go to OPAC main page 1.3) You don't see 'Search' anymore 1.4) You see in submit button an icon 1.5) Move mouse over submit button to see tooltip text 'Search' 2) 2.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Don't add' SearchMyLibraryFirst to 'Limit' 2.2) Go to OPAC main page 2.3) Log in 2.4) You don't see text 'Search (in ) only' 2.5) You see a question mark icon 2.6) Move mouse over submit button to see tooltip text 'Search (in ) only' Signed-off-by: Samu Heiskanen Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 --- Comment #9 from Kyle M Hall --- Created attachment 132853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132853=edit Bug 30345: Make Koha::BackgroundJob->enqueue set borrowernumber=undef if no userenv This patch makes ->enqueue set undef if no userenv is provided. The CLI scripts will usually use Koha::Script and have this set to undef as well, but on the tests, there's usually no userenv set unless we need to test it. And as we are adding triggers everywhere, that will schedule background jobs, it means we would end up mocking userenv or the ->enqueue method everywhere and it will get messy. This patch just make it set undef. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJob.t => FAIL: Wow, it explodes badly. Same as any test that happens to trigger a background job enqueuing. 3. Apply this patch 4. Repeat 2 => SUCCESS: Great, tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Kyle M Hall changed: What|Removed |Added Attachment #132851|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 132852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132852=edit Bug 30345: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 [Bug 30360] Add helper methods to Koha::BackgroundJobs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Kyle M Hall changed: What|Removed |Added Attachment #132824|0 |1 is obsolete|| Attachment #132825|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 132851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132851=edit Bug 30345: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17841] Can't use indexname "acqdate, st-date-normalized" in keyword search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17841 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Frido, that took a while, but it works, I think also with ge at the end in 20.11. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Tomás Cohen Arazi changed: What|Removed |Added Blocks|27344 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Tomás Cohen Arazi changed: What|Removed |Added Depends on|30345 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29346 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Add real-time holds queue update option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Add real-time holds queue update option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added Depends on|30345 |27783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 [Bug 27783] Introduce background job queues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #19 from Tomás Cohen Arazi --- Ok, after several talks at the hackfest, everyone agreed we should (or not opposed to) reverse the dependency to keep things clearer. I took on the task of rebasing, reorganizing things, etc keeping the attribution of the original patches. To put it clear, this *should* only be lacking what it already lacked of: integration with koha-worker so both worker processes are launched by default to .deb install users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 132850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132850=edit Bug 27783: Rename queues and adjust currently defined jobs This patch renames the queues so the default is the **real-time** one, and the other (*turtle*) is kept for **slow** tasks. All current *batch* tasks are explicitly assigned to the **turtle** queue as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 132849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132849=edit Bug 27783: (follow-up) Add DB change to installer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 132848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132848=edit Bug 27783: Add missing atomicupdate file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 132847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132847=edit Bug 27783: Replace --job-type by --queue This patch adds a new column background_jobs.queue, which default to 'default' By default, new jobs are enqueued into this default queue, and the background job worker will subscribe to the default queue unless told otherwise by the --job-queue option The new job UpdateElasticIndex is automatically enqueued in another queue named 'index' So you can have 'default' worker with misc/background_jobs_worker.pl and a dedicated indexing worker with misc/background_jobs_worker.pl --queue index This is to address bug 27344 comment #15 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 132846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132846=edit Bug 27783: Add --job-type to background_jobs_worker.pl This will let sysop adjust the number of workers and how they want to manage them. For instance one could want to have one worker for ES indexation and another worker for other jobs, to prevent ES index to be stuck behind bigger batch process. Signed-off-by: Arthur Suzuki Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132651|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132650|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 132845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132845=edit Bug 27344: Adapt to bug 30181 changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 132844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132844=edit Bug 27344: Add missing include file Signed-off-by: Arthur Suzuki Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #43 from Tomás Cohen Arazi --- Created attachment 132843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132843=edit Bug 27344: Implement Elastic's update_index_background using Koha::BackgroundJob This patch adds a background job submodule, UpdateElasticIndex, to deal with async ES index update (not the deletion). Using NYTProf (on a checkin): Without 618ms, executing 35676 statements and 26355 subroutine calls in 266 source files and 83 string evals. With 521ms, executing 13282 statements and 7979 subroutine calls in 195 source files and 26 string evals. However there are some problems with this patch: 1. We don't want *all* the index update to be in the background_jobs tabtle (we could add a filter on the list view) 2. We don't track the "progress" of the job as we are sending all the records to Elastic. It is okish in my opinion but it must be noted. Signed-off-by: Arthur Suzuki Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #1 from Arthur Suzuki --- Created attachment 132842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132842=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Arthur Suzuki changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132798|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
