[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #14 from David Cook  ---
Had a library ask for this today, but it sounds like the community is a bit
stuck on how to proceed?

For what it's worth, on the server side, we're using DataTables. We may as well
do it on the OPAC too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |

--- Comment #2 from Tomás Cohen Arazi  ---
Hi, only submitted regression tests while waiting for my flight. Now is time to
take off! See you soon!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 148629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148629=edit
Bug 33329: Regression tests

This patch introduces tests for the bug highlighted on bug 32336, but in
the context of lists of records.

To reproduce:
1. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> FAIL: Test fail, encoding is bad!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32734] REST API: Add a list endpoint for Biblios

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33329


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329
[Bug 33329] GET /biblios encoding wrong when UNIMARC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33329


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329
[Bug 33329] GET /biblios encoding wrong when UNIMARC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||32336, 32734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336
[Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734
[Bug 32734] REST API: Add a list endpoint for Biblios
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33329] New: GET /biblios encoding wrong when UNIMARC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329

Bug ID: 33329
   Summary: GET /biblios encoding wrong when UNIMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
CC: tomasco...@gmail.com

Same as bug 32336 but for listing biblios.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #31 from Janusz Kaczmarek  ---
(In reply to Nick Clemens from comment #26)
> (In reply to Janusz Kaczmarek from comment #25)
> > Nick, I have looked into the corrected version. I see one problem: with
> > Zebra, for:
> > 
> > 655 7 $a Literatura angielska $2 DBN
> > 
> > you search first for: "Literatura angielska + DBN" and, since there is no
> > 040 $f, there is the second query for: "Literatura angielska + undefined'
> 
> The second query passes "notdefined" - not undef 
[...]

Nick, thank you very much for you comment.  My eyes misses the difference
between 'notdefined' for 'z' without 040 $f and 'notspecified' for '|'.  I am
sorry for unnecessarily bothering you.


I understand your explanation about hardcoding Subject-heading-thesaurus but,
to be sincere, I do not share this argument.  Firstly, in Zebra also we have
the definitions in the configuration file--if somebody changes there something
he/she shouldn't, its his/her fault.  And secondly, which is IMHO more
important, shall we than, in the next step, hardcode also
Heading-use-main-or-added-entry for 008/14, Heading-use-series-added-entry for
008/16, Heading-use-subject-added-entry for 008/15 when we will be wanting to
narrow the search for linking even more specifically (which should definitely
be done at some point)?  So, I am still not convinced if it is the right
idea...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33132] Searching by DOB still broken in 22.05.x

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33132

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

--- Comment #10 from Tomás Cohen Arazi  ---
If you agree with my follow-up please set it back to PQA, otherwise let's
discuss it properly.

Best regards.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 148628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148628=edit
Bug 32336: (QA follow-up) Use $metadata->schema

When we worked on Koha::Biblio::Metadata, we agreed
biblio_metadata.schema would be the sourceof truth when it comes to the
record schema.

This patch acknowledges that, while retaining the fallback to the
syspref.

To test:
1. Apply this patch
2. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass, behavior is unchanged.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year.

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606

--- Comment #11 from Katrin Fischer  ---

> I think it's a great idea to display the budget names in the fund dropdown
> when adding orders to baskets.

I think we should standardize the fund pull downs and always include the budget
information. It's not uncommon to order on the current and next years end of
year here. I believe Nick did great work showing hierarchy, allowing to display
inactive etc. on the receive page. So I hope we could use that as a template.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32499] HOLDPLACED email goes to patron branch rather than item branch

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32499

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26477

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32499

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477

--- Comment #3 from Katrin Fischer  ---
Please see the discussion on bug 32499.

Right now it should be using he patron's home library and KohaAdminEmailAddress
only as a fallback.

Alternatively the pickup library could be used.

Anything related to the item probably won't work well as we could end up
spamming a lot of libraries in a multi-branch system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33318] Advanced editor doesn't load in 21.11.x

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33318] Advanced editor doesn't load in 21.11.x

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318

Alex Buckley  changed:

   What|Removed |Added

Summary|Revert bug 31818 from Koha  |Advanced editor doesn't
   |21.11.x branch  |load in 21.11.x
  Change sponsored?|--- |Sponsored
 Status|NEW |Needs Signoff

--- Comment #2 from Alex Buckley  ---
Ready for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33318] Revert bug 31818 from Koha 21.11.x branch

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318

--- Comment #1 from Alex Buckley  ---
Created attachment 148627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148627=edit
Bug 33318: Fix JS errors on advanced cataloguing editor

This patch reverts bug 31818

Test plan:
1. Checkout 21.11.x
2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable'
3. Go to Cataloguing > Advanced editor
4. Notice the advanced editor is stuck on 'Loading, please wait'
5. Right click > Inspect > Console
6. Notice there is a JS error: "Uncaught TypeError:
$.fn.popover.Constructor.DEFAULTS.whiteList is undefined"
7. Apply patch
8. Restart services
9. Refresh the advanced editor
10. Notice it is not stuck on 'Loading, please wait'
11. Right click > Inspect > Console
12. Notice the JS error is no longer showing
13. Click on 'Keyboard shortcuts' and confirm it contains content - that
is what bug 31818 was aiming to fix

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477

Katrin Fischer  changed:

   What|Removed |Added

 CC||ka...@bywatersolutions.com

--- Comment #2 from Katrin Fischer  ---
*** Bug 19464 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19464] emailLibrarianWhenHoldIsPlaced email enhancement

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19464

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 26477 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 148626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148626=edit
Bug 33328: Rename x-marc-schema => x-record-schema

This patch renames the header on the biblio API so it is not entirely
tied to MARC, trying to follow the biblio_metadata table generic
approach.

To test:
1. Apply this patch
2. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass
3. You agree with the change?
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33308] Add ability to to use SFTP with runreport.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add ability to to use sftp  |Add ability to to use SFTP
   |with runreport.pl   |with runreport.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33308] Add ability to to use sftp with runreport.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308

--- Comment #1 from Katrin Fischer  ---
I like the idea, but maybe a workaround: would be using the 'access files'
tools and a directory on the Koha server work? It would limit access to Koha
staff users with the right permission set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

--- Comment #15 from Hammat wele  ---
Created attachment 148625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148625=edit
Bug 21214: (fix) Rebuild the sql query

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33227] OpenAPI validation is failing for paths/biblios.yaml

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33227

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||33328


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328
[Bug 33328] x-marc-schema should be renamed x-record-schema
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Depends on||33227


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33227
[Bug 33227] OpenAPI validation is failing for paths/biblios.yaml
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33328] New: x-marc-schema should be renamed x-record-schema

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328

Bug ID: 33328
   Summary: x-marc-schema should be renamed x-record-schema
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
CC: tomasco...@gmail.com

Before it is too late, we need to rename the HEADER param.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #8 from Tomás Cohen Arazi  ---
I think we need some more here: we should really be using

my $metadata = $biblio->metadata;
my $schema   = $biblio->schema // C4::Context->preference("marcflavour");

Should we also file a new bug for list()?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33326] When adding an item to a basket from a purchase suggestion SUGGEST_FORMAT is lost

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326

Juliet Heltibridle  changed:

   What|Removed |Added

 CC||jheltibri...@rcplib.org

--- Comment #1 from Juliet Heltibridle  ---
It seems strange to me that the options for patrons to choose from are a
separate authorized value instead of just using the item types in the system.
But if that's not possible, we do need a way to retain the suggestion requested
format through the ordering process, so there is no confusion for staff on what
the patron wanted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Hammat wele  changed:

   What|Removed |Added

 Attachment #148624|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

--- Comment #14 from Hammat wele  ---
Created attachment 148624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148624=edit
Bug 21214: (fix) Change letter_code with letter_id in the sql query and code
modification

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Blocks||33327


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327
[Bug 33327] Hide resolved catalog concerns by default
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33327] New: Hide resolved catalog concerns by default

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327

Bug ID: 33327
   Summary: Hide resolved catalog concerns by default
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When viewing the Catalog concerns report (Cataloging > Catalog concerns), all
concerns are shown by default. I feel like this could become crowded quickly.
So we should hide the resolved tickets by default.

To reproduce:
1. Enable the CatalogConcerns system preference
2. Go to a bibliographic record and click New > New catalog concern
3. Fill out the form and submit
4. Refresh the page to see the concern in the Concerns tab
5. Click Details
6. Click Resolved
7. Go to Cataloging > Catalog concerns
   --> The concern is show by default

If you have lots of tickets (resolved and unresolved), the view can get
crowded. I only tested the functionality a little bit and I already have a
pageful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com

--- Comment #13 from Hammat wele  ---
Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Hammat wele  changed:

   What|Removed |Added

 Attachment #113009|0   |1
is obsolete||

--- Comment #12 from Hammat wele  ---
Created attachment 148623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148623=edit
Bug_21214: Change of SQL request in condition $mail with letter_code and code
modification

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214

Hammat wele  changed:

   What|Removed |Added

 Attachment #113008|0   |1
is obsolete||

--- Comment #11 from Hammat wele  ---
Created attachment 148622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148622=edit
Bug 21214: cleanup_database.pl --keep-lc to dodge deletion in message_queue
based on letter_code

Librarians sometime worry if a certain email was sent or not to a patron
(PREDUES, ODUES, etc.), and iirc, there are no way to have that information
once the cleanup_database.pl has run, unless we dig back an archive of their
database.
This patch would let an admin choose which letters to keep in the
message_queue, based on its letter_code, by passing a comma-separated list to
the script.

TEST PLAN:
1) Either you have already have data, or you'll want to add some new test lines
in your message_queue table
. INSERT INTO
message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued)
  VALUES(1,,'email','sent','2018-01-01 00:00:42');
2) Make a backup of this table
3) Run the script patchless with the --mail 1 option
3.1) Messages older than 1 day should have been deleted
4) Put the data back in
5) Apply patch
6) Choose a letter_code you'd like to keep, and run the script with --mail 1
--keep-lc [,]
7) Messages older than 1 day that don't have the code  [or ]
should've been deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #1 from Marie-Luce Laflamme  ---
I agree. For large libraries, it makes more sense to send the hold request to
the branch email rather than the KohaAdminEmailAddress.
Is there a way to prioritize the branch email? Then, if it's empty, Koha will
send the message to the admin email.

Someone else asks a similar request in the past. 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19464

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #73 from Christopher Brannon  ---
(In reply to Jonathan Druart from comment #67)
> Not blocker, but noting:

> 2. We don't have access to already read notes. Could be added later if
> needed.

Staff do, patrons do not.  Yes, something to consider adding later if needed. 
Would have to be adjusted on the staff side, as right now, staff have all
control as to how long a message sticks around.  We would need to probably have
some way of hiding the message when read, like we do on the patron side, and
then have a way to access read messages on both sides, and then decide how to
manage read messages.  Again, something for another bug perhaps.  This is a
good start.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33326] New: When adding an item to a basket from a purchase suggestion SUGGEST_FORMAT is lost

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326

Bug ID: 33326
   Summary: When adding an item to a basket from a purchase
suggestion SUGGEST_FORMAT is lost
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisette.sch...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

I know we can't copy over the item type since they won't necessarily match, but
it would be very helpful if there was a "suggestion requested format" or
similar. 

Even better if it could check and if the value matches the item code if it
could match them. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. The plugin is already added to the subfield for the default UNIMARC
bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833

David Nind  changed:

   What|Removed |Added

 Attachment #146769|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148621=edit
Bug 32833: Fix cataloguing/value_builder/unimarc_field_121a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. The plugin is already added to the subfield for the default UNIMARC
bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832

David Nind  changed:

   What|Removed |Added

 Attachment #146768|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148620=edit
Bug 32832: Fix cataloguing/value_builder/unimarc_field_120.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. The plugin is already added to the subfield for the default UNIMARC
bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select and enter the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831

David Nind  changed:

   What|Removed |Added

 Attachment #146767|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148619=edit
Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
How I tested


1. The plugin is already added to the subfield for the default UNIMARC
bibliographic framework in KTD.
2. Edit a bibliographic record.
3. Select the tag editor for the subfield.
4. Options and values should be the same before and after the patch is applied.

Description
~~~

This is a standard UNIMARC value builder for a subfield - it displays a form to
select and enter the values that make up the subfield.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830

David Nind  changed:

   What|Removed |Added

 Attachment #146766|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 148618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148618=edit
Bug 32830: Fix cataloguing/value_builder/unimarc_field_116.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #30 from Phil Ringnalda  ---
On https://sandboxes.biblibre.eu/ if you want to poke at it, see where I might
have gone wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117

--- Comment #25 from Laura Escamilla  ---
(In reply to Jonathan Druart from comment #24)
> Why are you passing the syspref value to the patron_autocomplete JS
> function, instead of retrieving the value from there?
> 
> I think you should create a global JS variable (in doc-head-close.inc for
> instance), then use it when you need it in patron_autocomplete.
> 
> Also you are using TT syntax in 2 js files (tags-review.js and viewlog.js),
> it won't work.


Thanks for the feedback. I'll look into how to adjust this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #29 from Phil Ringnalda  ---
I didn't for the Zebra case, since I applied the patches on sandbox creation so
I didn't think about needing to. Just switched it back to Zebra, did a reindex,
and it still didn't link. For ElasticSearch I did reindex before trying
anything, since nothing works post-switch until you do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #28 from Nick Clemens  ---
(In reply to Phil Ringnalda from comment #27)
> I just followed the test plan in a sandbox, first with Zebra and then with
> ElasticSearch, and in neither case was the Literatura angielska genre
> heading linked.

Did you reindex after applying the patches? While I tried to avoid it, it is
required

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
   Keywords|Academy |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277

--- Comment #27 from Phil Ringnalda  ---
I just followed the test plan in a sandbox, first with Zebra and then with
ElasticSearch, and in neither case was the Literatura angielska genre heading
linked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33222] Checkin message does not display when book is overdue and borrower has manual restriction

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33222

--- Comment #1 from Owen Leonard  ---
Created attachment 148617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148617=edit
Bug 33322: Refine click handler for suggestion batch operations

The handler for suggestion batch operations looks for clicks on
"button[type='submit']" which is not very specific. With the new staff
interface this ends up including the header search form.

This patch modifies the markup of the batch operations section of
the template and makes the click handler more specific so that only the
right buttons are affected.

To test, apply the patch and go to Suggestions.

- In the header search form, perform a catalog search. You should be
  able to click the submit button to successfully initiate the search.
- Without checking a checkbox associated with any open suggestion, test
  the batch operation buttons at the bottom:
  - Change status
  - Change item type
  - Update manager
  - Delete
  - Archive
  All should trigger a JS alert, "Please select at least one suggestion"
- Test each batch operation with one or more suggestions selected and
  confirm that the operation completes successfully.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33222] Checkin message does not display when book is overdue and borrower has manual restriction

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33222

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33132] Searching by DOB still broken in 22.05.x

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33132

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33325] New: UpdateItemLocationOnCheckin message should accurately report when location set to null

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33325

Bug ID: 33325
   Summary: UpdateItemLocationOnCheckin message should accurately
report when location set to null
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

To recreate:
1 - set UpdateItemLocationOnCheckin to "_ALL_: _PERM_"
2 - have an item where items.permanent_location is null but items.location is
not null
3 - check your item in, get message that location was updated, including
wording "New value: "Blank""
4 - check your item in the database, confirm location has been set to NULL
rather than blank

Getting location to have a value with permanent_location is null takes some
niche setup to accomplish in the staff interface. See this comment for
instructions, but it'd be easier to just set up a test item from the database:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33301#c2

The UpdateItemLocationOnCheckin syspref contains the option to set things to
"_BLANK_" at checkin. When that option is used, things are actually set to
blank (items.location='') rather than NULL, so in those cases the message *is*
accurate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324

--- Comment #1 from Owen Leonard  ---
Created attachment 148616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148616=edit
Bug 33324: Use template wrapper for tabs: Tools

This patch updates templates in the tools directory so that they use
the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and test each page to confirm that tabs still
work as before:

- Cataloging -> Export
  - This page by default will have two tabs, "Export bibliographic
records" and "Export authority records." You can edit koha-conf.xml
to enable two additional options: backup_db_via_tools and
backup_conf_via_tools
- Tools -> Batch patron modification
  - "By card number" and "By borrowernumber," and "By patron list" if
you have any patron lists defined.
- Tools -> Overdue notice/status triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24231] Create classes to the message that was created with sys pref UpdateItemLocationOnCheckin

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24231

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
I don't think this is valid any longer? On master, these messages get the class
"ret_location_updated." As far as I can tell, that's only used for
UpdateItemLocationOnCheckin messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571

Owen Leonard  changed:

   What|Removed |Added

 Blocks||33324


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324
[Bug 33324] Use template wrapper for tabs: Tools
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33324] New: Use template wrapper for tabs: Tools

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324

Bug ID: 33324
   Summary: Use template wrapper for tabs: Tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 32571

Continuing the work of Bug 32571, I would like to update three templates in the
tools directory to use the new WRAPPER for tabs:

- Export
- Batch patron modification
- Overdue notice/status triggers


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571
[Bug 32571] Use template wrapper to build tabbed components
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28895] Don't fill in items.location with NewItemsDefaultLocation if blank

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28895

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #8 from Andrew Fuerste-Henry  ---
Realized this was sitting in Assigned without an assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33311] Add preference for voice notices

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33311

--- Comment #2 from George Quaye  ---
I am looking for a way for patrons to indicate that they would like to be
called vs sms vs email.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33323] New: Select button in patron search modal is not translatable

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323

Bug ID: 33323
   Summary: Select button in patron search modal is not
translatable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

The modal is used in different places, one example is adding an owner/user to
an acquisition fund. When you search for patrons to add, the select button in
the last table column is not translatable:

It's build with JS and we are missing the right mark-up.

koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:

action_node += 'Select';

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17371] Add routes for biblios [OMNIBUS]

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371
Bug 17371 depends on bug 30799, which changed state.

Bug 30799 Summary: Add REST API route to update biblio metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #15 from Julian Maurice  ---
*** Bug 30799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30799] Add REST API route to update biblio metadata

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799

Julian Maurice  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|In Discussion   |RESOLVED

--- Comment #10 from Julian Maurice  ---


*** This bug has been marked as a duplicate of bug 31801 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33322] New: "Please select at least one suggestion" when doing a catalog search from suggestions page

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322

Bug ID: 33322
   Summary: "Please select at least one suggestion" when doing a
catalog search from suggestions page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Something is not quite right here:

* Go to Suggestions
* Click on catalog search and enter a search term
* Search for it
* You'll get an alert with "Please select at least one suggestion"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745

Katrin Fischer  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com,
   ||n...@bywatersolutions.com

--- Comment #1 from Katrin Fischer  ---
Any idea about this one? I think I saw something similar on the mailing list
too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32763] Display of diacritics in patrons to notify on receiving is broken

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32763

Katrin Fischer  changed:

   What|Removed |Added

Summary|Display of certain  |Display of diacritics in
   |characters from patrons to  |patrons to notify on
   |notify on receiving goes|receiving is broken
   |wrong   |
  Component|Acquisitions|I18N/L10N
 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #146847|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 148615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148615=edit
Bug 32336: Fix encoding of MARCXML output for REST API (UNIMARC)

Test plan:
1. Be sure to test on a UNIMARC instance
2. Enable system preferences RESTPublicAPI and RESTPublicAnonymousRequests
3. Create a biblio with some diacritics
4. Restart koha and do not interact with OPAC or the staff interface
   (this may change $MARC::File::XML::RecordFormat)
5. Query the public API to retrieve the created biblio in MARCXML. For
   instance with cURL:

   curl -H 'Accept: application/marcxml+xml' \
http://koha.local/api/v1/public/biblios/

   You should see encoding issues.
6. Apply the patch and restart Koha.
7. Repeat step 5.
   You should see no encoding issues.
8. You should also test /api/v1/biblios/ (this one
   requires authentication, so cURL might not be the most practical
   tool; use your favorite tool for this)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #146846|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  ---
Created attachment 148614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148614=edit
Bug 32336: Add unit test for UNIMARC encoding problems in REST API

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC)

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #5 from Jonathan Druart  ---
(In reply to Julian Maurice from comment #4)
> 8. You should also test /api/v1/biblios/ (this one
>requires authentication, so cURL might not be the most practical
>tool; use your favorite tool for this)

FYI you can use -u koha:koha ;)

curl -v -s -u koha:koha --request GET 'http://localhost:8081/api/v1/biblios/1'
--header 'Accept: application/marcxml+xml'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33311] Add preference for voice notices

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33311

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
Phone notifications will show as an option if you enable the PhoneNotification
system preference. See Bug 25334, in which this was added. 

But Koha does not contain any mechanism to actually place those calls; that
would rely on some third party service/software and probably a plugin. For
example, this blog post includes discussion of how to set up Twilio Voice in
Koha:
https://bywatersolutions.com/education/koha-question-of-the-week-twilio-koha

Are you looking just for a way for patrons to indicate that they'd like to be
called? Or for something within Koha to place those calls?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

--- Comment #72 from Jonathan Druart  ---
I am getting a conflict here that I managed to resolve, but then a "sha1
lacking or useless" on bug 32496. Could you rebase and eventually push both to
a remote branch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729

--- Comment #29 from Mason James  ---
(In reply to Jonathan Druart from comment #26)
> Why are you logging in plack-error.log?

oops! i've changed log file to plack-watcher.log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729

Mason James  changed:

   What|Removed |Added

 Attachment #148612|0   |1
is obsolete||

--- Comment #28 from Mason James  ---
Created attachment 148613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148613=edit
Bug 31729: renamed log file to plack-watcher.log

to test...

- modify some perl files in watched dir
  $ echo `date` >  /kohadevbox/koha/xxx.pl
  $ echo `date` >  /kohadevbox/koha/xxx.pm

- see HUP/inotify messages in log file
  $ tail -f /var/log/koha/kohadev/plack-watcher.log  \
/var/log/koha/kohadev/plack-error.log
  CLOSE_WRITE,CLOSE happened to xxx.pl in /kohadevbox/koha/
  CLOSE_WRITE,CLOSE happened to xxx.pm in /kohadevbox/koha/
  Sending children hup signal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33306] Agreements list endpoint cannot embed user_roles

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33306

--- Comment #3 from Jonathan Druart  ---
I've just pushed it to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806
Bug 32806 depends on bug 32923, which changed state.

Bug 32923 Summary: x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

--- Comment #39 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #36)
> Created attachment 148507 [details] [review]
> Bug 32923: Allow to embed user_roles for agreements

Patch pushed to master for 23.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #113 from Jonathan Druart  ---
Can we get a signoff from the sponsor?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #112 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #111)
> dataTables.select.min.js, select.dataTables.min.css
> 
> => Are you really using them? I am not seeing them in the rest of the patch.

I mean, I do see the include in the DOM, not where DT is actually using it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #111 from Jonathan Druart  ---
dataTables.select.min.js, select.dataTables.min.css

=> Are you really using them? I am not seeing them in the rest of the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >