[Koha-bugs] [Bug 33399] Improve checks of other items to determine if this is a valid recall

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399

--- Comment #1 from Aleisha Amohia  ---
Created attachment 149112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149112=edit
Bug 33399: [WIP] Improve checks of other items to determine if valid recall

This patch employs the following checks to determine if it is valid for a
patron to place a recall:
- that we don't include items already allocated to a hold (i.e. hold 'is
found') when counting for recallable items
- that we don't include items that aren't allowed to be recalled (based on the
recallsallowed circulation rule) when counting for recallable items

Test plan coming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33399] Improve checks of other items to determine if this is a valid recall

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33399] New: Improve checks of other items to determine if this is a valid recall

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399

Bug ID: 33399
   Summary: Improve checks of other items to determine if this is
a valid recall
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

One of the circulation rules relating to recalls is 'on shelf recalls' - this
can either be 'if any unavailable' or 'if all unavailable'.

When checking if a recall is valid, we check this circ rule and count how many
items are checked out to determine if we satisfy this criteria. However, items
that are checked out are not the only items that are unavailable to be
recalled.

Items that are lost, withdrawn or notforloan are unavailable to be recalled
too. These are already excluded.

We should also exclude items that:
- are allocated to holds i.e. awaiting pickup for a hold
- not allowed to be recalled i.e. recallsallowed =

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

--- Comment #18 from David Cook  ---
(In reply to David Cook from comment #17)
> I think I need to refactor this one.
> 
> Need to move the code into a separate module and add unit tests for it. 

Although that's hard to do because it needs to produce SQL specific to the
GetTopIssues function in C4::Circulation...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

--- Comment #17 from David Cook  ---
I think I need to refactor this one.

Need to move the code into a separate module and add unit tests for it. 

The Hidden and Suppression fields need more methods built up around them...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook  ---
Any chance of this getting backported to 22.11 as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl)

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Passed QA

--- Comment #4 from Victor Grousset/tuxayo  ---
Works, QA script happy, code looks good, makes sense, passing QA :)

Thanks Aleisha for the functional relevance confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl)

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #147177|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 149111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149111=edit
Bug 33040: Add "Date published (text)" to serials tab on record view
(detail.pl)

Some libraries would like to see the "Date published (text)" in the serials tab
on the "Normal" record view ( aka catalogue/detail.pl ).

Test Plan:
1) View the serials tab on detail.pl for a subscription where the latest
   serial has a "Date published (text)" field populated.
2) Apply this patch
3) Restart all the thigns!
4) Browse to detail.pl for that record
5) View the Subscriptions tab
6) Note the "Date published (text)" column exists now!

Signed-off-by: Matt Blenkinsop 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33398] New: Allow hold notification_method to be based on either messaging preferences or primary_contact_method

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398

Bug ID: 33398
   Summary: Allow hold notification_method to be based on either
messaging preferences or primary_contact_method
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a waiting hold is triggered a popup appears that includes "Patron
notification:". This is based on the patron messaging preferences for 'Hold
filled'.

We should allow libraries to choose between having this based on messaging
preferences or primary_contact_method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

--- Comment #3 from Catrina Berka  ---
Thank you, Lucas! This is exactly right and the patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #149109|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 149110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149110=edit
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system
preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

Signed-off-by: Catrina 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30648] Title is lost in holds history when biblio is deleted

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

--- Comment #1 from Lucas Gass  ---
Created attachment 149109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149109=edit
Bug 33390: Add links to various system preference descriptions

To test:
1. Apply patch and look at the descriptions of the following system
preferences. Make sure each link works and makes sense:

DefaultLongOverdueChargeValue
DefaultLongOverdueLostValue and DefaultLongOverdueDays
DefaultLongOverdueSkipLostStatuses
UpdateItemWhenLostFromHoldList

NewItemsDefaultLocation
UpdateItemLocationOnCheckin

SkipHoldTrapOnNotForLoanValue
UpdateNotForLoanStatusOnCheckin
Reference_NFL_Statuses

ItemsDeniedRenewal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
Version|22.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261

David Nind  changed:

   What|Removed |Added

 Attachment #148352|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 149108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149108=edit
Bug 33261: Format dates in subscription_issues table

To test:
* Add a subscription
* Receive some issues
* Go to the subscription detail page, issues tab
* Verify the dates there display as -MM-DD
* Change DateFormat system preference setting, nothing changes.
* Apply patch
* Date should now be formatted in the way specified in the DateFormat system
preference

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363

--- Comment #1 from Kristi  ---
Thank you for submitting a bug report for this, Donna!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
Hi Alex.

This works well.

My only comment would be to add a hint or note to the 1PageOrderPDFText system
preference about the length of the text.

I added multiple long paragraphs and the text was cut off where the order table
starts, and does not display the delivery comment.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393

David Nind  changed:

   What|Removed |Added

 Attachment #149078|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 149106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149106=edit
Bug 33393: Enable libraries to configure their own text in the 1-Page order PDF

Test plan:
1) Apply patches and restart services
2) Upgrade Koha schema:
sudo koha-upgrade-schema 
3) Go to Koha Administration -> Libraries. Ensure Library A has an
address, phone and fax.
4) Go to Koha Administration -> System preferences. Search for
OrderPdfFormat. Set this to English 1-page layout option.
5) Go to Acquisitions. Use an existing vendor or create a new one.
Ensure the vendor has a postal address, phone, fax and accout number.
6) Create a basket for this vendor. Add many orders to this basket, for
example 25 items (this is to make the Order PDF cover multiple pages).
7) Close the basket and add it to a basket group of the same name.
8) Edit the basket group. Add an address in the delivery place, and a
delivery comment. Check the box to close the basket group and Save.
9) Click the button to Export as PDF.
10) View the exported PDF. Confirm the PDF is multiple pages long. If it
is not then re-open the basketgroup and add more orders to the basket
and repeat steps 7, 8, and 9
11) If the PDF is multiple pages long then confirm:
- The text "Order number must appear on all related correspondence, shipping
papers and invoices. Notify us immediately if you are unable to supply
item(s)." appears above the order table.
- The page numbers at the bottom of the first page are not obscured by
the order table.
- That the order table starts near the top of the second page, and not
half way down.
12) Change content in the '1PageOrderPDFText' syspref (use the Enter key
to split text over multiple lines) and save
13) Back in the Acquisitions module click the button to Export as PDF
14) View the exported PDF. Confirm the following:
- The text above the order table is what you saved in the
1PageOrderPDFText system preference
- The page numbers at the bottom of the first page are not obscrued by
the order table.
- That the order table starts near the top of the second page and not
halfway down.
15) Empty the 1PageOrderPDFText system preference and save
16) Back in the Acquisitions module click te button to Export as PDF
17) View the exported PDF and confirm the line of text between the
Tel/Fax line and the order table has been removed.

Sponsored-by: Pymble Ladies' College
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #10 from Caroline Cyr La Rose  ---
Created attachment 149105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149105=edit
Bug 26403: (follow-up) Deleted old SQL files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #9 from Caroline Cyr La Rose  ---
Created attachment 149104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149104=edit
Bug 26403: "Issue refund" is not fully translatable

This patch moves account debit and credit types, as well as the CASH
payment type, into YAML files under
installer/data/en/mandatory. This should make the debit and credit types
translatable (for new installations only).

To test:
1. Apply patch
2. Update po files
   ./misc/translator/translate update xx-XX
3. View the xx-XX-installer.po file
   -->The default account debit and credit types (and cash payment type)
  should be available to be translated
4. Translate the strings
5. Apply the translations
   ./misc/translator/translate install xx-XX
6. Load the new translated YAML files (with a fresh install, or by deleting
   the values in the db and using ./misc/load_yaml.pl to load the files)
7. In the staff interface, go to Administration > Credit types
   --> They should be translated
8. Go to Administration > Debit types
   --> They should be translated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981

--- Comment #2 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #0)
> This could work just like bsort1 and bsort2 for the statistic fields. We add
> a AV category that is emtpy, but once it is filled in, the pronouns field
> will show up as a pull down. While it's empty, it's a free text field.

I just filed this Bug 33397, the way we add custom values can result in data
loss.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33397] Adding custom authorized values for bsort1/bsort2 can result in data loss

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33397

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33397] New: Adding custom authorized values for bsort1/bsort2 can result in data loss

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33397

Bug ID: 33397
   Summary: Adding custom authorized values for bsort1/bsort2 can
result in data loss
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:

1. Without having custom authorized values for bsort1/bsort2 create of edit
some patrons with sort1 and sort2 values in their borrower information.
2. sort1/sort2 are free text fields
3. Create a new bsort1 and bsort2 authorized values. 
4. Go back to the patron record and notice the free text field is now a
dropdown with the newly create authorized values.
5. Save the patron record without changing anything.
6. The initial values for sort1/sort2 are now empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33396] New: Request: link showing all courses in a particular department

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33396

Bug ID: 33396
   Summary: Request: link showing all courses in a particular
department
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ton...@swau.edu
QA Contact: testo...@bugs.koha-community.org

It would be nice to have a link, or option, that shows all courses in a
particular department.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #123 from Kelly McElligott  ---
In testing this bug, I found the multi-receiving option for the basket "create
items on receiving" to not work as expected. 

I have three orders for my basket, creating items on receiving.  Each order has
2 items in it.  When I click the three orders from this basket, I am brought to
a model which displays the titles and the number I should be receiving on each
title.  My option is to click edit to the far right of the screen.  This model
pops up in the tab "info'. I click over to the Item tab, and am brought to an
item template, to create the item that I am receiving.  Below the item
template, that I have options, Add Item, Clear, Add multiple Items (which are
choices one has generally). Further down, I have choices, Previous, Close, Save
Changes and Next.  When I fill out my item, I can choose to Save Changes, but
my item is not received.  If I am receiving multi, I choose Next and fill out
the next item template, but again, my receiving is not recorded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30096] Allow to change "late issue notification" setting in subscriptions batch modification tool

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #2 from Laura Escamilla  ---
(In reply to Julian Maurice from comment #1)
> Created attachment 130550 [details] [review]
> Bug 30096: Add "late issue notification" to subscriptions batch mod tool
> 
> This patch depends on bug 29997
> 
> Test plan:
> 1. On the Serials module main page, do a search that return at least 2
>subscriptions
> 2. Check at least 2 boxes in the first column of the table, then click
>on "Edit selected serials" above the table
> 3. Verify that the table above the form display correct data for the
>"Late issue notification" column
> 4. Submit the form without changing anything. Verify that the setting
>"late issue notification" was not changed for selected subscriptions
> 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the
>available options and submit the form. Verify that the setting "late
>issue notification" was changed to the selected option for all
>selected subscriptions

Received this error when applying the patch: 

Received the error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Unknown column 'me.librarian' in 'field list' at
/kohadevbox/koha/Koha/Objects.pm line 96
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30095] Allow to change "warn when late" setting in subscriptions batch modification tool

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095

--- Comment #3 from Laura Escamilla  ---
My apologies - this is the correct error code received when applying the patch: 


Template process failed: file error - parse error -
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt line
327: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30095] Allow to change "warn when late" setting in subscriptions batch modification tool

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095

Laura Escamilla  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Laura Escamilla  ---
(In reply to Julian Maurice from comment #1)
> Created attachment 130549 [details] [review]
> Bug 30095: Add "warn when late" to subscriptions batch mod tool
> 
> This patch depends on bug 29996
> 
> Test plan:
> 1. On the Serials module main page, do a search that return at least 2
>subscriptions
> 2. Check at least 2 boxes in the first column of the table, then click
>on "Edit selected serials" above the table
> 3. Verify that the table above the form display correct data for the
>"Warn when late" column
> 4. Submit the form without changing anything. Verify that the setting
>"warn when late" was not changed for selected subscriptions
> 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the
>form. Verify that the setting "warn when late" was changed to "No"
>for all selected subscriptions
> 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the
>form. Verify that the setting "warn when late" was changed to "Yes"
>for all selected subscriptions

Received the error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:
DBD::mysql::st execute failed: Unknown column 'me.librarian' in 'field list' at
/kohadevbox/koha/Koha/Objects.pm line 96
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236

Andrew Auld  changed:

   What|Removed |Added

 CC||andrew.a...@ptfs-europe.com
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Andrew Auld  ---
Tested on OPAC and Staff side on sandbox successfully. Suggestions
functionality all works as it should.

Only thing I couldn't verify was the actual sending of emails relating to
suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148221|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 149103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149103=edit
Bug 33236: Move NewSuggestion to Koha::Suggestion->store

The NewSuggestion routine saved the suggestion to the DB
and returned the id

This patch moves the code to Koha::Suggestion->store and
handles emailing upon creation, this adds that functionality to
suggestions added via api

To test:
1 - Apply patch
2 - Test adding a suggestion on the opac and staff client
3 - Confirm the suggestions are added correctly

Signed-off-by: Andrew Auld 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #95 from Laura Escamilla  ---
(In reply to The Minh Luong from comment #94)
> Created attachment 131094 [details] [review]
> Bug 12532: Send email to guarantee and guarantor;
> 
> This patch allows guarantors to receive emails sended to their
> guarentees. This patch is a rebase of the previous patches.
> NOTE: Attachment "Rebase and correction of the patch by adding the
> possibility of sending emails to several guarantors" generate an sha1 error.
> I had to took its content and put it in another commit.
> 
> TO TEST:
> 
> Before applying:
> 1) Search, or create, a patron with guarantor.
> 2) Enable checkout emails for both guarantors and guarantees.
> 3) Checkout an item. An email should be sent only to the guarantee.
> 4) Apply the patch.
> 5) Run updatedatabase.pl
> 6) Enable 'RedirectGuaranteeEmail'
> 7) Run misc/cronjobs/process_message_queue.pl
> 8) Notice that the email should be sended to both the guarantee AND the
> guarantor.


Emails were only sent to the guarantee and not the guarantor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #149102|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33395] New: Patron search results shows only overdues if patron has overdues

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395

Bug ID: 33395
   Summary: Patron search results shows only overdues if patron
has overdues
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When you search for patrons, in the results table, there is a Checkouts column.

If the patron has no checkouts, it shows 0 / 0 (0 overdues / 0 total
checkouts).

If the patron has checkouts but no overdues, it shows, for example, 0 / 1 (0
overdues / 1 total checkout).

If the patron has only overdues, it shows, for example, only 1 in red (1
overdue ?? total checkouts?).

If the patron has checkouts and overdues, it shows, for example, only 1 in red
also (1 overdue ?? total checkouts?)

It's like if there are overdues, the number of checkouts disappear.

To replicate:
1. Make sure SpecifyDueDate is enabled
2. Have 4 patrons (I used 4 patrons with B last names to see them all in one
go)
3. Checkout items as follows
   -  Checkout 1 item normally to Patron A
   -  Checkout 1 item to Patron B, specifying a due date in the past
   -  Checkout 1 item normally and 1 item with a past due date to Patron C
   -  Nothing to Patron D
4. Go to Patrons and search for the patrons, making sure there are more than
one results
   --> In the results table, the Checkouts column is like this
   Patron A: 0 / 1
   Patron B: 1 (red)
   Patron C: 1 (red)
   Patron D: 0 / 0

For Patron B, it should be (I think?) 1 / 1
For Patron C, it should be (I think?) 1 / 2

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33394] Cancelled holds report/tab

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33394

Sara Brown  changed:

   What|Removed |Added

Summary|Cancelled holds report/tab? |Cancelled holds report/tab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664

--- Comment #9 from Laura Escamilla  ---
Created attachment 149102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149102=edit
Bug 29664: WIP Test Patch

Test plan:
1. In a patron account create a manual fee of $5.00 - save and pay. 
2. In the same patron account, create a manual fee of $1.00 - save and pay. 
3. Under Transactions, void the payment of $5. Ensure that the “Account Type”
shows that the $5 amount has been voided. 
4. Go to Reports > Cash Register > Make sure that the “Transaction Type” is
showing as “All payments to the library” > Run the report.
1. Check that both the $5.00 voided payment and the $1.00 regular payment
are shown in the report. 
5. Run the report again, but this time change the “Transaction Type” to “Credit
has been voided”. Only the $5.00 voided payment should appear. 
6. Apply the patch and restart services. 
7. Repeat step 4. The report should only show the $1 payment. 
8. Repeat step 5. No changes should occur - the $5.00 voided payment should
still show.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21638] Allow reporting of holds cancelled by cancel_expired_holds.pl and ExpireReservesMaxPickUpDelay

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21638

Sara Brown  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33394

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33394] Cancelled holds report/tab?

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33394

Sara Brown  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21638

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33394] New: Cancelled holds report/tab?

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33394

Bug ID: 33394
   Summary: Cancelled holds report/tab?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sbr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Many libraries might find it helpful if there were a built-in way to view what
waiting holds have been cancelled either by cancel_expired_holds.pl or by
staff, especially when the staff cancelling the hold is at a different branch
than where the hold is waiting. Right now, libraries have to use reports to see
what holds have been cancelled, but those are less convenient than a tab or
other direct view and may be unavailable to some staff depending on their
permissions. Currently, if a staff member at branch A cancels a hold waiting at
branch B (if, for instance, the patron found another copy of the item at branch
A so no longer needs the branch B copy), the branch A staff has to call branch
B to ask them to remove the item from the holds shelf if they don't want it to
stay on the shelf until it expires.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387

--- Comment #1 from Owen Leonard  ---
Created attachment 149101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149101=edit
Bug 33387: Use template wrapper for breadcrumbs: Patrons part 3

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Patrons home page
- Patron detail page ->
  - Change password
  - Set permissions
  - Accounting ->
- Create manual invoice
- Create manual credit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Lucas Gass  changed:

   What|Removed |Added

 Attachment #148892|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 149100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149100=edit
Bug 32127: Add unit test

Run prove t/db_dependent/Template/Plugin/Categories.t

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Lucas Gass  changed:

   What|Removed |Added

 Attachment #148891|0   |1
is obsolete||

--- Comment #11 from Lucas Gass  ---
Created attachment 149099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149099=edit
Bug 32127: Sort by description in Koha::Template::Plugin::Categories

Like in Koha::Template::Plugin::Branches, methods in
Koha::Template::Plugin::Categories must return categories sorted by
description.

Test plan :
1) Create a new patron category with code ZZZ and description AA
2) Go to patron search /cgi-bin/koha/members/members-home.pl
3) Look at filter by category :
=> Without patch the value AA is last
=> With patch the value AA is first
4) Click on 'New patron'
=> Without patch the value AA is last
=> With patch the value AA is first

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32127] Sort patron categories by description in templates

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
This works and tests pass. On /cgi-bin/koha/members/members-home.pl the
dropdown sorts by description. 

If you click 'New patron', it sorts by description. 

If you are in '/members/memberentry.pl' and click the dropdown for 'Category:'
it still sorts by code. 

I will sign-off here and we can address that in separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373

Lucas Gass  changed:

   What|Removed |Added

 Attachment #149036|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 149098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149098=edit
Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3

This patch updates several circulation templates so that they use the
new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Circulation ->
  - Article requests -> Article request detail
  - Check in
  - Hold ratios
  - Transfers to send
  - Transfers to receive
  - Holds queue
  - Holds awaiting pickup
  - Set library

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Lucas Gass  changed:

   What|Removed |Added

 Attachment #149062|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 149097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149097=edit
Bug 33391: Prevent applying hover style on navmenulist currently active item

* Apply patch
* Run yarn css:build
* Do the 2nd example above again and verify

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

cathleen cole  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
 CC||cathl...@hchlibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

--- Comment #15 from Tomás Cohen Arazi  ---
Thanks for those follow-ups, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 149096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149096=edit
Bug 29234: Further clean Z3950 Tests

We are deleting all authorised values in Session2.t and assuming they don't
exist in Sesson.t

This patch ensures the tests will work regardless of data in DB

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 149095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149095=edit
Bug 29234: Set datesent for transfers in Z3950 Responder tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #149094|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #149093|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

--- Comment #12 from Nick Clemens  ---
Created attachment 149094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149094=edit
Bug 29234: Further clean Z3950 Tests

We are deleting all authorised values in Session2.t and assuming they don't
exist in Sesson.t

This patch ensures the tests will work regardless of data in DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234

--- Comment #11 from Nick Clemens  ---
Created attachment 149093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149093=edit
Bug 29234: Set datesent for transfers in Z3950 Responder tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23824] Add a ‘Save and run’ button to reports

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

Laura Escamilla  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #8 from Laura Escamilla  ---
(In reply to Magnus Enger from comment #7)
> I have taken the liberty of making a patch more in line with Katrin's
> suggestions.

Patch did not apply. 

CONFLICT (content): Merge conflict in reports/guided_reports.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23824: Add a Save and Run button to exports
[33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32976] Patron image Add/Edit button should not appear if permission is turned off

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32976] Patron image Add/Edit button should not appear if permission is turned off

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32447] In items table barcode column can not be filtered

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447

--- Comment #17 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32447] In items table barcode column can not be filtered

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25590] Street number is missing from alternate address in the OPAC

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590

--- Comment #11 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25590] Street number is missing from alternate address in the OPAC

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

David Nind  changed:

   What|Removed |Added

 Attachment #146944|0   |1
is obsolete||

--- Comment #32 from David Nind  ---
Created attachment 149092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149092=edit
Bug 32418: Can't call method 'unblessed' on an undefined value at
cataloguing/additem.pl

Check whether the current op is edititem or dupeitem and if so check
whether the itemnumber supplied as a query param actually exists.

If it doesn't, redirect to the additem op and hide all UI elements except
for a dialog that gives options to add a new item to the record or to
view the records holdings.

This behaviour was adapted from the addbiblio view, as suggested by
Fridolin.

To test:
1. Go to any record
2. Hit the edit button on an item in the holdings table
3. Modify the URL so that the query param for the itemnumber is either
3.1 empty:
/cgi-bin/koha/cataloguing/additem.pl?op=edititem=384=
3.2 an itemnumber that doesn't exist:
 
/cgi-bin/koha/cataloguing/additem.pl?op=edititem=384=99
3.3 whatever else you come up with..
4. Check the same thing for the dupe option (op=dupeitem)
5. Sign off

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #148897|0   |1
is obsolete||

--- Comment #82 from Biblibre Sandboxes  ---
Created attachment 149091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149091=edit
Bug 11844: Add tests for marcfield_mode

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #148895|0   |1
is obsolete||

--- Comment #81 from Biblibre Sandboxes  ---
Created attachment 149090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149090=edit
Bug 11844: Add tests for TransferOrder

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #148889|0   |1
is obsolete||

--- Comment #80 from Biblibre Sandboxes  ---
Created attachment 149089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149089=edit
Bug 11844: Add tests for Koha::AdditionalField

Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146506|0   |1
is obsolete||

--- Comment #79 from Biblibre Sandboxes  ---
Created attachment 149088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149088=edit
Bug 11844: (follow-up) Add format hint to the additional fields admin page

The MARC field needs to be added with a $ between field and subfield
for things to work right. So this adds a hint about the expected format.

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146505|0   |1
is obsolete||

--- Comment #78 from Biblibre Sandboxes  ---
Created attachment 149087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149087=edit
Bug 11844: (follow-up) Add new option to acq navigation

The navigation on the left in the acq module has links to
the additional fields for baskets and invoices. This also
adds a link for the new order lines feature.

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146504|0   |1
is obsolete||

--- Comment #77 from Biblibre Sandboxes  ---
Created attachment 149086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149086=edit
Bug 11844: (follow-up) Add standard note to database update

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146503|0   |1
is obsolete||

--- Comment #76 from Biblibre Sandboxes  ---
Created attachment 149085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149085=edit
Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record

This is about the note displaying after an additional field
that is linked to a MARC field.

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146502|0   |1
is obsolete||

--- Comment #75 from Biblibre Sandboxes  ---
Created attachment 149084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149084=edit
Bug 11844: [DO NOT PUSH] Schema changes

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146501|0   |1
is obsolete||

--- Comment #74 from Biblibre Sandboxes  ---
Created attachment 149083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149083=edit
Bug 11844: Fix QA issues (POD, TT filters, file exec flag)

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146500|0   |1
is obsolete||

--- Comment #73 from Biblibre Sandboxes  ---
Created attachment 149082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149082=edit
Bug 11844: Take into account itemtypes, branches, and cn_source

MARC subfields can be linked to "authorised values" that are not real
authorised values: itemtypes, branches, and cn_source.
Those were not taken into account. This patch fixes that

Test plan:
1. Create additional fields for order lines with a MARC subfield that is
   linked to one of those "fake" authorised values list
2. Follow the same steps as in the main test plan

Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #146497|0   |1
is obsolete||

--- Comment #72 from Biblibre Sandboxes  ---
Created attachment 149081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149081=edit
Bug 11844: Use additional fields for order lines

This patch allows to create additional fields for order lines.
Once created, these fields can be filled during order line creation or
modification.

If additional field is linked to a MARC field, there are two possible
scenario:
- MARC field mode = get: The field cannot be modified and its value is
  retrieved from the bibliographic record (current behaviour)
- MARC field mode = set: The field can be modified and its value is
  saved to the bibliographic record (new behaviour)

If additional field is linked to an authorised value category, then
authorised values are used. If not directly linked to an authorised
value category, but linked to a MARC field, a search for an AV category
is made on MARC default framework.

This patch doesn't display additional fields value anywhere (except in
order line creation/modification). Future patches will do that.

Test plan:
1/ Go to Acquisitions home
2/ In the left menu, click on "Add order line fields"
3/ Click on "New field" button
4/ Give the field a name (unique), no AV category and no MARC field.
5/ Save.
6/ Create 5 other fields:
   a/ no AV category, a MARC field not linked to AV category, MARC field
  mode = get
   b/ no AV category, a MARC field not linked to AV category, MARC field
  mode = set
   c/ no AV category, a MARC field linked to AV category, MARC field
  mode = get
   d/ no AV category, a MARC field linked to AV category, MARC field
  mode = set
   e/ an AV category, no MARC field
7/ Create everything you need to be able to create order lines
   (supplier, basket, ...)
8/ Create an order line. At bottom of the page, you should see your
   additional fields, with authorised values dropdrown list for fields
   (c), (d) and (e). Fields (a) and (c) should be disabled.
9/ Fill these fields with some data and save order line
10/ check that data was correctly saved into biblio for fields (b) and
(d), but not for (a) and (c)
11/ modify the same order line, check that values you've filled are
correctly retrieved and that values for (a) and (c) were correctly
retrieved from the bibliographic record
12/ modify all values, save, and check biblio once again

Signed-off-by: Harold Dramer 
Signed-off-by: Katrin Fischer 
Signed-off-by: Michaela Sieber 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391

Pedro Amorim  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418

--- Comment #31 from Paul Derscheid  ---
Hi Katrin, this is ready for retesting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23824] Add a ‘Save and run’ button to reports

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

Magnus Enger  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Magnus Enger  ---
I have taken the liberty of making a patch more in line with Katrin's
suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23824] Add a ‘Save and run’ button to reports

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

--- Comment #6 from Magnus Enger  ---
Created attachment 149080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149080=edit
Bug 23824: Add a "Save and run" button to reports [alternative]

This will save one click every time you want to save and then run
a report.

To test:
- Apply this patch
- Create a new report
- Click the new "Update and run SQL" button
- Verify the report was saved and the results are displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/