[Koha-bugs] [Bug 33850] New: Holdings - showing data on hover
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33850 Bug ID: 33850 Summary: Holdings - showing data on hover Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org What if the table columns option gave a third option to reveal information on hover? Maybe you don't want so much data filling up the table, but if you gave a hover option, an eyeball icon would appear in the table next to items, and if you hover over it, it shows all the data that is hidden but hoverable. For example, 22.11 introduces 2 more columns: issues and renewals. Maybe I don't want to cram so much into the table, but if I had an option to hover, I could easily see that info anytime by hovering over that row's eye. This keeps the table clutter free, but I wouldn't have to navigate away or reconfigure the table. It's just easier and cleaner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #38 from Laura Escamilla --- Created attachment 151771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151771=edit Bug 33117: New system preference - PatronAutoCompleteSearchMethod New Test Plan: 0. Ensure system preference PatronAutoComplete is set to Try 1. Create a patron that has a first name, middle name and two surnames. (i.e. Adela Maria, Hernandez Acosta). 2. In patron or checkout search, enter their first name and first surname without submitting. 3. Confirm that a record is found in the autocomplete results 4. In patron or checkout search, enter their first name and second surname without submitting. 5. Confirm that no record is found. 6. Enter their middle name and first surname. Confirm that no record is found. 7. Enter their middle name and second surname. Confirm that no record is found. 8. Apply the patch, update database 9. Under Administration > Global System Preferences > search for "PatronAutocompleteSearchMethod" 10. Choose "Contains" instead of "Starts with" for the system preference, reload your search page 11. Repeat steps 2-4. The patron record should appear for all search methods. 12. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33849] Duplicate patron warning resets borrowers branch if different than logged in user's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 ddem...@oslri.net changed: What|Removed |Added CC||ddem...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33849] New: Duplicate patron warning resets borrowers branch if different than logged in user's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33849 Bug ID: 33849 Summary: Duplicate patron warning resets borrowers branch if different than logged in user's branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When entering a new patron, if the patron's home library is not the same as the logged-in library of the user + the patron is flagged as a possible duplicate, the patron's home library reverts to the logged in user's library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 --- Comment #1 from Nick Clemens --- Created attachment 151770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151770=edit Bug 32695: Use title (subfield t) only for 'Other editions' search links Currently the code does a title phrase search, but combines the title field with the Main Entry (author) field. This patch simply limits the search to the title to ensure links work To test: 1 - Ensure systme preference 'UseControlNumber' is set to don't 2 - Edit Default MARC framework in administration->Marc frameworks 3 - Make 775 subfields a & t visible in editor 4 - Edit a record to add a field 775 with subfields a & t that match another title/author in your system 5 - Save the record and view the details page 6 - Click the other editions link - no results 7 - Apply patch, restart_all 8 - Reload details and confirm the link works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32695] Search string for 775 'Other editions' is incorrectly formed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #23 from Marcel de Rooy --- (In reply to Owen Leonard from comment #22) > I did not run the command with an extra exclamation mark. > > > Cannot detect source of 't/db_dependent/Stats.t'! > > The exclamation mark is added by the error message. > > I guess I assumed that Stats.t existed because the test plan said so: > > > Test plan: > > Run t/db_dependent/Stats.t t/db_dependent/Koha/Statistics.t | 144 +- t/db_dependent/Stats.t | 168 --- 2 files changed, 119 insertions(+), 193 deletions(-) delete mode 100755 t/db_dependent/Stats.t They are merged in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #22 from Owen Leonard --- I did not run the command with an extra exclamation mark. > Cannot detect source of 't/db_dependent/Stats.t'! The exclamation mark is added by the error message. I guess I assumed that Stats.t existed because the test plan said so: > Test plan: > Run t/db_dependent/Stats.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Owen Leonard changed: What|Removed |Added Blocks||33848 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33848] New: Enabling Coce in the OPAC breaks cover images on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Bug ID: 33848 Summary: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: andrew.a...@ptfs-europe.com, jbal...@gmail.com, jonathan.druart+k...@gmail.com, lu...@bywatersolutions.com, testo...@bugs.koha-community.org Depends on: 32412 If you enable multiple cover image services, including Coce, the bibliographic detail page in the OPAC doesn't display all covers. Viewing a title with Amazon, Google, Coce, and OpenLibrary, only the Amazon and Google images display. In the console is an error message: Uncaught TypeError: parent.find is not a function getURL http://localhost:8080/opac-tmpl/bootstrap/js/coce_22.1200048.js:20 The script stops processing other sources when Coce fails. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33775] Different/no results between Check Out and Search Patron when searching for names with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33775 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #1 from Nick Clemens --- This might be bug 33117 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16243] Add reference manager software (Mendeley and EasyBib) to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16243 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Laura Escamilla changed: What|Removed |Added Attachment #151317|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #37 from Laura Escamilla --- Created attachment 151769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151769=edit Bug 33117: Adding new PatronAutoCompleteSearchMethod system preference Test Plan: 0. Ensure system preference PatronAutoComplete is set to Try 1. Create a patron that has a first name, middle name and two surnames. (i.e. Adela Maria, Hernandez Acosta). 2. In patron or checkout search, enter their first name and first surname without submitting. 3. Confirm that a record is found in the autocomplete results 4. In patron or checkout search, enter their first name and second surname without submitting. 5. Confirm that no record is found. 6. Enter their middle name and first surname. Confirm that no record is found. 7. Enter their middle name and second surname. Confirm that no record is found. 8. Apply the patch, update database 9. Under Administration > Global System Preferences > search for "PatronAutocompleteSearchMethod" 10. Choose "Contains" instead of "Starts with" for the system preference, reload your search page 11. Repeat steps 2-4. The patron record should appear for all search methods. 12. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #151757|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 151768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151768=edit Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #151756|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 151767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151767=edit Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #151755|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 151766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151766=edit Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #151754|0 |1 is obsolete|| --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 151765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151765=edit Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #1 from Kyle M Hall --- Created attachment 151764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151764=edit Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. Test Plan: 1) Check out Koha 22.05.05 2) Create a default all/all/all rule, 3 other rules. Ensure they all have issuelength set to 7, with one of the non-default rules having an issuelength of 14. 3) Delete all but one of the non-default rules with the following query: Delete from circulation_rules where rule_name = 'issuelength' and ( issuelength != 14 or ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2; 4) Check out Koha 22.05.06 4) Run updatedatabase.pl 5) Note the rules were recreated with the value 0 6) Repeat steps 1-4 7) Apply this patch 8) Run updatedatabase.pl 9) Note the rules were recreated, but the value is the derived value from the all/all/all rule! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kyle M Hall changed: What|Removed |Added Blocks||33847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kyle M Hall changed: What|Removed |Added Depends on||29012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] New: Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Bug ID: 33847 Summary: Database update replaces undefined rules with defaults rather than the value that would be used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Nick Clemens changed: What|Removed |Added Blocks||33788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Nick Clemens changed: What|Removed |Added Depends on||32272 CC||n...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 --- Comment #2 from Nick Clemens --- Created attachment 151763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151763=edit Bug 33788: Limit the number of old issues rows returned This patch updates the parameter from 'limit' to 'rows' To test: 1 - Checkout an item to 5 different people 2 - View item details on items tab of record 3 - Note you see last borrower, and three previous borrowers 4 - Apply patch, restart all 5 - Refresh page 6 - You shoulw now only see last borrower and 2 previous borrowers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23305] Add ability to append to item notes in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23305 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Andrew Fuerste-Henry --- This is possible since bug 29781. Using capturing groups in a regex substitution, one can basically say "replace the current note with the current note plus these new words." A very basic example, if one wanted to append the text "Disc cleaned 5-26-23" to all notes on a group of items, one could put "(.*)" in the Regex Pattern and "$1 Disc Cleaned 5-26-23" in the Regex Replacement in the item batch mod interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27347] Allow automatic item modification by age to match NULL values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27347 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29941 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29941] Automatic item modification by age should be able to set a value to NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29941 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27347 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #27 from Matt Blenkinsop --- It didn't make any difference unfortunately, the key functionality is the same as the v-select so the same issues arose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524
--- Comment #1 from Owen Leonard ---
Created attachment 151762
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151762=edit
Bug 33524: Use template wrapper for tabs: Authority editor
This patch updates the authority editor template to replace tab markup
with the use of WRAPPERs. Some CSS and JS has been modified in order to
make the custom style and behavior of the tabs on this page work
correctly with standard Bootstrap tab markup.
To test, apply the patch and go to Authorities -> New authority.
- Confirm that the tabs look correct, with the same style they had
before the template change.
- The first tab ("0") should be selected by default.
- Confirm that tab-switching works correctly: The tab color should
change and the list of numbered tags in the menu just below should
change to match the section.
- Confirm that these tag number links still work correctly to jump you
down the page to the corresponding tag.
- Without filling in any mandatory fields, click the "Save" button.
- You should get an error message about missing mandatory fields.
- Clicking the "Go to field" link should take you to the correct tab
and the correct tag.
- Append a hash to the URL to pre-select a tab other than the first one,
e.g.
"/cgi-bin/koha/authorities/authorities.pl?authtypecode=PERSO_NAME#tab5XX_panel"
The correct tab should be selected upon page load.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Owen Leonard changed: What|Removed |Added Blocks||33524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 [Bug 33524] Use template wrapper for tabs: Authority editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33524] Use template wrapper for tabs: Authority editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||33525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 [Bug 33525] Use template wrapper for tabs: Basic MARC editor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Tomás Cohen Arazi changed: What|Removed |Added Blocks||33846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33846] 'Save' and 'close' buttons confusing on multi-receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com Depends on||8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33846] New: 'Save' and 'close' buttons confusing on multi-receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Bug ID: 33846 Summary: 'Save' and 'close' buttons confusing on multi-receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org I'm opening this so we don't forget. Talking with Kyle and Nick, we agreed the 'Save' button is weird, in the sense that it is not saving but updating the underlying table which can then be used to receive. And there's the 'Close' button, that seems to be doing the same thing i.e. closing the modal. Plus, there's no real way of 'resetting' your changes which is the usual thing we have: a confirm button and a cancel. I'm not sure what is the best solution here, but we could have: - Close (which updates the underlying table) - Cancel link (which resets any changes you've made) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #151758|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 151761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151761=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set. We set the unitprice in the table row so that it will be used when editing and will be saved even if not adjusted To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should check column from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy changed: What|Removed |Added Summary|item->is_denied_renewal |item->is_denied_renewal |should validate fields from |should check column from |associated pref |associated pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #2 from Marcel de Rooy --- Created attachment 151760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151760=edit Bug 33844: Fix is_denied_renewal Going via result_set->has_column does cost actually nothing if the object is already there. Test plan: Run again t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 --- Comment #1 from Marcel de Rooy --- Created attachment 151759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151759=edit Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33844] item->is_denied_renewal should validate fields from associated pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33844 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #7 from Tomás Cohen Arazi --- Can we make this happen before wednesday? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33830] Title and author not on same line anymore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33830 --- Comment #5 from Owen Leonard --- (In reply to Fridolin Somers from comment #4) > We should do the same in staff interface maybe. The staff interface already has this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens changed: What|Removed |Added Attachment #151469|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 151758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151758=edit Bug 33783: (bug 8179 follow-up) Populate actual cost with ecost during receiving if not set This restores behavior prior to 8179 to use the estimated cost when receiving if the actual cost is not set. We set the unitprice in the table row so that it will be used when editing and will be saved even if not adjusted To test: 1 - Add some orders to a basket, do not set actual cost field 2 - Close basket, receive orders 3 - Note actual cost field is blank 4 - Cancel receipt 5 - Apply patch 6 - Receive again 7 - Note actual cost is populated 8 - Complete receipt and confirm actual cost correctly saved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33783] Populate actual cost with estimated cost if actual cost not set when receiving (bug 8179 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33829] Cannot add patron to patron list if PatronAutoComplete is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 --- Comment #3 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33823] KohaTable vue component action buttons spacing differ from kohaTable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Owen Leonard --- Sorry this needs to be rebased again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #4 from Nick Clemens --- Created attachment 151757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151757=edit Bug 33845: (follow-up) escape hold notes for display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33834] api/v1/ill_requests.t fails randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #3 from Nick Clemens --- Created attachment 151756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151756=edit Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #2 from Nick Clemens --- Created attachment 151755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151755=edit Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 --- Comment #1 from Nick Clemens --- Created attachment 151754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151754=edit Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33845] Hold notes should show when viewing a patron's hold list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33845 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #122 from Matt Blenkinsop --- Quick summary of the new version as this has been idle for a while: - Rebased to latest master branch as of 26/05/23 - Accessibility fixes have been added where required - A glitch has been fixed with the codemirror editor where it was duplicating every time the "Add new code" button was pressed - Similarly, the confirmation alert for deleting new tracking code was also duplicating when the "Delete" button was pressed - Atomic update file has been revised to the new version - Two sysprefs removed and replaced with HTML customisations as per Katrin's last QA comments - One syspref renamed to make it clearer what it is for Setting back to Needs signoff as it has been on Failed QA for a while and I've made a few changes to the original concept -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #21 from Marcel de Rooy --- (In reply to Owen Leonard from comment #20) > When I run t/db_dependent/Stats.t I get an error: > > Cannot detect source of 't/db_dependent/Stats.t'! at > /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. > > Am I doing something wrong? It seems so. I could reproduce it: root@master:/usr/share/koha# prove t/db_dependent/Koha/Statistics.t! Cannot detect source of 't/db_dependent/Koha/Statistics.t!'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. This error signals running prove on a file that does not exist. Solution: Remove exclamation mark after .t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378
Matt Blenkinsop changed:
What|Removed |Added
CC||matt.blenkinsop@ptfs-europe
||.com
--- Comment #121 from Matt Blenkinsop ---
REVISED TEST PLAN
-
Note: As part of this test plan you will be required to remove a value from
your browser's local storage store, we use this for storing a browser's cookie
consent choice. To remove this value when instructed to do so, do the
following:
Chrome / Edge
--
- Press F12 or right click and choose “Inspect”
- Click the "Application" tab
- On the left, expand the "Local Storage" section
- Find the entry that corresponds with the URL of your Koha and click on it
- Find the entry in the list with a "Key" of "cookieConsent"
- Click on it and press "Delete" on your keyboard
Firefox
---
- Press F12
- Click the "Storage" tab
- On the left, expand the "Local Storage" section
- Find the entry that corresponds with the URL of your Koha and click on it
- Find the entry in the list with a "Key" of "cookieConsent"
- Click on it and press "Delete" on your keyboard
Note: Also you will be required to inspect cookies set in your browser. When
instructed to do so, do the following:
Chrome / Edge
--
- Press F12 or right click and choose “Inspect”
- Click the "Application" tab
- On the left, expand the "Cookies" section
- Find the entry that corresponds with the URL of your Koha and click on it
- View the list of cookies
Firefox
---
- Press F12
- Click the "Storage" tab
- On the left, expand the "Cookies" section
- Find the entry that corresponds with the URL of your Koha and click on it
- View the list of cookies
1. Ensure you have a tab open on the intranet view and one open on the OPAC
view, ensure you are logged in on both
2. Search for “cookieconsent" in the sysprefs
=> TEST: Observe there are 2 new sysprefs:
- “CookieConsentedJS"
- "CookieConsent"
3. Change the value for the "CookieConsent" syspref to "Require" and save
4. Refresh the intranet page
=> TEST: In the intranet view, observe that a cookie consent bar appears at the
bottom of the page with just a single "Accept all cookies" button
5. Refresh the OPAC page
=> TEST: In the OPAC view, observe that a cookie consent bar appears at the
bottom of the page with just a single "Accept all cookies" button
6. Navigate to Tools > HTML customisations
7. Click New entry
8. In Display location, select CookieConsentBar
9. Set the Publication Date for today’s date
10. Add some text to the text editor and click save
11. Refresh the intranet page
=> TEST: In the intranet view, observe that the cookie consent bar appears at
the bottom of the page containing the text you specified
12. Refresh the OPAC page
=> TEST: In the OPAC view, observe that the cookie consent bar appears at the
bottom of the page containing the text you specified
13. In the HTML customisations, repeat steps 7-10 but this time selecting
CookieConsentPopup
14. Return to system preferences and search for “cookieconsent” again
15. Click the “CookieConsentedJS" syspref input
16. Click the "Add new code" link
17. Enter a name and description, and check both checkboxes.
- For "String used to identify cookie name", enter "test1", this enables us
to delete the cookie when consent is withdrawn.
- For "Cookie domain" enter the domain of your Koha.
- For "Cookie path" enter "/"
18. Click the "Click to expand" link
19. Enter the following Javascript:
(function() {
console.log('Hello from test1');
document.cookie = “test1=testing; domain=localhost; path=/;
SameSite=None; Secure”;
})();
N.B. IF YOUR DOMAIN IS NOT LOCALHOST, YOU WILL NEED TO CHANGE THIS TO YOUR
CORRECT DOMAIN
20. Repeat steps 11 to 14 twice more, substituting "test1" for "test2" &
"test3"
21. Click "Save"
22. Refresh the intranet page
=> TEST: In the intranet view, observe that the cookie consent bar appears at
the bottom of the page containing 3 buttons
23. Refresh the OPAC page
=> TEST: In the OPAC view, observe that the cookie consent bar appears at the
bottom of the page containing 3 buttons
24. Click the "More information" button
=> TEST: Observe that a cookie consent popup is displayed listing the codes you
added in the syspref, displaying the name,description and checkbox for each,
allowing a code to be selected
25. Select a code
=> TEST: Observe that "Accept selected non-essential cookies" is enabled
26. Deselect all codes
=> TEST: Observe that "Accept selected non-essential cookies" is disabled
27. Open the developer tools for your browser (usually F12) and ensure you are
viewing the Javascript console
28. Click accept all cookies
=> TEST: In the Javascript console, observe that the messages in all the codes
you added to the CookieConsentedJS syspref are
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #120 from Matt Blenkinsop --- Created attachment 151753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151753=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #119 from Matt Blenkinsop --- Created attachment 151752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151752=edit Bug 27378: Prevent delete confirmation from duplicating Previously, if the "Add new code" button was clicked multipe times in the CookieConsentedJS editor and then those new items were deleted, the confirmation alert would show multiple times. This was an incremental issue, i.e. if 4 new items were deleted, then the first of those would require 4 confirmations to delete, the second would require 3 and so on. This is now prevented by looping through all delete buttons and avoiding duplicating the event listeners -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #118 from Matt Blenkinsop --- Created attachment 151751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151751=edit Bug 27378: Stop the codemirror editor from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #117 from Matt Blenkinsop --- Created attachment 151750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151750=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #116 from Matt Blenkinsop --- Created attachment 151749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151749=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #115 from Matt Blenkinsop --- Created attachment 151748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151748=edit Bug 27378: Add aria-label to more information button This patch adds an aria-label to the More Information button in order to comply with WCAG Accessibility guidelines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #114 from Matt Blenkinsop --- Created attachment 151747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151747=edit Bug 27378: Add missing aria-labels The checkboxes on the cookie consent modal were failing accessibility testing for not being labelled. This patch adds aria-labels to the checkboxes to satisfy the accessibility requirements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #113 from Matt Blenkinsop --- Created attachment 151746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151746=edit Bug 27378: Fix missing bootstrap button classes This patch restores the background colour to buttons in the intranet where bootstrap classes were being overidden with a default of #fff. The colour of the the "More Information" button in the cookies bar and the "Accept selected non-essential cookies" button in the cookies modal have been changed slightly to comply with accessibility colour contrasts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #112 from Matt Blenkinsop --- Created attachment 151745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151745=edit Bug 27378: Fix heading structure of opac-patron-consent The current heading structure of opac-patron-consent.tt jumps straight from an h1 to an h5 for cookie consents. This has been changed to an h2 with scss updates to maintain formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135318|0 |1 is obsolete|| --- Comment #111 from Matt Blenkinsop --- Created attachment 151744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151744=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135317|0 |1 is obsolete|| --- Comment #110 from Matt Blenkinsop --- Created attachment 151743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151743=edit Bug 27378: (follow-up) Fix update delimiter As suggested by Nick in Comment #64 (cherry picked from commit cf64bc373dcec60c51dccfe2e2f9359500c6cc9b) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135316|0 |1 is obsolete|| --- Comment #109 from Matt Blenkinsop --- Created attachment 151742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151742=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. Signed-ff-by: Barry Cannon (cherry picked from commit 2221f55646eb1675888725282005a613435ef0df) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135315|0 |1 is obsolete|| --- Comment #108 from Matt Blenkinsop --- Created attachment 151741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151741=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Signed-ff-by: Barry Cannon (cherry picked from commit 13bea186b66e1fd02ddad1327c073a64701edb12) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135314|0 |1 is obsolete|| --- Comment #107 from Matt Blenkinsop --- Created attachment 151740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151740=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. Signed-ff-by: Barry Cannon (cherry picked from commit a663a7afa5fec005fed90b8a870e6633e133a539) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135313|0 |1 is obsolete|| --- Comment #106 from Matt Blenkinsop --- Created attachment 151739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151739=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate Signed-ff-by: Barry Cannon (cherry picked from commit 40d4b094420ea1495996976434d250b15ee78c1b) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135312|0 |1 is obsolete|| --- Comment #105 from Matt Blenkinsop --- Created attachment 151738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151738=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm Signed-ff-by: Barry Cannon (cherry picked from commit e8469e9997eaaefad834b9685e4906f89337bbc6) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135311|0 |1 is obsolete|| --- Comment #104 from Matt Blenkinsop --- Created attachment 151737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151737=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. Signed-ff-by: Barry Cannon (cherry picked from commit 16e78715c6bafba054104eadd1778599a75026da) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135310|0 |1 is obsolete|| --- Comment #103 from Matt Blenkinsop --- Created attachment 151736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151736=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup Signed-ff-by: Barry Cannon (cherry picked from commit d17ee9aff67f99393aa47376a33764840eb2ab38) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #135309|0 |1 is obsolete|| --- Comment #102 from Matt Blenkinsop --- Created attachment 151735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151735=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string Signed-ff-by: Barry Cannon (cherry picked from commit ec2dc19564a733a7d1db673331d41c3ae44235e1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #30 from Owen Leonard --- Created attachment 151734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151734=edit Bug 28966: Prefetch patron data for holds queue viewer Test Plan: 1) Generate the holds queue 2) Load the holds queue viewer page 3) Apply this patch 4) Restart all the things! 5) Reload the page 6) Note nothing has changed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Owen Leonard changed: What|Removed |Added Attachment #143859|0 |1 is obsolete|| Attachment #145395|0 |1 is obsolete|| --- Comment #29 from Owen Leonard --- Created attachment 151733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151733=edit Bug 28966: Add Koha::Object(s) for tmp_holdsqueue Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard --- When I run t/db_dependent/Stats.t I get an error: Cannot detect source of 't/db_dependent/Stats.t'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. Am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32215] 'You Searched for' for patron restrictions is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32215 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32588] Filters on top of 'Items with no checkouts' report are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32588 Owen Leonard changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
