[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook changed: What|Removed |Added Attachment #152022|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 152031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152031=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 David Cook changed: What|Removed |Added Attachment #151990|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 152030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152030=edit Bug 33896: Check whether index is defined before string match This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching Test plan: 1) In the intranet, search the catalog from the top search bar 2) Check plack-intranet-error.log 3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq" 4) Apply patch 5) restart_all and then re-try the search 6) The warning should no longer appear Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33896] Catalog search from the masthead searchbar produces a warning in the logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33896 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 David Cook changed: What|Removed |Added Blocks||33881 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150712|0 |1 is obsolete|| --- Comment #34 from David Cook --- Created attachment 152028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152028=edit Bug 32341: (follow-up) Making the label not showed twice when the tables are in responsive mode Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150711|0 |1 is obsolete|| --- Comment #33 from David Cook --- Created attachment 152027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152027=edit Bug 32341: (follow-up) Add responsivity to Curbside pickups table and changing button style for finestables To activate Curbside pickups 1- Enable the CurbsidePickup system preference 1.1 Go to Administration > Global system preferences 1.2 Search for CurbsidePickup 1.3 Change the value for 'Enable' 1.4 Click on 'Save all circulation preferences' 2- Configure time slots for at least one library 2.1 Go to Administration > Curbside pickup 2.2 Fill out the form for Centerville (or another library) Enable: Check Pickup interval: 10 (or other) Maximum boss per interval: 3 (or other) Patron-scheduled pickup: Check Enable for waiting holds only: DO NOT check 2.3 Add a time slot In 'New slot', enter Monday From: 10:00 To: 12:00 Click on 'Add' 3- Make an appointment from the OPAC 3.1 Go to OPAC 3.2 Open mobile mode 3.3 Connect with a user 3.4 Click on 'Curbside pickups' 3.5 Choose the library in 'Pick a library' 3.6 Choose a date in 'Pickup date' 3.7 Choose a time range in 'Select a time' 3.8 Click on 'Schedule pickup' => Notice The table is not responsive 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform step 3.1, 3.2, 3.3, 3.4, 8- click on 'Your pickups' => Confirm that the CurbsidePickup table are now displayed correctly and is now responsive. 9- Click on 'Charges' => Confirm that the Charges table are now displayed correctly and is now responsive. I correct a little bug. The "suspend_hold" button did not work anymore. This change resets it to it's original state. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150710|0 |1 is obsolete|| --- Comment #32 from David Cook --- Created attachment 152026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152026=edit Bug 32341: (follow-up) Making the remains OPAC tables responsive Apply the patch and check for the responsivity of the following tables 1- Go to the OPAC 2- Open mobile mode 3- The following tables are not responsive - Summary - Clubs - Summary - Recalls - Summary - Article requests - Charges - (relative's) - Search history - Authority - Checkout history - All - Checkout history - Checkouts - Checkout history - On-site - Recalls history - Messaging - Subscription (serial) - Course reserves - Courses - Course reserves - Reserves - Authority search results 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform previous step (1-3) 8- Confirm that the tables are now displayed correctly and is now responsive. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150709|0 |1 is obsolete|| --- Comment #31 from David Cook --- Created attachment 152025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152025=edit Bug 32341: (follow-up) Alternate button style This patch applies a different button style and does a couple of clean up tasks: Removing the redundant sorting-related CSS and moving the responsive button CSS to _common.scss where other DataTable-related styles are found. I think this different button style is more consistent with the OPAC's design. It also eliminates untranslatable strings from the CSS. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150708|0 |1 is obsolete|| --- Comment #30 from David Cook --- Created attachment 152024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152024=edit Bug 32341: (Fix) Changing the placement of the button This attachment correct the placement of the responsive button. It is now in its own column at the last column and the '+' and '-' are remplaced by 'Expand' and 'Unexpand' to make it more clear. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 David Cook changed: What|Removed |Added Attachment #150707|0 |1 is obsolete|| --- Comment #29 from David Cook --- Created attachment 152023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152023=edit Bug 32341: Some OPAC tables are not displayed well in mobile mode Some OPAC tables are not displayed well in mobile mode, it is absolutely necessary to scroll to the right to read the content properly This patch fix this problem by making the tables responsive To test: 1- Go to the OPAC 2- Open mobile mode 3- Go to a bibliographic record detail page in the OPAC (opac-detail.pl?biblionumber=X) 4- Check the Holdings table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> we see very narrow columns --> unreadable text 5- Go to to the page 'Summary' (opac-user.pl) 6- Check the 'Checked out' table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 7- Check the 'Overdue' table --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 8- Go to the page 'Charges' (opac-account.pl) 9- Click on 'Show all transactions' --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 10- Go to the page 'Search history' (opac-search-history.pl) --> the information is not presented in a table as it is when viewing on a laptop or PC browser screen. --> The columns are overflowing to the right 11- Apply the patch 12- Execute 'yarn build --view opac' 13- Clean your cache or open your navigator on private mode (to load updated css files) 14- Perform previous step (1-10) 15- Confirm that the tables are now displayed correctly and is now responsive. Signed-off-by: pauld Signed-off-by: LMSCloudPaulD Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #28 from David Cook --- (In reply to Martin Renvoize from comment #27) > sha1 issues on apply I'm afraid. Hmm weird. I've rebased, so I'll upload again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This moves the HTML for the release notes||pop-up window with the ||information for a library ||(where it exists) on the ||OPAC detail page inside the || tag so that it ||validates correctly. There ||is no change to the ||appearance or behavior of ||the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What|Removed |Added Attachment #152017|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 152022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152022=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 David Nind changed: What|Removed |Added Text to go in the|This enhancement makes |This enhancement makes release notes|minor changes to the|minor changes to the |structure of the "Manage|structure of the "Manage |MARC imports" page so that |staged MARC records" page |sections are more clearly |for a batch so that |delineated and forms have |sections are more clearly |the correct structure. It |delineated and forms have |also shortens the new |the correct structure. It |framework field labels and |also shortens the new |adds hints for |framework field labels and |clarification. |adds hints for ||clarification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 David Nind changed: What|Removed |Added Text to go in the||This enhancement makes release notes||minor changes to the ||structure of the "Manage ||MARC imports" page so that ||sections are more clearly ||delineated and forms have ||the correct structure. It ||also shortens the new ||framework field labels and ||adds hints for ||clarification. CC||da...@davidnind.com --- Comment #3 from David Nind --- A nice update! One thing I noticed (both before and after the patch was applied) was that the DIff view page background is all grey and aligned to th efar left of the page - maybe this needs the div background change made? Possibly a separate bug, or a follow-up if a change is warranted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 David Nind changed: What|Removed |Added Attachment #151798|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 152021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152021=edit Bug 33855: Clean up forms and page sections on 'manage MARC imports' page This patch makes minor changes to the structure of the "Manage MARC imports" page so that sections are more clearly delineated and forms have the correct structure. The patch also shortens the new framework field labels and adds hints for clarification. To test, apply the patch and go to Cataloging -> Stage MARC records for import. - Import a batch of MARC records. - Go to Cataloging -> Manage staged records. - View the batch you just imported. - You should see three sections: - A list of information about the batch - Options for changing the matching rules - Options for setting frameworks during import. - Test that the form for applying different matching rules still works correctly. - Import a batch of records which contains matches (by, for example, exporting MARC records from Koha and then reimporting the same batch) - On the manage page for that batch try changing the matching rule applied, switching between "Do not look for matching records" and a matching rule which will catch the duplicate records. - Test that your records are imported correctly according to the framework settings you select, both for new records and for replaced records. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33855] Clean up forms and page sections on 'manage MARC imports' page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 David Nind changed: What|Removed |Added Text to go in the||This enhancement updates release notes||the jQuery Multiple Select ||plugin version from 1.1 to ||1.6. This plugin is used in ||the staff interface system ||preferences area. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 David Nind changed: What|Removed |Added Attachment #151867|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 152020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152020=edit Bug 33868: Upgrade the Multiple Select plugin in the staff interface This patch upgrades the Multiple Select plugin in the staff interface and adds some minor adjustments to system preferences CSS to accommodate the change. The listing on the about page is updated with current information. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences. - Test some preferences which use the plugin, e.g. - ApplyFrameworkDefaults - CoceProviders - OpacHiddenItemsExceptions - OPACAllowUserToChangeBranch - Confirm that the menus look correct and work correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33868] Upgrade the Multiple Select plugin in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind changed: What|Removed |Added Attachment #152001|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 152019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152019=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind changed: What|Removed |Added Attachment #152000|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 152018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152018=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33894] Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass changed: What|Removed |Added Blocks||33902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What|Removed |Added Depends on||33897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 --- Comment #1 from Lucas Gass --- Created attachment 152017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152017=edit Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- This looks good. I was able to test with Syndetics but not LibraryThing for Libraries. Unrelated thing: I notices a modal ( #libraryInfoModal ) that is outside of the page's HTML tags. So I filed Bug 33902. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass changed: What|Removed |Added Attachment #151991|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 152016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152016=edit Bug 33897: Use template wrapper for tabs: OPAC bibliographic detail page This patch updates the OPAC bibliographic detail page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and locate a bibliographic record. View the detail page. Verify that tabs are working, including all the options: - Holdings - Other holdings (If OpacSeparateHoldings is enabled) - Descriptions (MARC notes) - Subscriptions - Serial collection (UNIMARC, untested) - Components (If ShowComponentRecords is enabled. See Bug 11175 for sample record) - Comments - Editions (OPACFRBRizeEditions) - Html5media (If HTML5MediaEnabled is on. See Bug 8377 for sample records) - Images (If OPACLocalCoverImages is enabled) - NovelistSelect - Author identifiers (Witgh OPACAuthorIdentifiers enabled, see Bug 29897) Bonus points for testing these tabs for which I don't have credentials: - Syndetics TOC - Syndetics Excerpt - Syndetics Reviews - Syndetics AuthorNotes - LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView set to "in tabs.") Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33897] Use template wrapper for tabs: OPAC bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33902] New: On opac-detail.tt the libraryInfoModal is outside of HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33902 Bug ID: 33902 Summary: On opac-detail.tt the libraryInfoModal is outside of HTML tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If you go to OPAC detail and look for the #libraryInfoModal you'll notice it is outside of the tag. Run the HTML through a validator and it will come back with an error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33893] Use template wrapper for tabs: OPAC checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33893 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- The aria-controls attribute's point to all_checkouts_panel, checkout_panel, onsite_checkout_panel but I don't see those elements on the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33891] Use template wrapper for tabs: OPAC advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Lucas Gass changed: What|Removed |Added Attachment #151988|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 152015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152015=edit Bug 33891: Use template wrapper for tabs: OPAC advanced search This patch adds the tab WRAPPER markup to the OPAC, adapted for the Bootstrap version used by the OPAC (4.5.0). The advanced search page is updated to use the wrapper construction. Unrelated markup fix: an empty size attribute is removed from an . To test, apply the patch and view the the advanced search page in the OPAC. The tabs for item type, shelving location, and collection should all look correct and work correctly. In the staff interface, go to Administration -> System preferences -> OpacAdvancedSearchTypes and try various configurations, confirming each time that the OPAC page adjustes correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33891] Use template wrapper for tabs: OPAC advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33815] Crash when librarian changes their own username in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #18 from Laura Escamilla --- Will this be backported to 22.11.xx? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33779] Terminology: biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33779] Terminology: biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33779 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33697] Remove deprecated RecordedBooks (rbdigital) integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33697] Remove deprecated RecordedBooks (rbdigital) integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33525] Use template wrapper for tabs: Basic MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33697] Remove deprecated RecordedBooks (rbdigital) integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33697 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||release-notes-needed Summary|Remove RecordedBooks|Remove deprecated |(rbdigital) integration |RecordedBooks (rbdigital) ||integration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33789] Checkout information is missing when adding a credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 152014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152014=edit Bug 33789: Update POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 from Martin Renvoize --- Makes sense to me and keeps the data in a clean form whilst allowing us foreign keys. We could perhaps make deleted_biblio_id a foreign key on the deletedbiblios table too.. Signing off and leaving Katrin to QA and comment on the above question. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize changed: What|Removed |Added Attachment #152008|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 152013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152013=edit Bug 21983: Make DelBiblio update linked ILL requests This patch makes DelBiblio update the biblio linked ILL requests so the value in biblio_id is moved to the deleted_biblio_id. The change is covered by tests. To test: 1. Apply this patchset 2. Run: $ ktd --shell k$ updatedatabase k$ qa --run-tests => SUCCESS: Tests pass! All green/good 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize changed: What|Removed |Added Attachment #152007|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 152012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152012=edit Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize changed: What|Removed |Added Attachment #152006|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 152011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152011=edit Bug 21983: DBIC schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Martin Renvoize changed: What|Removed |Added Attachment #152005|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 152010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152010=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33865] JS error when importing a staged MARC record file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33865] JS error when importing a staged MARC record file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33748] UI issue on addorderiso2709.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33247] Deleted authority still on results list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33247] Deleted authority still on results list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m --- Comment #14 from Tomás Cohen Arazi --- I followed the test plan and managed to replicate the issue and the patch fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Tomás Cohen Arazi changed: What|Removed |Added Attachment #151882|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 152009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152009=edit Bug 33873: Improve check for inexistant biblio object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 152008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152008=edit Bug 21983: Make DelBiblio update linked ILL requests This patch makes DelBiblio update the biblio linked ILL requests so the value in biblio_id is moved to the deleted_biblio_id. The change is covered by tests. To test: 1. Apply this patchset 2. Run: $ ktd --shell k$ updatedatabase k$ qa --run-tests => SUCCESS: Tests pass! All green/good 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 152007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152007=edit Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 152006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152006=edit Bug 21983: DBIC schema [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 152005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152005=edit Bug 21983: DB update This patch: - Adds a illrequests.deleted_biblio_id column - Adjusts existing db_rev so people upgrading have the biblio_id value moved to the also created column, before attempting to add the FK constraint on the biblios table. - Adds a new db_rev for those who unfortunately already updated, it should be idempotent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate, ||rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added Summary|Deleting a bib does not |Better handling of deleted |delete a request's link to |biblios on ILL requests |it - missing foreign key| CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com, ||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added Attachment #83227|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 --- Comment #38 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32775] Ordering when there are multiple languages within a language group is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32775 Pedro Amorim changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.07 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28366] Add batch patron modification to patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28366 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m Status|Pushed to master|Needs documenting --- Comment #6 from Pedro Amorim --- Enhancement. Not pushed to 22.11.07. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33900] advance_notices.pl cronjob hangs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33900 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33900] advance_notices.pl cronjob hangs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33900 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33901] Only one issue shown in Test prediction pattern
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32554 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33901 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #7 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33463] 'Actions' column on plugins table should not be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Pedro Amorim changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.07 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33658] Capitalization: **To Reproduce**
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33658 Pedro Amorim changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||pedro.amo...@ptfs-europe.co ||m --- Comment #5 from Pedro Amorim --- Missing new feature dependency. Not pushed to 22.11.07. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Pedro Amorim changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||pedro.amo...@ptfs-europe.co ||m --- Comment #156 from Pedro Amorim --- New feature. Not pushed to 22.11.07. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33900] advance_notices.pl cronjob hangs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33900 Sam Lau changed: What|Removed |Added Attachment #152003|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 152004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152004=edit Bug 33900: Fix handling of due_digest Test plan, on k-t-d 1) Go to 'my account' 2) On 'Patron messaging preferences', click 'Edit' 3) On the 'Item due' row, check the 'Email' and 'Digests only' checkboxes and save 4) On the top search bar, press 'Check out' and enter '42' (koha user cardnumber) 5) On the checkout input bar, enter a barcode e.g. 301372 and press checkout 6) Run the following query to force the due_date to be equal to 'todays' date: NOTE: change the -MM-DD below to whatever day it is you're running this test plan UPDATE issues SET date_due = '2023-06-05 23:59:00' where issue_id = 1; 7) Run the cronjob: ./koha/misc/cronjobs/advance_notices.pl -c --digest-per-branch 8) Notice it hangs, it's stuck on an infinite loop on the 2nd while cycle after if () 9) Cancel the cronjob script, apply patch 10) Run the cronjob script again (step 7), notice it finishes 11) Access patron's notices: /cgi-bin/koha/members/notices.pl?borrowernumber=51 Check that the 'Item due reminder' notice is there. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33900] advance_notices.pl cronjob hangs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33900 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
