[Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427

--- Comment #7 from David Cook  ---
I'm looking at master and it looks like this would still be a problem.

It seems to me that _CanBookBeAutoRenewed() and friends should be moved up in
C4::Circulation::CanBookBeRenewed() to before the return for "too_many".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34293] ILS-DI returns 200 instead of 403 for unauthorized requests

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34293

--- Comment #4 from David Cook  ---
So I think this might be impossible without removing
Plack::Middleware::ErrorDocument or mounting ilsdi.pl as its own Plack app. 

The latter could be doable using the following:

my $ilsdi_app = Plack::App::WrapCGI->new(script =>
"/path/to/script.pl")->to_app;

mount '/opac/ilsdi.pl' => $ilsdi_app;

Plack::App::WrapCGI is what's used under the hood by Plack::App::CGIBin.

The path to script would depend on whether or not it's a DEV_INSTALL, but it
would be doable.

--

But it might not be worth it just to get better HTTP codes...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34293] ILS-DI returns 200 instead of 403 for unauthorized requests

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34293

--- Comment #3 from David Cook  ---
Actually this one is harder because the error message is coming from the
ErrorDocument Plack Middleware and not Apache...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34293] ILS-DI returns 200 instead of 403 for unauthorized requests

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34293

--- Comment #2 from David Cook  ---
(In reply to David Cook from comment #1)
> Ah right... we can't do that without changing Apache because otherwise it'll
> use the the generic Koha HTML 403 error document...

This is something I bumped into at
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=31982=142662

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34293] ILS-DI returns 200 instead of 403 for unauthorized requests

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34293

--- Comment #1 from David Cook  ---
Ah right... we can't do that without changing Apache because otherwise it'll
use the the generic Koha HTML 403 error document...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34293] New: ILS-DI returns 200 instead of 403 for unauthorized requests

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34293

Bug ID: 34293
   Summary: ILS-DI returns 200 instead of 403 for unauthorized
requests
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

We had a third-party hitting the ILS-DI API and in the logs it said 200, but
they were actually getting the "Unauthorized IP address" message.

It seems to me that we should have the ILS-DI API reply with 403 in that
situation, so that Koha sysadmins can see that the requests are failing.

This could also be useful for security monitoring.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] Saving RIS results to Error 505

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

--- Comment #7 from Eugene Espinoza  ---
I confirm that this bug also persist in 22.11.xx.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30623] Copy permissions from one user to another

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #12 from David Cook  ---
I'm not sure I'm a fan in terms of the UX but I don't see an issue from the
security side. 

At a glance, it seems to only be copying the permission flags, so there is no
data tying the permission flags to a particular user. 

The actual update is done server-side anyway, so it wouldn't be bypassing any
authorization/validation steps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646

--- Comment #5 from David Cook  ---
I've kept this issue open in my local tracker, but it's very low on my priority
list :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33666] Add facet for publication year

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33666

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29769] Claim return status cannot be changed without checking item in

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769

mathieu saby  changed:

   What|Removed |Added

 CC||mathsaby...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

--- Comment #3 from Andreas Roussos  ---
Created attachment 153524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153524=edit
Bug 34292: Fix typos in JSDoc documentation

equivilent -> equivalent
koha -> Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

--- Comment #2 from Andreas Roussos  ---
Created attachment 153523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153523=edit
Bug 34292: Format the check out date with dt_from_string()

In the current master, checking out an item to a patron results
in a 'Checked out on' date of the form '2023-07-16 12:44:18'
when viewing the patron's 'Checkouts' table. This is due to commit
1000ab402b from Bug 33804 which changed the `mDataProp` property
of the 'Checked out on' column from "issuedate_formatted" to plain
"issuedate" (for both the issues and relatives' issues DataTables).

"issuedate" comes straight from the issues.issuedate DB column
(which has `datetime` format), whereas "issuedate_formatted" is
formatted using Koha::DateUtils::dt_from_string() which takes
into account the `dateformat` System Preference.

This patch restores the original behaviour w.r.t. the formatting
of the 'Checked out on' column.

Note: in `svc/checkouts` we don't pass `as_due_date => 1` for
`issuedate_formatted` because we *do* want to show a check out
date with a time component of 23:59.

Test plan:

1) Without applying this patch, issue an item to a patron and
   notice that in the 'Checkouts' table the 'Checked out on'
   date is of the form -MM-DD HH:MM:SS.

2) Apply this patch, restart Plack if necessary.

3) Refresh the patron 'Checkouts' table: this time the 'Checked
   out on' date will observe the setting of your `dateformat`
   System Preference.

4) Extra credit: repeat step 3) for different `dateformat`
   settings, each time you should get a 'Checked out on' date
   that matches the date format you chose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Andreas Roussos  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format)

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34292

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33804

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Andreas Roussos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |a.rous...@dataly.gr
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

--- Comment #1 from Andreas Roussos  ---
The relevant commit is 1000ab402b from Bug 33804, where the `mDataProp`
property of the "Checked out on" column was changed for both the issues
and the relatives' issues DataTables from "issuedate_formatted" to plain
"issuedate".

"issuedate" is retrieved (via svc/checkouts) from the `issues` database
table and is a datetime column of the form -MM-DD HH:MM:SS. This
explains the "2023-07-16 12:44:18" checkout date that Katrin observed.

"issuedate_formatted" comes from the same DB column, but is formatted
using Koha::DateUtils::dt_from_string() which takes into account the
`DateFormat` System Preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Barbara Johnson  ---
This works great and will be a timesaver.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #153426|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 153522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153522=edit
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS.
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it
works correecly.
6. Try editing an existing record and make sure the toggle works well when
editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced
editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no
longer present.

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

--- Comment #5 from Katrin Fischer  ---
Created attachment 153521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153521=edit
Bug 34181: Fix jQuery selector to make delete checkboxes reappear

Bug 32257 changed the page structure slightly to fix a display
issue with the labels. This resulted in a broken selector in the
function for displaying the checkboxes for deleting/emptying a
certain patron field.

To test:
* Go to Tools > Batch patron modifications
* Enter some cardnumbers or borrowernumbers
* On the batch patron edit form, verify that the checkboxes
  behind each input field are missing
* Apply patch
* Verify the checkboxes reappeared
  * Verify that for mandatory fields the checkbox is locked
* Make some batch edits and verify the checkboxes work as
  intended

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32257] Label for patron attributes misaligned on patron batch mod

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||34181


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181
[Bug 34181] Batch patron modification tool missing checkboxes to clear field
values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||32257


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257
[Bug 32257] Label for patron attributes misaligned on patron batch mod
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

--- Comment #4 from Katrin Fischer  ---
A git bisect points to:
Bug 32257 - Label for patron attributes misaligned on patron batch mod

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

Katrin Fischer  changed:

   What|Removed |Added

Summary|Batch Patron Modification   |Batch patron modification
   |Tool missing checkboxes to  |tool missing checkboxes to
   |clear field values  |clear field values
Version|22.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34181] Batch Patron Modification Tool missing checkboxes to clear field values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181

--- Comment #3 from Katrin Fischer  ---
The checkboxes are still there, but they are set to 'display:none' in the
source code.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #152922|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 153520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153520=edit
Bug 29732: Check alert in cataloguing authorities should be a static message

This patch modifies the authority record editor so that form
validation errors are collected in a static "dialog" at the top of the
page instead of showing in a transient JavaScript alert.

The text of the message is roughly the same as it was in the alert, and
links have been added so that the user can click to jump directly to the
field referenced.

If the user scrolls down away from the static error message, a button
appears in the floating toolbar to jump back to the message.

- Go to Authorities and create a new authority record using a framework
  which has multiple mandatory fields defined
  (e.g. an unmodified default framework)
- Without entering anything in mandatory fields, click the "Save"
  button.
- You should see a message box appear at the top of the page.
  - It should list each missing mandatory subfield and tag, each with a
"Go to field" link next to it.
  - Clicking the "Go to field" link should switch you to the correct tab
and scroll the mandatory field into view.
- When you have scrolled down far enough for the error messages to be
  offscreen, an "Errors" button should appear in the floating toolbar.
  Clicking it should scroll the box back into view.
- If you fix some but not all of the missing mandatory fields the
  message should update with only the current issues.
- Confirm that the record saves when all issues are resolved.

Signed-off-by: Phil Ringnalda 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34157] Exporting labels as a barcode range can cause 500 error

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34157

--- Comment #1 from Katrin Fischer  ---
I am not sure about this one. 

I was thinking of barcode range as a feature to pre-produce labels. So you can
than add them to the items and scan them in at the same time when cataloguing.

I believe as the range allows for you to enter any number and isn't linking to
existing items, it probably won't/can't work with labels using bibliographic
information.

Maybe we need to catch this in a nicer way?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34177] Call number browser is not opening in new window

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34177

--- Comment #3 from Katrin Fischer  ---
I also tested and it worked correctly.

* Updated framework BKS to link 952$o to cn_browser
* Searched for a record, add item
* Opened the plugin

Does this match what you did? What could be the difference?

Could any local JS have gotten in the way?

As it complains about 'authorised' - any editing limitations in place?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34186] Adding subfield q to 110/710 to framework

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34186

--- Comment #1 from Katrin Fischer  ---
Hi Barbara, 

do you mean that q won't display on the detail page, even if catalogued?

I just tested this:

* Edited a record, adding 100$q to an existing author
* Saved
* Verifed that $q showed in detail pages and result lists in OPAC and staff
interface

I think your frameworks could be the issue here:

If the subfield is missing from your frameworks always make sure you add them.
If you don't add them, you risk losing data when the record is edited. Also:
they might not display in the OPAC as we derive the visibility settings from
the frameworks.

Can you please check?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27379] Autocomplete addresses for a patron using Google Places API (Maps).

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27379

Katrin Fischer  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #9 from Katrin Fischer  ---
Inlibro: do you agree with closing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34145] Patron search broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145

--- Comment #8 from Katrin Fischer  ---
Can we get some non-code summary on what happens here and a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941

Katrin Fischer  changed:

   What|Removed |Added

 CC||esther.melander@bywatersolu
   ||tions.com

--- Comment #6 from Katrin Fischer  ---
*** Bug 34272 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34272] Add Library of Congress help links for Authority fields

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34272

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Good ideas repeat :)

*** This bug has been marked as a duplicate of bug 10941 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #28 from Katrin Fischer  ---
I am not sure what/how to test... but I just started anyway :)

1) QA test tools

 FAIL   t/db_dependent/Koha/Object.t
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 991)

Fixed in a follow-up.


2) Unit tests 

Passed.

Note: we have a 'dirty' test somewhere: I ended up with 4 new testbuilder-style
itemtypes in my db. They should have been cleaned up by the test creating them.

3) Did some GUI testing:

* Checkouts with rental feeds
* Backdated checkouts
* Renewal
* Checkin
** Fines calculated
** Suspension days added

4) Went through the code, found a typo:

-C<$item> item hashref
+C<$item> patron object

Fixed in follow-up.

I added my sign-off lines to this, feel free to switch to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

--- Comment #27 from Katrin Fischer  ---
Created attachment 153519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153519=edit
Bug 32496: (QA follow-up) Fix POD and DateTime use

 FAIL   t/db_dependent/Koha/Object.t
   FAIL   forbidden patterns
forbidden pattern: Use of DateTime->now should certainly be
replaced with dt_from_string (bug 24840) (line 991)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153018|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 153518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153518=edit
Bug 32496: Some fixes

This can be squashed

Signed-off-by: Jonathan Druart 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32496] Reduce unnecessary unblessings of objects in Circulation.pm

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153017|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 153517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153517=edit
Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm

Refactor the most performance critical subroutines in Circulation.pm
to take objects instead of unblessed ones to reduce unnecessary
unblessings and generally clean up the code.

To test:

1) Ensure the following tests all pass:
  t/db_dependent/Circulation.t
  t/db_dependent/Circulation/CalcDateDue.t
  t/db_dependent/Circulation/CheckIfIssuedToPatron.t
  t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
  t/db_dependent/Circulation/GetTopIssues.t
  t/db_dependent/Circulation/IsItemIssued.t
  t/db_dependent/Circulation/MarkIssueReturned.t
  t/db_dependent/Circulation/ReturnClaims.t
  t/db_dependent/Circulation/Returns.t
  t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
  t/db_dependent/Circulation/TooMany.t
  t/db_dependent/Circulation/dateexpiry.t
  t/db_dependent/Circulation/issue.t
  t/db_dependent/Circulation/maxsuspensiondays.t
  t/db_dependent/Circulation/transferbook.t
  t/db_dependent/Circulation_holdsqueue.t
  t/db_dependent/DecreaseLoanHighHolds.t
  t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t
  t/db_dependent/Holds/RevertWaitingStatus.t
  t/db_dependent/ILSDI_Services.t
  t/db_dependent/Illrequests.t
  t/db_dependent/Koha/Account/Line.t
  t/db_dependent/Koha/Biblio.t
  t/db_dependent/Koha/Items.t
  t/db_dependent/Koha/Object.t
  t/db_dependent/Koha/Patrons.t
  t/db_dependent/Koha/Pseudonymization.t
  t/db_dependent/Koha/Template/Plugin/CirculationRules.t
  t/db_dependent/Letters/TemplateToolkit.t
  t/db_dependent/Members/GetAllIssues.t
  t/db_dependent/Members/IssueSlip.t
  t/db_dependent/Patron/Borrower_Discharge.t
  t/db_dependent/Patron/Borrower_PrevCheckout.t
  t/db_dependent/SIP/ILS.t
  t/db_dependent/Holds.t
  t/db_dependent/Holds/LocalHoldsPriority.t
  t/db_dependent/Holds/HoldFulfillmentPolicy.t
  t/db_dependent/Holds/HoldItemtypeLimit.t
  t/db_dependent/Reserves/GetReserveFee.t
  t/db_dependent/api/v1/return_claims.t
  t/db_dependent/api/v1/biblios.t
  t/db_dependent/api/v1/checkouts.t
  t/db_dependent/Reserves.t
  t/db_dependent/HoldsQueue.t
  t/db_dependent/selenium/regressions.t
  t/db_dependent/Koha/Plugins/Circulation_hooks.t
  t/db_dependent/Koha/Plugins/Recall_hooks.t
  t/db_dependent/Koha/Recalls.t
  t/db_dependent/Koha/Recall.t
  t/db_dependent/Circulation/_CalculateAndUpdateFine.t

Sponsored-by: Gothenburg University Library

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153512|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34292] New: Date formatting in checkouts list broken

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292

Bug ID: 34292
   Summary: Date formatting in checkouts list broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, jonathan.druart+k...@gmail.com

I checked out an item and it showed the checkout date as:

2023-07-16 12:44:18

Dateformat was set to MM/DD/. Switching it to DD.MM. made no
difference.

Due date displays correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34086] On detail.tt if item.permanent_location is NULL no shelving location will show

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34122

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34122] Updating location changes location of all related records

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122

Katrin Fischer  changed:

   What|Removed |Added

Summary|Updating Shelvingloc|Updating location changes
   |changes location of all |location of all related
   |related records |records
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34086

--- Comment #5 from Katrin Fischer  ---
Hi Laura, 

please make sure to also add the problem description and test plan to the
commit (see: https://wiki.koha-community.org/wiki/Commit_messages)

A common issue here is to think that git bz edit does change the commit message 
too, but it will only post it here.


(In reply to Nick Clemens from comment #4)
> If I set  UpdateItemLocationOnCheckin to:
> _ALL_: CART
> 
> And checkin an item with no location set, the permanent_location is NULL and
> the location is CART, but nothing displays for the item

Can you explain this a bit more? Could it be bug 34086 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276

--- Comment #5 from SOS  ---
I'm layman could you please help me with the SQL queries and how to run it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34080] Updating suggestion status can result in 500 error

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34080

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate,
   ||rel_23_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34188] Require library selection when logging in

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---
Hi Sam, 

congrats on your patch :)

Some notes:

1) The patch description should always describe the fix, not the problem. For
example here:

Add system preference to make library required on login

2) Always run the QA test tools:

 FAIL   installer/data/mysql/atomicupdate/bug_34188.pl
   FAIL   file permissions
File must have the exec flag
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
   FAIL   filters
missing_filter at line 121 (Library:)
missing_filter at line 122 ()
   FAIL   tt_valid
lines 122

There is a script in misc/devel that can help you fix the filters quickly:
add_missing_filters.pl

The TT valid points to some template issue, double check your changes for this
one.

Overall this looks good - close!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34174] Saving RIS results to Error 505

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174

--- Comment #6 from Katrin Fischer  ---
(In reply to Laura Escamilla from comment #5)
> (In reply to Tomás Cohen Arazi from comment #4)
> > Pushed to master for 23.11.
> > 
> > Nice work everyone, thanks!
> 
> 
> Can this be backported to 22.11.xx?

It needs to get into 23.05 first, then it can be considered. If you say the bug
is in this version and as this is marked major it usually will be backported.
Last decision is always up to RMaints.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34188] Require library selection when logging in

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188

Katrin Fischer  changed:

   What|Removed |Added

Summary|Require Library Branch  |Require library selection
   |Selection when Logging in   |when logging in
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29258] Add a value builder for filling in the vendor id in the item form

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29258

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8676

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29258

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||34255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||34255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34255] Add an enquiry/request/workflow management module

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||33105, 31028


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105
[Bug 33105] Add vendor issues
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33105] Add vendor issues

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|34255   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|34255   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4461] Add a context-sensitive report a problem process

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||34255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255
[Bug 34255] Add an enquiry/request/workflow management module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34255] Add an enquiry/request/workflow management module

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|33105, 31028|4461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
[Bug 4461] Add a context-sensitive report a problem process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105
[Bug 33105] Add vendor issues
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34252] Ability to link to ILL request in external ILL system

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34252

--- Comment #4 from Katrin Fischer  ---
The order ID can be used to construct the URL. I think was looking for some way
to add this nicely to the GUI without resorting to jQuery. 

Might need some more thought.

Having something configurable might be nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Katrin Fischer  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

--- Comment #11 from Katrin Fischer  ---
*** Bug 34249 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34249] New privacy option for lists: staff only

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34249

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 19501 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33070] Get rid of Koha::Patron->can_edit_item and use can_edit_item_from instead

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33070

Katrin Fischer  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #5 from Katrin Fischer  ---
*** Bug 34173 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34173] Imported items do not require home/holding branches, causing uneditable item records

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34173

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---
(In reply to Kyle M Hall from comment #1)
> Looks like bug 33070 resolve this issue.

Closing this as duplicate.

*** This bug has been marked as a duplicate of bug 33070 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34251] MARC editor with JS error when using fast add framework

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153349|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 153516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153516=edit
Bug 34251: When using the fast add framework in addbiblio.pl there is thrown a
JS error in selectTab( "#tab0XX_panel" );

This is because no nav tabs are build in addbiblio.tt as BIG_LOOP has a
length(size) of 1

To test:

1) go to More>Cataloging
2) click +New record
3) Click Settings> Fast add framework
4) take a look on console
5) try selecting a different framework now, will have no effect
6) apply patch and redo steps 1 to 5
7) there should be no error in console and a change in settings works a
   expected

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34251] MARC editor with JS error when using fast add framework

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34251] MARC editor with JS error when using fast add framework

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251

Katrin Fischer  changed:

   What|Removed |Added

Summary|Marc editor with JS error   |MARC editor with JS error
   |when using fast add |when using fast add
   |framework   |framework
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29324] Some files still don't have the correct license statement

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Katrin Fischer  ---
Hi Philip,

happy to see you submitting patches!

It looks like all files now have these lines included:

+# Copyright 2000-2002 Katipo Communications
+# Copyright 2010 BibLibre
+# Copyright 2011 Equinox Software, Inc.

This doesn't seem right to me. Should we not just update the license statements
(This file is part of Koha...) here?

https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388

--- Comment #5 from Katrin Fischer  ---
(In reply to Juliet Heltibridle from comment #4)
> Our library would still like to be able to hide notes from the issues table.
> Many of our nonpublic notes are not used at checkout, and having them appear
> in red on the issues table gives the impression that the notes are something
> that needs to be acted upon when they are not.

Hi Juliet, have you tried the CSS from comment#3 ? You just need to paste it
into IntranetUserCSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31736] Context for translation: "All"

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31736

--- Comment #4 from Katrin Fischer  ---
Hi Caroline, ready for sign-off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34247] Improve translation of notice character count

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247

Katrin Fischer  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731

--- Comment #5 from Katrin Fischer  ---
Love this, really nice enhancement!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731

--- Comment #4 from Katrin Fischer  ---
Created attachment 153515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153515=edit
Bug 31731: (QA follow-up) Add pull down to DefaultLongOverdueLostValue and
DefaultLongOverdueChargeValue preferences

Adds LOST pull downs to 2 more preferences.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153270|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 153514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153514=edit
Bug 31731: Offer user a dropdown of authorized values instead of a text field
in preferences

This patch updates the system preferences interface so that preferences
which ask for a single authorized value can offer a dropdown menu of
choices instead of a text field.

The patch also updates a few existing preferences to use the new
feature: BundleLostValue, BundleNotLoanValue, and
ClaimReturnedLostValue.

To test, apply the patch and restart services.

- Go to Administration -> System preferences and search for "authorized
  value."
- The search results should include the entries for BundleLostValue,
  BundleNotLoanValue, and ClaimReturnedLostValue.
- Confirm that the dropdowns show the correct authorized value category
  (LOST or NOT_LOAN)
- Confirm that setting or unsetting each of the preferences works
  correctly.

Signed-off-by: Sam Lau 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31731] Offer user a dropdown of authorized values instead of a text field in preferences

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31731

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34245] Scan index option only works on limited indexes

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34245

--- Comment #1 from Katrin Fischer  ---
Limiting the list when Elasticsearch is used makes sense to me. Should we
hardcode the list or would it be possible to look-up which of the indexes are
configured to work? I would support both fixes, we have the most important ones
covered I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364

--- Comment #5 from Katrin Fischer  ---
Hi Sam, if you want to try again: 

git bz apply ... 
Apply? [(y)es, (n)o, (i)nteractive] i

Then comment out the second patch by removing the # so it won't be applied.

The other option that works here:
git bz apply ...
Apply? [(y)es, (n)o, (i)nteractive] i
git bz apply --skip

This will also keep the second patch from being applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364

Katrin Fischer  changed:

   What|Removed |Added

Version|22.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26611] Required match checks don't work for authority records

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #152369|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 153513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153513=edit
Bug 33992: Only consider the date when auto-expiring problematic recalls

This patch carries this fix into the misc/cronjobs/recalls/expire_recalls.pl
cronjob so that recalls are automatically expired when they have been waiting a
problematic number of days, not considering hours, as expected.

To test, follow the test plan from the first patch. This will set you up with a
waiting problematic recall.

Run the cronjob manually

perl misc/cronjobs/recalls/expire_recalls.pl

Refresh your 'Recalls awaiting pickup' page. Your problematic recall should be
gone/expired.

Expiration dates will apply when expiring any 'unfulfilled' recall i.e. newly
requested, overdue to be returned, and awaiting pickup.

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #152368|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 153512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153512=edit
Bug 33992: Only consider the date when labelling a waiting recall as
problematic

This patches makes sure Koha ignores the hours/minutes/seconds when comparing a
recall waiting date to decide if it has been waiting too long for pickup.

To test:

1. Enable UseRecalls syspref and set the relevant circulation and fines rules
to configure recalls
2. Set the RecallsMaxPickUpDelay to 1 day
3. Check out Item A to Patron A
4. Log into the OPAC as Patron B
5. Search for Item A and place a recall
6. Log back into the staff interface and check in Item A
7. Confirm the recall as waiting for Patron B
8. Go to Circulation -> Recalls awaiting pickup
9. Confirm your recall exists under the 'Recalls waiting' tab
10. Log into the database and get the time for now

sudo koha-mysql INSTANCE
select now();

11. Change the waiting_date in the database for this recall to yesterday so we
would expect to see it under the 'Recalls waiting over 1 days' tab. Base the
hours on the now() timestamp from the step before, add a few hours to this.

For example, if the above SQl query returns "2023-06-13 10:54:21", change
waiting_date to be slightly less than 1 day/24 hours before this now()
timestamp, but still what we would consider 'yesterday'

select * from recalls; # to get the recall_id
update recalls set waiting_date = "2023-06-12 14:54:21" where recall_id = X;

12. Refresh the Circulation -> Recalls awaiting pickup page. The recall will
not show up under the 'Recalls waiting over 1 days' tab, even though we expect
it to.

13. Apply the patch, restart services, refresh the page
14. Confirm the recall now shows under the 'Recalls waiting over 1 days' tab as
expected.

Sponsored-by: Auckland University of Technology
Signed-off-by: David Nind 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

--- Comment #10 from Katrin Fischer  ---
There were some warns when running the expire_recalls.pl script, but the lines
seem unrelated to this change:

Argument "" isn't numeric in numeric ge (>=) at
misc/cronjobs/recalls/expire_recalls.pl line 61.
Argument "" isn't numeric in numeric gt (>) at
misc/cronjobs/recalls/expire_recalls.pl line 62.

File separately?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739

--- Comment #2 from Katrin Fischer  ---
I think adding it to the endpoint would be the way to go, so it matches who
Koha authenticates in all other spots.

We were just not sure how it should present in the endpoint when discussing
this.

The user of the endpoint might not know if the login information entered was
the cardnumber or the username. 

The simplest route might be to extend userid to check for both internally
without changing how the API is used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32767] Optionally allow for trimming whitespace from patron attribute values

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767

Katrin Fischer  changed:

   What|Removed |Added

Summary|Trimming of attribute types |Optionally allow for
   |by wish (if enabled)|trimming whitespace from
   ||patron attribute values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32767] Trimming of attribute types by wish (if enabled)

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32767

--- Comment #4 from Katrin Fischer  ---
I am not sure if this needs to be optional. I can't come up with a use case for
whitespace before or after any entered values. If this is not a problem for
maybe multi-line entries, why not make it the default behaviour? Or maybe
default for anything marked unique at least?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34196] UI adjustment to filters on funds administration page

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34196

Katrin Fischer  changed:

   What|Removed |Added

Summary|UI adjustment to aqbudgets  |UI adjustment to filters on
   ||funds administration page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34196] UI adjustment to aqbudgets

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34196

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #153499|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 153511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153511=edit
Bug 34196: Improve styling of sidebar form on funds admin page

This patch makes a few markup changes to the sidebar filter form on the
funds administration page in order to make it more usable and more
consistent with other similar forms.

The patch removes the link for expanding and collapsing the sidebar
filter because it looked bad and was inconsistent with all similar
forms.

To test, apply the patch and go to Administration -> Funds. Confirm that
the sidebar form looks correct. Compare to, for example, the sidebar
form at Acquisitions -> Invoices.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34196] UI adjustment to aqbudgets

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34196

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Clean up biblioitems.serial data

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34128] Clean up biblioitems.serial data

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
Summary|Series entry in the 490 |Clean up biblioitems.serial
   |field causes the ordering   |data
   |of items to change in the   |
   |holdings table  |

--- Comment #12 from Katrin Fischer  ---
I would love to see clean-up, but not sure how we can best do it.

* Whatever we do, we want to limit to MARC21 installations.
* We don't know if the library has been setting the flag manually in some
cases.
* We will need to access MARC data, which might make any clean-up really slow
on big databases.


Ideas:

Would running misc/batchRebuildBiblioTables.pl.fix the issue now? Then we could
add a database statement recommending to run it.

Could we assume that we only if 942$s exists/is filled, we should set
biblioitems.serial? I think the previously false code, didn't create that
field, right or wrong?


Thinking more about it... what does the alternative sorting do exactly?
It seems to counteract OPACHoldingsDefaultSortField?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34287] Patron's should not be able to ask for checkoutability for different patrons

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34287

--- Comment #1 from Katrin Fischer  ---
I assume this is a public route? It does sound not quite right. Not sure what
is returned, but could others learn about restrictions etc.?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )

2023-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

--- Comment #8 from Katrin Fischer  ---
I think it's a good idea, our current logs all log a little differently. A
'fresh start' in a new column makes sense to get out of the situation
incrementally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >