date:20230915

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #10 from David Nind  ---
Testing notes (using KTD):

1. After applying patches run: updatedatabase, dbic, yarn build

2. To run cypress tests: time perl /kohadevbox/misc4dev/run_tests.pl
--run-cypress-tests-only (hope this is the correct way to do this - from
https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo/Setup_Koha_environment_with_koha-testing-docker
- see output - all cypress tests pass[1])


[1] Results from running Cypress tests:

 Spec  Tests  Passing  Failing 
Pending  Skipped  
 
┌┐
  │ ✔  KohaTable_spec.ts00:0311   
--- │
 
├┤
  │ ✔  ERM/Agreements_spec.ts   00:3155   
--- │
 
├┤
  │ ✔  ERM/Dialog_spec.ts   00:0944   
--- │
 
├┤
  │ ✔  ERM/Licenses_spec.ts 00:2055   
--- │
 
├┤
  │ ✔  ERM/Packages_spec.ts 00:2055   
--- │
 
├┤
  │ ✔  ERM/Searchbar_spec.ts00:0444   
--- │
 
├┤
  │ ✔  ERM/Titles_spec.ts   00:3766   
--- │
 
└┘
✔  All specs passed!02:07   30   30   
---  

Done in 139.81s.
all good
Running [koha-shell kohadev -c "touch testing.success"]...

real2m20.061s
user0m31.341s
sys 0m18.387s

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 Attachment #155610|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 155733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155733=edit
Bug 34789: Update unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 Attachment #155609|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 155732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155732=edit
Bug 34789: Update usage throughout Koha modules and Vue components

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 Attachment #155608|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 155731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155731=edit
Bug 34789: DBIC file

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 Attachment #155607|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 155730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155730=edit
Bug 34789: Database and API update

Currently the erm_eholdings_titles table has a field called
preceeding_publication_title_id. This should be preceding_publication_title_id

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34789] Fix typo in erm_eholdings_titles

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34789

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

David Nind  changed:

   What|Removed |Added

 Attachment #155713|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 155729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155729=edit
Bug 34807: Move EnableItemGroups in cataloging preferences

This patch moves the EnableItemGroups system preference with cataloging
preferences, as it deals with the grouping of items in a bibliographic record.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for enableitemgroup
--> EnableItemGroups should be in cataloging preferences
--> EnableItemGroupHolds should be in circulation preferences

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 28224] Make date range for order search configurable

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224

--- Comment #3 from David Nind  ---
Created attachment 155728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155728=edit
Bug 28224: (follow-up) New system preference description

Update the description for OrderSearchFromDate:
- Fix spelling
- Use active voice

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 28224] Make date range for order search configurable

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224

David Nind  changed:

   What|Removed |Added

 Attachment #155697|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 155727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155727=edit
Bug 28224: Make date range for order search configurable

When searching orders in the acquisitions module the search
is automatically limited to orders created within the last year.

In some circumstances, like when testing migration data or
when working with standing orders, this can get annoying and
is not very useful.

This patch adds the OrderSearchFromDate system preference to
make this date configurable.

To test:
* Go to acquisitions > order search > config icon > advanced search
* Verify the From date is from one year ago
* Apply patch and run database update
* Verify the date is still the same
* Update the OrderSearchFromDate system preference to x days ago
  Example: 3
* Verify the date on the search form changes accordingly
* Add a basket with an order line
* Add another basket, add an order line using "From existing orders (copy)"
* Verify the date on the form is calculated correctly to the pref setting
* Copy your existing order
* Use the order search and send it empty - your 2 order lines should be shown

To test the search itself, you need baskets with different creation dates,
as the search searches aqbasket.creationdate.
  UPDATE aqbasket SET creationdate = "-MM-DD" WHERE basketno = X;

* Verify the search form and the top bar search respect the new from setting.

Sponsored by: The Research University in the Helmholtz Association (KIT)

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 28224] Make date range for order search configurable

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28224

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18926] Web installer gets stuck in a loop with plack enabled

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18926

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Katrin Fischer  ---
I haven't seen any reports of this for a long time. I assume it is fixed,
please re-open if you disagree!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18788] neworderempty.pl blindly deletes field 952 regardless the MARC flavour

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18788

--- Comment #1 from Katrin Fischer  ---
Hi Tomas, Can you explain how to replicate this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661

--- Comment #8 from David Nind  ---
Testing notes using KTD:

1. I've found the 'reset_all_unimarc' command doesn't work very well for me -
resets everything but no search results, even after a reindex. I tend to update
the KOHA_MARC_FLAVOUR=unimarc in .env file and then start up KTD.

2. I have signed off, feel free to change status if some of the things noted in
5 + 6 need addressing for this bug. A really nice improvement!

3. Tested using Firefox, I think Google Chrome or Chromium renders things
slightly differently, so some of the issues noted with window sizing may be
related to that.

4. Used this list to quickly check after all were individually tested -
https://gitlab.com/-/snippets/2555254

5. Some issues, but not related to this bug as this was the case before the
patch is applied - happy to create bugs for these if needed:

106$a - OK - Window sizing, need to scroll to the right
110$a - OK - Window sizing, need to scroll to the right
117$a - OK - Window sizing, need to scroll down
146$a - OK - By default it is set up as an authorized value list, changed to
plugin; labelled as "Framework plugin for UNIMARC 146$a" and is formatted
differently - field label above input field; when clicking on the tag editor it
jumps to the top of the page - popup window still populates the field but need
to scroll back down again
146$b - OK - Missed off list in testing plan, labelled as "Framework plugin for
UNIMARC 146$b" and is formatted differently - field label above input field
146$c - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$c"
and is formatted differently - field label above input field
146$d - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$d"
and is formatted differently - field label above input field
146$e - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$e"
and is formatted differently - field label above input field
146$f - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$f"
and is formatted differently - field label above input field
146$h - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$h"
and is formatted differently - field label above input field; when clicking on
the tag editor it jumps to the top of the page - popup window still populates
the field but need to scroll back down again
146$i - OK - Same as 146$b - labelled as "Framework plugin for UNIMARC 146$i"
and is formatted differently - field label above input field; when clicking on
the tag editor it jumps to the top of the page - popup window still populates
the field but need to scroll back down again

6. Some issues, don't do this before the patch is applied - happy to create
bugs for these if required:

325$h - OK - Jumps to 325$a after value selected
325$j - OK - Jumps to 325$a after value selected

7. Notes about specific value builders:

181$c - OK - By default it is set up as an authorized value list, needed to
remove authorized value list and add plugin; note that changing 181$c also
changes 181$2 (depending on the value selected)
182$2 - OK - Needed to add the plugin in the framework
182$a - OK - Needed to remove the authorized value list from the framework
182$c - OK - Needed to remove the authorized value list from the framework;
note that this may change 182$2 depending on the value selected
183$a - OK - Note that this may change 182$2 depending on the value selected
210c_bis - OK - This is an autocomplete field, based on the values available -
start typing the name of a publisher, for example: pub
225$a - OK - Not able to test fully as requires some work to set up (see
description in koha/cataloguing/value_builder/unimarc_field_225a.pl)
225$a-bis - OK - This is an autocomplete field, start typing - for example: fic

8. Not covered in test plan but look OK to me:

unimarc_field_010.pl - no popup window
unimarc_field_009_ppn.pl - authorities related?, no pop up window
unimarc_field_124.pl - OK
unimarc_field_125.pl - OK
unimarc_field_126.pl - OK
unimarc_field_127.pl - OK
unimarc_field_700-4 - OK
unimarc_leader_authorities.pl - OK

9. Not covered in test plan, search plugins so no footer with Save and Cancel
buttons required in footer:

unimarc_field_210$c - Search for authority type EDITORS
unimarc_field_4XX - Search
unimarc_field_686a - Search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661

David Nind  changed:

   What|Removed |Added

 Attachment #155588|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 155726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155726=edit
Bug 34661: FOR TESTING ONLY, a database update to configure MARC plugins

This patch is for testing purposes only: An update to change the default
framework's plugin settings for various fields in order to make all the
updated UNIMARC plugin available.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661

David Nind  changed:

   What|Removed |Added

 Attachment #155587|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 155725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155725=edit
Bug 34661: Update UNIMARC cataloging plugins with consistent footers

This patch updates UNIMARC cataloging plugin templates so that they have
consistent fixed footers in the plugin popup window. Plugins for the
following UNIMARC fields have been updated:

000 (Leader) 123$f128$a181$b
100$a123$g128$b182$2
105$a123$i128$c182$a
106$a123$j130$a182$c
110$a124$a135$a183$2
115$a124$b140$a183$a
115$b124$c141$a210$c
116$a124$d146$a225$a
117$a124$e146$c225$a
120$a124$f146$d283$2
121$a124$g146$e283$a
121$b125$a146$f325$h
122$a125$b146$h325$j
123$a126$a146$i
123$d126$b181$2
123$e127$a181$a

Most of these will be pre-configured in a test system with default
UNIMARC data. In KTD you can use the 'reset_all_unimarc' command.

Go to Cataloging -> New record and test the plugin link for each of the
fields listed above.

  - In each case, confirm that the correct popup window is shown when
you click the plugin link.
  - Confirm that clicking the "Cancel" button closes the window without
copying any data to the field in the MARC editor.
* Note that if the plugin is also triggered by cursor focus in the
  input field, some data may be automatically filled anyway.
  - Confirm that filing in data and clicking "Submit" will copy the
correct information into the field.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34661] Update UNIMARC cataloging plugins with consistent footers

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34661

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18768] Add the ability to authenticate patrons against other ILSs via SIP2

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18768

--- Comment #4 from Katrin Fischer  ---
Hi Kyle, is this still something you plan to work on? Could you explain the use
case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18738] Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18738

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Patch doesn't apply |RESOLVED

--- Comment #6 from Katrin Fischer  ---
Test file Koha_Elasticsearch_Indexer.t no longer exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18711] No longer possible have a blank value for Classification Sources in the Administration Module

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18711

--- Comment #4 from Katrin Fischer  ---
We should allow to leave  DefaultClassificationSource empty, so we can set the
field to mandatory and force libraries to make a conscious choice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18705] collections_tracking-table is missing index/foreign key to items

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18705

--- Comment #4 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Katrin Fischer  ---
I can't find this string in the templates anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #155717|0   |1
is obsolete||

--- Comment #43 from Phil Ringnalda  ---
Created attachment 155724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155724=edit
Bug 24480: (follow-up) Adjust tests

With the way the patchset alters to use insert_fields_ordered, we now add
fields to the beginning of their number group as opposed to appending before.
We just need ot shift the order we expect the fields to end up in to make the
tests pass

To test:
1 - Apply all patches except this
2 - prove -v t/SimpleMARC.t t/db_dependent/MarcModificationTemplates.t
3 - It fails
4 - Apply this
5 - prove -v t/SimpleMARC.t t/db_dependent/MarcModificationTemplates.t
6 - It passes

Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #155716|0   |1
is obsolete||

--- Comment #42 from Phil Ringnalda  ---
Created attachment 155723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155723=edit
Bug 24480: (follow-up) Shift new fields into array and add after all are copied

The updated code removed the pushing of fields to an array - this caused a bug.
When multiple fields were copied and replaced and there were more fields added
than existed originally we were adding the new field to the end, then removing
the first occurence of the original field. If we tried to move 2 650 fields to
651 and the record had no 651 we would:
- Delete the first 651, there were none, so nothing happened
- Take the first 650, add it to the end of the 651 group (there were none, so
it became the first 651)
- Delete the first 651, which was the field we just copied
- Take the second 650 and add it to the end of the 651 group (whihc had none,
because we deleted it)

I re-add the line, but do as suggesed by Phil and reverse the order (unshift vs
push)

To test:
1 - Apply other patches
2 - prove -v t/SimpleMARC.t
3 - It fails
4 - Apply this patch
5 - prove -v t/SimpleMARC.t
6 - It still fails, but more tests pass (there's another patch to follow)

Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #155715|0   |1
is obsolete||

--- Comment #41 from Phil Ringnalda  ---
Created attachment 155722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155722=edit
Bug 24480: Unit test

This updates the SimpleMARC tests and MarcModificationTemplates
tests to expect the new order of fields

Signed-off-by: Kelly 
Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Phil Ringnalda  changed:

   What|Removed |Added

 Attachment #155714|0   |1
is obsolete||

--- Comment #40 from Phil Ringnalda  ---
Created attachment 155721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155721=edit
Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC

Test plan :
 - create a marc modification template which add a new field to a record
 - apply that template to some records
 - verify that the new field is always appended at the bottom of the record,
even if some fields are higher.
 - apply patch
 - apply template to another set of records
 - verify the added field is now ordered within the already existing fields in
the records

Signed-off-by: Kelly 
Signed-off-by: Phil Ringnalda 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Phil Ringnalda  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #8 from Lucas Gass  ---
Created attachment 155720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155720=edit
Bug 33703: (follow-up) declare variables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34626] Add waiting since date to holdswaiting patron message

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626

--- Comment #4 from Katrin Fischer  ---
Hi Emlam, please sign-off and re-attach the patches when passing QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34752] Use AV descriptions in display for sort1/sort2 in basket display

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752

--- Comment #9 from Katrin Fischer  ---
Hi Elam, it looks like the first patch is missing your sign-off line, do you
want to fix? And thx for QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #39 from Phil Ringnalda  ---
Test pass? Copy, move, and insert all have the same ordering behavior?

THAT'S THE PATCHSET I'VE BEEN LOOKING FOR!

Thanks, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18628] Reference books shows as unavailable

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18628

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---
I believe this has been fixed as we now show the specific status and we have
the Reference_NFL_Statuses system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34626] Add waiting since date to holdswaiting patron message

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|Signed Off  |Passed QA

--- Comment #3 from Emily Lamancusa  ---
Trivial change, QA tool is happy. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18622] Require Z39.50 feature to enter bibliographic detail during making purchase suggestion on behalf of Patron

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18622

Katrin Fischer  changed:

   What|Removed |Added

Version|16.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502

Katrin Fischer  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

--- Comment #20 from Katrin Fischer  ---
*** Bug 18599 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18599] "Record URL" link href is broken for multiple 856$u links in MARC record

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18599

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 20502 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18583] Add the ability to merge multiple authorities

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18583

--- Comment #5 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18576] MARC Bibliographic framework test does not check for framework created

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18576

--- Comment #1 from Katrin Fischer  ---
This is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

--- Comment #7 from Lucas Gass  ---
Created attachment 155719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155719=edit
Bug 33703: Add cleave.js for direct input dateformatting

To test:
1. Apply patch
2. Restart all, clear browser cache
3. In the staff interface start testing some flatpickr instances with direct
inputs.
4. Try entering your dates without delimiters, '/' or '-', or '.'.
5. Make sure the dates are well formed.
6. Test with each of dateformat's Koha supports. ( system preference
'dateformat').

Some places to test:
-Patron record date of birth
-Patron record registration date
-Patron record expiry date
-Checkouts, manually set a due date
-Patron category, enrollment period

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18575] QueryFuzzy not enabled for Title search in Zebra

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18575

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18575] QueryFuzzy not enabled for Title search in Zebra

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18575

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Using the "Title" drop-down in the OPAC, both searches work for me:

Hitchhiker's Guide To the Galaxy
Hitchhikers Guide To the Galaxy

I believe that the CCL commands/expert search doens't fuzzy is to be expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18567] Amazon #reader-link feature is not available for all titles, causes error

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18567

--- Comment #1 from Katrin Fischer  ---
The example link doesn't give an error now - could this have been fixed on
Amazon's side?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34752] Use AV descriptions in display for sort1/sort2 in basket display

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

--- Comment #8 from Emily Lamancusa  ---
Trivial patch, works and makes sense. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33703] Entering dates should be more flexible accepting different entry formats

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
cleave.js looks like a stable and popular library that handles this very well.
It is licensed as "Apache License Version 2.0".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34752] Use AV descriptions in display for sort1/sort2 in basket display

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34752

--- Comment #7 from Emily Lamancusa  ---
Created attachment 155718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155718=edit
Bug 34752: (QA follow-up) perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927

Katrin Fischer  changed:

   What|Removed |Added

 CC||jandr...@washoecounty.us

--- Comment #34 from Katrin Fischer  ---
*** Bug 18563 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 30927 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Katrin Fischer  ---
As far as I could see, these templates have all been changed since.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #286 from Victor Grousset/tuxayo  ---
The problem is not to test the concept of delete flagging. The patches on this
ticket well demonstrated that.

Even without that already done, not sure that was ever a question. The
difficulty is that biblio, biblioitems, biblio_metadata, and items (and their
counterpart) are used in a lot of places in Koha. Even taken individually that
is still **a lot** of places to change, **test** and review.
Really a lot of workflows to check for regression. Automated test coverage
doesn't seem enough. Not sure there is any way to be sure enough to not miss
many usages of biblio, biblioitems, biblio_metadata, and items. And thus avoid
shipping a few regressions in edge cases. That needs to be weighted against the
benefits of this refactoring.

(In reply to Katrin Fischer from comment #281)
> Securing funding is one part, but the other part is to come to a decision as
> community about these change and ensure that there will be enough
> time/committment to see it through, if it's decided to do this. 
[...]
> I am not fully persuaded on benefits vs. work/risk yet, but would be open to 
> be persuaded.

+1 , money can buy a provider to have someone do the painful task of changing a
lot of the table usage everywhere. But it still needs other people in the
community to test and review it. And the benefits that refactoring need to be
weighted against the huge cost in testing and QA. Given the current huge
bottleneck on signoff (141 waiting tickets (25 bugfixes)) and QA (168 tickets,
(26 bugfixes)) including other refactorings, the benefits of this one need to
be big also. In the long run, which alternate timeline Koha **can be expected**
to have the less bugs, cleaner code, most features? That depends on the
benefits of the refactoring here.

Even finding a way to do that incrementally (something with DB views maybe?) to
avoid the need of pulling out of massive effort spike won't make the problem of
overall testing and review effort go away.

A way to make the question way easier is to get literally a dozen or more
**weekly active** librarians and Koha sysadmins to do some patch testing.
Making the bottleneck mostly go away. Librarians, rise up!
(and library executives: let the workers improve their tools!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34808] New: Batch Patron Modification Tool - Select all / clear all does not select/clear all

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34808

Bug ID: 34808
   Summary: Batch Patron Modification Tool - Select all / clear
all does not select/clear all
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To recreate:
1. Open the Batch Patron Modification Tool
2. Insert or open a file with 25+ card numbers or borrower numbers to modify
then click on continue. 
3. Notice that there are 2 or more pages of entries showing. If you click on
clear all, it will only clear entries 1-20 but not anything on the second page
(21-...). Similarly if you clear both pages and try to select all, it will only
select the entries on the page you are viewing. 

It would useful if the select all/clear all worked on all entries. Especially
for libraries that are modifying hundreds of patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Nick Clemens  changed:

   What|Removed |Added

   Assignee|arthur.suz...@biblibre.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #38 from Nick Clemens  ---
(In reply to Phil Ringnalda from comment #30)
> Nick: comment 28, why?

I think I was trying to make the tests pass, and thought it was the actual
intended behavior. I do still think it's right, but agree that was not the best
place to fix that.

I have fixed the test here without changing behavior, or at least not as mich
as before ;-)

The comment on the bug should explain

The second test patch highlights another change from this patchset, and updates
the patches accordingly.

Moving back to NSO for feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #37 from Nick Clemens  ---
Created attachment 155717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155717=edit
Bug 24480: (follow-up) Adjust tests

With the way the patchset alters to use insert_fields_ordered, we now add
fields to the beginning of their number group as opposed to appending before.
We just need ot shift the order we expect the fields to end up in to make the
tests pass

To test:
1 - Apply all patches except this
2 - prove -v t/SimpleMARC.t t/db_dependent/MarcModificationTemplates.t
3 - It fails
4 - Apply this
5 - prove -v t/SimpleMARC.t t/db_dependent/MarcModificationTemplates.t
6 - It passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #36 from Nick Clemens  ---
Created attachment 155716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155716=edit
Bug 24480: (follow-up) Shift new fields into array and add after all are copied

The updated code removed the pushing of fields to an array - this caused a bug.
When multiple fields were copied and replaced and there were more fields added
than existed originally we were adding the new field to the end, then removing
the first occurence of the original field. If we tried to move 2 650 fields to
651 and the record had no 651 we would:
- Delete the first 651, there were none, so nothing happened
- Take the first 650, add it to the end of the 651 group (there were none, so
it became the first 651)
- Delete the first 651, which was the field we just copied
- Take the second 650 and add it to the end of the 651 group (whihc had none,
because we deleted it)

I re-add the line, but do as suggesed by Phil and reverse the order (unshift vs
push)

To test:
1 - Apply other patches
2 - prove -v t/SimpleMARC.t
3 - It fails
4 - Apply this patch
5 - prove -v t/SimpleMARC.t
6 - It still fails, but more tests pass (there's another patch to follow)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #35 from Nick Clemens  ---
Created attachment 155715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155715=edit
Bug 24480: Unit test

This updates the SimpleMARC tests and MarcModificationTemplates
tests to expect the new order of fields

Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Nick Clemens  changed:

   What|Removed |Added

 Attachment #150665|0   |1
is obsolete||
 Attachment #150666|0   |1
is obsolete||

--- Comment #34 from Nick Clemens  ---
Created attachment 155714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155714=edit
Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC

Test plan :
 - create a marc modification template which add a new field to a record
 - apply that template to some records
 - verify that the new field is always appended at the bottom of the record,
even if some fields are higher.
 - apply patch
 - apply template to another set of records
 - verify the added field is now ordered within the already existing fields in
the records

Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18559] Koha::Clubs - methods should not get the return type in parameter

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #2)
> Kyle, Here is my try.
> But tests fail now...

Trying to raise attention - fqa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18559] Koha::Clubs - methods should not get the return type in parameter

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18558] Koha::Clubs->get_enrollable explodes if no patron given

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18538] OPAC database user login internal server error

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|In Discussion   |RESOLVED

--- Comment #7 from Katrin Fischer  ---
I can't replicate the internal server error in current versions. I only get:

Staff:
Error: Invalid username or password

OPAC:
You entered an incorrect username or password. 

I believe this is ok then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 155713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155713=edit
Bug 34807: Move EnableItemGroups in cataloging preferences

This patch moves the EnableItemGroups system preference with cataloging
preferences, as it deals with the grouping of items in a bibliographic record.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for enableitemgroup
--> EnableItemGroups should be in cataloging preferences
--> EnableItemGroupHolds should be in circulation preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34807] New: Move EnableItemGroups in cataloging preferences

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34807

Bug ID: 34807
   Summary: Move EnableItemGroups in cataloging preferences
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

While doing bug 31832, I thought that while EnableItemGroupHolds is a
circulation preference, EnableItemGroups is actually more a cataloging
preference, since it pertains to grouping the items in a record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33927] Improve translation of title tags: Tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927

Lucas Gass  changed:

   What|Removed |Added

 Attachment #155711|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 155712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155712=edit
Bug 33927: Improve translation of title tags: Tools

This patch modifies tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

To test, apply the patch and go to Tools. Test each of the following
pages and each variation of the page to confirm that titles,
breadcrumbs, and page headers look correct.

- Tools home page
- Import patrons
  - Import results
- Notices and slips
  - Main page
- Main page filtered by library
- New notice
- Edit notice
  - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice,
fill in the "Data for preview" box in the "Email" section.
Although the template loads in a modal window which doesn't show
the page title, you can confirm that there are no errors.
- Overdue notice/status triggers
- Batch patron deletion
  - Confirmation page
- Batch patron modification
- Batch extend due dates
- Upload patron images

Print notices: With useDischarge enabled, log into the OPAC as a
user with no checkouts. Go to the "Ask for a discharge" tab and click
"Ask for a discharge."

Locate the patron's record in the staff interface and click "Discharges"
in the left-hand sidebar menu. Click "Generate discharge." Open the
resulting PDF file in a browser. The page title should be "Print notices
for [date]."

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33927] Improve translation of title tags: Tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33927] Improve translation of title tags: Tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
One note for testing. To test "Upload patron images" pages make sure the system
preference 'patronimages' is set to 'allow'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472

--- Comment #45 from Victor Grousset/tuxayo  ---
https://sourceforge.net/p/icu/mailman/icu-support/thread/d1a3c944-02a7-4cc0-87ad-4ad30b773967%40tuxayo.net/#msg37895241

> > I think you might be able to get that by reordering spaces above
> > punctuation, and setting the first non ignorable to be the first space.
> >
> 
> No, I am pretty sure that alternate=shifted compares the primary weight
> with the maxVariable setting before script reordering.
> 
> I just tried this in the ICU Collation Demo
>  with
> 
>- rule "[reorder punct space]"
>- alternate=shifted
>- max variable=punct
> 
> and both spaces and punctuation get shifted/ignored.
> 
> So I don't think we have a way to ignore/shift anything other than
> "anything up to the max variable".
> 
> You might be best off pre-processing the strings, removing punctuation
> characters before sending the string into collation.

Quite over my head but it seems to confirm no way to get what we want with ICU
config.


If the assumptions are correct
- punctuation ignored, but whitespace not ignored is our need
- strength: quaternary" is still better than "alternate: shifted" and better
than the current sorting
  - might need more testing since it managed to masquerade as complying with
the test plan ^^"

Then immediate move forward is go on with the "strength: quaternary" patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33927] Improve translation of title tags: Tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927

--- Comment #1 from Owen Leonard  ---
Created attachment 155711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155711=edit
Bug 33927: Improve translation of title tags: Tools

This patch modifies tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

To test, apply the patch and go to Tools. Test each of the following
pages and each variation of the page to confirm that titles,
breadcrumbs, and page headers look correct.

- Tools home page
- Import patrons
  - Import results
- Notices and slips
  - Main page
- Main page filtered by library
- New notice
- Edit notice
  - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice,
fill in the "Data for preview" box in the "Email" section.
Although the template loads in a modal window which doesn't show
the page title, you can confirm that there are no errors.
- Overdue notice/status triggers
- Batch patron deletion
  - Confirmation page
- Batch patron modification
- Batch extend due dates
- Upload patron images

Print notices: With useDischarge enabled, log into the OPAC as a
user with no checkouts. Go to the "Ask for a discharge" tab and click
"Ask for a discharge."

Locate the patron's record in the staff interface and click "Discharges"
in the left-hand sidebar menu. Click "Generate discharge." Open the
resulting PDF file in a browser. The page title should be "Print notices
for [date]."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33927] Improve translation of title tags: Tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34719] Middle name doesn't show on autocomplete

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34719

--- Comment #7 from Katrin Fischer  ---
(In reply to Erin A. from comment #4)
> (In reply to Lucas Gass from comment #2)
> > Created attachment 155344 [details] [review] [review]
> > Bug 34719: Add middle_name to patron autocomplete
> > 
> > To test:
> > 1. Apply patch and clear browser cache.
> > 2. Find some patrons with middle_name populated or add new patrons with a
> > middle_name.
> > 3. Make sure PatronAutoComplete is on
> > 4. Try searching for a part of one of the patron's names who has a
> > middle_name.
> > 5. It should appear in the autocomplete dropdown
> 
> Hi Lucas,
> 
> Do I submit a ticket for Bywater to apply the patch or is this something I
> do? Thanks! New to this.
> 
> Erin

Hi Erin, I suspect your question was missed here - maybe reach out to the
Bywater support directly raising a ticket. If you don't have full access to
your server, you won't be able to do this yourself. The bug fix will be
backported to the stable releases, but and then be included in one of the
upcoming bugfix releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620

Katrin Fischer  changed:

   What|Removed |Added

Summary|Writeoff causes 500 error   |Writeoff causes 500 error
   |if  RequirePaymentType is   |if  RequirePaymentType is
   |on. |on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34794] Typo in recalls_to_pull.tt

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34794

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34794] Typo in recalls_to_pull.tt

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34794

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34719] Middle name doesn't show on autocomplete

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34719

--- Comment #6 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34719] Middle name doesn't show on autocomplete

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34719

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34589] Update on bug 20256 is not idempotent

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34589] Update on bug 20256 is not idempotent

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34589

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES)

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406

--- Comment #16 from Tomás Cohen Arazi  ---
Pushed to master for 23.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES)

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34773] Improve translation of title tags: Cataloging tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773

Owen Leonard  changed:

   What|Removed |Added

 Attachment #155668|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 155710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155710=edit
Bug 34773: (follow-up) Missed templates

This patch fixes three templates I missed the first time around:
Inventory, MARC diff view, and Upload local cover images.

- Cataloging -> Inventory and the results page after submitting a
  batch of barcodes.
- Cataloging -> Manage staged records -> Select a batch which includes
  record matches: Click the "View" link in the "Diff" column for a
  record which has a match.
- Cataloging -> Upload local cover image (with LocalCoverImages enabled)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732

--- Comment #14 from Victor Grousset/tuxayo  ---
(double checked scanning with a phone before and after the patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #13 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732

--- Comment #12 from Victor Grousset/tuxayo  ---
Created attachment 155709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155709=edit
Bug 34732: (QA follow-up): tidy up code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34732] Barcode image generator doesn't generate correct Code39 barcode

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34732

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #155391|0   |1
is obsolete||

--- Comment #11 from Victor Grousset/tuxayo  ---
Created attachment 155708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155708=edit
Bug 34732: For Code39, append or prepend asterisk if missing from barcode

This patch appends or prepends an asterisk on Code39 barcodes if
they are missing from the input. This is so that they form correct
Code39 barcode images.

Test plan:
0. Apply the patch
1. koha-plack --reload kohadev
2. Go to http://localhost:8081/cgi-bin/koha/labels/barcode-print.pl
3. Type 301310 into "Barcode" and click "Show barcode"
4. Note that the barcode text on the right includes asterisks around it
5. Type *301310 into "Barcode" and click "Show barcode"
6. Note the same as above
7. Type 301310* into "Barcode" and click "Show barcode"
8. Note the same as above
9. Type *301310* into "Barcode" and click "Show barcode"
10. Note the same as above

Signed-off-by: Matt Blenkinsop 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20859] Enter SMS number and SMS provider during self registration

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

--- Comment #18 from Christopher Brannon  ---
(In reply to Lucas Gass from comment #16)
> (In reply to Marcel de Rooy from comment #15)
> > +[% IF ( Koha.Preference('SMSSendDriver') ) &&
> > !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') &&
> > action != 'edit' %]
> > 
> > Please explain this condition.
> > What about the case that I want to hide one of them? Is that just nonsense?
> > Later on you test again:
> > [% UNLESS hidden.defined('smsalertnumber') %]
> > But you should know that already given the earlier condition.
> > 
> > Please clarify
> 
> I suppose the question is should patrons be allowed to give a SMSnumber when
> SMSSendDriver is turned off?

If you want to make Koha take that into consideration for asking for it, you
could.  Worst case scenario is that they take a number for SMS and nothing is
done with it.  However, it seems, as a library, if I am going to ask for this
piece of information, I would want to ensure that it is setup properly.  At the
very least it is on the Admin if they ask for a piece of information they are
not prepared to do anything with.  Does email work that way?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20859] Enter SMS number and SMS provider during self registration

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

--- Comment #17 from Emily Lamancusa  
---
I think the question is, why does the condition contain

&& !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id')

# which will only show the section if both fields are enabled

instead of something like

&& ( !hidden.defined('smsalertnumber') || !hidden.defined('sms_provider_id') )

# which will show the section as long as at least one field is enabled

I hadn't looked that closely at the code when I signed off, but that's a good
point - from what I understand, knowing the SMS provider of individual patrons
isn't always needed, so a library may want to hide sms_provider_id but still
show smsalertnumber.

There's no real use for knowing the provider without the number, though, so
maybe the answer is to simplify the condition and only check whether
smsalertnumber is hidden at that point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34796] Improve translation of title tags: Tools - Additional tools

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34796

Owen Leonard  changed:

   What|Removed |Added

 Attachment #155667|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 155707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155707=edit
Bug 34796: Improve translation of title tags: Tools - Additional tools

This patch modifies templates for tools under the "Additional tools"
heading so that title tags can be more easily translated. The patch also
makes some modifications to titles, breadcrumb navigation, and page
headers in order to make them more consistent with each other and with
other similar pages.

To test, apply the patch and go to Tools. Test each page below and each
variation of the page to confirm that titles, breadcrumbs, and page
headers look correct.

- Calendar
- CSV profiles
  - Main page
- New CSV profile
- Modify CSV profile
- Confirm deletion of CSV profile
- Log viewer
  - Search results
- News, HTML customizations, and pages
  - Create and modify each content type: news, pages, HTML
customizations
- Task scheduler
- Quote editor
  - Main page
  - New quote
  - Edit quote
  - Import quotes
- Uploads
  - Main page
  - Upload file
  - Delete file
  - Search for file
- Access files
- OPAC problem reports (with OPACReportProblem enabled)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

--- Comment #11 from Lucas Gass  ---
(In reply to Martin Renvoize from comment #8)
> Whilst the functionality here works nicely, I'm not sure about the styling
> myself.
> 
> I think I'd either prefer a 'Switch to X editor' button that contextually
> sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle
> switch rather than the large toggle the includes the text within it.
> 
> Tagging Owen for that more artistic eye ;P

Martin, maybe my latest patch is more in line with what you envision?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

Lucas Gass  changed:

   What|Removed |Added

 Attachment #154472|0   |1
is obsolete||

--- Comment #10 from Lucas Gass  ---
Created attachment 155706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155706=edit
Bug 34275: Add toggle switch for basic/advanced cataloging editors

To test:
1. Apply patch and regenerate CSS.
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
2. Turn on EnableAdvancedCatalogingEditor.
3. Go to cataloging > 'New record'
4. In the upper left notice a new toggle switch labeled 'Editor:'.
5. Try toggling the switch back and forth to move between editors. Verify it
works correecly.
6. Try editing an existing record and make sure the toggle works well when
editing records.
7. Try the other method of switch editors, Settings > Switch to basic/advanced
editor. Make sure it works the same as always
8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no
longer present.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34782] ImportBreedingAuth does not limit to the import batch

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34782

--- Comment #2 from Phil Ringnalda  ---
I'm not sure how many of these are readily fixable in a single reworking, but
there are several other problems (unsurprisingly, since we're using it as a
cache, and cache invalidation is canonically a hard problem):

Even using the import batch just means limiting by the hostname of the server.
For the two we ship, there aren't collisions because control numbers in the LC
NAF start with n and control numbers in the LC SAF start with sh (or sj or gf),
but there's no guarantee that holds true for any domain name hosting more than
one authority database. You could easily get baffling errors when
auths-o-plenty.com happened to have two records with the control number
0001372638648 with the same 100 and everything else different, from two
different databases so as far as they were concerned there was no collision.

There's also nothing in MARC saying that 001 is unique within a single
database. (003)001 really ought to be since they are completely meaningless
otherwise, but not 001.

Nor does (003)001+1xx define a particular instance of the record: when someone
dies and gets the year of their death added to their personal name record, it
will also be added to their name in a 500 see-also in the corporate name record
for the name of the band they were a member of. If you look for the records on
the day that your source is changing them, but an hour before they actually
did, you'll be fine for the personal name, since we'll be looking for
Timberlake, Justin, 1981-2023 and not confused by Timberlake, Justin, 1981-,
but once you looked at the copy of 'NSync (Musical Group) with 500 Timberlake,
Justin, 1981-, that's all you will be shown, making you think your source was
sloppy and failed to update the see-also. I've actually done that, and wondered
what sort of workflow caused the LC to update the main entry a day before they
updated the see-also, because by the next day I had a cleaned-up lx2.loc.gov
that no longer had an outdated cached copy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20859] Enter SMS number and SMS provider during self registration

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

--- Comment #16 from Lucas Gass  ---
(In reply to Marcel de Rooy from comment #15)
> +[% IF ( Koha.Preference('SMSSendDriver') ) &&
> !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') &&
> action != 'edit' %]
> 
> Please explain this condition.
> What about the case that I want to hide one of them? Is that just nonsense?
> Later on you test again:
> [% UNLESS hidden.defined('smsalertnumber') %]
> But you should know that already given the earlier condition.
> 
> Please clarify

I suppose the question is should patrons be allowed to give a SMSnumber when
SMSSendDriver is turned off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 28688] Automatically renew patron membership

2023-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26355

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 4 >

1 - 100 of 392 matches

Mail list logo