[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #20 from Jonathan Druart --- (In reply to Blou from comment #15) > (In reply to Jonathan Druart from comment #14) > > We are loosing the logaction calls. > > Very good point. > > This needs to be preserved, one way or another. It's unfortunate the call > to "preference" being to prevalent everywhere, it makes it hard to move all > that elsewhere. Koha::Config::Sysprefs could have been the entry point > otherwise. Yes, this is what need to be done here (remove C4::Context->preference). It could be scripted. I was sure we had a bug for that but I didn't find it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34008] REST API: Add a list (GET) endpoint for itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34008 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_11_candidate --- Comment #11 from Tomás Cohen Arazi --- I see a few problems with this implementation. I'm marking this one rel_23_11_candidate because they are easily solvable and I can help. * What I will need input on is on the attributes names. This needs work. To start with, we call them item_type across the other endpoints. So the endpoint name and the id need a change. The rest of the attribute names need some love (i.e. we hide our weird internal names and put something better, along with a mapping). * The controller shouldn't deal explicitly with embeds. Pick the /cities endpoint controller as an example and you'll be fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35172] New: Order receiving error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35172 Bug ID: 35172 Summary: Order receiving error Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: librar...@sageuniversity.in QA Contact: testo...@bugs.koha-community.org Created attachment 157967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157967=edit Error in order receiving I am using koha version 22.11.10.when receiving order something went wrong when loading the table 500 internal server error please see the screen shot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32776] Choose to convert oldest reserve or all possible reserves to recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32776 Aleisha Amohia changed: What|Removed |Added Attachment #157178|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 157966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157966=edit Bug 32776: Terminology: Reserves to Holds The syspref is now called ConvertSelectedHoldsToRecalls The script is now called misc/cronjobs/recalls/convert_holds_to_recalls.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 --- Comment #18 from David Nind --- It seems to work with my limited testing - if this isn't sufficient, please change the status. The only thing I found confusing was the message shown when run "Deleted XX authorities" - I'm assuming there is some logic here that I don't quite get. Basic testing notes (using KTD): 1. Go to Authorities 2. Duplicate an existing personal name authority that is used in a record 3. Note the original and duplicate authority number 4. Run the script: misc/maintenance/dedup_authorities.pl -v -a PERSO_NAME -m date -c 5. Check the authorities in the staff interface - one is deleted and one is kept I did some other testing, notes as follows. FYI === Number of terms for authority types - from the script and search results in the staff interface: Chronological (CHRON_TERM): Script: 0 ; Search result: 0 Corporate Name (CORPO_NAME): Script: 88 ; Search result: 88 Genre/Form Term (GENRE/FORM): Script: 49 ; Search result: 49 Geographic Name (GEOGR_NAME): Script: 142 ; Search result: 142 Meeting Name (MEETI_NAME): Script: 3 ; Search result: 3 Personal Name (PERSO_NAME): Script: 650 ; Search result: 650 Topical Term (TOPIC_TERM): Script: 663 ; Search result: 663 Uniform Title (UNIF_TITLE): Script: 111 ; Search result: 111 Default/No authority type selected: Script: 1706 ; Search result: 1706 Script result - showing authority records by type: kohadev-koha@kohadevbox:koha(bz13706)$ misc/maintenance/dedup_authorities.pl -v -m date RUNNING IN TEST MODE, NO CHANGES WILL BE MADE Fetching authtypecodes... Fetching authtypecodes done. Deduping authtype '' Fetching authorities for ''... 0 authorities found End of deduping for authtype '' Updated 0 biblios Deleted 0 authorities Deduping authtype 'CHRON_TERM' Fetching authorities for 'CHRON_TERM'... 0 authorities found End of deduping for authtype 'CHRON_TERM' Updated 0 biblios Deleted 0 authorities Deduping authtype 'CORPO_NAME' Fetching authorities for 'CORPO_NAME'... 88 authorities found End of deduping for authtype 'CORPO_NAME' Updated 0 biblios Deleted 0 authorities Deduping authtype 'GENRE/FORM' Fetching authorities for 'GENRE/FORM'... 49 authorities found End of deduping for authtype 'GENRE/FORM' Updated 0 biblios Deleted 0 authorities Deduping authtype 'GEOGR_NAME' Fetching authorities for 'GEOGR_NAME'... 142 authorities found Progression for authtype 'GEOGR_NAME': 100/142 (70.42%) End of deduping for authtype 'GEOGR_NAME' Updated 0 biblios Deleted 0 authorities Deduping authtype 'MEETI_NAME' Fetching authorities for 'MEETI_NAME'... 3 authorities found End of deduping for authtype 'MEETI_NAME' Updated 0 biblios Deleted 0 authorities Deduping authtype 'PERSO_NAME' Fetching authorities for 'PERSO_NAME'... 650 authorities found Malformed authority record, no heading at misc/maintenance/dedup_authorities.pl line 172. Progression for authtype 'PERSO_NAME': 100/650 (15.38%) Progression for authtype 'PERSO_NAME': 200/650 (30.77%) Progression for authtype 'PERSO_NAME': 300/650 (46.15%) Progression for authtype 'PERSO_NAME': 400/650 (61.54%) Progression for authtype 'PERSO_NAME': 500/650 (76.92%) Malformed authority record, blank heading at misc/maintenance/dedup_authorities.pl line 176. End of deduping for authtype 'PERSO_NAME' Updated 0 biblios Deleted 0 authorities Deduping authtype 'TOPIC_TERM' Fetching authorities for 'TOPIC_TERM'... 663 authorities found Progression for authtype 'TOPIC_TERM': 100/663 (15.08%) Progression for authtype 'TOPIC_TERM': 200/663 (30.17%) Progression for authtype 'TOPIC_TERM': 300/663 (45.25%) Progression for authtype 'TOPIC_TERM': 400/663 (60.33%) Progression for authtype 'TOPIC_TERM': 500/663 (75.41%) End of deduping for authtype 'TOPIC_TERM' Updated 0 biblios Deleted 0 authorities Deduping authtype 'UNIF_TITLE' Fetching authorities for 'UNIF_TITLE'... 111 authorities found End of deduping for authtype 'UNIF_TITLE' Updated 0 biblios Deleted 0 authorities No biblios to update Testing using Genre/Form Term = Summary ~~~ Total before script run: 49 terms Manually went through results in staff interface to identify duplicates: Commedy films. 982 (deleted), 1586 (kept) Feature films. 625 (deleted), 650 (deleted), 654 (deleted), 822 (deleted), 984 (kept), 987 (deleted) Fiction films. 823 (deleted), 985 (kept), 988 (deleted) Foreign films. 626 (kept), 988 (deleted) Historical fiction. 1018 (kept), 1019 (deleted) Video recordings for the hearing impaired. 986 (kept), 989 (deleted) Summary = 17 terms, should only be 6 = 11 should be deleted Expected number of terms to be deleted: 11 (result would be 38 terms left) Results from running the script - shows 14 deleted (3 shown as deleted twice): 987, 822, 625, 625, 650, 654, 655, 988, 823, 823, 982, 982, 989, 1019 End result is the same, not sure why showing as it does. Search results after in the staff interface: 38 Script results after: 38
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 David Nind changed: What|Removed |Added Attachment #157935|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 157965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157965=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. Script is in misc/maintenance/ It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query using the 'search_form' for the heading 2.2) run the query, retrieve the results 2.3) among duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) delete the merged authorities Use --help for more informations on options To be done: 1 - Move to module and cover with tests 2 - Add option to only merge unused authorities 3 - Expand 'ppn' option to be 'control-number' option and allow specifying field 4 - More? 1 & 2 I will attempt - 3 & 4 may be future enhancements Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #23 from Lucas Gass --- > For consistency: How do these templates behave when looked at in the notices > tab or when sent per email? Im my tests/examples I used overdue notices ( ODUE ), so what I see in notice tab/email remains consistent with the patch, without the patch, and when I remove the regex line. TEST1 Our Address Our City Our State Thank you, Library But this is because that content is generated by overdue_notices.pl and is not going through gather_print_notices.pl Question: Could the regex line we are changing in gather_print_notices.pl be something that we make configurable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #22 from Katrin Fischer --- (In reply to Lucas Gass from comment #20) > I have a question. When we tick the box to make a notice an HTML message ( > is_html=1 ) do we expect in the entire template to marked up? In Matt's > example that is the case. Hm, I think we are getting to the bottom of this now. Yes, I think we do for email notices and we should also do that for print notices? If we use HTML and especially with TT mark-up we want the line breaks to be explicit, not implicit. You will want to format a CASE statement or similar on multiple lines to be readable. And it should collapse them as expected from HTML. Doing implicit line breaks might help people who didn't stick with HTML, but it removes control for everyone else and force us to do weird things. Our templates are getting more advanced and complicated all the time with TT, I could also see an IF-statement, that leaves blank lines if the condition is not met. I believe that this behaviour will bite us. > I ask because we have a lot of templates where this is not the case. For > instance someone might add a logo at the top of the notice, src="somesorc" width="500" alt="somealt" /> > > > But after that they rest of the notice is NOT marked up. So here is my > example template: > > > TEST1 > > > Our Address > Our City > Our State > > > Thank you, > > > Library > > > > With no patch applied I continue to have line breaks honored for the content > NOT wrapped in HTML elements. > > With the patch my non-marked up content looks like this: > > > Our Address Our City Our State > Thank you, > Library > > > > With no regex, like Cait suggests I get this for my non-marked up content: > > > Our Address Our City Our State Thank you, Library > I can see where this whole thing is a problem now when this has worked before :( For consistency: How do these templates behave when looked at in the notices tab or when sent per email? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #21 from Lucas Gass --- So I guess the question is whether or not we should allow for this mix of html/non-html content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #20 from Lucas Gass --- I have a question. When we tick the box to make a notice an HTML message ( is_html=1 ) do we expect in the entire template to marked up? In Matt's example that is the case. I ask because we have a lot of templates where this is not the case. For instance someone might add a logo at the top of the notice, But after that they rest of the notice is NOT marked up. So here is my example template: TEST1 Our Address Our City Our State Thank you, Library With no patch applied I continue to have line breaks honored for the content NOT wrapped in HTML elements. With the patch my non-marked up content looks like this: Our Address Our City Our State Thank you, Library With no regex, like Cait suggests I get this for my non-marked up content: Our Address Our City Our State Thank you, Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074 --- Comment #24 from David Cook --- (In reply to Martin Renvoize from comment #23) > I'm considering coming back to option 1 in David's suggestions... do you > think you're likely to have any time to work through this early next cycle > David? I'm a little out of my depth, but would love to see this moving > forward. Probably not :/. I've away a lot in January and then I'll have a lot of work to catch up on in Feb and March. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 --- Comment #5 from Aleisha Amohia --- Created attachment 157964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157964=edit Bug 17617: Confirmation email to patron when hold is placed This enhancement adds a new notice HOLDPLACED_PATRON that will be sent to a patron when a hold is placed for them. It depends on the new system preference EmailPatronWhenHoldIsPlaced to be enabled. To test: 1) Update database and restart services 2) Go to Koha Administration -> System preferences and search for the new EmailPatronWhenHoldIsPlaced syspref. It should be disabled by default - leave it disabled for now. 3) Search for a record and go to the Holds tab. Place a hold for your patron. 4) Go to your patron's account and go to the Notices tab. Confirm the HOLDPLACED_PATRON notice was NOT queued. 5) Enable the EmailPatronWhenHoldIsPlaced syspref. 6) Repeat steps 3 and 4. Confirm the HOLDPLACED_PATRON notice WAS generated and queued. 7) Confirm tests pass t/db_dependent/Holds.t Sponsored-by: Fire and Emergency New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 --- Comment #4 from Aleisha Amohia --- Created attachment 157963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157963=edit Bug 17617: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 --- Comment #3 from Aleisha Amohia --- Created attachment 157962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157962=edit Bug 17617: Add HOLDPLACED_PATRON notice A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 --- Comment #2 from Aleisha Amohia --- Created attachment 157961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157961=edit Bug 17617: EmailPatronWhenHoldIsPlaced system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35019] Can't delete news from the staff interface main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35019 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- On a side note, generally speaking, we want to avoid putting CSRF tokens in GET requests, and we want to avoid state changes via GET requests. This could've been an opportunity to refactor this delete to use a POST instead. At some point, I think we'll update the coding guidelines to reflect that, but just a FYI to folk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #8 from David Nind --- For Step 9, I'm not seeing the message about blocking and non-blocking fines if "Included in noissuescharge?" is not ticked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|Needs documenting Resolution|FIXED |--- --- Comment #65 from Katrin Fischer --- (In reply to Fridolin Somers from comment #64) > Enhancement not pushed to 23.05.x > > Such a long report should have great release notes ;) ... and Documentation! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #21 from Emily Lamancusa --- Ooh, good point. I was thinking that AddReturn had all of that covered, but the last time I looked at this I missed the fact that AddReturn would only get called if the item had a current checkout. Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31846] Allow setting serials search results limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34704] Print templates are formatted incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 --- Comment #19 from Katrin Fischer --- I thought I was clear: Can you explain why we are adding at all? It feels like this is an unneded change. We either have an HTML template, then we are good. Or we have a plain text template and we are using pre - we are also good. I think it helps your sites, because it reduces unwanted additional breaks, but why add any at all? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28530] Allow configuration of floating limits by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Ashley Johnson changed: What|Removed |Added CC||ajohn...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28530] Allow configuration of floating limits by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #19 from Blou --- moved my patches to Bug 28411, more appropriate as pointed out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Blou changed: What|Removed |Added Attachment #157953|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Blou changed: What|Removed |Added Attachment #157945|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 --- Comment #14 from David Nind --- Created attachment 157960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157960=edit Bug 34894: (follow-up) Fix id for HTML customization help Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 David Nind changed: What|Removed |Added Attachment #157917|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 157959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157959=edit Bug 34894: (follow-up) Add entry to HTML customization help include Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 David Nind changed: What|Removed |Added Attachment #157916|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 157958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157958=edit Bug 34894: Convert OpacSuppressionMessage system preference to HTML customization This patch moves the OpacSuppressionMessage system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the OpacSuppressionMessage system preference before applying the patch. Apply the patch and run the database update process. - In the staff interface, locate a bibliographic record and open it for editing. - Under tab 9, tag 942, change subfield n, "Suppress in OPAC", to "Yes" and save the record. - Go to the OPAC and try to navigate directly to the bibliographic detail page for that record: /cgi-bin/koha/opac-detail.pl?biblionumber=X - You should be redirectd to the "Blocked" page. Under the message "You are not authorized to view this record" you should see the content which was previously in the OpacSuppressionMessage system preference. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacSuppressionMessage is now stored there. - The HTML customization entry form should offer OpacSuppressionMessage as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the OpacSuppressionMessage HTML customization and add unique content to the "fr-FR" tab. - Go to the OPAC and switch to your updated translation. Try to view the suppressed record again and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "OpacSuppression." The description of these preferences should show an updated message about using HTML customizations to create OpacSuppressionMessage content. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com --- Comment #5 from Blou --- Added two exploratory patches. Huge effect on memory footprint, but doesn't pass tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 --- Comment #4 from Blou --- Created attachment 157957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157957=edit Bug 28411: remove Koha::Config::Syspref(s) from C4::Context Use straigth SQL queries to access systempreferences instead of relying on the ORM, thus removing all direct and indirect dependencies to Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28411] Investigate memory footprint of the different dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28411 --- Comment #3 from Blou --- Created attachment 157956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157956=edit Bug 28411: Use lazy loading to reduce memory footprint of C4/Context.pm This simply removes some 'use' declarations at the top of the file to instead use 'require' later on. The effect can be validated with a simple one-liner (provided KOHA_CONF and PERL5LIB being set) perl -e "use C4::Context; while(1){sleep(1);}" And monitoring the memoring usage in tools like 'top' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #18 from Blou --- prove t/db_dependent/sysprefs.t fails the cache test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Attachment #157949|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 157955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157955=edit Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef This patch makes the effective not for loan status be set the item value if not defined at itype level. To test: 1. Apply the regressions tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Attachment #157948|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 157954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157954=edit Bug 35167: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Blou changed: What|Removed |Added Attachment #157952|0 |1 is obsolete|| --- Comment #17 from Blou --- Created attachment 157953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157953=edit Bug 28410: remove Koha::Config::Syspref(s) from C4::Context Use straigth SQL queries to access systempreferences instead of relying on the ORM, thus removing all direct and indirect dependencies to Koha::Object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Blou changed: What|Removed |Added Attachment #157946|0 |1 is obsolete|| --- Comment #16 from Blou --- Created attachment 157952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157952=edit Bug 28410: remove Koha::Config::Syspref(s) from C4::Context Use straigth SQL queries to access systempreferences instead of relying on the ORM, thus removing all direct and indirect dependencies to Koha::Object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17617] Confirmation e-mail to patron when hold is placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34678] Concurrent changes to the holds can fail due to primary key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34678 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34678] Concurrent changes to the holds can fail due to primary key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34678 Emily Lamancusa changed: What|Removed |Added Attachment #157914|0 |1 is obsolete|| --- Comment #14 from Emily Lamancusa --- Created attachment 157951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157951=edit Bug 34678: Allow new entries to overwrite hold_fill_targets When using background jobs, there is a possibility of a race condition where two jobs will be updating the holds queue for the same biblio. We should try to minimize those cases (see bug 34596) In the meantime though, we should prevent jobs possibly dying, and allow the most recent update to succeed. There is a possibility two updates wil assign different items to the same reserve, and that a reserve could end up in the queue twice, however, whichever one is filled first will delete both entries. as filling the hold deletes by reserve id (see bug 24359) This patch adds a transaction to delete and then inset the new row To test: 1 - prove -v t/db_dependent/Reserves.t 2 - It fails 3 - Apply patch 4 - t/db_dependent/Reserves.t 5 - It succeeds! Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34678] Concurrent changes to the holds can fail due to primary key constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34678 Emily Lamancusa changed: What|Removed |Added Attachment #157913|0 |1 is obsolete|| --- Comment #13 from Emily Lamancusa --- Created attachment 157950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157950=edit Bug 34678: Unit test Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26170] Add protected status for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #47 from Tomás Cohen Arazi --- Hi, I have some doubts about this 'feature' and the implementation. Will do my best to review it and provide feedback ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35119] Make bibliographic errors more prominent and match current styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Tomás Cohen Arazi changed: What|Removed |Added Keywords||additional_work_needed CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi --- This seems to have broken some selenium tests. Please fix ASAP. https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #40 from Tomás Cohen Arazi --- Hey, this broke tests. Please provide a fix ASAP. https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #15 from Blou --- (In reply to Jonathan Druart from comment #14) > We are loosing the logaction calls. Very good point. This needs to be preserved, one way or another. It's unfortunate the call to "preference" being to prevalent everywhere, it makes it hard to move all that elsewhere. Koha::Config::Sysprefs could have been the entry point otherwise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579 Émily-Rose Francoeur changed: What|Removed |Added Assignee|hammat.w...@inlibro.com |emily-rose.francoeur@inLibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #14 from Jonathan Druart --- We are loosing the logaction calls. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added CC||dc...@prosentient.com.au, ||lu...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate, ||rel_23_05_candidate, ||rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0 and itemtype.notforloan == NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Summary|GET /items* broken if |GET /items* broken if |notforloan == 0 |notforloan == 0 and ||itemtype.notforloan == NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 --- Comment #7 from Lucas Gass --- > 4. Our patrons check out almost exclusively on self check stations and they > are not including the rental related fees in the amount shown, because they > are not being sent through SIP. This patchset deals with the display in the staff interface on the moremember.pl and circulation.pl pages. Anything dealing with SIP should be a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 157949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157949=edit Bug 35167: Make 'effective_not_for_loan_status' fallback to 0 if itype has it undef This patch makes the effective not for loan status be set the item value if not defined at itype level. To test: 1. Apply the regressions tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 157948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157948=edit Bug 35167: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 --- Comment #6 from Lucas Gass --- Created attachment 157947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157947=edit Bug 33264: Add information about both blocking/non-blocking fines/fees to blocked-fines.inc 1. Go to Administration > Item types and add a rental charge to an item type. 2. Check out some items of that type to a patron. 3. Go to Debit Types -> RENT and check "Included in noissuescharge?" 3. Now you will see those rental changes on both the checkout and detail pages, checkouts are blocked 4. Go to Debit Types -> RENT and uncheck "Included in noissuescharge?" 5. Now you see no information about the rental charges on the checkout/detail pages. 6. APPLY PATCH, restart services 7. Now check the morememember.pl and cicruclation.pl pages. You should see information about both blocking/non-blocking charges on both of the pages. 8. Turn on BatchCheckout 9. Now from the patrons batch checkout screen make sure the information appears for both blocking/non-blocking charges. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33264] Rental fees should show on checkout/detail pages regardless of RentalsInNoissuesCharge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33264 Lucas Gass changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #191 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #190) > QA Comment: > > Great work. We have a base to build further. We might still improve on > details? To infinity, and beyond! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 --- Comment #13 from Blou --- Created attachment 157946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157946=edit Bug 28410: remove Koha::Config::Syspref(s) from C4::Context Use straigth SQL queries to access systempreferences instead of relying on the ORM, thus removing all direct and indirect dependencies to Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 Blou changed: What|Removed |Added Attachment #157875|0 |1 is obsolete|| --- Comment #12 from Blou --- Created attachment 157945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157945=edit Bug 28410: Use lazy loading to reduce memory footprint of C4/Context.pm This simply removes some 'use' declarations at the top of the file to instead use 'require' later on. The effect can be validated with a simple one-liner (provided KOHA_CONF and PERL5LIB being set) perl -e "use C4::Context; while(1){sleep(1);}" And monitoring the memoring usage in tools like 'top' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35171] runreport.pl cronjob should optionally send an email when the report has no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35171 --- Comment #1 from Nick Clemens --- Created attachment 157944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157944=edit Bug 35171: Add send_empty option to runreport This patch adds a new 'send_empty' option to runreport.pl To test: 1 - Create a report in Koha that will not return any results: SELECT barcode FROM items WHERE 1=2 2 - perl misc/cronjobs/runreport.pl 1 3 - Output is: NO OUTPUT: 0 results from execute_query 4 - perl misc/cronjobs/runreport.pl 1 --send_empty 5 - Output is: no results were returned for the report 6 - perl misc/cronjobs/runreport.pl 1 --send_empty --email 7 - It will die on an email error unless you have SMTP configured - this si good, it means we sent an email 8 - Bonus points: Test on a system that can correctly send emails, confirm it works :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35171] runreport.pl cronjob should optionally send an email when the report has no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35171 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35171] New: runreport.pl cronjob should optionally send an email when the report has no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35171 Bug ID: 35171 Summary: runreport.pl cronjob should optionally send an email when the report has no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Some libraries would like to know that a report was run overnight, even if there were no results. We should allow this as an optional feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #116 from Martin Renvoize --- One for next cycle at this point I reckon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579 Émily-Rose Francoeur changed: What|Removed |Added CC||emily-rose.francoeur@inLibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #61 from Emily Lamancusa --- Awesome, just tested the fixes and they all seem to be working! Adding a tiny follow-up patch to fix what I assume is a copy/paste error, though. In the "Use same conditions..." follow-up, shouldn't the button id still be "hold_grp_btn" though? (the patch changed it to "hold_any_btn") > > - The circ rule for maximum number of items allowed per record was not > > enforced for item-level holds. i.e. with a limit of 2, it was possible to > > place 3 item-level holds for the same patron even if overrides were not > > allowed. If overrides are allowed, there should be a warning at the top of > > the page, but the warning does not appear for a patron with the max number > > of item-level holds. > > I don't recreate this one I'm not recreating it anymore either. Maybe it was just something weird on my end. I don't follow Koha's template logic well enough yet to be confident QAing this one, but I added an additional sign-off since I confirm everything worked as expected in my testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #60 from Emily Lamancusa --- Created attachment 157943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157943=edit Bug 30579: (follow-up) fix button id Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157792|0 |1 is obsolete|| --- Comment #59 from Emily Lamancusa --- Created attachment 157942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157942=edit Bug 30579: (follow-up) Add required label and warning when hold levels required Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157791|0 |1 is obsolete|| --- Comment #58 from Emily Lamancusa --- Created attachment 157941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157941=edit Bug 30579: (follow-up) Use same conditions on item groups place hold button as on other options Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157790|0 |1 is obsolete|| --- Comment #57 from Emily Lamancusa --- Created attachment 157940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157940=edit Bug 30579: (follow-up) Add fieldsets and style disabled elements This patch surrounds each section with a fieldset which allow enabling/disabling all the elements in one go. CSS is added to make it clear which fields are disabled. Button for item specific is moved form the multi-hold section Javascript is simplified to use the new fieldsets To test: 1 - Repeate test plan on earlier commit 2 - Additionally, search and select multiple records and place hold 3 - Confirm multi-hold placing works :-) Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157789|0 |1 is obsolete|| --- Comment #56 from Emily Lamancusa --- Created attachment 157939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157939=edit Bug 30579: Remove doubled notes field Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157788|0 |1 is obsolete|| --- Comment #55 from Emily Lamancusa --- Created attachment 157938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157938=edit Bug 30579: Add missing for attribute on label Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What|Removed |Added Attachment #157787|0 |1 is obsolete|| --- Comment #54 from Emily Lamancusa --- Created attachment 157937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157937=edit Bug 30579: Disentangle multi-hold and single bib forms This patch alters the structure of the hold request page to make it clear that "Hold next available", "Hold item group", and "Hold specific item" are mutually-exclusive options. While there is some duplication from this, it makes the sections easier to read and allows for more variation in the two forms To test: 1 - Find a bib with multiple items 2 - Enable item groups and item group holds in system preferences 3 - Load the records detail page 4 - Add an item group on the item groups tab 5 - Select two items and add to the group 6 - Click the 'Holds' tab and search for/select a patron 7 - Confirm the three levels of holds are clear 8 - Confirm checking the radio next to one disables the others 9 - Check 'Hold next available item from an item group' 10 - Do not select an item group 11 - Click 'Place hold' and confirm you are notified of need to select an item group NOTE: if you are overrirding you may also have an alert that the items cannot normally be put on hold 12 - Click 'Place hold on a specific item' - but do not select an item 13 - Click place hold and confirm there is an alert and you cannot continue 14 - Click 'Hold next available item' and place hold 15 - Hold is successfully placed 16 - Place another hold for the same patron 17 - Only the 'Hold next available item' form is enabled 18 - Confirm you cannot switch hold type 19 - Place hold 20 - Select a new patron and place an item group hold 21 - Select the same patron and place another hold - you are forced to place an item group hold 22 - Select a new patron and place a hold on a specific item 23 - Place a second hold, confirm you can only place it on a specific item Signed-off-by: hinemoea Signed-off-by: Sam Lau Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #15 from Lucas Gass --- Created attachment 157936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157936=edit Bug 35131: Fix preference description and move barcode to bottom of patroninfo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35167] GET /items* broken if notforloan == 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35167 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35170] Make long overdue item type options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35170 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35169 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35170 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35170] New: Make long overdue item type options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35170 Bug ID: 35170 Summary: Make long overdue item type options configurable in interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Being able to set the item type options: 'itemtype=s'=> $itemtype 'skip-itemtype=s' => $skip_itemtype, Via the staff interface would be really helpful for users being able to update their longoverdue settings without needing to edit the command line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35169] New: Make long overdue borrower category options configurable in interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35169 Bug ID: 35169 Summary: Make long overdue borrower category options configurable in interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Being able to set the borrower category options: 'category=s'=> $borrower_category, 'skip-category=s' => $skip_borrower_category Via the staff interface would be really helpful for users being able to update their longoverdue settings without needing to edit the command line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35122] Allow Koha to Print Barcodes Singularly or a Batch of barcodes that are not in the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35122 --- Comment #10 from Chris Nighswonger --- I'm looking for a use case or three. Maybe there are library holdings which are not cataloged, but need a formal label of some sort? Should this new feature allow entry of data other than the barcode to be printed on the resulting label? And/or ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34896] Separate Z39.50 permission from edit_catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34896 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35168] Add a fines amnesty setting in library administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35168 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31498] Allow for custom primary contact method values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35122] Allow Koha to Print Barcodes Singularly or a Batch of barcodes that are not in the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35122 --- Comment #9 from Kelly McElligott --- Very true! One could create a new process to print labels outside of Koha. However, since a library has created a label template and layout in Koha to print labels- allowing the possibility to do this from Koha would be a time saver! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35168] New: Add a fines amnesty setting in library administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35168 Bug ID: 35168 Summary: Add a fines amnesty setting in library administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Some libraries will occasionally have a 'fines amnesty' week, or similar, to allow patrons to return items with no fines. Currently you can select a dropbox while checking in to accomplish this, however, it requires manual work and memory. It would be nice to have an option to enable/disable this for a branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31184] Add default permissions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184 --- Comment #1 from Katrin Fischer --- I would not want to have to maintain say circulation rules for multiple staff patron categories just because they have different permission profiles. I think having the permission profiles separate from patron categories would be much more useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27441] Create a notice that can be sent when the Long Overdue Cron runs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27441 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What|Removed |Added Attachment #127263|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 157935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157935=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. Script is in misc/maintenance/ It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query using the 'search_form' for the heading 2.2) run the query, retrieve the results 2.3) among duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) delete the merged authorities Use --help for more informations on options To be done: 1 - Move to module and cover with tests 2 - Add option to only merge unused authorities 3 - Expand 'ppn' option to be 'control-number' option and allow specifying field 4 - More? 1 & 2 I will attempt - 3 & 4 may be future enhancements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #14 from Lucas Gass --- (In reply to Owen Leonard from comment #4) > What is the use case here? If the patron record is already up why scan the > barcode? > > I ask in part because my impulse is to say the barcode should go below the > patron info, but I don't know if that conflicts with the original > requirements. > > I think the preference description should be a little more specific: > > "Show a barcode of the patron record." > > Could be... "Show a barcode of the patron's card number in the > sidebar of patron-related pages" ? I agree. I will change the pref and add the barcode below the patron info. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #13 from Lucas Gass --- The feedback I am getting from libraries is very similar to the workflow explained by Ed and Dave: "This will enable us to quickly aid a patron who has forgotten their library card at the self-check machines. We would be able to scan this rather than put it in manually by hand. It would make us much more efficient on the floor." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #43 from Kyle M Hall --- (In reply to Martin Renvoize from comment #42) > Thanks for all the testing everyone, it's been really helpful having this > feedback :) https://monosnap.com/file/IiPJSKVtDkBOoR0toNlxBkDydMXqt0 It looks like I was able to place an out of bounds booking? More importantly, it seems that one patron cannot book something twice, but there's no feedback other than the patron's name not being selectable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 --- Comment #17 from Émily-Rose Francoeur --- Created attachment 157934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157934=edit Bug 30745: Display pagination for the results page I have fixed the pagination issue when the search returns multiple results. Test plan: - Enable elasticsearch - git to labels/label-item-search.pl - search using after date only => check you get items with date-of-acquisition greater than after date - search using before date only => check you get items with date-of-acquisition less than before date - search using after and before date => check you get items with date-of-acquisition between after and before - Combine this searches with a specified index - enable zebra and repeat these tests pagination tests - Perform a search that returns more than 20 notices - Navigate through different result pages using page numbers, the "Next" button, and the "Previous" button => On each page, check that "Results X through X of X" displays the correct information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #38 from Martin Renvoize --- Adding bug 18203 to the pile that would benefit from this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/