[Koha-bugs] [Bug 35079] Add option to gulp tasks po:update and po:create to control if POT should be built

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35079

--- Comment #19 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #18)
> Just adding a few lines for anyone who reads this later. Resolved situation
> by:
> 
> Using NODE_MAJOR=18
> 
> # npm / nodejs
> mkdir -p /etc/apt/keyrings; \
> curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key |
> gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg; \
> echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg]
> https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee
> /etc/apt/sources.list.d/nodesource.list; \
> apt-get update; \
> apt-get -yq install nodejs; \
> npm install -g yarn; \
> 
> Note that you cannot apt-get install nodejs npm. This gives a conflict. npm
> is part of the above install of nodejs.

Yes, see also
https://gitlab.com/koha-community/koha-testing-docker/-/issues/404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #47 from Jonathan Druart  ---
Last two patches pushed to master. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35283] XSLT 583 Action note is missing subfield h and x in staff interface

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283

--- Comment #11 from Katrin Fischer  ---
(In reply to David Cook from comment #10)
> While it's possible that "h" could have private information, this field has
> an indicator that prevents the note from showing if it's private, plus the
> subfield can be hidden from the OPAC using the MARC bibliographic
> frameworks, so sounds good about including it.

But then couldn't have any field private information? There is no note on the
field that indicates any internal use in the documentation and from the example
it seems like you'd want to see that (if you want your 583 to display):

$h - Jurisdiction

Name of a person, an institution, or a position or function within an
institution, in whom or in which responsibility for an action is vested.
583 ##$atransfer$c19770613$huniversity archives

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This enhancement makes
  release notes||authority record notes
   ||(6xx) more accessible in a
   ||special Notes pop-up,
   ||available in all authority
   ||search result lists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

--- Comment #1 from Aleisha Amohia  ---
Created attachment 158902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158902=edit
Bug 35328: Add a notes pop-up for authority records to authority search results

This enhancement makes authority record notes (6xx) more accessible in a
special Notes pop-up, available in all authority search result lists.

To test:
1) In the staff interface, go to the Authorities module and conduct a search.
Any records with 6xx fields should show with an italicised Notes link under the
heading. Click on the Notes link for each record and confirm the correct notes
for that record show.
2) Test this in the following staff interface pages:
- authority plugin when cataloguing a biblio record
- batch authority record modification
- batch authority record deletion
3) Test the Notes pop-up is available in the OPAC authority search
4) Confirm the Notes link does NOT show if there is no 6xx field in the record

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] Add a notes pop-up for authority records to authority search results

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35328] New: Add a notes pop-up for authority records to authority search results

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35328

Bug ID: 35328
   Summary: Add a notes pop-up for authority records to authority
search results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35283] XSLT 583 Action note is missing subfield h and x in staff interface

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283

--- Comment #10 from David Cook  ---
While it's possible that "h" could have private information, this field has an
indicator that prevents the note from showing if it's private, plus the
subfield can be hidden from the OPAC using the MARC bibliographic frameworks,
so sounds good about including it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20065] Perennial or persistent identifier implementation

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20065

--- Comment #3 from Pablo AB  ---
> We ourselves are using a custom plugin that adds a PID in field 024 for auth 
> and biblio.

Those plugins are FOSS? We are also using 024 to save our ORCIDs (subset of
ISNIs).

OTOH would be great to generate the ARK ID, maybe a NAAN on a syspref (like 
MARCOrgCode) or a branch attribute, and a value builder plugin to generate the
Shoulder+Blade+Tip. Probably a queue/cron should be added to inform the NMA(s)
about the new ID/URL map.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

Lari Taskula  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lari.task...@hypernova.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

--- Comment #1 from Lari Taskula  ---
Created attachment 158901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158901=edit
Bug 35327: Fix capitalization of language name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] Fix capitalization of language name

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

Lari Taskula  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35327] New: Fix capitalization of language name

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327

Bug ID: 35327
   Summary: Fix capitalization of language name
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: lari.task...@hypernova.fi
QA Contact: testo...@bugs.koha-community.org

Just a minor mistake I noticed while translating

koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt:176
english -> English

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427

David Cook  changed:

   What|Removed |Added

   Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun
   ||ity.org

--- Comment #25 from David Cook  ---
(In reply to Marcel de Rooy from comment #22)
> No Assignee. Please always use this field, David :)

If you look at the history, you'll see that I did back in July, Marcel :)

Last week Martin changed it to him and then to the default. 

At the moment, I don't intend to work on this further. I've been trying to get
this issue fixed for years, but autorenewals is a moving target. That is, it's
constantly changing. Perhaps Nick's ideas in Comment 19 are a better way to go. 

Resetting assignee to default in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31074] Cached plugin code is used in Koha even after changes to plugin (install/upgrade/uninstall)

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31074

--- Comment #37 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #36)
> Ok since the multi-tenant case isn't a problem here, one Koha instance will
> always have a reasonable number of workers vs the number of threads. So a
> Koha SIGHUPing it's starman master process shouldn't cause enough trouble to
> make option 2 of comment 19 non-viable. (IIUC)

I would hope that one wouldn't allow plugin upload for a multi-tenant case,
since tenant A could upload a malicious plugin that harms tenants B, C, D, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29079] Make bibliographic information in holds queue customizable

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079

CJ  changed:

   What|Removed |Added

 CC||cj.ly...@westlakelibrary.or
   ||g

--- Comment #7 from CJ  ---
This would be a helpful enhancement and would allow libraries to customize the
needed information, as well as conserve page space when certain information is
not needed. The suggestion of two new table columns seems like a good solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #9 from David Nind  ---
Also, once I've tested something and signed off, etc., I normally do:

1. git checkout master
2. git branch -D bzXX
3. git reset --hard origin/master
4. reset_all (resets Koha - gives you a clean setup, with needing to shut down
and restart KTD)

Here is a link to my KTD cheat sheet if that helps:
https://gitlab.com/-/snippets/1893788

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #8 from David Nind  ---
Hi Brendan.

This is what I normally do in KTD (assuming your Bugzilla credentials are in
the .env file):

1. Koha clone - up-to-date: on master branch, git pull
2. KTD up-to-date: git pull, ktd pull
3. Start up KTD: ktd up
4. Access Koha using the shell: ktd --shell
5. Checkout a branch for testing the bug: git checkout -B bzXX 
6. Apply the patches: git bz apply XXX
7. Test using the test plan, if there is one, or you know what it is about
8. Sign-off once happy: 
   8.1 git bz so X (X = the number of patches, in this case 2) (if you git log,
your sign-off line should show at the end of the patch)
   8.2 git bz attach -e XX HEAD (for one patch)
   or
   git bz attach -e XX HEAD~X.. (for multiple patches, where X = number
of patches, in this case 2) 
9. Check on Bugzilla that the status was changed to signed off.

XX = the bug number

I tried to apply the patch, but it no longer applies - I'm not a developer, so
don't normally try and resolve the conflict, and change the status in Bugzilla
to Patch doesn't apply.

If I get an error when going through the test plan, or it doesn't work, I would
normally indicate this in a comment on the bug and change the status to Failed
QA.

Patch doesn't apply message


kohadev-koha@kohadevbox:koha(bz35307)$ git bz apply 35216

Bug 35216 - Use return variable names from CanBookBeIssued in circulation.pl
for consistency

158185 - Bug 35216: Rename question to needsconfirmation
158187 - Bug 35216: Rename error to issuingimpossible

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35216: Rename question to needsconfirmation
Applying: Bug 35216: Rename error to issuingimpossible
error: sha1 information is lacking or useless (circ/circulation.pl).
error: could not build fake ancestor
Patch failed at 0001 Bug 35216: Rename error to issuingimpossible
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-35216-Rename-error-to-issuingimpossible-mjakx8dk.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35318] Item editing does not work. The fields do not appear.

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35318

--- Comment #5 from Alipio  ---
Thank you.. That was it...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35318] Item editing does not work. The fields do not appear.

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35318

--- Comment #4 from Katrin Fischer  ---
I'd also suggest running the MARC bibliographic framework test under
administration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35318] Item editing does not work. The fields do not appear.

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35318

--- Comment #3 from Katrin Fischer  ---
You probably removed 952 - this is the field that controls the item form. A
good rule is to never delete, but only hide fields and subfields from the
frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35318] Item editing does not work. The fields do not appear.

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35318

--- Comment #2 from Alipio  ---
Did you change the bibliographic frameworks?

Yes, I did. I removed some fields.

Are you using UNIMARC or MARC21?

Marc21

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #28 from Katrin Fischer  ---
I agree, I think showing only the option that works is better for now. I'll try
to test, but feel free to beat me to it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

--- Comment #7 from Brendan Lawlor  ---
Hi David, 

I am having trouble going through the process with git bz and now am afraid I
could be doing something wrong. I reset the Koha clone, deleted the local
branch I was testing on and tried again. 

git reset --hard origin/master
git checkout -b bug_35216

ktd up

ktd --shell

git bz apply 35216

This time I got a merge conflict in circ/circulation.pl. I'm using VS Code and
I went through and accepted the incoming changes and checked to make sure the
code looked right.

Then when I tested again, if I checked out an item that was already checked
out, I got the error that I got the first time:

Can't use string ("RENEW_ISSUE") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/circ/circulation.pl line 419
in (eval) at /kohadevbox/koha/circ/circulation.pl line 419
  416: 
  417: # pass needsconfirmation to template if issuing is possible
and user hasn't yet confirmed.
  418: foreach my $needsconfirmation ( keys %$needsconfirmation ) {
  419: $template_params->{$needsconfirmation} =
$$needsconfirmation{$needsconfirmation};
  420: $template_params->{getTitleMessageIteminfo} =
$biblio->title;
  421: $template_params->{getBarcodeMessageIteminfo} =
$item->barcode;
  422: $template_params->{NEEDSCONFIRMATION} = 1;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo  ---
> 6) Repeat 1) to 3). Notice it shows 2 current renewals even tho only 1 
> corresponds to the currently active check out

When clicking on "View" I see «Note: 1 out of 2 renewals have been logged».
What is the function of this?
Is that code in checkout_renewals_modal.js still relevant? I'm not sure after
the patch we can still get that message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35318] Item editing does not work. The fields do not appear.

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35318

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Katrin Fischer  ---
Did you change the bibliographic frameworks? 
Are you using UNIMARC or MARC21?

Overall this is more likely a support request/configuration issue than a bug
and I suggest to continue discussion on the mailing list
(https://koha-community.org/support/koha-mailing-lists/) or the IRC chat
(https://koha-community.org/get-involved/irc/).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Katrin Fischer  ---
Yes, you would think that, but it's actually not the spot.

OpacMoreSearches appears in the OPAC navigation - I just tested.

You mean  OPACSearchForTitleIn, this has not been migrated to HTML
customizations yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

--- Comment #36 from Fridolin Somers  ---
Fixed test suite, AddIssue still uses unblessed patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992

--- Comment #35 from Fridolin Somers  ---
Created attachment 158900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158900=edit
Bug 27992: [23.05] (follow-up) Fix unit test with unblessed patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32391] [DOCS] Reorganise the manual contents

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391

--- Comment #12 from Heather  ---
That would be great, Aude!!  I'll get my thoughts and notes together and be in
touch--it would be so helpful to look at it with you--I am such a newbie with
the manual and would appreciate your guidance!  Thank you!!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a checked out item is on hold for someone else

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284

--- Comment #27 from Fridolin Somers  ---
Unit test was failing :

#   Failed test 'No tests run for subtest "AuthenticatePatron test"'
#   at t/db_dependent/ILSDI_Services.t line 124.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'opacusercss' in 'field list' at
/kohadevbox/koha/t/lib/TestBuilder.pm line 384

Fixed in 23.05.x with follow-up :
AddIssue() still uses unblessed patron object.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #9 from Martin Renvoize  ---
Ha, I just missed the final addition of the relations in the spec file. I'm out
at the minute, but just adding vendor, deleted and basket keys to the edi_file
spec should get this going.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Laura O'Neil  changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

--- Comment #21 from Laura O'Neil  ---
This is a big request from our partner libraries; turning this into a system
preference would be lovely. The JS is good to have on hand, but sometimes stops
working after major releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21284] ILS-DI: Allow GetPatronInfo to tell if a checked out item is on hold for someone else

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21284

--- Comment #26 from Fridolin Somers  ---
Created attachment 158899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158899=edit
Bug 21284: [23.05] (follow-up) Fix unit test with unblessed patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #8 from Martin Renvoize  ---
Thanks for testing Kyle, good call on the relation change. I'll continue here
later tonight, be great to see this little enhancement in.

Ray, I'll work through the issues Kyle highlighted and then look at it getting
it into your test system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35316] Add call number to holds history page

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35316

Lucas Gass  changed:

   What|Removed |Added

 Attachment #158880|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 158898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158898=edit
Bug 35316: Fix column settings for holds history

Test plan:
Verify that you are able to toggle the column on the holdshistory
form.
Verify that you are able to hide the column via Table settings
by default.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35316] Add call number to holds history page

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35316

Lucas Gass  changed:

   What|Removed |Added

 Attachment #158879|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 158897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158897=edit
Bug 35316: Add callnumber to holdshistory

Test plan:
Verify that column Call number now shows on the form.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35316] Add call number to holds history page

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35316

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35316] Add call number to holds history page

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35316

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
Test plan:

1. Set IntranetReadingHistoryHolds to 'Allow'.
2. Place a item level hold for a user on an item that has a call number.
3. Go to the 'Holds history' tab on the patron's account. 
4. Notice the call number
5. Place a bib level hold. There will be no call number. 
6. Verify that you are able to hide the column via Table settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
Are you able to add your sign-off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35325] Add the ERM module to Library Groups

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35325

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] Terminology: Add additional elements to the "More Searches" bar...

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

--- Comment #1 from Owen Leonard  ---
Created attachment 158896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158896=edit
"More searches" menu item on the OPAC detail page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35326] New: Staff confirmation on shared accounts

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35326

Bug ID: 35326
   Summary: Staff confirmation on shared accounts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Some libraries use a single account for multiple staff to use, like at a front
desk.  It would be great if we could mark such accounts, and when certain
actions are recorded, Koha would prompt for a staff name.  For example, any
time a patron record is created or modified, item or bib records
created/modified, holds modified, etc.  It doesn't have to be everything a
staff member does.  But it should be some key things.  Maybe we could have a
preference for this.

Ideally it would much simpler if libraries didn't use shared accounts, but
since all libraries are different, and this can be a common practice, some of
us would might like there to be a way to better track who is doing what.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34136] Add ability to render a report using a notice template

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

--- Comment #40 from David Nind  ---
Thanks for your perseverance Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind  changed:

   What|Removed |Added

 Attachment #158873|0   |1
is obsolete||

--- Comment #39 from David Nind  ---
Created attachment 158895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158895=edit
Bug 30287: (follow-up) Make unit test more reliable in ktd

This patch mocks NoticeCSS earlier to ensure we're not inadvertantly
failing due to a local setup in ktd having added to the preference.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind  changed:

   What|Removed |Added

 Attachment #158872|0   |1
is obsolete||

--- Comment #38 from David Nind  ---
Created attachment 158894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158894=edit
Bug 30287: (follow-up) Unit test for html_content

This patch adds a unit test for the new `html_content` method introduced
to Koha::Notice::Template in the previous patch.

Test
1) Run the new unit test ;P

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind  changed:

   What|Removed |Added

 Attachment #158871|0   |1
is obsolete||

--- Comment #37 from David Nind  ---
Created attachment 158893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158893=edit
Bug 30287: (follow-up) Add content wrap matching send time

This patch adds a new method to the Koha::Notice::Message class to wrap
content in the same way we currently do at email send time. We then
update the notice preview to use this method so we're embedding
NoticeCSS into that iframe. This means the generated preview should now
exactly match how your notice will display in email clients including
any CSS you may have placed within NoticeCSS.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind  changed:

   What|Removed |Added

 Attachment #158870|0   |1
is obsolete||

--- Comment #36 from David Nind  ---
Created attachment 158892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158892=edit
Bug 30287: Conditionally render notice preview

This patch adds conditional formatting based on whether the notice was
generated from an HTML template or a plaintext one. We simply drop the
'html_line_break' filter for the case where the notice should already be
html formatted.

I was tempted to replace the html_line_break for plaintext formatted
notices too as I believe this closer resembles how we actually output
such generated notices.. but I decided that should be for another bug.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Martin Renvoize  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26554] allow news tag in all slips

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26554

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Lucas Gass  ---
We can already do this by using something like this in any slip/notice:

[% USE AdditionalContents %]
[% SET my_news = AdditionalContents.get( location => "slip", library =>
borrower.branchcode  ) %]

[% IF my_news.content.count > 0 %]
[% FOREACH item IN my_news.content %]
Title: [% item.title %]
Content: [%  item.content  %]

[% END %]
[% END %]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35319] Default sorting of the holdings table with OPACHoldingsDefaultSortField is broken

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35319

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

Martin Renvoize  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

Martin Renvoize  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260

--- Comment #39 from Martin Renvoize  ---
Comment on attachment 158855
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158855
Bug 33260: Make styles apply per notice

Review of attachment 158855:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=33260=158855)
-

I think this patch belongs in bug 33478 personally.. it's a fix for that bug
not this one after rebases.

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt
@@ +39,5 @@
>  [% SET slips = [{content => slip, is_html => !plain, style => style }] %]
>  [% END %]
>  [% FOR slip IN slips %]
> +[% IF slip.style %][% slip.style.replace('[^{]+{', '#slip_' _ slip.id 
> _ ' {') | $raw %][% END %]
> +

Also.. this should really be a block level element in my opinion rather than an
inline level element.. Probably a 'div'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31714

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31714] Add a more generic way to print patron slips

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31714

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30287

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35285] Centralise notice content wrapping for html output

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285

--- Comment #6 from Martin Renvoize  ---
Created attachment 158891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158891=edit
Bug 35285: Unit tests

This patch adds unit tests for the new 'is_html' function introduced in
Koha::Notice::Message and update the tests to include the new plaintext
handling of html_content.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35285] Centralise notice content wrapping for html output

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158658|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 158890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158890=edit
Bug 35285: Remove switch in notices.tt

We now wrap appropriately for non-html formatted messages as
part of the html_content method. This means we can remove the
case from members/notices.tt and rely on html_content doing
the right thing for notice previews.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35285] Centralise notice content wrapping for html output

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #158657|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 158889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158889=edit
Bug 35285: Add non-html template support to html_content wrapping

This patch adds support for messages generated using non-html formatted
notice templates to the html_content method of Koha::Notice::Message.

We continue to wrap content for html generated messages with the
appropriate headers, css and title.

For non-html generated content we wrap in the  block to maintain text formatting as defined in the original
plaintext template.

Test
Follow the test plan for bug 30287, nothing should outwardly change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

--- Comment #6 from David Gustafsson  ---
Context is module and filter, so if rules are applied with either z3950 or
batchmod, '*' rules are ignored. '*' rules are only applied if there are no
rules defined for the current context (module + filter). I think I decided on
this so that each context would have a clean slate and though that would be
easier to maintain, not having to undo wildcard rules for a new context, but I
can see how it's not the most intuitive. For our library for example, we want
to protect quite a lot of fields on imports, but want everything to be
overwritable in the staff interface. So we define the "import" rules in the '*'
context, and can just add one tag wildcard rule with for the staff interface to
make everything overwritable again. I think I assumed that would be the most
common use case. Merging in '*' would complicate things for us (but perhaps
make things easier for others). Another reason avoided this was that it
complicates the code quite a bit, but I think it would still be doable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12044] Checkout should be clearly disallowed before inputting item barcode if a patron's fines will block the transaction

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35187] Fix line breaks in some HTML notices, including WELCOME

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35187

--- Comment #21 from Fridolin Somers  ---
Great thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35325] New: Add the ERM module to Library Groups

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35325

Bug ID: 35325
   Summary: Add the ERM module to Library Groups
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: ERM
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: ke...@bywatersolutions.com
CC: jonathan.druart+k...@gmail.com,
jonathan.fi...@ptfs-europe.com,
martin.renvo...@ptfs-europe.com,
matt.blenkin...@ptfs-europe.com,
pedro.amo...@ptfs-europe.com

For multi-library systems in Koha currently, to use the ERM module, there is no
separation to identify what agreements and licenses go to which library.  It
would be fantastic to add the ERM module to Library Groups to allow a way to
separate and identify between libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #27 from Kyle M Hall  ---
(In reply to Pedro Amorim from comment #26)
> (In reply to Kyle M Hall from comment #25)
> > (In reply to Pedro Amorim from comment #24)
> > > I think it solves the issue nicely! However, previously we could have an
> > > "E-mail" type of notice for a Report and now we don't! I have added a new
> > > follow-up that maintains the "Email" and "SMS" options and only shows 
> > > "File
> > > name" for "Print", keeping "Message subject" for the other two. Feel free 
> > > to
> > > obsolete if this is not needed.
> > 
> > I'm not opposed to that, but I'm curious how you would use the email and sms
> > options.
> 
> This is why I said feel free to obsolete =D I don't know the feature
> in-depth but I would imagine you would also be able to send a report notice
> to an e-mail (as with other notices types), additionally to have the option
> to download it, if not please ignore it.

Thanks!
I'm going to deprecate it for the time being because that is not a function the
feature supports at this time, though it would make for a great followup
enhancement!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #158885|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||35324


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35324
[Bug 35324] Display for items not correct on receive for subscription orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35324] New: Display for items not correct on receive for subscription orders

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35324

Bug ID: 35324
   Summary: Display for items not correct on receive for
subscription orders
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 8179

There are some cases, where we show the header of the item table to the left on
the receive form, when there are no items. We should not be doing that.

It seems to always happen, when we have a subscription order. It could also be
that this points to missing functionality, as for subscriptions, we should have
a separate table with additional information.

The cases where something is not quite right are marked with a *:

Items in cataloging
* ordered 1, receive 1
* ordered 5, receive 2
* standing order, received on multiple invoices
* subscription*
* subscription + standing order*

Items on receive
* ordered 1, receive 1
* ordered 5, receive 2
* standing order, received on multiple invoices
* subscription*
* subscription + standing order* 

Items on order
* ordered 1, receive 1
* ordered 5, receive 2
* standing order, received on multiple invoices
* subscription (no items, because it's a subscription order)*
* subscription + standing order (no items, because it's a subscription order)*


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
[Bug 8179] Receiving multiple order lines at once
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #26 from Pedro Amorim  ---
(In reply to Kyle M Hall from comment #25)
> (In reply to Pedro Amorim from comment #24)
> > I think it solves the issue nicely! However, previously we could have an
> > "E-mail" type of notice for a Report and now we don't! I have added a new
> > follow-up that maintains the "Email" and "SMS" options and only shows "File
> > name" for "Print", keeping "Message subject" for the other two. Feel free to
> > obsolete if this is not needed.
> 
> I'm not opposed to that, but I'm curious how you would use the email and sms
> options.

This is why I said feel free to obsolete =D I don't know the feature in-depth
but I would imagine you would also be able to send a report notice to an e-mail
(as with other notices types), additionally to have the option to download it,
if not please ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35323] New: Terminology: Add additional elements to the "More Searches" bar...

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35323

Bug ID: 35323
   Summary: Terminology: Add additional elements to the "More
Searches" bar...
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Found in translation:
Add additional elements to the "More Searches" bar on the OPAC, with this
content (leave blank to disable). 

I don't think the element is labelled "More searches" anywhere in Koha - maybe
we should call it "Navigation links below the simple search" or similar? 

Also: capitalization.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #25 from Kyle M Hall  ---
(In reply to Pedro Amorim from comment #24)
> I think it solves the issue nicely! However, previously we could have an
> "E-mail" type of notice for a Report and now we don't! I have added a new
> follow-up that maintains the "Email" and "SMS" options and only shows "File
> name" for "Print", keeping "Message subject" for the other two. Feel free to
> obsolete if this is not needed.

I'm not opposed to that, but I'm curious how you would use the email and sms
options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

--- Comment #5 from Katrin Fischer  ---
Hm, If they were intended as a fallback, why does my second rule in the example
above not work? 

What is context here?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

--- Comment #1 from Nick Clemens  ---
Created attachment 15
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15=edit
Bug 35307: Add a hidden input for expired holds

To test:
 1 - Place 3 holds on a bib, each for a different patron
 2 - IN the db, set the first hold to be expired:
UPDATE reserves SET expirationdate='2023-01-01' WHERE reserve_id=1;
 3 - Refresh the holds page for the biblio
 4 - Note the first hold now says 'Expired' in the expiration date column
 5 - Set an expiration date for the last hold
 6 - Click 'Update holds'
 7 - Note the date is applied to the second hold
 8 - Delete the holds
 9 - Apply patch
10 - Repeat 1-6
11 - Confirm only the correct hold is updated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35307] Expired holds are missing an input, so updating holds causes loss of data

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35307

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #4 from David Gustafsson  ---
Yes, even though this behaviour seems be confusing users, that was the
intention. '*' rules are never "merged in" into another rule set, they just
serve as defaults where no rules matching the current context are found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

--- Comment #7 from Kyle M Hall  ---
Created attachment 158887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158887=edit
Bug 30070: (follow-up) Return unless the related object exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Kyle M Hall  ---
I'm testing this is some production data and I'm getting 500 errors. I think
it's because Koha::Edifact::File presumes every file will have a vendor and
basket, but that's not necessarily true. I've patched those two methods but
then I get the error:

omething went wrong when loading the table.
500: Internal Server Error. 
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.
Properties not allowed: basket, deleted, vendor.

Can you try testing with an edi message that has a null basket number?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #185 from Emily-Rose Francoeur  
---
(In reply to Katrin Fischer from comment #183)
> Do you have the latest version of QA script? (separate repository from Koha)

Yes, I use the last version of QA Test Tools :
https://wiki.koha-community.org/wiki/QA_Test_Tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #2 from Martin Renvoize  ---
This would be easier to implement if we had continued down the path from bug
31714.. we'd have fewer places to change :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32346] Migrate issueslip from printslip.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32346

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35267

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32346

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32345] Migrate checkinslip from printslip.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32345

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35267

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32345

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32344] Migrate print_overdues.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35267

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=32344

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322

--- Comment #1 from Kyle M Hall  ---
Created attachment 158886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158886=edit
Bug 35322: Fix the logic for checking for holds in CanBookBeIssued

We are having reports that AllowItemsOnHoldCheckoutSCO and
AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued,
the ignore reserves check was changed from "check reserves unless the ignore
reserves flag was passed" to "check reserves unless the ignore reserves flag
was passed *and* we have a recall". I think this was a logic mistake and we
want to check reserves unless we have an ignore flag *or* there is a recall.

Test Plan:
1) Enable AllowItemsOnHoldCheckoutSCO
2) Place a hold on an item
3) Attempt to check that item out to another patron
4) Note the checkout is blocked
5) Apply this patch
6) Restart all the things!
7) Attempt the checkout again
8) The checkout now succeeds!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32344] Migrate print_overdues.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32344

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32345] Migrate checkinslip from printslip.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32345

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32346] Migrate issueslip from printslip.pl to printnotice.pl

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32346

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35322] New: AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322

Bug ID: 35322
   Summary: AllowItemsOnHoldCheckoutSCO and
AllowItemsOnHoldCheckoutSIP do not work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We are having reports that AllowItemsOnHoldCheckoutSCO and
AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued,
the ignore reserves check was changed from "check reserves unless the ignore
reserves flag was passed" to "check reserves unless the ignore reserves flag
was passed *and* we have a recall". I think this was a logic mistake and we
want to check reserves unless we have an ignore flag *or* there is a recall.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #24 from Pedro Amorim  ---
I've added my sign-off, if @Katrin wants to turn hers to PQA.

(In reply to Kyle M Hall from comment #18)
> The intention of the feature is to only use the "print" transport. I've
> added a followup so that only the print transport shows up for report notice
> templates. I think that solves the issue nicely! If you sign it, we can use
> Katrin's sign-off as the QA signoff at her discretion.

I think it solves the issue nicely! However, previously we could have an
"E-mail" type of notice for a Report and now we don't! I have added a new
follow-up that maintains the "Email" and "SMS" options and only shows "File
name" for "Print", keeping "Message subject" for the other two. Feel free to
obsolete if this is not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35193] Rename "Message subject" to "File name" when module "Reports" was chosen

2023-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193

--- Comment #23 from Pedro Amorim  ---
Created attachment 158885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158885=edit
Bug 35193: Show 'File name' for Print only, keep 'Email' and 'SMS' transport
types as options for 'Report' notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >