[Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #18) > It's not about porting back, but about data. > > The checkouts_renewals table was added in 22.11, so in Koha terms not that > long ago. Before that we had no data bout individual renewals, just the last > renewal date and the number of renewals, both stored in issues. Ah ok the DB table, not the HTML table! > So when updating, the checkouts_renewals table was not filled retroactively, > because it was not possible. > > Instead the GUI reacts to it - if there are entries in checkouts_renewals it > can show them. If not it shows just summary information. > > We need to keep that working, as libraries still have tons of old data, but > dev environments usually don't. Indeed, thanks for catching that! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #26 from Phil Ringnalda --- The commit name for the second would have been "Bug 29825: Oops, I forgot to 'git add'" so really rather than fixing it, the first two should just be squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 --- Comment #4 from Brendan Lawlor --- I had trouble with git commit --amend to add the test plan To test: 1. Run any page that contains the Search patrons search bar through an HTML validator 2. See Error stray end tag td 3. Apply patch 4. Run the page through the HTML validator again 5. See the stray end tag error go away 6. Test that patron search still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #159084|0 |1 is obsolete|| --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 159119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159119=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Lucas Gass changed: What|Removed |Added Attachment #159096|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 159118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159118=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #159114|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 159117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159117=edit Bug 35356: Show SMS labels only when data exists To test: APPLY PATCH 1. Set SMSSendDriver = Email 2. Admin > SMS cellular providers, have at least 1. 3. Go to the members/moremember.pl 4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear. 5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Lucas Gass --- Thanks Brendan, looks good! Straighforward fix here, passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Lucas Gass changed: What|Removed |Added Attachment #159115|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 159116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159116=edit Bug 35365: fix stray td tag Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Brendan Lawlor changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Brendan Lawlor changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 --- Comment #1 from Brendan Lawlor --- Created attachment 159115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159115=edit Bug 35365: fix stray td tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35359] Granular Cataloging permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35359 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 --- Comment #1 from Lucas Gass --- Created attachment 159114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159114=edit Bug 35356: Show SMS labels only when data exists To test: APPLY PATCH 1. Set SMSSendDriver = Email 2. Admin > SMS cellular providers, have at least 1. 3. Go to the members/moremember.pl 4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear. 5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35356] SMS number field shows on moremember.pl even when null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35356 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #7 from Fridolin Somers ---
Hi,
my $i_order = GetOrderFromItemnumber($itemnumber);
my $i_serialid = Koha::Serial::Items->search( {itemnumber => $itemnumber}
)->get_column('serialid');
Is there a performance impact ?
Better prefetch linked tables maybe.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 --- Comment #5 from Andrew Fuerste-Henry --- I made those wording changes as part of signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #154910|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 159113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159113=edit Bug 34643: Split CircConfirmItemParts for self-checkout and self-checkin Many libraries wish to be able to allow self-check for multi-part items while requesting librarians to verify the parts when checking out/in at the desk. It makes sense to split CircConfirmItemParts into three prefs such that the feature can be enabled/disabled for SCO and SCI independently. Test Plan: 1) Apply this patch 2) Enable SCO and SCI 3) Set CircConfirmItemPartsSCO to "Don't allow" 4) Attempt to checkout out an item with materials via SCO, it should fail 5) Set CircConfirmItemPartsSCO to "Allow" 6) Repeat step 4, it should succeed 7) Set CircConfirmItemPartsSCI to "Don't allow" 8) Attempt to check in the item via SCI, it should fail 9) Attempt to check in the item via SCO, it should fail 9) Set CircConfirmItemPartsSCI to "Allow" 10) Attempt to check in the item via SCO and SCI, it should succeed! Signed-off-by: AFHDubCoLib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Brendan Lawlor changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |blaw...@clamsnet.org |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35365] New: Incorrectly closed tag on patron search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35365 Bug ID: 35365 Summary: Incorrectly closed tag on patron search page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: martin.renvo...@ptfs-europe.com Reporter: blaw...@clamsnet.org QA Contact: testo...@bugs.koha-community.org CC: martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, oleon...@myacpl.org In /koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc On line 160 there is a incorrectly close tag [% CASE 'dateexpiry' %]Expires on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||blaw...@clamsnet.org --- Comment #9 from Brendan Lawlor --- I tested this using this plugin: https://chrispederick.com/work/web-developer/ before the patch there were 56 stray start and end tags found tag span. After the patch there were 0. Just a note there was one other invalid html error and one warning found by the validator that maybe need another patch? I ran the validator on http://localhost:8081/cgi-bin/koha/members/members-home.pl Error: Stray end tag td. From line 1010, column 39; to line 1010, column 43 Expires on↩ Warning: Empty heading. From line 1037, column 17; to line 1037, column 64 ↩ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20958] Allow admins to choose data types for additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20958 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 Brendan Lawlor changed: What|Removed |Added Attachment #158226|0 |1 is obsolete|| --- Comment #8 from Brendan Lawlor --- Created attachment 159112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159112=edit Bug 35157: Remove spans from patronfields.inc Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Emily Lamancusa changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #69 from Emily Lamancusa --- Thanks for the fixes! I added a follow-up with a couple of trivial fixes to the alerts. :) The notice is sent twice when reverting or cancelling an item-level hold from the prompt (sorry for missing that the last time I tested). Is there a reason LostItem needs to be called a second time when the user responds to the prompt of whether to revert or cancel an item-level hold? Couldn't the prompt cancel/revert the hold directly at that point, and avoid re-doing all the lost item processing (including the second notice)? Also, tests are failing: # Subtest: Waiting item is marked as lost 1..17 ok 1 - Biblio-level hold placed not ok 70 - Waiting item is marked as lost # Looks like you planned 17 tests but ran 1. # Failed test 'Waiting item is marked as lost' # at t/db_dependent/Reserves.t line 1546. Can't call method "effective_itemtype" on an undefined value at /kohadevbox/koha/Koha/Hold.pm line 234. # Looks like your test exited with 11 just after 70. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 9/78 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #68 from Emily Lamancusa --- Created attachment 159111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159111=edit Bug 20844: (follow-up) Fix alert boxes for item-level holds Fix styling on the alert in additem.tt Don't show alert in moredetail page if RevertBibLevelHolds is disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35364] Update label creator pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 --- Comment #1 from Owen Leonard --- Created attachment 159110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159110=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35364] Update label creator pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What|Removed |Added Blocks||35364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 [Bug 35364] Update label creator pop-up windows with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35364] New: Update label creator pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 Bug ID: 35364 Summary: Update label creator pop-up windows with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34343 I would like to update several serial module pop-up windows to be consistent with Bug 34343 and its children: - serials/acqui-search-result.tt - serials/acqui-search.tt - serials/result.tt - serials/subscription-bib-search.tt - serials/routing-preview-slip.tt - serials/subscription-renew.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11029] Marc Language Code in a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Phil Ringnalda changed: What|Removed |Added CC||paivi.knuuti...@joensuu.fi --- Comment #5 from Phil Ringnalda --- *** Bug 35340 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35340] Drop-down menu for the language code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35340 Phil Ringnalda changed: What|Removed |Added Resolution|--- |DUPLICATE CC||p...@chetcolibrary.org Status|NEW |RESOLVED --- Comment #1 from Phil Ringnalda --- *** This bug has been marked as a duplicate of bug 11029 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #21 from Kyle M Hall --- Created attachment 159109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159109=edit Bug 35331: (QA follow-up): Patron ILL history With the previous patches applied and successfull test plans, access the users ILL history page, visit: /cgi-bin/koha/members/ill-requests.pl?borrowernumber=51 Notice you get an error. Apply this patch, and try again, notice the error is gone and the custom plugin action is also in the patron's ILL history table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #20 from Kyle M Hall --- Created attachment 159108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159108=edit Bug 35331: (QA follow-up): Avoid code pattern iterating on plugin responses (see bug 28010) Use plugin call pattern established in bug 28211. Please utilize version 1.0.1 of the plugin to test this follow-up: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.1 Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 --- Comment #19 from Kyle M Hall --- Created attachment 159107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159107=edit Bug 35331: Add plugin hook tests prove t/db_dependent/Koha/Plugins/Ill_hooks.t Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159105|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 159106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159106=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Attachment #159046|0 |1 is obsolete|| Attachment #159047|0 |1 is obsolete|| Attachment #159048|0 |1 is obsolete|| Attachment #159049|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 159105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159105=edit Bug 35331: Add table actions hook to ILL table Test plan, k-t-d, apply patches: 1) Install FreeForm backend, enable ILLModule sys pref, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Navigate to ILL requests, visit: /cgi-bin/koha/ill/ill-requests.pl 3) Click '+New ILL request', select a type, enter an existing cardnumber (e.g. '42') and pick a library. Click 'Create'. 4) Visit ILL requests again, repeat 2) 5) Notice the row for the created request has the already existing action button 'Manage request' 6) Install the ILL actions plugin, located at: https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v1.0.0 7) Restart plack, run: koha-plack --restart kohadev 8) Repeat 4) and 5). Notice the row for the created request now has a new custom action in addition to the already existing core one. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35331] Add an ILL table actions plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35340] Drop-down menu for the language code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35340 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #14 from Kyle M Hall --- Could we get some unit tests for link_marc_host? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 --- Comment #1 from Owen Leonard --- Created attachment 159104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159104=edit Bug 35363: Update transfer order pop-up window with consistent footer markup This patch updates the "Transfer order" pop-up window so that it has a fixed footer consistent with other similar pop-up windows. In order to make navigation between pages within the pop-up window easier I've added a button in the footer which can take the user back to the previous step, including any necessary parameters. To test, apply the patch and go to Acquisitions. - Locate a vendor with a basket, and a basket with one or more orders. - On the basket detail page, click the "Transfer" link in the "Modify" column. - In the pop-up window, test each step: - Vendor search - Vendor selection - Basket selection - Confirm that at any step you can use the new button to go back to the previous step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall --- Can we get unit tests for the new methods? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Thomas Klausner changed: What|Removed |Added CC||d...@plix.at -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What|Removed |Added Blocks||35363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 [Bug 35363] Update transfer order pop-up window with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35363] New: Update transfer order pop-up window with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 Bug ID: 35363 Summary: Update transfer order pop-up window with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34343 I would like to update the transfer order pop-up window in Acquisitions to be consistent with Bug 34343 and its children. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
--- Comment #32 from Thomas Klausner ---
Created attachment 159103
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159103=edit
Bug 33036: REST API: Merge biblio records implements merging of records +
attached items, subscriptions etc via the API as an alternative to the web
interface: cgi-bin/koha/cataloguing/merge.pl
This is a slightly improved version of Zenos patch: I (domm) have converted the
code in Koha::Biblio to a more DBICy style and packed it into a transaction (as
requested in Comment 23)
The QA script complains about files being less tidy, but if we add the perltidy
changes to this commit I'm afraid the actual change will be much less clear to
review. So I did not run perltidy on the changed files.
To test:
1) you need an API user with the permissions "editcatalogue"
2) two records: one to be merged into (with biblio_id, eg 262) and another
one from
which to merge (with biblio_id_to_merge, eg 9) which will be deleted!
both records may/should have items, subscription, subscriptionhistory,
serial, suggestions
orders and holds
3) check both records via the web
4) Apply patch
5) Write a JSON file with inside the field 'biblio_id_to_merge' and the
biblionumber from wihich to merge.
As example:
{
"biblio_id_to_merge" : 9
}
6) Execute an API call with correct headers and location. For example:
curl -s -u koha:koha --header "Content-Type: application/json" --header
"Accept: application/marc-in-json"
--request POST
"http://127.0.0.1:8080/api/v1/biblios/262/merge; -d @file.json
You must to setup the headers and to use a json file with parameters
7) The record with the id 9 is deleted now, the record with 262 has all
items, etc attached,
the return is: return code 200 and the changed record 262 in
marc-in-json format
8) It is possible to override biblio data with an external bib record. You
need to put external bib record
into the json file in marc-in-json format. To write use the json file
uploaded as example
You need to fill the fields 'rules' and 'datarecord'. The field 'rules'
must contains 'override_ext'
To do the call:
curl -s -u koha:koha --header "Content-Type: application/json"
--header "Accept: application/marc-in-json"
--request POST
"http://127.0.0.1:8080/api/v1/biblios/XXX/merge; -d @file_with_recod.json
9) The record in 'biblio_id_to_merge' is deleted now, in biblio XXX now
there are the bibliographic data
of field 'datarecord' of json file, the return is: return code 200 and
the changed record XXX in marc-in-json format
10) Go into intranet and do a search. Select two or (better) more record.
11) Merge them; merge must be a success.
12) Test with prove -v t/db_dependent/Koha/Biblio.t
13) Test with prove -v t/db_dependent/api/v1/biblios.t
To test with curl the step 8 you can customize the json file attached in
bugzilla.
The marc-in-json record inside follows the MAR21 standard
Sponsored-by: Technische Hochschule Wildau
Co-authored-by: Zeno Tajoli
Co-authored-by: Thomas Klausner
Co-authored-by: Mark Hofstetter <>
Signed-off-by: Jan Kissig
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35107] ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35107 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #28 from Kyle M Hall --- Created attachment 159102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159102=edit Bug 26831: (follow-up) Tidy cleanup_database.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #27 from Kyle M Hall --- Created attachment 159101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159101=edit Bug 26831: (follow-up) Tidy code for qa script Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #26 from Kyle M Hall --- Created attachment 159100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159100=edit Bug 26831: (follow-up) Update system preference description Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #25 from Kyle M Hall --- Created attachment 159099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159099=edit Bug 26831: Attempting to clarify prioritising of options Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 --- Comment #24 from Kyle M Hall --- Created attachment 159098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159098=edit Bug 26831: Use new PurgeListShareInvitesOlderThan syspref Enable librarians in the staff client to control when unaccepted list invites will be removed from the database. Test plan: 1. Apply patches 2. Update database sudo koha-shell cd installer/data/mysql ./updatedatabase.pl 3. Confirm the PurgeListShareInvitesOlderThan syspref = 14 4. Run cleanup_database.pl with --list-invites parameter defined: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites 10 -v 5. Confirm the output contains: "Purging unaccepted list share invites older than 10 days." 6. Set PurgeListShareInvitesOlderThan syspref = 15 7. Run cleanup_database.pl without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl -v 8. Confirm the output contains: "Purging unaccepted list share invites older than 15 days." 9. Empty PurgeListShareInvitesOlderThan syspref 10. Run cleanup_database without the --list-invites parameter: sudo koha-shell cd misc/cronjobs ./cleanup_database.pl --list-invites -v 13. Confirm the output contains: "Purging unaccepted list share invites older than 14 days." Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added Attachment #157711|0 |1 is obsolete|| Attachment #157712|0 |1 is obsolete|| Attachment #157713|0 |1 is obsolete|| Attachment #157714|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 159097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159097=edit Bug 26831: Add new system preference PurgeListShareInvitesOlderThan Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34884] Allow styling and customization of checkout screen by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34884 --- Comment #1 from Rebecca Coert --- +1 Having this functionality would be a great help to our public services staff. We have several "special loan" patron categories and this easy-to-notice visual alert would remind staff to not/loan particular items to that patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #1 from Owen Leonard --- Created attachment 159096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159096=edit Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34643] Split CircConfirmItemParts for self-checkout and self-checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34643 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #3 from Andrew Fuerste-Henry --- This works, but could be presented more clearly. Your syspref names strongly imply that one preference controls the behavior of the web-based self checkout while the other controls the behavior of the web-based self check-in. However that is not quite the case. I suggest rewording the sysprefs thus: CircConfirmItemPartsSCI: (Allow / Don't allow) multi-part items to be checked in via the web-based self check-in and self checkout modules. CircConfirmItemPartsSCO: (Allow / Don't allow) multi-part items to be checked out via the web-based self checkout module. This clarifies the difference between the two sysprefs, clarifies that they're not about SIP or any other interface, and makes the wording consistent with SelfCheckInModule and WebBasedSelfCheck. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34343] Z39.50 search background not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What|Removed |Added Blocks||35362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 [Bug 35362] Update patron module pop-up windows with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] New: Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Bug ID: 35362 Summary: Update patron module pop-up windows with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 34343 I would like to update two pop-up windows in the patron module to be consistent with Bug 34343 and its children: - Brief patron view - Update child to adult category selection Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35361] New: Search filter on receive orders page crashes the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361
Bug ID: 35361
Summary: Search filter on receive orders page crashes the
system
Change sponsored?: ---
Product: Koha
Version: 23.05
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
CC: tomasco...@gmail.com
The search filter for the table on the page acqui/parcel.pl generates the below
api-request, which results in the below sql query. Note how the LIMIT clause
is applied to the sub-query, not the whole query. For us, this specific query
actually yielded a search result of in total over 171 000 rows.
GET
/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20={"-and":[{"basket.vendor_id":5},[[{"basket.name":{"like":"%97891%"}}],[{"basket.basket_group.name":{"like":"%97891%"}}],[{"me.order_id":{"like":"%97891%"}}],[{"biblio.title":{"like":"%97891%"}},{"biblio.author":{"like":"%97891%"}},{"biblio.isbn":{"like":"%97891%"}},{"biblio.publisher":{"like":"%97891%"}},{"me.internal_note":{"like":"%97891%"}},{"me.vendor_note":{"like":"%97891%"}}],[{"me.replacement_price":{"like":"%97891%"}}],[{"me.quantity":{"like":"%97891%"}}],[{"me.ecost":{"like":"%97891%"}}],[{"fund.name":{"like":"%97891%"}}]]]}&_match=contains&_order_by=+basket.name
HTTP/1.1
SELECT `me`.`ordernumber`, `me`.`biblionumber`, `me`.`deleted_biblionumber`,
`me`.`entrydate`, `me`.`quantity`, `me`.`currency`, `me`.`listprice`,
`me`.`datereceived`, `me`.`invoiceid`, `me`.`freight`, `me`.`unitprice`,
`me`.`unitprice_tax_excluded`, `me`.`unitprice_tax_included`,
`me`.`quantityreceived`, `me`.`created_by`, `me`.`datecancellationprinted`,
`me`.`cancellationreason`, `me`.`order_internalnote`, `me`.`order_vendornote`,
`me`.`purchaseordernumber`, `me`.`basketno`, `me`.`timestamp`, `me`.`rrp`,
`me`.`replacementprice`, `me`.`rrp_tax_excluded`, `me`.`rrp_tax_included`,
`me`.`ecost`, `me`.`ecost_tax_excluded`, `me`.`ecost_tax_included`,
`me`.`tax_rate_bak`, `me`.`tax_rate_on_ordering`, `me`.`tax_rate_on_receiving`,
`me`.`tax_value_bak`, `me`.`tax_value_on_ordering`,
`me`.`tax_value_on_receiving`, `me`.`discount`, `me`.`budget_id`,
`me`.`budgetdate`, `me`.`sort1`, `me`.`sort2`, `me`.`sort1_authcat`,
`me`.`sort2_authcat`, `me`.`uncertainprice`, `me`.`subscriptionid`,
`me`.`parent_ordernumber`, `me`.`orderstatus`, `me`.`line_item_id`,
`me`.`suppliers_reference_number`, `me`.`suppliers_reference_qualifier`,
`me`.`suppliers_report`, `me`.`estimated_delivery_date`,
`me`.`invoice_unitprice`, `me`.`invoice_currency`, `basket`.`basketno`,
`basket`.`basketname`, `basket`.`note`, `basket`.`booksellernote`,
`basket`.`contractnumber`, `basket`.`creationdate`, `basket`.`closedate`,
`basket`.`booksellerid`, `basket`.`authorisedby`,
`basket`.`booksellerinvoicenumber`, `basket`.`basketgroupid`,
`basket`.`deliveryplace`, `basket`.`billingplace`, `basket`.`branch`,
`basket`.`is_standing`, `basket`.`create_items`, `basket_group`.`id`,
`basket_group`.`name`, `basket_group`.`closed`, `basket_group`.`booksellerid`,
`basket_group`.`deliveryplace`, `basket_group`.`freedeliveryplace`,
`basket_group`.`deliverycomment`, `basket_group`.`billingplace`,
`biblio`.`biblionumber`, `biblio`.`frameworkcode`, `biblio`.`author`,
`biblio`.`title`, `biblio`.`medium`, `biblio`.`subtitle`,
`biblio`.`part_number`, `biblio`.`part_name`, `biblio`.`unititle`,
`biblio`.`notes`, `biblio`.`serial`, `biblio`.`seriestitle`,
`biblio`.`copyrightdate`, `biblio`.`timestamp`, `biblio`.`datecreated`,
`biblio`.`abstract`, `biblioitem`.`biblioitemnumber`,
`biblioitem`.`biblionumber`, `biblioitem`.`volume`, `biblioitem`.`number`,
`biblioitem`.`itemtype`, `biblioitem`.`isbn`, `biblioitem`.`issn`,
`biblioitem`.`ean`, `biblioitem`.`publicationyear`,
`biblioitem`.`publishercode`, `biblioitem`.`volumedate`,
`biblioitem`.`volumedesc`, `biblioitem`.`collectiontitle`,
`biblioitem`.`collectionissn`, `biblioitem`.`collectionvolume`,
`biblioitem`.`editionstatement`, `biblioitem`.`editionresponsibility`,
`biblioitem`.`timestamp`, `biblioitem`.`illus`, `biblioitem`.`pages`,
`biblioitem`.`notes`, `biblioitem`.`size`, `biblioitem`.`place`,
`biblioitem`.`lccn`, `biblioitem`.`url`, `biblioitem`.`cn_source`,
`biblioitem`.`cn_class`, `biblioitem`.`cn_item`, `biblioitem`.`cn_suffix`,
`biblioitem`.`cn_sort`, `biblioitem`.`agerestriction`,
`biblioitem`.`totalissues`, `items`.`itemnumber`, `items`.`biblionumber`,
`items`.`biblioitemnumber`, `items`.`barcode`, `items`.`dateaccessioned`,
`items`.`booksellerid`, `items`.`homebranch`, `items`.`price`,
`items`.`replacementprice`, `items`.`replacementpricedate`,
`items`.`datelastborrowed`, `items`.`datelastseen`, `items`.`stack`,
`items`.`notforloan`, `items`.`damaged`, `items`.`damaged_on`,
`items`.`itemlost`, `items`.`itemlost_on`,
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #9 from Martin Renvoize --- Quick typo fix applied ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Attachment #159090|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 159095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159095=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Attachment #159089|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 159094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159094=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159080|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 159093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159093=edit Bug 35348: Remove cookie consents link from opac consents The cookies details modal is now visible for all users from a footer link, we no longer need it under the 'Consents' tab for logged in users. Test plan 1) Enable CookieConsent and add a placholder tracker cookie to CookieConsentedJS preference 2) Log into the OPAC 3) Note that the 'Consents' link no longer appears in the users page. 4) Enable 'PrivacyPolicyConsent' 5) Note that the 'Consents' link now appears but on navigating to it there is no link for Cookie consents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159079|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 159092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159092=edit Bug 35348: Ensure users can access cookie details in staff client We remove the check on JSConsents content so that when cookie consent is enabled we retain the option for users to get more information about what cookies are being used. Test plan 1) Enable CookieConsents 2) Do not add any tracking cookies for the staff client into CookieConsentedJS preference 3) Note that 'My consents' appears in the user menu 4) Clicking 'My consents' opens the 'Cookie consent' modal displaying information about the cookies used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Martin Renvoize changed: What|Removed |Added Attachment #159078|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 159091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159091=edit Bug 35348: Add cookies link to opac footer This patch adds a link that opens the cookies info dialogue to the opac footer when the CookieConsent feature is enabled. Test plan 1) Enable CookieConsent 2) On the OPAC you should now see a 'Cookies' link at the bottom of the page. 3) Clicking the link should open the "Cookie consent" modal where you can see the details of the cookies you have accepted and change your choices. 4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of 'Cookies' in the same footer bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize --- Aude did all the hard work here putting together the text, I just helped to construct the patch and upload it. Great work Aude, I think it looks much better now as a feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #5 from Martin Renvoize --- Created attachment 159090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159090=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #4 from Martin Renvoize --- Created attachment 159089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159089=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 --- Comment #4 from Andrew Fuerste-Henry --- Bug 31157 created a system preference to determine which library's rules to follow when generating overdue notices and restrictions. I think it'd make sense to create a comparable system preference for long overdue notices. It wouldn't be *wrong* to make long overdues just follow the syspref for overdues, but it does feel like someone's going to come up with a compelling need for the distinction sooner or later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35360] New: Inconsistent use/look of 'Cancel hold(s)' button on circ/waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35360 Bug ID: 35360 Summary: Inconsistent use/look of 'Cancel hold(s)' button on circ/waitingreserves.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you go to circ/waitingreserves.pl there are 3 tabs: -Holds waiting -Holds waiting past their expiration date -Holds with cancellation requests -Holds waiting includes a 'Canceled selected' button at the top of the table. It is with in a #toolbar. -Holds waiting past their expiration date includes a 'Cancel selected' and a 'Cancel all' button. None are within a #toolbar. The 'Cancel selected' here lacks a Bootstrap .btn class. The 'Cancel all' button does have a .btn class. -Holds with cancellation requests has neither a 'Cancel selected' or a 'Cancel all' button. It would be nice if things were a bit more consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #37 from Andrew Fuerste-Henry --- (In reply to Nick Clemens from comment #36) > Rebased and squashed. > > As far as I can tell, this correctly fetches the calendar per branch, > however, the items queries do not take branches into account - so we run a > query per branch with different date ranges, but don't limit the items by > branch. > > I think we also need a switch here to control how we will decide which > branch to apply - is it the patron's branch? the item's home/holding branch? > I think this could follow CircControl - but needs some logic > > Moving to Failed QA. That's a great point, though I'm not at all happy about it. Longoverdue does not currently have any concept of branch-specificity (see BZ 9596). There is no branch-agnostic calendar. This one can't move forward without BZ 9596. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35265] Remove drag and drop in Elasticsearch mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35265 --- Comment #11 from Owen Leonard --- (In reply to Martin Renvoize from comment #9) > In other words.. bug 35249 is still valid I'm afraid Owen :) That's fine... I was trying to wait for Bug 34913 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||18064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||9596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 [Bug 9596] Allow longoverdue.pl to be configured by library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #36 from Nick Clemens --- Rebased and squashed. As far as I can tell, this correctly fetches the calendar per branch, however, the items queries do not take branches into account - so we run a query per branch with different date ranges, but don't limit the items by branch. I think we also need a switch here to control how we will decide which branch to apply - is it the patron's branch? the item's home/holding branch? I think this could follow CircControl - but needs some logic Moving to Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Attachment #136213|0 |1 is obsolete|| Attachment #136214|0 |1 is obsolete|| Attachment #136263|0 |1 is obsolete|| Attachment #139978|0 |1 is obsolete|| Attachment #145920|0 |1 is obsolete|| Attachment #147497|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 159088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159088=edit Bug 18064: Add syspref to launch longOverdue script with calendar support The problem here is that the longOverdue script does not support calendars and when libraries set their holidays, long overdues do not take this into account. For example, during the covid pandemic, some libraries were closed for days, maybe months, but longOverdue didn't care and set "lost" or other values on the items. This fix / enhancement based on taking calendars into account to test it, regardless of your rules related to longOverdue, I propose this test plan: Test plan : 1) For clearer vision on what the patch does, have at least "2" libraries 2) Go to Tools/Calendar and place holidays, on each of the libraries for example, of any kind (special, repeated, as you want) 3) Manually run the misc/cronjobs/longoverdue.pl script with the -v (verbose) argument to get as much information as possible 4) You will see a common "block", with today's date + 366 days (by default if you don't pass any arguments to the script), holidays are not taken into account in this date range 5) Apply my patch 6) Launch the updatedatabase 7) Set the new system preference "LongOverdueNoticeCalendar" to "use calendar" 8) Repeat step 3 9) You will see in output one line per library and according to the number of days off in the interval of dates, the start date of the analysis will have been postponed by as many days in order to take these holidays into account. If something is not completely clear, we can of course discuss it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33794] Holds Queue builder skips least cost branch unless target item's homebranch is patron's homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33794 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #14 from Kevin Carnes --- Created attachment 159087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159087=edit Bug 33847: Rewrite to use SQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Kevin Carnes changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Attachment #159073|0 |1 is obsolete|| --- Comment #22 from Brendan Lawlor --- Created attachment 159086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159086=edit Bug 35216: Rename error to issuingimpossible Test plan: 1 - Apply two patches 2 - Confirm code changes make sense 3 - Confirm you can check out items 4 - Confirm checkout blocks still block Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35216] Use return variable names from CanBookBeIssued in circulation.pl for consistency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35216 Brendan Lawlor changed: What|Removed |Added Attachment #159072|0 |1 is obsolete|| --- Comment #21 from Brendan Lawlor --- Created attachment 159085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159085=edit Bug 35216: Rename question to needsconfirmation Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34924] Add ability to send 'final auto renewal notice'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34924 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Attachment #158626|0 |1 is obsolete|| --- Comment #24 from Lucas Gass --- Created attachment 159084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159084=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
