[Koha-bugs] [Bug 32695] Search string for various 7xx linking fields is incorrectly formed

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695

Sabrina Kiehl  changed:

   What|Removed |Added

 CC||ki...@mpis.mpg.de
 Status|Needs Signoff   |Signed Off

--- Comment #12 from Sabrina Kiehl  ---
Hi,
For MARC 787 the search string was already formed as intended (ti,phr:("title")
AND au:("creator")) before applying the patch.
After applying the patch the search string is a combined with subfield t in
ti,phr index and subfield a in au index. If subfield a is empty the search
string is formed :
ti,phr:("title")

If subfield t is empty the search string is formed:
ti,phr:("") AND au:("creator")
Which seems okay to me, because I can't think of a cataloguing situation in
which subfield t could be empty and only subfield a is used. I just want to
mention it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #16 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #15)
> (In reply to Marcel de Rooy from comment #14)
> > Hmm Seeing:
> > PRECONDITION_FAILED - unknown delivery tag 1
> 
> "PRECONDITION_FAILED - unknown delivery tag" usually happens because of
> double ack-ing, ack-ing on wrong channels or ack-ing messages that should
> not be ack-ed.
> 
> => ?

Cause found in my own changes ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32695] Search string for various 7xx linking fields is incorrectly formed

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #152240|0   |1
is obsolete||

--- Comment #11 from Biblibre Sandboxes  ---
Created attachment 161168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161168=edit
Bug 32695: Fix search strings for 775, 780, 785 and 787

In the past due to some misunderstanding of the MARC standard
we built the search links for these fields using $a and $t with
the title index. But we actually need to search $t as title
and $a as author.
This patch fixes the templates for the MARC 7xx fields:
* 775
* 780
* 785
* 787

To test:
* Ensure systme preference 'UseControlNumber' is set to don't
* Create a record with the linking fields above
* Look at the OPAC and staff interface detail views
* Verify the content of your fields shows and the links combine a+t as a title
search
* Apply patch
* Verify you have nicely formatted links now

Example:
775 _ _ ‡asomeone‡ttitle775
780 0 2 ‡asomeone‡ttitle780
785 0 2 ‡asomeone‡ttitle785
787 _ _ ‡ilabel:‡ttitle787‡asomeone

Signed-off-by: Sabrina Kiehl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32695] Search string for various 7xx linking fields is incorrectly formed

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32695

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #152239|0   |1
is obsolete||

--- Comment #10 from Biblibre Sandboxes  ---
Created attachment 161167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161167=edit
Bug 32695: Use title (subfield t) only for 'Other editions' search links

Currently the code does a title phrase search, but combines the title field
with the Main Entry (author) field.

This patch simply limits the search to the title to ensure links work

To test:
1 - Ensure systme preference 'UseControlNumber' is set to don't
2 - Edit Default MARC framework in administration->Marc frameworks
3 - Make 775 subfields a & t visible in editor
4 - Edit a record to add a field 775 with subfields a & t that match another
title/author in your system
5 - Save the record and view the details page
6 - Click the other editions link - no results
7 - Apply patch, restart_all
8 - Reload details and confirm the link works

Signed-off-by: Sam Lau 
Signed-off-by: Sabrina Kiehl 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #62 from Martin Renvoize  ---
So.. those two could be new bug follow-ups as they're enhancements on top of
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #15 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #14)
> Hmm Seeing:
> PRECONDITION_FAILED - unknown delivery tag 1

"PRECONDITION_FAILED - unknown delivery tag" usually happens because of double
ack-ing, ack-ing on wrong channels or ack-ing messages that should not be
ack-ed.

=> ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #61 from Martin Renvoize  ---
Created attachment 161166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161166=edit
Almost invisible feedback

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #60 from Martin Renvoize  ---
Created attachment 161165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161165=edit
Widescreen display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #59 from Martin Renvoize  ---
Next comment.. could we perhaps put the results next to rather than under the
filters form in the modal?

It feels odd to have so much whitespace in the modal and have the actual useful
content almost hidden off screen.. widescreen aspect ratios are pretty common
these days?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #14 from Marcel de Rooy  ---
Hmm Seeing:
PRECONDITION_FAILED - unknown delivery tag 1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35329] Move patron searches to a modal

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329

--- Comment #58 from Martin Renvoize  ---
Minor comment, I think the result of an action could be made more apparent..
it's rather hidden away.. also, if re-opening the modal, the result of the last
operation is still visible.

I tested with New Order Empty to deduct the above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35842] New: Reset failed background jobs to new

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35842

Bug ID: 35842
   Summary: Reset failed background jobs to new
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

Would it make sense to be able to reset a "failed" background job to "new", so
processing can be attempted one more time? Similar to how a failed message can
be reset to new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14216] Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216

--- Comment #2 from Katrin Fischer  ---
When the password is changed we have PASSWORD_CHANGE now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|jonathan.druart+koha@gmail. |tomasco...@gmail.com
   |com |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35839] Local use is double-counted when using both RecordLocalUseOnCheckin and statistical patrons

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35839

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Magnus Enger  ---
Looks like this was added twice.

*** This bug has been marked as a duplicate of bug 35840 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnCheckin and statistical patrons

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

--- Comment #1 from Magnus Enger  ---
*** Bug 35839 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Bug and nuances described in Christopher and George's koha-US The Terrific
Every-Other-Thursday Training Video (19 January 2024):
https://www.youtube.com/watch?v=vtjWbfQhHCU

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

--- Comment #20 from David Nind  ---
(In reply to Victor Grousset/tuxayo from comment #19)
> > - Start KTD using MySQL 8
> 
> How does one do that? Just changing the DB image leads to failure due to
> default MySQL having changed and adding docker-compose.mysql8.0.yml causes a
> conflict with the default mariadb stuff already present the default compose
> file. More details:
> https://gitlab.com/koha-community/koha-testing-docker/-/issues/411

This how I start KTD with MySQL instead of the default MariaDB:

1. Edit your .env file and change DB_IMAGE=mysql:8.0
2. Run: ktd pull

Result: koha-mysql kohadev will show the database server running as Server
version: 8.0.36 MySQL Community Server - GPL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #19 from Victor Grousset/tuxayo  ---
> - Start KTD using MySQL 8

How does one do that? Just changing the DB image leads to failure due to
default MySQL having changed and adding docker-compose.mysql8.0.yml causes a
conflict with the default mariadb stuff already present the default compose
file. More details:
https://gitlab.com/koha-community/koha-testing-docker/-/issues/411

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35753] Checkbox() function in additional-contents not necessary

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #4 from Victor Grousset/tuxayo  ---
Much simpler, thanks :D

Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35753] Checkbox() function in additional-contents not necessary

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35753

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #160800|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 161164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161164=edit
Bug 35753: Remove Checkbox() function

To test:
1. APPLY PATCH and clear browser cache.
2. Have multiple additional content items ( news/HTML customization/Pages )
3. From one of the pages ( news/HTML customization/Pages ) click the 'Delete
selected' button. Since no items are checked you should see the 'Please select
content to delete' alert.
4. Check some items and click 'Delete selected' they should be correctly
deleted.

Note: There is no change in behavior from this patch.

Signed-off-by: Jonathan Druart 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|lu...@bywatersolutions.com  |vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||vic...@tuxayo.net

--- Comment #6 from Victor Grousset/tuxayo  ---
Works, makes sense, QA script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35752] Can't delete additional contents with 'Delete selected' button

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35752

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #160799|0   |1
is obsolete||

--- Comment #5 from Victor Grousset/tuxayo  ---
Created attachment 161163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161163=edit
Bug 35752: Pass CSRF token to del_form

To test:

1. Have multiple additional content items ( news/HTML customization/Pages )
2. On one of the pages ( news/HTML customization/Pages ) select more than one
item and try to delete using the 'Delete selected' button
3. You are redirected but nothing happens.
4. APPLY PATCH
5. Try again, this time you should be able to successfully delete
additional-contents.

Signed-off-by: Jonathan Druart 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35841] Update text of 'Cancel' hold button on OPAC

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35841

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35841] Update text of 'Cancel' hold button on OPAC

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35841

--- Comment #1 from Lucas Gass  ---
Created attachment 161162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161162=edit
Bug 35841: Change wording to indicate request to cancel

1. APPLY PATCH
2. Update circ rules "Default waiting hold cancellation policy" to allow
cancellation of holds.
3. Put some holds onto a patron account, Make some waiting holds and have
others be any other status besides waiting.
4. Log in to the OPAC as that patron.
5. Go to your account details and look at the Holds tab.
6. You should see a 'Request to cancel' button for all waiting holds.
7. You should see a 'Cancel' button for all non-waiting holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35841] Update text of 'Cancel' hold button on OPAC

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35841

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35841] New: Update text of 'Cancel' hold button on OPAC

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35841

Bug ID: 35841
   Summary: Update text of 'Cancel' hold button on OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

On the OPAC, if a hold is waiting one can request to cancel it. However, the
wording of the button is misleading. It reads 'Cancel', indicating to patrons
that there hold has been canceled. 

It should be 'Request to cancel'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161031|0   |1
is obsolete||

--- Comment #5 from Biblibre Sandboxes  ---
Created attachment 161161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161161=edit
Bug 30324: Don't use default rule if we have a parent rule

Currenty, if we find only a defult rule for a checkout we are ignoring the
parent rule.
We should not use the default if there is a parent rule

To test:
 1: have an itype BK
 2: create an itype BK2, set BK as the parent to BK2
 3: create a circ rule for All Patrons, item type BK (displays as "Books (All)"
in the circ rules interface), setting total checkouts to 1
 4: do not create any rule specifically for the BK2 itype
 5: have some BK items and some BK2 items
 6: check a BK item out to a patron
 7: check a BK2 item out to the same patron, observe you are not blocked from
doing so
 8: try to check out a second BK2 item to the same patron, get message "Too
many checked out. 1 checked out, only 1 are allowed."
 9: try to check out a second BK item to the same patrons, get message "Too
many checked out. 2 checked out, only 1 are allowed."
10: return both items
11: check a BK2 item out to your patron
12: try to check a BK item out to your patron, get message "Too many checked
out. 1 checked out, only 1 are allowed."
13: Apply patch
14: Repeat 7, you are now blocked
15: Other results should be the same

Signed-off-by: David Nind 
Signed-off-by: Michael Adamyk 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35840

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35840] New: Local use is double-counted when using both RecordLocalUseOnCheckin and statistical patrons

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840

Bug ID: 35840
   Summary: Local use is double-counted when using both
RecordLocalUseOnCheckin and statistical patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
- enable RecordLocalUseOnReturn
- create a statistical patron category and a patron in it
- check an item out to your statistical patron
- count local use entries with a report: SELECT * FROM statistics WHERE
type='localuse' AND itemnumber= (your item)
- see that your one checkout has created 2 entries in statistics

It seems plausible that a single library might want to use these two features
concurrently to count different things, but doing so creates an inflated count.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35839

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35839] New: Local use is double-counted when using both RecordLocalUseOnCheckin and statistical patrons

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35839

Bug ID: 35839
   Summary: Local use is double-counted when using both
RecordLocalUseOnCheckin and statistical patrons
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: andre...@dubcolib.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
- enable RecordLocalUseOnReturn
- create a statistical patron category and a patron in it
- check an item out to your statistical patron
- count local use entries with a report: SELECT * FROM statistics WHERE
type='localuse' AND itemnumber= (your item)
- see that your one checkout has created 2 entries in statistics

It seems plausible that a single library might want to use these two features
concurrently to count different things, but doing so creates an inflated count.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161151|0   |1
is obsolete||

--- Comment #80 from Biblibre Sandboxes  ---
Created attachment 161160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161160=edit
Bug 16122: CanBookBeIssued unit test

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161150|0   |1
is obsolete||

--- Comment #79 from Biblibre Sandboxes  ---
Created attachment 161159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161159=edit
Bug 16122: AddReturn unit tests and small fix in sub AddReturn

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161149|0   |1
is obsolete||

--- Comment #78 from Biblibre Sandboxes  ---
Created attachment 161158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161158=edit
Bug 16122: Perltidy and spelling

To test:
1. Apply patch, updatedatabase & schema, restart all Services
2. Go to Administration > Table setting. Find the holdings table ( Catalog >
holdings_table ) and turn the local use column on.
3. Go to an item record and notice the column 'Local uses'
4. Turn the system preference RecordLocalUseOnReturn Off.
5. Check in an item that is not checkout out. No local use should be recorded
for the item.
6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out.
Local use on that item should increment by 1.
7. Create a statistical patron and check an item out to them. Local use should
increment by 1.
8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for
localuse look correct.

To test maintainence script:
1. Without the patch, have RecordLocalUseOnReturn on.
2. Check in some items to record localuse in the stats table. Keep note of
those stats.
3. Apply the patches, updatedatabase.
4. Run the maintenance script, perl update_localuse_from_statistics.pl
5. Now check that items.localuse is congruent with what is in the stats table

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161148|0   |1
is obsolete||

--- Comment #77 from Biblibre Sandboxes  ---
Created attachment 161157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161157=edit
Bug 16122: Add maintenance script to update items.localuse from stats

Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 
Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161147|0   |1
is obsolete||

--- Comment #76 from Biblibre Sandboxes  ---
Created attachment 161156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161156=edit
Bug 16122: Add display and Table settings

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161146|0   |1
is obsolete||

--- Comment #75 from Biblibre Sandboxes  ---
Created attachment 161155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161155=edit
Bug 16122: Increment items.localuse in AddReturn

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161145|0   |1
is obsolete||

--- Comment #74 from Biblibre Sandboxes  ---
Created attachment 161154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161154=edit
Bug 16122: API and Schema updates

Signed-off-by: Christopher Brannon 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 
Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Biblibre Sandboxes  changed:

   What|Removed |Added

 Attachment #161144|0   |1
is obsolete||

--- Comment #73 from Biblibre Sandboxes  ---
Created attachment 161153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161153=edit
Bug 16122: Add localuse column to items and deleteditems

Signed-off-by: Christopher Brannon 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 
Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #72 from Andrew Fuerste-Henry  ---
When I have RecordLocalUseOnCheckin enabled and check an item out to a
statistical patron, Local Use for that item goes up by 2. That seems wrong, but
also doesn't appear to be new, exactly. Without this patch, if I have
RecordLocalUseOnCheckin enabled and check an item out to a statistical patron I
get 2 local use lines in statistics. I'm going to file a new bug for this
issue, I only mention it here because I almost marked this one Failed QA
thinking it was new behavior rather than old behavior made more obvious.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012

--- Comment #52 from Caroline Cyr La Rose  ---
Here is the insert we did in all our clients' databases

`insert into circulation_rules (rule_name, rule_value) values
("processingreturn", 0);`

If the rule is not in the circulation_rules table, it automatically refunds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

--- Comment #51 from Blou  ---
This should have had a default value inserted in the DB to maintain the
previous behavior.

This has ruined some of our users days to discover all fees credited suddenly
after update, now their books don't balance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31698] Add ability to move a hold to a new biblio/item

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32137] Resend notices with updated info

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32137

--- Comment #4 from Christopher Brannon  ---
It is especially troublesome if you enter a patron email address incorrectly,
and hit save, and the welcome message bounces.  Great.  Maybe staff realize the
entered incorrectly and fix it, but the resend in the notifications is
misleading.  As admin, I know I can go to More and send a new welcome message,
but most staff are not going to get that.

We NEED to have resend work with current patron info, not saved info.  Current
name, current contact info, current address, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476

Emily Lamancusa  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #40 from Emily Lamancusa  
---
Bug 35133 is now in Passed QA status, so this bug is no longer blocked. It does
cause test failure in t/db_dependent/Circulation.t, though :(

#   Failed test '(Bug 8236), Cannot renew, this item is not overdue but
patron has overdues'
#   at t/db_dependent/Circulation.t line 738.
#  got: '1'
# expected: '0'

#   Failed test 'Correct error returned'
#   at t/db_dependent/Circulation.t line 739.
#  got: undef
# expected: 'overdue'

#   Failed test '(Bug 8236), Cannot renew, this item is overdue so patron
has overdues'
#   at t/db_dependent/Circulation.t line 741.
#  got: '1'
# expected: '0'

#   Failed test 'Correct error returned'
#   at t/db_dependent/Circulation.t line 742.
#  got: undef
# expected: 'overdue'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14216] Koha should send a notice (via e-mail/print/or both) when changes are made to a patron account.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14216

--- Comment #1 from Christopher Brannon  ---
8 years later, this is still an important need.  I was just thinking the other
day, it would be good if the patron was notified if their password was changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35133] Accessors defined in AUTOLOAD does not work if called with SUPER

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35133

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Emily Lamancusa  ---
Looks like this has been a bug in Perl since version 5.18 -
https://www.perlmonks.org/?node_id=1171033

It makes sense to me to avoid adding the method reference to the symbol table
when handling a SUPER call, since the reference will not work and the next call
will fall back to AUTOLOAD anyway. This shouldn't have any side effects, and it
passes the QA checks. Thanks for including a clear explanation in the comments,
too!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35133] Accessors defined in AUTOLOAD does not work if called with SUPER

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35133

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #160778|0   |1
is obsolete||

--- Comment #8 from Emily Lamancusa  ---
Created attachment 161152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161152=edit
Bug 35133: Don't lazily define accessor methods when invoked through SUPER

To test:
  1) Apply Bug 32476
  2) Run tests in t/db_dependent/Patrons.t
  3) This should produce multiple "Subroutine Koha::Patron::SUPER::dateexpiry
redefined at ..." warnings
  4) Apply patch
  5) Run tests in t/db_dependent/Patrons.t again
  6) The warnings in 3) should now no longer appear

Signed-off-by: matthias le gac 
Signed-off-by: Phan Tung Bui 
Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35133] Accessors defined in AUTOLOAD does not work if called with SUPER

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35133

Emily Lamancusa  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc
   |y.org   |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19037] Circulation and fine rules test tool

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19037

--- Comment #10 from Christopher Brannon  ---
Looking forward to this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24956] Add ability to define emergency/override circ rules

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #3 from Christopher Brannon  ---
I would be interested in a way to override some or all rules without touching
the original rules.  Sounds like a great idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35630] Add ability to log changes to Authorized Values

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630

--- Comment #1 from Laura O'Neil  ---
+1, this would be extremely useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35630] Add ability to log changes to Authorized Values

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630

Laura O'Neil  changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30934] Allow for this system preference NoRefundOnLostReturnedItemsAge to be library specific

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30934

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Christopher Brannon  ---
+1  It does not make sense that some financial workflows can be defined by
branch, and other workflows force everyone to do the same thing.  This is a
rather important and needed change.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #71 from Lucas Gass  ---
Created attachment 161151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161151=edit
Bug 16122: CanBookBeIssued unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

David Nind  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

--- Comment #30 from David Nind  ---
(In reply to Matt Blenkinsop from comment #29)
> Thanks for adding the text - just had a look and it looks good to me!

Thanks Matt!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35832] Add option to include an email signature on all notices

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35832

--- Comment #2 from Katrin Fischer  ---
I was thinking of Bug 30723 - Allow for notices to have custom header/footer
include earlier :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

--- Comment #70 from Lucas Gass  ---
Created attachment 161150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161150=edit
Bug 16122: AddReturn unit tests and small fix in sub AddReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35696] Transit status not properly updated for items advanced in Stock Rotation tool

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161006|0   |1
is obsolete||

--- Comment #69 from Lucas Gass  ---
Created attachment 161149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161149=edit
Bug 16122: Perltidy and spelling

To test:
1. Apply patch, updatedatabase & schema, restart all Services
2. Go to Administration > Table setting. Find the holdings table ( Catalog >
holdings_table ) and turn the local use column on.
3. Go to an item record and notice the column 'Local uses'
4. Turn the system preference RecordLocalUseOnReturn Off.
5. Check in an item that is not checkout out. No local use should be recorded
for the item.
6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out.
Local use on that item should increment by 1.
7. Create a statistical patron and check an item out to them. Local use should
increment by 1.
8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for
localuse look correct.

To test maintainence script:
1. Without the patch, have RecordLocalUseOnReturn on.
2. Check in some items to record localuse in the stats table. Keep note of
those stats.
3. Apply the patches, updatedatabase.
4. Run the maintenance script, perl update_localuse_from_statistics.pl
5. Now check that items.localuse is congruent with what is in the stats table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161005|0   |1
is obsolete||

--- Comment #68 from Lucas Gass  ---
Created attachment 161148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161148=edit
Bug 16122: Add maintenance script to update items.localuse from stats

Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161004|0   |1
is obsolete||

--- Comment #67 from Lucas Gass  ---
Created attachment 161147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161147=edit
Bug 16122: Add display and Table settings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161003|0   |1
is obsolete||

--- Comment #66 from Lucas Gass  ---
Created attachment 161146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161146=edit
Bug 16122: Increment items.localuse in AddReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161002|0   |1
is obsolete||

--- Comment #65 from Lucas Gass  ---
Created attachment 161145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161145=edit
Bug 16122: API and Schema updates

Signed-off-by: Christopher Brannon 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16122] Item record needs to keep local use count

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Lucas Gass  changed:

   What|Removed |Added

 Attachment #161001|0   |1
is obsolete||

--- Comment #64 from Lucas Gass  ---
Created attachment 161144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161144=edit
Bug 16122: Add localuse column to items and deleteditems

Signed-off-by: Christopher Brannon 
Signed-off-by: Emily Lamancusa 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

Owen Leonard  changed:

   What|Removed |Added

 Blocks||33195


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195
[Bug 33195] Reindent the bibliographic details page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33195] Reindent the bibliographic details page

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195

Owen Leonard  changed:

   What|Removed |Added

 Depends on||33568
 Status|Patch doesn't apply |BLOCKED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
[Bug 33568] Use the REST API to display items on the biblio detail view
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35838] Use template wrapper for tabs: Curbside pickups administration

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838

--- Comment #1 from Owen Leonard  ---
Created attachment 161143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161143=edit
Bug 35838: Use template wrapper for tabs: Curbside pickups administration

This patch updates the curbside pickups administration template so that
it uses the new WRAPPER directive to build tabbed navigation.

To test, apply the patch and enable curbside pickups if necessary:
Administration -> System preferences -> CurbsidePickup.

- Go to Administration -> Curbside pickups.
- Confirm that the tabs look correct and behave as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35838] Use template wrapper for tabs: Curbside pickups administration

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35838] Use template wrapper for tabs: Curbside pickups administration

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838

Owen Leonard  changed:

   What|Removed |Added

Summary|Use template wrapper for|Use template wrapper for
   |tabs: Curbside pickups  |tabs: Curbside pickups
   ||administration

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30723] Allow for notices to have custom header/footer includes

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30723

--- Comment #5 from Christopher Brannon  ---
(In reply to Christopher Brannon from comment #4)
> Personally, I would want a dropdown for both header and footer in the
> notice, and be able to select which customization to include.  That way I
> could have more than one reusable header or footer.
> 
> Display location should be "Notice Header" or "Notice Footer" and only the
> headers should be selectable in the notice headers dropdown, or "None", and
> only footers should be selectable in the notice footers dropdown, or "None".
> 
> Hope that makes sense.

I should clarify:

Display location in the HTML Customization should be "Notice Header" for any
custom headers or "Notice Footer" for any custom footers and only the header
locations should be selectable in the notice headers dropdown, or "None", and
only footer locations should be selectable in the notice footers dropdown, or
"None".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30723] Allow for notices to have custom header/footer includes

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30723

--- Comment #4 from Christopher Brannon  ---
Personally, I would want a dropdown for both header and footer in the notice,
and be able to select which customization to include.  That way I could have
more than one reusable header or footer.

Display location should be "Notice Header" or "Notice Footer" and only the
headers should be selectable in the notice headers dropdown, or "None", and
only footers should be selectable in the notice footers dropdown, or "None".

Hope that makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571

Owen Leonard  changed:

   What|Removed |Added

 Blocks||35838


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838
[Bug 35838] Use template wrapper for tabs: Curbside pickups
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35838] New: Use template wrapper for tabs: Curbside pickups

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838

Bug ID: 35838
   Summary: Use template wrapper for tabs: Curbside pickups
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 32571

Continuing the work of Bug 32571, I would like to update the curbside pickups
page in the staff client to use the new WRAPPER for tabs


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571
[Bug 32571] Use template wrapper to build tabbed components
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #18 from Emily Lamancusa  
---
Testing notes:

I replicated the failure with the following configuration:
- git checkout v23.05.01
- Start KTD using MySQL 8
- Open a kshell, and edit /etc/koha/sites/kohadev/koha-conf.xml. Set
 to 0.
- git switch 23.11.x
- restart_all
- updatedatabase

Database update succeeded after applying the patch - signing off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #160462|0   |1
is obsolete||

--- Comment #17 from Emily Lamancusa  
---
Created attachment 161142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161142=edit
Bug 35687: Fix db rev for 23.06.00.013

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

Emily Lamancusa  changed:

   What|Removed |Added

 Attachment #160461|0   |1
is obsolete||

--- Comment #16 from Emily Lamancusa  
---
Created attachment 161141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161141=edit
Bug 35687 - Upgrade to 23.06.00.013 may fail

There are reports that this update triggers the error Cannot change column
'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1'

Test Plan:
1) Upgrade to post 23.06.00.013
2) Note the failure
3) Apply this patch set
4) Run updatedatabase.pl
5) Update should succeed!

Signed-off-by: Emily Lamancusa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35687] Upgrade to 23.06.00.013 may fail

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687

--- Comment #15 from Emily Lamancusa  
---
(In reply to Tomás Cohen Arazi from comment #14)
> Look at bad638578b6bb3d0913841bd71ab9fba220a529e
> 
> We've been facing this for a while.

Can we add a coding guideline for this? Something that's causing this many
issues ought to be documented somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35837] It would be useful to understand what plugins are being used in the wild.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35837

Martin Renvoize  changed:

   What|Removed |Added

 CC||matt.blenkinsop@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35837] New: It would be useful to understand what plugins are being used in the wild.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35837

Bug ID: 35837
   Summary: It would be useful to understand what plugins are
being used in the wild.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

HEA hasn't seen much love of late.. it would be great to send back statistics
on plugins used in an installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35717] Add an ordernumber column to suggestions

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717

--- Comment #13 from Andrew Fuerste-Henry  ---
(In reply to Lucas Gass from comment #12)
> (In reply to Andrew Fuerste-Henry from comment #11)
> > Hi these patches applied, I'm getting an error when attempting to receive an
> > order tied to a suggestion. It looks like maybe an undefined basket number?
> 
> I don't recreate this. Did you updatedatabase after applying the patch?

I'm getting this error on a sandbox that was provisioned with the patch applied
from the start. My understanding is that inherently includes an updatedatabase,
and I can see via SQL that the suggestions table *does* include the ordernumber
field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836

Matthias Le Gac  changed:

   What|Removed |Added

 CC||matthias.le-...@inlibro.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35836] New: search_for_data_inconsistencies.pl - Search for loops in dependencies.

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836

Bug ID: 35836
   Summary: search_for_data_inconsistencies.pl - Search for loops
in dependencies.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: matthias.le-...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We have guarantors who guarantee individuals who are, in turn, their
guarantors. 

It is not clear if this should be allowed (bz35421), but it works, and has been
working for a while.

However, it breaks with bz12532, which produces a recursion that disrupts
everything.

Creation of a code in search_for_data_inconsistencies.pl that identifies loops
in borrower_relationships. This must work in both directions for validation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||35290

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

--- Comment #1 from Marcel de Rooy  ---
Created attachment 161140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161140=edit
Bug 35835: Fix shebang in cataloguing/ysearch.pl

Speaks for itself.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35835] New: Fix shebang for cataloguing/ysearch.pl

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35835

Bug ID: 35835
   Summary: Fix shebang for cataloguing/ysearch.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

See 35290

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

--- Comment #13 from Tomás Cohen Arazi  ---
FTR: I manually installed the mentioned RabbitMQ plugin [1], and couldn't make
it work.

[1] v3.8.9 here https://github.com/rabbitmq/rabbitmq-delayed-message-exchange

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #161067|0   |1
is obsolete||
 Attachment #161071|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 161139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161139=edit
Bug 35819: Notify NACK and requeue when Job ID not found

This patch makes the worker reject the incoming frame for putting the
message back in the queue, in the event the job id doesn't exist yet.
Which is the case when some actions are being triggered inside a
transaction which hasn't been commited to the DB yet.

To test you will need 3 KTD shells
(a) mysql:
   $ ktd --shell
  k$ sudo koha-mysql kohadev

(b) logs:
   $ ktd --shell
   # for restarting the worker and looking at the logs
  k$ sudo koha-worker --restart kohadev  ; tail -f
/var/log/koha/kohadev/worker-*.log
(c) running the test:
   $ ktd --shell

1. Have (a), (b) and (c) terminals ready
2. On (c), run:
   $ perl -MKoha::Database -MKoha::BackgroundJob::BatchUpdateBiblioHoldsQueue
-e 'Koha::Database->schema->txn_do( sub {
Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue({ biblio_ids =>
[ 1 ] }); sleep 1;  } );'
=> FAIL:
   * (b) shows (once) an error about a job not existing
3. On (a) run:
   > SELECT * FROM background_jobs;
=> FAIL: Notice the job ID mentioned on 2 stands as 'new'.
4. Apply this patch
5. Ctrl+c on (b), and re-run to launch the worker with the patch applied
6. Repeat 2
=> SUCCESS (partial): The error about the job not existing is displayed
many times
7. Repeat 3
=> SUCCESS: The job ID mentioned on 6 stands as 'finished'.
8. Sign off :-D

Discussion:

* The `requeue` header I added is correct, but it is the default
  behavior anyway. I prefered to make it explicit, though.

* To avoid that bunch of retries, we should requeue with some delay. I
  didn't manage to make it work (yet) but there's a 'delay' plugin for
  rabbit [1]. We already install the 'stomp' plugin in
  koha-common.postinst. But this plugin requires downloading it. Which
  would require further investigation.

* As Nick and Marcel pointed, we need to revisit the whole architecture,
  the need of a MQ (DB polling wouldn't have this problem), etc. But
  that's for another place.

[1]
https://hevodata.com/learn/rabbitmq-delayed-message/#:~:text=To%20delay%20a%20message%2C%20the,to%20queues%20or%20other%20exchanges.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35819] "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35514] New order line form: Total prices not updated when adding multiple items

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514

--- Comment #10 from Thibaud Guillot  ---
ah right... that's my mistake... I meant to say that the price is simply not
updated... I misspoke.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items

2024-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748

--- Comment #28 from Thibaud Guillot  ---
Hi Katrin,

Sorry for the delay in my reply. I've gone back over the code a bit, concerning
the presence of the value if it's not the current value, I've taken a look at
the form for modifying the categorycode of a borrower and the value, even if
it's limited to a branch, does appear in the list... maybe it's a recent patch,
I seemed to have seen a few things that dealt with this but I can't find them
:/

Could we add the disabled attribute to the entry to display it all the same, or
should we stick with "hidden"? 


On the other hand, I don't understand your sentence "It looks like the code
doesn't take the 'false' AV like itemtype into account, but it should." I'm
calling the original GetAuthorisedValues function with an extra parameter, but
it didn't retrieve the basic itemtypes, so I'd like to ask you to clarify this.

Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >