[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 --- Comment #7 from Martin Renvoize --- It's already PQA, we're in a security freeze right now. It'll be pushed as soon as that freeze is unlocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #159859|0 |1 is obsolete|| --- Comment #27 from PTFS Europe Sandboxes --- Created attachment 162085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162085=edit Bug 30031: Add column settings to list view To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Lists: Table id: searchresults 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 7. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view=1 ) 8. Set item-level_itypes to 'bibliographic record' so the item type column will show. 9. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anni Rajala Signed-off-by: Ray Delahunty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #468 from David Cook --- My test plan: 0a) koha-upgrade-schema kohadev 0b) koha-plack --restart kohadev __OPAC results__ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx==test_search=1 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Checkbox "Treat as hold group (next available item fulfills all holds)" 5. Click "Confirm hold" 6. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl 7. Click "Holds" 8. Confirm the two holds appear with the text "part of a hold group", and when you click on that text it shows you both hold group titles 9. Note the "Holds" tab shows 1 hold signifying the 2 holds in the hold group count as 1 hold total 10. In the staff interface, check in "301310" 11. Click "Confirm hold (Y)" 12. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 13. Note only 1 hold appears, and when you click on "part of a hold group" it only shows 1 hold title 12. In the OPAC, go to http://localhost:8080/cgi-bin/koha/opac-user.pl 13. Note that only 1 hold appears now 14. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 15. Cancel the hold __Staff interface results__ 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 2. Checkbox results 1 and 2 3. Click "Place hold" at the top of the search results 4. Search for patron "koha" 5. Checkibox "Treat as hold group" 6. Choose "Centerville" as "Pickup at" 7. Click "Place holds" 8. Click on "part of a hold group" on the each hold and note the modal with "Hold group" appears showing the 2 titles 9. Check in "301310" 10. Click "Confirm hold (Y)" 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Cancel the hold __OPAC detail__ NOTE: This is irrelevant without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 so 15565 can focus on implementing it. __Staff interface detail__ NOTE: This is irrelevant without https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 so 15565 can focus on implementing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #467 from David Cook --- QA tool seems mostly happy. I think it just has issues with Koha schema files which are irrelevant and sysprefs.sql which isn't related to this change. -- OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 15) WARN Koha/Schema/Result/OldReserve.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 136, now: 152) WARN Koha/Schema/Result/Reserve.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 161, now: 177) OK circ/circulation.pl OK circ/view_holdsqueue.pl OK installer/data/mysql/atomicupdate/bug_15516_-_hold_group_table.pl OK installer/data/mysql/kohastructure.sql FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs hidelostitems is bad placed (see bug 10610) OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt OK koha-tmpl/opac-tmpl/bootstrap/js/holds.js OK members/moremember.pl OK opac/opac-reserve.pl OK opac/opac-user.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t OK t/db_dependent/Reserves/HoldGroup.t Processing additional checks OK! Running tests (2) * Proving /kohadevbox/koha/t/db_dependent/Reserves/HoldGroup.t OK! * Proving /kohadevbox/koha/t/db_dependent/Koha/Holds.t OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #466 from David Cook --- Created attachment 162084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162084=edit Bug 15516: Add 'DisplayAddHoldGroups' system preference to toggle ability to add titles to hold groups These patches add the ability to create hold groups across multiple bibs in the staff interface or OPAC. These hold groups are fulfilled by the first item checked in across the hold group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #465 from David Cook --- Created attachment 162083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162083=edit Bug 15516: (follow-up) Only show hold groups for multi hold in staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #464 from David Cook --- Created attachment 162082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162082=edit Bug 15516: (follow-up) Only show hold groups for multi hold in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #463 from David Cook --- Created attachment 162081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162081=edit Bug 15516: Add ability to create and view hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #462 from David Cook --- Created attachment 162080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162080=edit Bug 15516: Tidy reserve/placerequest.pl This includes tidying existing lines, so it'll be a separate patch, and not squashed into the hold group code changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #461 from David Cook --- Created attachment 162079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162079=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. The other holds will also be removed from the holds queue. 9. Confirm tests pass - t/db_dependent/Koha/Holds.t - t/db_dependent/Reserves/HoldGroup.t Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl - circ/view_holdsqueue.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #460 from David Cook --- Created attachment 162078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162078=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #459 from David Cook --- Created attachment 162077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162077=edit Bug 15516: Schema updates Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Attachment #138738|0 |1 is obsolete|| Attachment #138739|0 |1 is obsolete|| Attachment #138740|0 |1 is obsolete|| Attachment #138741|0 |1 is obsolete|| Attachment #138742|0 |1 is obsolete|| Attachment #138772|0 |1 is obsolete|| Attachment #138868|0 |1 is obsolete|| Attachment #138869|0 |1 is obsolete|| --- Comment #458 from David Cook --- Created attachment 162076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162076=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #550 from David Cook --- (In reply to Katrin Fischer from comment #548) > There is another major different: item groups group items from the same > record. The point of 15526 I think is creating groups with items from > different records (I don't care if I get the movie, the paperback, the > hardcover...) I've just finished rebasing and doing some testing... With bug 15516 alone, it creates hold groups using record-level or item-level holds from different records. However, when bug 15516 and bug 15565 are combined, then you can do hold groups for items within the same bib record as well. For now, on Bugzilla, I'm trying to keep the two bug reports separate. Locally, I join them together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook changed: What|Removed |Added Blocks||35754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 David Cook changed: What|Removed |Added Depends on||24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36075] Add API route to list recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 --- Comment #1 from Aleisha Amohia --- Created attachment 162075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162075=edit Bug 36075: Add REST API endpoint to list recalls This enhancement adds a REST API endpoint to list recalls and run search queries on recalls /api/v1/recalls /api/v1/recalls?patron_id=X To test: 1. Log in to the staff interface as your superlibrarian self (Patron A) 2. Go to Koha Administration -> Global system preferences. Enable the UseRecalls system preference 3. Set the relevant recalls circulation and fines rules 4. Search for an item (Item A) 5. Check out Item A to yourself (Patron A) 6. Log in to the OPAC as Patron B 7. Search for Item A and request a recall 8. Test the API returns the recall: https://your-opac-url/api/v1/recalls 9. Test other search parameters: https://your-opac-url/api/v1/recalls?patron_id=PATRON_B_NUMBER 10. Confirm you are able to view a list of Patron B's recalls 11. Confirm tests pass: t/db_dependent/api/v1/recalls.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35967] REST API: Add /api/v1/patrons/{patron_id}/recalls endpoint to list patron's recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35967 Aleisha Amohia changed: What|Removed |Added Blocks||36075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 [Bug 36075] Add API route to list recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks|36075 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 [Bug 36075] Add API route to list recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36075] Add API route to list recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075
Aleisha Amohia changed:
What|Removed |Added
Depends on|19532 |35967
Status|NEW |Needs Signoff
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35967
[Bug 35967] REST API: Add /api/v1/patrons/{patron_id}/recalls endpoint to list
patron's recalls
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #288 from David Cook --- I noticed there is a FAIL in the QA tools, but it's not related to this change: -- testing 4 commit(s) (applied to d130a6c '6b Bug 35962: (bug 35843 follow-up 2)') Processing files before patches The PO directory has not been found. There is a problem in your Koha installation. at /kohadevbox/koha/Koha/I18N.pm line 197. |>| 5 / 5 (100.00%) Processing files after patches |>| 5 / 5 (100.00%) FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs hidelostitems is bad placed (see bug 10610) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK reserve/placerequest.pl OK reserve/request.pl Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the staff|on a record in the staff |interface and OPAC. |interface and OPAC. | | |Item|Item |radio buttons are replaced |radio buttons are replaced |with checkboxes.|with checkboxes. || ||This ||feature is enabled/disabled ||via the system preference ||"DisplayMultiItemHolds". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #287 from David Cook --- Created attachment 162074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162074=edit Bug 15565: Add 'DisplayMultiItemHolds' system preference to toggle display of multi item holds These patches allow the display of checkboxes instead of radio buttons for placing specific item holds in the OPAC and staff interface. This display is controlled by the system preference 'DisplayMultiItemHolds'. When disabled, the hold display is the same as in the past. When enabled, the user can select multiple items to place holds on at the same time. If there is an error placing one or more holds, an error will display on the following screen. Test plan: 0. Apply the patches and koha-plack --reload kohadev 1. Enable 'DisplayMultiItemHolds' syspref 2. In staff interface, go to a record with multiple holdable items 3. Check the boxes next to 2+ items and click the button to place the holds 4. Note that the holds are all placed (unless there is a failure) 5. Cancel the holds, and try again (but this time make Holds per record (count) only 1 in the circ rules) 6. Note that one of the holds is placed, but the others are not and an error message is displayed saying that one or more holds could not be placed because the holds per record was exceeded 7. Perform the same above procedure on the OPAC 8. If DisplayMultiPlaceHold is enabled, you can test placing multiple specific item holds across multiple bibs in the OPAC via the search results 9. If EnableItemGroups and EnableItemGroupHolds is enabled, you can test that you can either place item group holds or specific item holds. Toggling the checkboxes in the staff interface will uncheck the item group hold radio button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #286 from David Cook --- Created attachment 162073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162073=edit Bug 15565: Place multiple holds on one or more records in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #285 from David Cook --- Created attachment 162072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162072=edit Bug 15565: Tidy reserve/placerequest.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Attachment #120639|0 |1 is obsolete|| Attachment #120640|0 |1 is obsolete|| Attachment #120641|0 |1 is obsolete|| Attachment #121941|0 |1 is obsolete|| Attachment #122098|0 |1 is obsolete|| --- Comment #284 from David Cook --- Created attachment 162071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162071=edit Bug 15565: Place multiple holds on one record on staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #549 from David Cook --- (In reply to Katrin Fischer from comment #548) > (In reply to David Cook from comment #547) > > I'm starting to look at this and it looks like a similar idea to bug 15516 > > except that it's the library creating the group rather than the patron. > > > > I wonder if bug 15516 could be re-implemented as a item_group. Maybe we > > could add a column to differentiate between staff-added and user-added item > > groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see... > > There is another major different: item groups group items from the same > record. The point of 15526 I think is creating groups with items from > different records (I don't care if I get the movie, the paperback, the > hardcover...) Hmm that could be. It's been a while since I looked at a live implementation or the code. I'll be looking at it very shortly so I guess I'll see! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #283 from David Cook --- (In reply to David Cook from comment #282) > The difference with the past patches is that we don't get the > warnings/restrictions in the UI *before* placing the hold. We only get the > warnings about failures *after* trying to place the hold. > > I think warning *before* the hold is actually a separate feature. I actually don't know if there is a practical bug-free way of doing it *before*, since each individual item can have different rules. There's a complex interplay of rules. For instance, item A could have 1 "Holds per record", while item B could have 10 "Holds per record". Trying to pre-emptively calculate holdability on selected holds rather than placed holds... is tough to do without potential for errors. One could argue that it's unlikely a bib record would have items of different types, but I see it all the time. That said, only warning *after* trying to place the holds isn't great, because it might not be obvious which holds were placed and which weren't placed. But we can't do much about that while our hold placing scripts use redirects. Replacing those redirects with API calls would work better, because the user would be able to see immediately which holds were placed and which weren't. (But that also involves messing around with the DOM in unfun ways - unless we use Vue.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Michael Hafen changed: What|Removed |Added CC||michael.ha...@washk12.org --- Comment #5 from Michael Hafen --- Created attachment 162070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162070=edit Add branch and skip-branch options to cronjobs/longoverdue.pl Test plan: 1. apply patch 2. identify two books at different branches the same number of days overdue. 3. run the longoverdue.pl script specifying one of the branches in the --branch command line parameter. 4. observe that the book at the specified branch has been or would be affected by the script while the other book is not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #282 from David Cook --- (In reply to David Cook from comment #281) > I've rewritten the staff-interface code to be much more minimal yet still > effective. Its error handling is patterned off the OPAC, which makes it > consistent across the interfaces as well. The difference with the past patches is that we don't get the warnings/restrictions in the UI *before* placing the hold. We only get the warnings about failures *after* trying to place the hold. I think warning *before* the hold is actually a separate feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35754 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15565 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #548 from Katrin Fischer --- (In reply to David Cook from comment #547) > I'm starting to look at this and it looks like a similar idea to bug 15516 > except that it's the library creating the group rather than the patron. > > I wonder if bug 15516 could be re-implemented as a item_group. Maybe we > could add a column to differentiate between staff-added and user-added item > groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see... There is another major different: item groups group items from the same record. The point of 15526 I think is creating groups with items from different records (I don't care if I get the movie, the paperback, the hardcover...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #281 from David Cook --- I've rewritten the staff-interface code to be much more minimal yet still effective. Its error handling is patterned off the OPAC, which makes it consistent across the interfaces as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 David Cook changed: What|Removed |Added Depends on|24857 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook changed: What|Removed |Added Blocks|35754 | --- Comment #547 from David Cook --- I'm starting to look at this and it looks like a similar idea to bug 15516 except that it's the library creating the group rather than the patron. I wonder if bug 15516 could be re-implemented as a item_group. Maybe we could add a column to differentiate between staff-added and user-added item groups. I'll be looking again at bug 15516 shortly, so I suppose I'll see... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||36075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 [Bug 36075] Add API route to list recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36075] Add API route to list recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36075] New: Add API route to list recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 Bug ID: 36075 Summary: Add API route to list recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz CC: tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 David Cook changed: What|Removed |Added Blocks||35754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 [Bug 35754] Place multiple item-group holds at once for the same record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35754] Place multiple item-group holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35754 David Cook changed: What|Removed |Added Depends on||24857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What|Removed |Added Text to go in the|Allow borrowers to place|Allow borrowers to place release notes|multiple item-level holds |multiple item-level holds |on a record in the staff|on a record in the staff |interface and OPAC. |interface and OPAC. | | |Item|Item |radio buttons are replaced |radio buttons are replaced |with checkboxes, and once a |with checkboxes. |borrower has reached the| |circulation rules 'Holds| |per record (count)' value | |the remaining unticked | |checkboxes are disabled.| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34976] Encryption keys should not be shared between modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34976 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #4 from Liz Rea --- At the point you have access to root to get the koha-conf, you have everything including the database and all of the keys anyway (because you can become koha-mysql or koha-dump the whole thing) and all of the keys are right there in the koha-conf. While I agree that one key does allow access to more things, the added complexity of multiple keys... the idea of it makes me very tired, for a really negligible gain in security. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36074] Make materials specified note easier to customize, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34890] Cannot delete plugin with error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34890 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36074] Make materials specified note easier to customize, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074
--- Comment #1 from Lucas Gass ---
Created attachment 162069
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162069=edit
Bug 36074: Add classes to materials specfied message on check in and checkout
when CircConfirmItemParts is on.
To test:
1. APPLY PATCH
2. Set CircConfirmItemParts to 'Require'.
3. Add a materials specified message to an item. ( 952$3 )
4. Add the following CSS to your IntranetUserCSS:
.mats_spec_label { color: white; background: purple; }
.mats_spec_message { color: white; background: green; }
5. Checkout that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.
6. Check in that item. Notice the message should be green and the label (Note
about the accompanying materials:) should be purple.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36074] Make materials specified note easier to customize, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36074] New: Make materials specified note easier to customize, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36074 Bug ID: 36074 Summary: Make materials specified note easier to customize, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 35253 made the materials specified note easier to customize. However I failed to realized that the message is slightly different if 'CircConfirmItemParts' is set to 'Require'. That message should also include the HTML classes added for Bug 35253. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 --- Comment #6 from Andrii Nugged --- this comment is not related to the code/solution, but to the problem as before the ticket: we recently found that before this solution Koha brings the wrong returning branches when the item is returned on circ/circulation.pl page (moreover, it looks like (unsure) that it reads branch data of another user from the Plack session because the current wasn't populated properly) so this bug should have "increased" priority, IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #7 from David Nind --- Makes sense to me! Testing notes (using KTD): 1. Apply the patch. 2. Reset everything so it is like a new install: reset_all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 David Nind changed: What|Removed |Added Attachment #161996|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 162068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162068=edit Bug 36055: Simplify MARC21 Fast Add framework This patch removes or hides a lot of unecessary fields from the MARC21 Fast Add framework, notably subfields $6 and $8 which are used only in advanced cataloging. Fast Add is meant to add an item fast, while the patron is waiting, in order to check it out to them. There is no need to enter details, only what is necessary to identify and check out the item. To test: 1. Go to Circulation > Fast cataloging --> Notice all the fields present 2. Fill out mandatory fields (000, 008, 245$a, 942$c) 3. Click 'Save' --> Notice all the item fields present 4. Apply patch and reset 5. Redo steps 1-3 --> There should be a lot less fields Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Blocks|36073 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass changed: What|Removed |Added Blocks||36073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Lucas Gass changed: What|Removed |Added Blocks||36073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36073] Add Holds Queue info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 Lucas Gass changed: What|Removed |Added Depends on|36064 |36063, 22456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 [Bug 22456] Allow patrons to cancel their waiting holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 [Bug 36063] Add Holds to Pull info to intranet-main page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 [Bug 36064] Add Holds with cancellation requests info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36064] Add Holds with cancellation requests info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 Lucas Gass changed: What|Removed |Added Blocks||36073 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 [Bug 36073] Add Holds Queue info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36073] Add Holds Queue info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 Lucas Gass changed: What|Removed |Added Depends on||36064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36064 [Bug 36064] Add Holds with cancellation requests info to intranet-main page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #6 from Lucas Gass --- (In reply to Christopher Brannon from comment #5) > Which is why I recommend basing this off the holds queue. This is what I am > doing via jQuery right now. This is also consistent with how the rest of > the alerts work. Staff don't need to be looking at alerts that don't > concern them. I filed Bug 36073, as it would be good to add this for the 'Holds queue' as well. I don't love the idea of adding a sys pref to show or hide each of these from the main page and it can be hidden with CSS if needed. Setting this back to 'Signed off'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36073] New: Add Holds Queue info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36073 Bug ID: 36073 Summary: Add Holds Queue info to intranet-main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Like Bug 36063 but for Holds Queue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36063] Add Holds to Pull info to intranet-main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36063 --- Comment #5 from Christopher Brannon --- Which is why I recommend basing this off the holds queue. This is what I am doing via jQuery right now. This is also consistent with how the rest of the alerts work. Staff don't need to be looking at alerts that don't concern them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 --- Comment #5 from Esther Melander --- Yes, I had it install the patch when the Sandbox was created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34062] Additional contents with library set do not appear in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34062 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #6 from Kelly McElligott --- We are testing this in 23.11.00 and this is also not working with library-specific messages within the HTML customizations, OPACResultSidebar. This does work with an 'all library' message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 --- Comment #4 from Caroline Cyr La Rose --- (In reply to Esther Melander from comment #3) > I applied the patch on my Sandbox, which is at 23.12.00, and none of the > changes listed above were applied. Did you reset all? Not sure how this is done on a sandbox. Reset database or restart? It will not change anything on existing installations, as it is an installer file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36055] Simplify MARC21 Fast Add framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36055 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #3 from Esther Melander --- I applied the patch on my Sandbox, which is at 23.12.00, and none of the changes listed above were applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Koha Team University Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@univ-lyon3.fr --- Comment #30 from Koha Team University Lyon 3 --- Hi, tested on a sandbox. When we edit a vendor with a discount with no decimal (ex : 10), nothing is added when we saved it. If we try to enter a number with a comma in the discount, a red message appears "Please enter a decimal number in the format: 0.0" It's no more possible to make the discount not recorded because of a wrong input. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #161706|0 |1
is obsolete||
--- Comment #29 from PTFS Europe Sandboxes ---
Created attachment 162067
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162067=edit
Bug 35087: (follow-up) Accept only values which will be saved correctly
This patch adds a regex (thanks to Katrin for the help) specific to the
range of values which will be accepted by the discount column in the
database which has the type "float(6,4)".
The patch also removes the format() filter from the template so that
values returned from the database won't be truncated:
Using "format ('%.1f')", a value in the db of '9.009' would appear in
the edit form as '9.0', a change which could be missed if the user was
editing some other field in the vendor edit form.
To test, apply the patch and clear your browser cache if necessary.
- Go to Acquisitions -> Vendors -> Edit vendor.
- Under "Ordering information," test entering various values in the
"Discount" field. It should accept numbers with up to two digits
before the decimal and up to three digits after the decimal:
9, 99, -99, 99.9, 0.99, 99.99, 99.999
- In each of these cases, confirm that a value accepted by the
client-side validation is also accepted when you submit the form and
is correctly displayed when you edit that vendor again.
- It should not accept:
100, 100.001, 100.1
- The error message has been updated to read, "Please enter a decimal
number in the format: 0.0"
Signed-off-by: Owen Leonard
Signed-off-by: Sonia
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #161705|0 |1 is obsolete|| --- Comment #28 from PTFS Europe Sandboxes --- Created attachment 162066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162066=edit Bug 35087: alternative patch to display validation Same test plan as for the other patch, but here validation impacts the js asset Signed-off-by: Owen Leonard Signed-off-by: Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35087] Discount rate does not accept comma as decimal separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #161704|0 |1 is obsolete|| --- Comment #27 from PTFS Europe Sandboxes --- Created attachment 162065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162065=edit Bug 35087: Discount rate only accepts a point as decimal separator When a comma is used to define the discount rate of a vendor, the data is not recorded (as NULL), it is however recorded if the separator is a point. Test plan: 1) Go to acqui module and edit a vendor 2) Set a discount rate with a comma as decimal separator 3) Edit again or request your database to see that there is no data saved 4) Do it again with a point as decimal and see it works 5) Apply this patch and reloard the build for the templates 6) Repeat step 2 and see the warning to inform you that you must use a point Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19605] ILL backends should be pluggable through regular Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #15 from Tomás Cohen Arazi ---
I been looking at the PluginBackend implementation, and got a bit confused
about this:
sub new_backend {
my ( $class, $params ) = @_;
my $self = {};
$self->{_logger} = $params->{logger} if ( $params->{logger} );
$self->{_config} = $params->{config} if ( $params->{config} );
bless( $self, $class );
return $self;
}
It seems to me that in this particular implementation, as we already have a
plugin instance in this context:
+my $backend_plugin = $self->get_backend_plugin($backend_name);
+if ($backend_plugin) {
+
+# New way of loading backends: Through plugins
+my $backend_plugin_class = $backend_plugin->{class};
+
+$self->{_my_backend} = $backend_plugin_class->new_backend(
it doesn't make sense to instantiate the plugin again. Thus, the PluginBackend
implementation could just be:
sub new_backend {
my ($self,$params) = @_;
$self->{_logger} = $params->{logger} if ( $params->{logger} );
$self->{_config} = $params->{config} if ( $params->{config} );
return $self;
}
I would rather rename the method to `get_ill_backend`, and leave the plugin
authors the decision on what to return (the name change is a matter of taste,
but I think `ill` needs to be part of the method name).
In my case, I would love to be able to (say) have my own class for the backend,
so my implementation would be written like this:
sub get_ill_backend {
my ($self,$params) = @_;
require INNReach::ILL::Backend;
return INNReach::ILL::Backend->new({
plugin => $self,
logger => $params->{logger}
});
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 --- Comment #33 from Lucas Gass --- (In reply to Martin Renvoize from comment #32) > Whilst I agree that having AddReturn embedding inside CanBookBeIssued is > wrong, it is at least contained to 'statistical patrons'. > > I think we should allow this through QA, but I really want to see the logic > moved out of CanBookBeIssued and into the controllers calling it really.. > are you intending to work on bug 25950 at all Lucas? Martin, assuming you mean Bug 35950 I am happy to take that up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36051] Add option to specify SMS::Send driver parameters in a system preference instead of a file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36051 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- Can we use C4::Context->yaml_preference here Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added CC||matthias.le-...@inlibro.com --- Comment #21 from Matthias Le Gac --- Rebase to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Martin Renvoize changed: What|Removed |Added Blocks||35950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on||35840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Martin Renvoize changed: What|Removed |Added Blocks|35950 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on|35840 | --- Comment #1 from Martin Renvoize --- I think the AddReturn should be moved into circ/circulation.pl after the call to CanBookBeIssued when CanBookBeIssued returns a 'stat' response.. I also think that perhaps the actual recording of the state should be dropped from CanBookBeIssued and only take place within AddReturn. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added Attachment #158679|0 |1 is obsolete|| Attachment #158680|0 |1 is obsolete|| Attachment #158681|0 |1 is obsolete|| --- Comment #20 from Matthias Le Gac --- Created attachment 162064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162064=edit Bug 21214: cleanup_database.pl rebase to master Librarians sometime worry if a certain email was sent or not to a patron (PREDUES, ODUES, etc.), and iirc, there are no way to have that information once the cleanup_database.pl has run, unless we dig back an archive of their database. This patch would let an admin choose which letters to keep in the message_queue, based on its letter_code, by passing a comma-separated list to the script. TEST PLAN: 1) Either you have already have data, or you'll want to add some new test lines in your message_queue table . INSERT INTO message_queue(borrowernumber,letter_code,message_transport_type,status,time_queued) VALUES(1,,'email','sent','2018-01-01 00:00:42'); 2) Make a backup of this table 3) Run the script patchless with the --mail 1 option 3.1) Messages older than 1 day should have been deleted 4) Put the data back in 5) Apply patch 6) Choose a letter_code you'd like to keep, and run the script with --mail 1 --keep-lc [,] 7) Messages older than 1 day that don't have the code [or ] should've been deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21214] cleanup_database.pl --mail should let admin choose which letter codes to keep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21214 Matthias Le Gac changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #32 from Martin Renvoize --- Whilst I agree that having AddReturn embedding inside CanBookBeIssued is wrong, it is at least contained to 'statistical patrons'. I think we should allow this through QA, but I really want to see the logic moved out of CanBookBeIssued and into the controllers calling it really.. are you intending to work on bug 25950 at all Lucas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 Martin Renvoize changed: What|Removed |Added Depends on||35840 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 Martin Renvoize changed: What|Removed |Added Blocks||35950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 Brendan Lawlor changed: What|Removed |Added Attachment #161955|0 |1 is obsolete|| --- Comment #2 from Brendan Lawlor --- Created attachment 162063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162063=edit Bug 36053: Correct input name for item replacement fields To test: 1 - Follow test plan and use sample record from bug 35912 ( or similar) 2 - Confirm that when the order is saved the replacement price is $0.00 3 - Apply patch, restart_all 4 - Delete previous orders, and stage and add to basket again 5 - Confirm that upon adding orders to basket the replacement price is saved correctly Signed-off-by: Brendan Lawlor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 Brendan Lawlor changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36069] (bug 29990 follow-up) authority heading use in search results should work with ES as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36069 Janusz Kaczmarek changed: What|Removed |Added Status|NEW |Needs Signoff Priority|P5 - low|P3 Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36069] (bug 29990 follow-up) authority heading use in search results should work with ES as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36069 --- Comment #1 from Janusz Kaczmarek --- Created attachment 162062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162062=edit Bug 36069: (bug 29990 follow-up) authority heading use in search results should work with ES as well It seems that the enhancement introduced with bug 29990 (syspref: ShowHeadingUse) works only with Zebra (generation of main/subject/series use info is made only in C4::AuthoritiesMarc == a Zebra incarnation of search_auth_compat) and has no effect on ES search results. This patch does the same for ES. Test plan: 1. Have an installation with Elasticsearch enabled. 2. Go to Koha Administration -> system preferences -> searching tab. Enable ShowHeadingUse system preference. 3. Do an authority search. Notice that in the Heading use column you get always 'x' for all use types: main/subject/series. 4. Apply the patch. 5. Do an authority search. Notice that you get now 'v' or 'x' for use types main/subject/series, depending on the 008/14-16 bytes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #105 from Martin Renvoize --- Coming back to comment #88 > and it would be great to have a fallback to default for opening hours so you > could set at the global level and override at the branch level.. like many of > our other options of this style. I think this is the resolution we need for tests.. if we allow library_id to be nullable in library_hours and add a row for each day with default opening hours to fall back to, then handling this in code should mean we can get tests passing more easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 --- Comment #1 from Owen Leonard --- Created attachment 162061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162061=edit Bug 36045: Use DataTables filter for suggestions search This patch removes the server-side suggestions search form and related code from the OPAC suggestions page. In its place is a DataTables filter form and a custom dropdown to replace the "suggested by me/anyone" option from the old search. To test you should have some suggestions in your system submitted by two or more users. - Apply the patch and rebuild the OPAC CSS. - Go to Administration -> System preferences and set the "OPACViewOthersSuggestions" preference to "Show." - Log in to the OPAC as one of the users who has submitted suggetions. - Go to the purchase suggestions page. - The initial view should be of "your" suggestions. - The dropdown filter at the top should have "Suggested by me" selected. - The "Clear filter" button should be disabled. - Test that the "Suggested by me" dropdown works to change what's shown in the table. - The "Clear filter" button should be enabled when you choose "Suggested by anyone." - The DataTables "Search" field should work correctly with either setting of the "Suggested by..." dropdown. - Go back to Administration in the staff interface and disable the "OPACViewOthersSuggestions" preference. - Return to the suggestions page in the OPAC. - You should see only your suggestions, and the "Suggested by..." dropdown should not be there. - Confirm that filtering still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36045] Use DataTables filter for suggestions search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36045 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Thibaud Guillot changed: What|Removed |Added Attachment #161800|0 |1 is obsolete|| --- Comment #15 from Thibaud Guillot --- Created attachment 162060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162060=edit Bug 35114: Fix calculation around basketgroup and basket details Test plan: 1) I purpose a simple way to test it with new fresh data. First of all go to one of your vendor and set a discount of 9%. Then create a new basket, add to basket a new line from an empty record. Set a vendor price to 15.90 and just add this order 2) Configure the basket.pl table to show all columns, see budgeted cost and actual cost (exc or inc). There is already a difference of one cent. 3) Let's take a look at the basket groups now, for this, close this basket. Go on tab menu and select basket group. Click on new basket group. Normally you will see the new basket created on step 1. The total here is 14.47.. and when you check on basket detail it's 14.46 cause this total (from basket groups) comes from ecost exc. while total line on basket detail comes from actual cost exc. 4) Apply this patch and see changes Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #104 from Martin Renvoize --- I've fixed a whole bunch of little issues to get this vaguely working now, but as I run the test suit against it I see there are more issues hidden. I've fixed some array indexing issues where your code worked in opposition to how Koha's calendar indexes days of the week already.. but Circulation tests still fail. This is because, as far as I can tell, your code expects every branch to always have opening hours set.. i.e. there MUST be rows for days 0 to 6 for every branch, even if those rows have hours of null-null. I've fixed the database update to handle this, however the failing tests expose the lack of treatment for this in t/lib/TestBuilder. We'll need that resolving before this can work it's way through QA. I'm not sure whether we should be adding this handling to TestBuilder (i.e. to always ensure there's 7 rows per branch for any time a branch is added in testing), or whether really we should not be making this assumption in the first place and instead we should be allowing for missing rows in the library_hours table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
