[Koha-bugs] [Bug 36076] paycollect.tt is missing permission checks for manual credit and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36076 David Nind changed: What|Removed |Added Attachment #162088|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 162252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162252=edit Bug 36076: paycollect.tt add permission checks for manual credit and invoice In members/pay.tt one can see permission checks for manual credit and invoice : CAN_user_updatecharges_manual_invoice CAN_user_updatecharges_manual_credit This is missing from members/paycollect.tt. HTML is also missing classes manualcredit and manualinvoice. Test plan : 1) Create a user with permissions to manage accounting but without manual_invoice and manual_credit 2) Go to a patron account with an invoice 3) Click on "Make a payment", you dont see tabs manual credit/invoice 4) Click on "Pay" in "Actions" column => Without patch you see tabs manual credit/invoice => With patch you do not see them Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36076] paycollect.tt is missing permission checks for manual credit and invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36076 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I'm not sure that I've tested this correctly. Do I need to add a payment plugin, such as the paypal one, to test this change? If I haven't tested correctly, please change status back to needs signoff. 2. I added some charges for a patron, and then added a payment and a write off. 3. In the OPAC I made sure that the figures shown in the charges tab add up correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088 David Nind changed: What|Removed |Added Attachment #162128|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 162251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162251=edit Bug 36088 - Remove useless code form opac-account-pay.pl The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Note there is no change in behavior Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36088] Remove useless code form opac-account-pay.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Michael Hafen changed: What|Removed |Added Attachment #162070|0 |1 is obsolete|| --- Comment #9 from Michael Hafen --- Created attachment 162250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162250=edit Bug 9596: Add branch and skip-branch options to cronjobs/longoverdue.pl [ Tidied and commit message fixed ] This script doesn't seem to be included in cron files by default. This change is to allow script parameters to effect only certain branches. This allows the script to be added multiple times to a cron file with different settings for different branches. Test plan: 1. apply patch 2. identify two books at different branches the same number of days overdue. 3. run the longoverdue.pl script specifying one of the branches in the --branch command line parameter. i.e. koha-shell -c 'misc/cronjobs/longoverdue.pl --branch branch_code --lost 60=2 --maxdays=61 --confirm' instance_name 4. observe that the book at the specified branch has been or would be affected by the script while the other book is not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #32 from Victor Grousset/tuxayo --- QA script reports this: WARN C4/Circulation.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1095, now: 1098) WARN Koha/Schema/Result/Accountline.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 142, now: 162) WARN Koha/Schema/Result/Issue.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 108, now: 112) WARN Koha/Schema/Result/OldIssue.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 106, now: 110) At the time of the 1st submission these patches, perltidy was already in Coding Guidelines (PERL1), and was about default perltidy config. Likely a lot of current errors are from default config and not or few customization. So at least a lot at the messy lines would be needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa changed: What|Removed |Added Depends on||36127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 [Bug 36127] Port default HOLDPLACED and HOLD_CHANGED notices to Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36127] New: Port default HOLDPLACED and HOLD_CHANGED notices to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36127 Bug ID: 36127 Summary: Port default HOLDPLACED and HOLD_CHANGED notices to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org Blocks: 15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa changed: What|Removed |Added Depends on||36126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 [Bug 36126] Port default HOLD notice to Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36126] New: Port default HOLD notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Bug ID: 36126 Summary: Port default HOLD notice to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org Blocks: 15278 We have default HOLD notices defined for email, sms, and print - all three need to be updated to Template Toolkit syntax Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. As the koha user, set up an item for booking and place a booking - everything should work as expected: 1.1 Enable an item to be booked: . Go to a record with item(s). . Go to the items tab. . Update an item so that it is bookable (Priority section, update Bookable to 'Yes' 1.2 From the buttons above the title, select 'Place booking': . Choose a patron . Select a period (click a start and end date) . Submit 2. Set up another staff patron (such as Henry) so that: 2.1 You can log in as them. 2.2 They have these permissions: . Staff access, allows viewing of catalogue in staff interface (catalogue) . Check out and check in items (circulate) (including Manage item bookings (manage_bookings)) 3. Log in as them and try to make a booking - note that when searching for the patron name (such as lisa or mary), that you get no search results and can't select a patron. 4. Apply the patch, flush_memcached, and restart everything (restart_all) 5. Try again to make a booking - you should now be able to successfully search for a patron and submit the booking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Emily Lamancusa changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36125 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa changed: What|Removed |Added Depends on||36125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36125 [Bug 36125] Port default HOLD_SLIP notice to Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36125] New: Port default HOLD_SLIP notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36125 Bug ID: 36125 Summary: Port default HOLD_SLIP notice to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org Blocks: 15278 Bug 17975 proved that HOLD_SLIP was supported for TT syntax, and could be used as a reference for adjusting the default content. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind changed: What|Removed |Added Attachment #160876|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 162249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162249=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Emily Lamancusa changed: What|Removed |Added Depends on||36124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36124 [Bug 36124] Port default Article Request notices to Template Toolkit syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36124] New: Port default Article Request notices to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36124 Bug ID: 36124 Summary: Port default Article Request notices to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org Blocks: 15278 There are 6 notices associated with Article Requests, whose default text still uses "hungry alligator" syntax: AR_CANCELED AR_COMPLETED AR_PENDING AR_REQUESTED AR_PROCESSING AR_SLIP The notices are pretty similar to each other, so it might make sense to update them all together. If not we can always split out another bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #97 from Victor Grousset/tuxayo --- Tried a rebase, failed at Applying: Bug 25260: Add a 'holds' table In kohastructure.sql, it's too hard with the column renames and reorder to propagate the changes of main/master's reserves table to holds. Maybe with git imerge it would help since it finds the conflicts cases one by one instead of having all of them fused together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Caroline Cyr La Rose changed: What|Removed |Added Blocks||36122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose changed: What|Removed |Added Depends on||33236 --- Comment #3 from Caroline Cyr La Rose --- Possibly linked to bug 33236 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #16 from Caroline Cyr La Rose --- (In reply to Fridolin Somers from comment #15) > Enhancement, not backporting to 23.05.x These commits are in 23.05.01. https://git.koha-community.org/Koha-community/Koha/commits/branch/23.05.x/search?q=33236 Should we edit the "Version released in"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- I'm not sure about all of the implications and places to change but at least here is another signoff. Changes in tests make sense. Additional testing: Confirmed that purged old_issues (cleanup_database.pl) are handled well :) (accountlines.issue_id is nulled) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161923|0 |1 is obsolete|| --- Comment #30 from Victor Grousset/tuxayo --- Created attachment 162248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162248=edit Bug 22421: Schema Update Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161922|0 |1 is obsolete|| --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 162247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162247=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161921|0 |1 is obsolete|| --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 162246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162246=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161920|0 |1 is obsolete|| --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 162245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162245=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161919|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 162244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162244=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36123] New: Visibility setting in framework for the 856$u not being followed in OPAC or Staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36123 Bug ID: 36123 Summary: Visibility setting in framework for the 856$u not being followed in OPAC or Staff interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I tested this behavior on 23.05 and two test sites for 23.11. To replicate: 1. Check the default framework and ensure the 856$u is visible in the OPAC and Staff Interface. Ensure the URL box is checked. 2. Find a record in the default framework. 3. Add a link like https://www.google.com to the 856$u and Google to the 856$y 4. View the record in the record detail view and the OPAC. Click the link to make sure it works. 5. Now edit the default framework and uncheck the box for OPAC visibility. Leave all other settings as is. 6. Look at the record in the OPAC again and see that the Online Resource and link is still showing. Click on the link and see that it returns an error page. 7. Look at the record in the Staff interface and click on the link and see it is successful. 8. Edit the default framework again. Uncheck the box for Staff visibility and check the box for URL. 9. Click on the URL in the Staff Interface and the link works. 10. Edit the default framework and leave the visibility for the Staff Interface unchecked and uncheck the box for URL. 11. Test the link again in the staff interface and see the link is visible and works. A combination of checking/unchecking visibility boxes and the URL box seems to result in inconsistent behavior. Disabling the URL sometimes returns an error page, sometimes does not. Most concerning is the visibility, which is being completely ignored. In some cases, it is preferable to hide the URL in the OPAC and still have it visible in the Staff Interface with a working link. There are two current work arounds: 1. Disable the URL so that the link returns an error (though one could hover over the link and see what it is) which doesn't work consistently. 2. Removing the URL from the record seems to be the only way to not display the URL in the OPAC, but that also removes it from the staff interface. I would expect the 856$u to not be visible if the OPAC or Staff visibility was unchecked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #2 from Caroline Cyr La Rose --- I forgot the patron's email address in the test plan. I don't think notices are generated if the patron doesn't have an email address. To recreate: 1. Enable EmailPurchaseSuggestions 2. Go to a patron's account and add an email address, a different one than the one used for EmailPurchaseSuggestions 3. Create a suggestion from the OPAC 3.1. Go to the OPAC and log in as a patron 3.2. Go to Your account > Purchase suggestions 3.3. Click New purchase suggestion 3.4. Enter a title 3.5. Click Submit your suggestion 4. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 5. Update the suggestion to accepted 5.1. In the staff interface, go to Acquisitions > Suggestions 5.2. In the suggestions list, check the box next to the suggestion 5.3. At the bottom of the screen, choose Mark selected as: Accepted 5.4. Click Submit 6. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 7. Order the suggestion 7.1. Go to Acquisitions 7.2. Search for a vendor 7.3. Click New > Basket 7.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 7.5. Click Save 7.6. Click Add to basket 7.7. Click From a suggestion 7.8. Click Order next to the suggestion 7.9. Enter order details 7.10. Click Save 7.11. Click Close basket 7.12. Click Yes, close 8. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 --- Comment #1 from Caroline Cyr La Rose --- Might be the same as bug 35854, but I'm not 100% sure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35854 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36122 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35854] Suggestions generate identical messages when edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35854 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- I just created bug 36122, I'm not sure if it's the same as this or not. It's similar but affects the NEW_SUGGESTION notice sent for every change in the suggestion when EmailPurchaseSuggestion is enabled instead of the patron notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36122] New: NEW_SUGGESTION is sent for every modification to the suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36122 Bug ID: 36122 Summary: NEW_SUGGESTION is sent for every modification to the suggestion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org If EmailPurchaseSuggestions is enabled, a new NEW_SUGGESTION notice is sent to the staff every time a modification is made to the suggestion. Create the suggestion --> NEW_SUGGESTION is sent to staff Accept the suggestion --> ACCEPTED is sent to patron; NEW_SUGGESTION is sent to staff Order the suggestion --> ORDERED is sent to patron; NEW_SUGGESTION is sent to staff To recreate: 1. Enable EmailPurchaseSuggestions 2. Create a suggestion from the OPAC 2.1. Go to the OPAC and log in as a patron 2.2. Go to Your account > Purchase suggestions 2.3. Click New purchase suggestion 2.4. Enter a title 2.5. Click Submit your suggestion 3. Check the message_queue, there should be one NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should be 1 entry in message_queue) 4. Update the suggestion to accepted 4.1. In the staff interface, go to Acquisitions > Suggestions 4.2. In the suggestions list, check the box next to the suggestion 4.3. At the bottom of the screen, choose Mark selected as: Accepted 4.4. Click Submit 5. Check the message_queue again, there should be one ACCEPTED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 3 entries in message_queue) 6. Order the suggestion 3.1. Go to Acquisitions 3.2. Search for a vendor 3.3. Click New > Basket 3.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 3.5. Click Save 3.6. Click Add to basket 3.7. Click From a suggestion 3.8. Click Order next to the suggestion 3.9. Enter order details 3.10. Click Save 3.11. Click Close basket 3.12. Click Yes, close 7. Check the message_queue again, there should be one ORDERED message sent to the patron and a new NEW_SUGGESTION message sent to whichever address you chose in EmailPurchaseSuggestions (in a fresh db, there should now be 5 entries in message_queue) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 adz...@noordacom.org changed: What|Removed |Added CC||adz...@noordacom.org --- Comment #8 from adz...@noordacom.org --- It'd be great to see this issue fixed, so that the second indicator was taken into account. Titles with articles are incorrectly sorting in my Lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36053] Replacement prices not populating when supplied from MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35904] C4::Auth::checkauth cannot be tested easily
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35904 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #18) > It's a dependency for a security bug, as such it's in the security repo not > the public one until after release of the stables that include it. Ok, I get it. -- (In reply to Jonathan Druart from comment #19) > Please move this to its own bug, on top of the other things. I am not > willing to rebase the whole tree only for wording. Ok, it only made sense if all patches still needed to be pushed to the branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35704] Add hold limits to Parent Child Item Types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m --- Comment #4 from Catrina Berka --- Hold limits are enforced for the sum of child item types, but not their corresponding parent or the default: For example, I have two child item types (Audio book and new books) under a parent Book. In my circulation rules, I set Holds allowed (total) for audio books and new books to 1 each and then set my Book rule to 4. I place a hold on an audio book. It successfully prevents me from placing a second hold. I do the same with new books - first hold successfully placed, second prevented. When I attempt to place a first hold on a Book, I get the error Cannot place hold - Too many holds: can only place a maximum of 2 total holds. Koha is only adding the holds allowed from the children item types, not considering the parent or default limits. It is misleading to have the holds allowed (total) columns on child item type circulation rules if they're not enforced in parent/child item type rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 --- Comment #9 from Nick Clemens --- (In reply to Catrina Berka from comment #8) > This bug is also affecting hold limits. For example, I have two child item > types (Audio book and new books) under a parent Book. In my circulation > rules, I set Holds allowed (total) for audio books and new books to 1 each > and then set my Book rule to 4. I place a hold on an audio book. It > successfully prevents me from placing a second hold. I do the same with new > books - first hold successfully placed, second prevented. When I attempt to > place a first hold on a Book, I get the error Cannot place hold - Too many > holds: can only place a maximum of 2 total holds. Koha is only adding the > holds allowed from the children item types, not considering the parent or > default limits. Parent/child types don't currently affect holds - see bug 35704 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m --- Comment #8 from Catrina Berka --- This bug is also affecting hold limits. For example, I have two child item types (Audio book and new books) under a parent Book. In my circulation rules, I set Holds allowed (total) for audio books and new books to 1 each and then set my Book rule to 4. I place a hold on an audio book. It successfully prevents me from placing a second hold. I do the same with new books - first hold successfully placed, second prevented. When I attempt to place a first hold on a Book, I get the error Cannot place hold - Too many holds: can only place a maximum of 2 total holds. Koha is only adding the holds allowed from the children item types, not considering the parent or default limits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Angela Berrett changed: What|Removed |Added CC||angela.berrett@familysearch ||.org --- Comment #6 from Angela Berrett --- +1 Agreed that this would be very helpful! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36047] Apostrophe in suggestion status reason blocks order receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36047 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m --- Comment #3 from Pedro Amorim --- I may come back to this but I'm out of time for now so just wanted to submit the result of my dig through. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36047] Apostrophe in suggestion status reason blocks order receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36047 --- Comment #2 from Pedro Amorim --- Created attachment 162243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162243=edit Bug 36047: Workaround the apostrophe This is just a quick hack fix highlighting where the issue lies the real fix should be escape HTML entities coming from biblio.suggestions as this fix may also fail in case the data contains double quotes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #9 from Martin Renvoize --- Rebased on the tree.. We need unit test updates for the changes to filter_by_bookable too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize changed: What|Removed |Added Attachment #161961|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 162242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162242=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35773] Cannot create bookings without edit_borrowers, label_creator, routing or order_manage permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 --- Comment #3 from Martin Renvoize --- They're really meant to be applied in order Magnus. I did that so that we get this important fix in 23.11.x even if we don't backport 29509 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 --- Comment #1 from Martin Renvoize --- *** Bug 36121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36121] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36121 Martin Renvoize changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 36120 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Blocks||36121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36121 [Bug 36121] Add pickup locations to Bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36121] New: Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36121 Bug ID: 36121 Summary: Add pickup locations to Bookings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 29002 Currently, there's no way to set where a booking is intended to be collected from. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Blocks||36120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to Bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] New: Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Bug ID: 36120 Summary: Add pickup locations to Bookings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 29002 Currently, there's no way to set where a booking is intended to be collected from. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Blocks||36119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36119 [Bug 36119] Bookings to collect needs a print option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36119] New: Bookings to collect needs a print option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36119 Bug ID: 36119 Summary: Bookings to collect needs a print option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 33736 A a print option to the bookings to collect report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 [Bug 33736] Add bookings to collect circulation report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36118] New: ILL request log does not display patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36118 Bug ID: 36118 Summary: ILL request log does not display patron information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com CC: pedro.amo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #20 from Matthias Le Gac --- I tried qa1 before to squash and I have no error but after squash I have this error : WARN tidiness The file is less tidy than before (bad/messy lines before: 83, now: 95) but I don't understand why because the code is the same -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36094] svc/authentication needs adjustements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36094 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36117 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36117] New: Can svc/bib_profile be removed?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36117 Bug ID: 36117 Summary: Can svc/bib_profile be removed? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Is this used? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35361] Search filter on receive orders page crashes the system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35361 --- Comment #11 from Andreas Jonsson --- I can understand why we want to use something like DBIx::Class. But have we properly considered the quality and the viability of DBIx::Class as an open source project? My impression is that it is not a good library: - The query semantics is vague and ambigous - The documentation cannot be trusted - It is slow - It is unmaintainable Although hundreds of people are listed as contributors, judging by the commit history, it is in practice a one-man project. Is there any Koha developer who has read the source code (e.g., https://metacpan.org/release/RIBASUSHI/DBIx-Class-0.082843/source/lib/DBIx/Class/Storage/DBI.pm) and can say that they feel confident about the situation? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Lucas Gass changed: What|Removed |Added Attachment #162232|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 162241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162241=edit Bug 32132: Do not allow NULL value in column aqbudgets.budget_period_id If budget_period_id column is set as NULL, "Late orders" page dies on error 500. Logs read: Template process failed: undef error - DBIC result _type isn't of the _type Aqbudget at /home/koha/Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt line 157 This patch makes changes to column aqbudgets.budget_period_id so that it no longer allows NULL values. This is in line with aqbudgets tables foreign key "budget_period_id" which has ON DELETE CASCADE clause. To test: 1. Run prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should fail 2. Run updatedatabase.pl and restart services if needed 3. Rerun prove t/db_dependent/Koha/Acquisition/Fund.t => Tests should now pass Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32132] Missing budget_period_id in aqbudgets kills lateorders.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32132 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org --- Comment #30 from Martin Renvoize --- Rebased.. I still think this is important -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Martin Renvoize changed: What|Removed |Added Attachment #157894|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 162240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162240=edit Bug 31427: (follow-up) Unit tests This patch adds a unit test for error precidence where autorenewals is involved. It is not comprehensive however, and I'm a little confused by the logic around cron vs non-cron handling... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Martin Renvoize changed: What|Removed |Added Attachment #156232|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 162239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162239=edit Bug 31427: Get auto renewal errors before other renewal errors This patch changes CanBookBeRenewed so that automatic renewal errors pop up before other renewal errors. This means that a book will be considered "auto_too_soon" before things like "too_many" or "restricted". (Otherwise, you'll get an email saying you can't renew a book the day after using your last auto renewal, even though the earliest renewal isn't available until later.) Test plan: 0. Apply patch 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Holds.t 3. prove t/db_dependent/Koha/Account/Line.t 4. prove t/db_dependent/Koha/Account.t Additional tests: 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=RestrictionBlockRenewing 6. Change to "block" 7. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab==search=AutoRenewalNotices 8. Change to "according to patron messaging preferences" 9. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 10. Set "Automatic renewal" to "Yes" and "No renewal before" to 4 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Checkout 301310 with a due date 4 days in the future 13. Add a manual restriction 14. Run `perl ./misc/cronjobs/automatic_renewals.pl` 15. Note that it says something like the following: Issue id: 1237 for borrower: 51 and item: 73 would not be renewed. (auto_too_soon) Instead of something like the following: Issue id: 1237 for borrower: 51 and item: 73 would not be renewed. (restriction) Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36116] New: Link to suggestion leads to undefined suggestion in parcel.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36116 Bug ID: 36116 Summary: Link to suggestion leads to undefined suggestion in parcel.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org While investigating the reception problem in bug 36047, I noticed the link to the suggestion from the receive page leads to an empty (?) suggestion. To recreate: 1. Create a suggestion 1.1. Go to Acquisitions > Suggestions 1.2. Click New purchase suggestion 1.3. Enter a title 1.4. Click Submit your suggestion 2. Accept the suggestion 2.1. In the suggestions list, check the box next to the suggestion 2.2. At the bottom of the screen, choose Mark selected as: Accepted 2.3. Click Submit 3. Order the suggestion 3.1. Go to Acquisitions 3.2. Search for a vendor 3.3. Click New > Basket 3.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 3.5. Click Save 3.6. Click Add to basket 3.7. Click From a suggestion 3.8. Click Order next to the suggestion 3.9. Enter order details 3.10. Click Save 3.11. Click Close basket 3.12. Click Yes, close 4. Receive the order 4.1. Click Receive shipments 4.2. Enter a Vendor invoice number 4.3. Click Next 4.4. Click the name after Suggested by: --> The suggestion it leads to is empty --> If you hover the mouse on the link, you'll see it says suggestionid=undefined -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #19 from Matthias Le Gac --- yes I already try this but I got a error with qa1 test but I will try again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36105] Add option to filter for "No status alias"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36105 Lucas Gass changed: What|Removed |Added Attachment #162215|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 162238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162238=edit Bug 36105: Add 'No status alias' option 1) Install FreeForm and enable ILLModule, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Visit /cgi-bin/koha/admin/authorised_values.pl add search for 'alias', click on ILL_STATUS_ALIAS 3) Click on the 'New authorized value for ILL_STATUS_ALIAS' button and add 'alias_code' in authorized value and 'Alias Description' in Description 4) Visit /cgi-bin/koha/ill/ill-requests.pl and create a new FreeForm request 5) After created, click 'Manage request', and then click the 'Edit request' button 6) Edit the Status and select 'Alias Description', click 'Submit' 7) Create a second request but do not set a status alias this time 7) Visit /cgi-bin/koha/ill/ill-requests.pl and select 'Alias description' on the 'Status aliases:' left-side filter 8) Notice the correct record is returned. 9) Now repeat 7) and select 'No status alias'. Notice the request with an empty status_alias is returned 10) Repeat 7 but select 'All status aliases'. Notice both requests are returned Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36105] Add option to filter for "No status alias"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36105 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 --- Comment #27 from Martin Renvoize --- Bug 34924 is now in Koha.. is it time to revisit this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #6 from Heather --- That's a great use of the field, Caroline--thank you for mentioning it! (And that the frameworks aren't updated for existing installations--alerts me to some changes I might want to make!) I could see this subfield being useful to use for staff access to a site vs. patron/public access, so it would be good to have this subfield display only in the staff client. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #18 from Magnus Enger --- (In reply to Matthias Le Gac from comment #17) > If you have a solution ? Sorry, not really. Have you tried squashing the three patches into one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23415] Notify patron fines when renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31427 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23415 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36115 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36115] Improve documentation for Return-Path (branches.branchreturnpath)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36115 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28729 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36115] New: Improve documentation for Return-Path (branches.branchreturnpath)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36115 Bug ID: 36115 Summary: Improve documentation for Return-Path (branches.branchreturnpath) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org I am not sure if the code or the documentation is the problem here, but let's start with the documentation. For reference, the manual says this today: Email: the email address field is not required, but it should be filled for every library in your system - Note: Be sure to enter a library email address to make sure that notices are sent to and from the right address - Note: If no email address is entered here, the address in the KohaAdminEmailAddress system preference will be used to send notices from this library Reply-To: you can enter a different ‘Reply-To’ email address. This is the email address that all replies will go to. - Note: If no email address is entered here, the address in the ReplytoDefault system preference will be used to receive replies to this library Return-Path: you can enter a different ‘Return-Path’ email address. This is the email address that all bounced messages will go to. - Note: If no email address is entered here, the address in the ReturnpathDefault system preference will be used to receive bounced messages from this library. https://koha-community.org/manual/latest/en/html/administration.html#adding-a-library Mu scenario is as follows: We host Koha for a number of libraries that want to send messages to their patrons by email. For some libraries we can't send email through their SMTP for different reasons. So we set up a noreply address with a domain that we control, so that we can use that as the sender of the emails, and we can do our best to set up SPF, DKIM etc for it, so it won't be seen as spam by services such as Gmail. Based on the description above, I set it up like this: Email = noreply Reply-To = real library email Return-Path = real library email But it turns out that when postfix was processing the email, and passing it on to our SMTP server, it was seeing the "real library email" from the Return-Path setting as the "from" address, not the "noreply" address that we wanted it to see. So the question is: - Is the code wrong in using the Return-Path address as the "from" address? - Or is the documentation wrong in saying that the Return-Path is just for bounced messages? See also: Bug 28729 - Return-path header not set in emails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Caroline Cyr La Rose changed: What|Removed |Added Blocks||36047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36047 [Bug 36047] Apostrophe in suggestion status reason blocks order receipt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36047] Apostrophe in suggestion status reason blocks order receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36047 Caroline Cyr La Rose changed: What|Removed |Added Depends on||8179 Severity|enhancement |major CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com --- Comment #1 from Caroline Cyr La Rose --- I have had several complaints about this from clients since we upgraded them. Here is the test plan to recreate the problem: 1. Create a suggestion 1.1. Go to Acquisitions > Suggestions 1.2. Click New purchase suggestion 1.3. Enter a title 1.4. Click Submit your suggestion 2. Update the suggestion to accepted and add a reason with an apostrophe 2.1. In the suggestions list, check the box next to the suggestion 2.2. At the bottom of the screen, choose Mark selected as: Accepted 2.3. In With this reason, choose Others... 2.4. Enter a reason with an apostrophe (my case was in French : Disponible en impression à la demande (POD). S'attendre à un long temps d'attente) 2.5. Click Submit 3. Order the suggestion 3.1. Go to Acquisitions 3.2. Search for a vendor 3.3. Click New > Basket 3.4. Enter a basket name (Optional: for testing I like to change Create items when: cataloging the record) 3.5. Click Save 3.6. Click Add to basket 3.7. Click From a suggestion 3.8. Click Order next to the suggestion 3.9. Enter order details 3.10. Click Save 3.11. Click Close basket 3.12. Click Yes, close 4. Receive the order 4.1. Click Receive shipments 4.2. Enter a Vendor invoice number 4.3. Click Next 4.4. Click Receive next to the order --> Page stays In processing forever I upped the severity to major as this causes a functionality to not work at all (acquisitions receive), but there is a workaround (remove the apostrophe), so not critical. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Lucas Gass --- Thanks Michael, this looks good and works as described. You just need to fix your commit message and perltidy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no Status|Needs Signoff |Failed QA --- Comment #8 from Magnus Enger --- (In reply to Martin Renvoize from comment #5) > This patch updates the notes field to a $raw filter to prevent html > escaping of the data within it. (In reply to David Cook from comment #7) > Yeah I don't think we can just expose the raw HTML. Sounds like a security problem and a FQA to me. Please set back to NSO if you disagree. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #17 from Matthias Le Gac --- euhh yes it's true I know this is not good but it's because if I don't make this tricks the qa1 test doesn't pass and I don't understand why because is the same code. The qa1 test doesn't pass for attach 1 but pass for the attach 3 but this is the same code. If you have a solution ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #16 from Magnus Enger --- Should both of these patches be active? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161843 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161844 It's late on a Friday so my eyes might be deceiving me, but it looks like to me like the second one undoes the change from the first? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34360] [WARN] DBIx::Class::ResultSetColumn::new(): Attempting to retrieve non-unique column 'biblionumber' on a resultset containing one-to-many joins will return duplicate results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34360 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #8 from Magnus Enger --- (In reply to Nick Clemens from comment #6) > I added a patch, however, I noted a new error: > DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse > has_many results in iterator mode due to order criteria - performed an eager > cursor slurp underneath. Consider using ->all() instead at > /kohadevbox/koha/Koha/Objects.pm line 317 Should this be fixed before the current patch is signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 --- Comment #8 from Blou --- We manage a hundred personnalized koha installations and we don't want to manually install all the plugins. Plus we have multiple in-house plugins, but not all of them go to all clients. It's much simpler for certain plugins to be in the koha git rather than floating in their standalone plugin in github, most of them because anyway they depend on a personnalised codebase. Some depend on the level of support the user has, etc... What was the use case for install_plugins.pl ? Shouldn't people just use the UI ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #5 from Caroline Cyr La Rose --- (In reply to Heather from comment #3) > I would completely hide this subfield in my OPAC *and* staff client, frankly! I'm using this field for a migration where all the links have to be changed (the client is also changing their website at the same time, so the links won't work anymore). I'm using 856$h to store the "old" link. I think it's interesting to see it in the staff interface for that case, without having to go "edit" the record. But like we both mentioned, it should not trigger the link display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #4 from Caroline Cyr La Rose --- (In reply to Heather from comment #3) > (The label for the field should also be changed from "Processor of request" > to "Non-functioning URI" to conform to the MARC21 standard. IMO.) This part was done in bug 34665. It's just that we don't update frameworks for existing installations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30724] Add ability for administrator to reset a users 2FA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30724 helm.consort...@nhs.net changed: What|Removed |Added CC||helm.consort...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29835] 2FA - ask for the users password when they choose to disable 2FA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835 helm.consort...@nhs.net changed: What|Removed |Added CC||helm.consort...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35210] 2FA: more flexibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35210 helm.consort...@nhs.net changed: What|Removed |Added CC||helm.consort...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34978] Add --include and --exclude options to install_plugins.pl to choose the plugins to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34978 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- What is the use case for this ? Why would you add plugins in the plugins path if you do not want to install them ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35952] Removed unnecessary line in opac-blocked.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35952 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35952] Removed unnecessary line in opac-blocked.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35952 Julian Maurice changed: What|Removed |Added Attachment #161681|0 |1 is obsolete|| --- Comment #3 from Julian Maurice --- Created attachment 162237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162237=edit Bug 35952: Remove unnecessary line for OpacSuppressionMessage To test: 1. Apply patch and restart all 2. Add an additional contetn entry for `OpacSuppressionMessage`, make sure it has a publication date in the past. 3. Make sure OpacSuppression is set to 'hide'. 4. Suppress a record in the OPAC, ( 942$n ) 5. Visit the detail page for that record and make sure you OpacSuppressionMessage customization displays. Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35952] Removed unnecessary line in opac-blocked.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35952 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35880] Use template wrapper for accordions: Patrons requesting modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35880 Julian Maurice changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com |y.org | CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
