[Koha-bugs] [Bug 34755] Error authenticating to external OpenID Connect (OIDC) identity provider : wrong_csrf_token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34755 --- Comment #40 from David Cook --- Note that we'll need this for 23.05 and 22.11 as well since they implement bug 33675 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind --- For the SCO log in (step 3), I have to log in three times - I'm assuming this is not what is expected: 1. Normal log in 2. SCO log in 3. Normal log on --> Then get to check out items In addition, when using KTD I needed to enable the SelfCheckInModule system preference for step 1. Tested using both Firefox and Chromium. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692
--- Comment #45 from David Cook ---
I also got a question about embedding the barcode in the WELCOME email.
I thought that was pretty interesting.
This solution wouldn't work in that case.
If we had a $patron->generate_barcode({ type => 'Code39' }) method, we could
call that from within Template Toolkit and generate a base64 encoded inline
data URI.
I don't know if we'd want to add the base64 encoding to the method or have a
separate Template::Toolkit filter for that.
But that could be interesting.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #44 from David Cook --- In the near future, we'll have a large library using a more up-to-date version of the plugin to show an authenticated patron their barcode on the OPAC. If all goes well, I imagine that I will make an effort to add it to core. Right now, I use the API endpoint to generate the image, and then I use OpacUserJS to add a barcode icon to the top navbar and display the barcode in a modal. In the core version, I'd want to add the barcode icon and modal via the OPAC templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36176] [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36176 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #10 from wainuiwitikap...@catalyst.net.nz --- Backported to 22.05.x-security for 22.05.20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10060] Allow adding a branch parameter to the web-based self check to indicate library its used at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #26 from David Cook --- (In reply to Christopher Brannon from comment #23) > Then we need to do something like allow the library to navigate their self > check to /cgi-bin/koha/sco/sco-main.pl?branch=BRANCHCODE, which would tell > the page to login to the self check with the credentials from their page. > > AutoSelfCheckAllowed set to allow, but having nothing filled in for > AutoSelfCheckID or AutoSelfCheckPass could be the queue for Koha to check > for credentials under the branch, if specified in the URL. > > Thoughts? Locally we use /cgi-bin/koha/sco/sco-main.pl?branch=BRANCHCODE and then add a hidden input to each operation after that to include the branch. We also have AutoSelfCheckID and AutoSelfCheckPass as well still, but we suffix it with a branchcode so that each branch can have its own particular user and password. Nick's POC is interesting though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Zeno Tajoli changed: What|Removed |Added Text to go in the||A new endpoint of REST API release notes||/biblios, to merge two ||bibliographic records. You ||need to pass parameters ||with a json file. ||Complete ||endpoint: ||/api/v1/biblios/< ||biblo_id>/merge ||Parametes ||of json file: ||- ||biblio_id_to_merge ||(mandatory) ||- rules ||(optional) ||- ||framework_to_use (optional) ||- datarecord (optional) ||More info in the ||Swagger/OpenAPI ||Specification of the API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Zeno Tajoli changed: What|Removed |Added Documentation|A new endpoint | submission|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33036] REST API: Merge biblio records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 Zeno Tajoli changed: What|Removed |Added Documentation||A new endpoint submission|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36354] New: Action log viewer should give option to search by object type (item, biblio, borrowernumber, reserve_id sql.id etc)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36354 Bug ID: 36354 Summary: Action log viewer should give option to search by object type (item, biblio, borrowernumber, reserve_id sql.id etc) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org There is no way to specify what kind of object you want to be searching for. Some of the modules will limit to only one (report for example) but cataloging searches by itemnumber unless you go directly from the bib. An option to specify would be helpful . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36120] Add pickup locations to Bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 Kristi changed: What|Removed |Added CC||kkrue...@cuyahogalibrary.or ||g --- Comment #35 from Kristi --- For Martin: CCPL reviewed a video Lisette made of the pickup location option, and it looked as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36345] Deleting related things causes data loss for old_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 --- Comment #1 from Katrin Fischer --- I think this is the solution for bug 36101, but I am not sure about doubling up the data. We could imagine having a FK on deleteditems if we add the information on delete for example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36346] CheckReserves sometimes lead to bad behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36346 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |In Discussion --- Comment #2 from Nick Clemens --- I am not sure this is a bug - librarians sometimes want to be able to force a hold that will only fill later - for example a book on the display shelves might not fill holds, but it can fill holds after it moves, and they could use an itemtype for this control - new books are a similar example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29948] Display author information for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 Katrin Fischer changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #19 from Katrin Fischer --- It's been a long time - maybe I was worried that the field might be locked for manual input if the value is not linked to a vendor? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36340] Gender free type box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36340 --- Comment #1 from Katrin Fischer --- Hi Helen, the gender field is currently a free text field - can you explain a bit more what the difference would be and how the new field would be used? Could a patron attribute do the trick? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #15 from Tomás Cohen Arazi --- The submitted patches implement the requested feature, paired with the 'record sources' feature. Test plan: 1. Have bug 35919 applied 2. Apply this patchset 3. Create 2 'Record sources' in the Administration section * Record source A having edition disabled * Record source B having edition enabled Take notes on the record source ID for each. 4. Create a valid staff member (known user and pass) 5. Have the user set the following permissions: - catalogue (staff access) - editcatalogue => all subpermissions bug `edit_locked_records` 6. Login with the user on a private/incognito browser 7. Pick a record and browse to it on the private browser => SUCCESS: You can edit it 8. Make the record source for the chosen record be A: $ koha-mysql kohadev > UPDATE biblio_metadata SET record_source_id= WHERE biblionumber=; 9. Refresh the private window => SUCCESS: You are redirected to an error page 10. Search for the chosen record 11. Try to edit it => SUCCESS: The 'Edit record' link is greyed and cannot be used => SUCCESS: The greyed text has a tooltip explaining what's going on 12. Either change the record source to B, or just edit the record source A to allow editing 13. Refresh the record detail page => SUCCESS: The 'Edit record' link is no longer greyed, and the record can be edited => SUCCESS: Record edition is limited by source configuration 14. Verify superlibrarians can always edit such records Note: the only way to set the record source for now is the API, which is extensively tested on the provided tests (t/db_dependent/api/v1/biblios.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 163378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163378=edit Bug 31791: Add x-record-source-id header to POST /biblios This patch adds support for setting the record source on the API. It does so by adding support for a new header `x-record-source-id`. Setting the record source is restricted to patrons with the `set_record_sources` permission. A 403 error is returned on an attempt to set it without the correct permissions. The feature is documented on the spec. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! Tests cover the right use cases! 3. Play with Postman (or similar) 4. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791
--- Comment #13 from Tomás Cohen Arazi ---
Created attachment 163377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163377=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)
Sponsored-by: ByWater Solutions
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 163376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163376=edit Bug 31791: Limit editing locked records Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 163375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163375=edit Bug 31791: Add edit_locked_records and set_record_sources subpermissions Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 163374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163374=edit Bug 31791: Add record locking based on source Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 163373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163373=edit Bug 31791: Add TT plugin method Biblio.CanBeEdited Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 163372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163372=edit Bug 31791: DB changes Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 163371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163371=edit Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing This patch adds a convenient method that tells if the record is editable, according to it's record source. To test: 1. Apply this patch 2. Run: $ ktd k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! Use cases covered! 3. Sign off :-D Signed-off-by: Matt Blenkinsop Bug 31791: Rename can_be_edited -> source_allows_editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36331] Items that cannot be held are prevented renewal when there are holds on the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36331 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23540] Gender 'N' is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23540 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23609] Tie patron gender to an authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23609 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36340 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36340] Gender free type box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36340 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23609 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36340] Gender free type box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36340 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36345] Deleting related things causes data loss for old_reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16544] Changes to circ rules should be logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 --- Comment #9 from Noémie Labine --- ++1 :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36353] Ensure consistent empty selection style for guarantor relationship drop-downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36353 Laura Escamilla changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36353] Ensure consistent empty selection style for guarantor relationship drop-downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36353 --- Comment #1 from Laura Escamilla --- Created attachment 163370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163370=edit Bug 36353: Update relationship value so that it is blank and consistent with other forms To Test: 1. Choose a User Eligible for a Guarantor: 1. Modify the user profile to include a new guarantor. 2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box. 2. Select a User Eligible for a Guarantee: 1. Navigate to "Add Guarantee" in the top menu. 2. Verify that the guarantor field is automatically populated with the selected user. 3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.' 3. Apply Patch and Refresh the Page for Step 2: 1. After applying the patch, refresh the page for step 2. 2. Ensure that the empty option value for 'Relationship' is now displayed as blank. 4. Sign Off and Have a Great Day! # -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31804] Filtering not working when searching for a basket number on the receive orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31804 --- Comment #1 from Noémie Labine --- stil valid in 23.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32607] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Tomás Cohen Arazi changed: What|Removed |Added Blocks|31791 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 Tomás Cohen Arazi changed: What|Removed |Added Depends on|32607 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add record sources CRUD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36353] Ensure consistent empty selection style for guarantor relationship drop-downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36353 Laura Escamilla changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36353] New: Ensure consistent empty selection style for guarantor relationship drop-downs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36353 Bug ID: 36353 Summary: Ensure consistent empty selection style for guarantor relationship drop-downs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To Replicate: 1. Choose a user eligible for a guarantor. 1. Modify the user profile to include a new guarantor. 2. Upon selecting a guarantor, observe that the empty option in the 'Relationship' drop-down appears as a blank box. 2. Select a user eligible for a guarantee. 1. Navigate to "Add Guarantee" in the top menu. 2. The guarantor field is automatically populated with the selected user. However, note that the 'Relationship' drop-down displays the empty option as 'Empty record.' To Ensure Consistency: Both 'Relationship' drop-downs in the Patron Guarantor section should display a blank option consistently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36352] New: Allow agreements to have multiple vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36352 Bug ID: 36352 Summary: Allow agreements to have multiple vendors Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.dru...@gmail.com Reporter: billieanne.g...@frontier.edu CC: jonathan.dru...@gmail.com, jonathan.fi...@ptfs-europe.com, martin.renvo...@ptfs-europe.com, matt.blenkin...@ptfs-europe.com, pedro.amo...@ptfs-europe.com Some agreements may have multiple vendor relationships, for example, a title could be published by one entity but billed through another. It would be helpful to have both listed with the agreement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi changed: What|Removed |Added Attachment #163353|0 |1 is obsolete|| --- Comment #40 from Tomás Cohen Arazi --- Created attachment 163369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163369=edit Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing This patch adds a convenient method that tells if the record is editable, according to it's record source. To test: 1. Apply this patch 2. Run: $ ktd k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! Use cases covered! 3. Sign off :-D Signed-off-by: Matt Blenkinsop Bug 31791: Rename can_be_edited -> source_allows_editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35836] search_for_data_inconsistencies.pl - Search for loops in dependencies.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35836 --- Comment #26 from Matthias Le Gac --- Created attachment 163368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163368=edit Bug 35836: change | by , for the print We have guarantors who guarantee individuals who are, in turn, their guarantors. It is not clear if this should be allowed (bz35421), but it works, and has been working for a while. However, it breaks with bz12532, which produces a recursion that disrupts everything. Creation of a code in search_for_data_inconsistencies.pl that identifies loops in borrower_relationships. This must work in both directions for validation. This is the first bz I've made. Here's the test plan, let me know if there's anything to improve. Test Plan: 1 - Apply the patch. 2 - Create 4 different adult users. 3 - In the terminal, navigate to the database. 4 - Insert relationships into the "borrower_relationships" table: - Example: INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (1, 52, 53, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (2, 53, 54, 'father'); INSERT INTO borrower_relationships (id, guarantor_id, guarantee_id, relationship) VALUES (3, 54, 52, 'father'); - Ensure that the relationships created form a loop of guarantors. 5 - In the terminal, navigate to your Koha environment's git repository. 6 - Change directory to "cd misc/maintenance." 7 - Run the script to detect guarantor loops: ./search_for_data_inconsistencies.pl 8 - Verify that the output provides the borrower IDs involved in the guarantor loop. *Have fun creating intricate relationships to test the script's limit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 --- Comment #10 from Kyle M Hall --- Created attachment 163367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163367=edit Bug 36329: Make POST /transfer_limits/batch honor BranchTransferLimitsType This patch adds tests for the different cases of `BranchTransferLimitsType`. It also adds tests for the situation of the consumer sending both limit criterias on the request. The controller gets adjusted for this new behavior and the spec gets documentation added about this. Bonus: tests are added the right guidelines code, and BranchTransferLimitsType gets mocked to avoid failures due to existing data. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ qa => SUCCESS: All green, and tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 --- Comment #9 from Kyle M Hall --- Created attachment 163366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163366=edit Bug 36329: Miscelaneous spec fixes Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 Kyle M Hall changed: What|Removed |Added Attachment #163280|0 |1 is obsolete|| Attachment #163281|0 |1 is obsolete|| Attachment #163282|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 163365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163365=edit Bug 36329: Add missing return codes Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36329] Transfer limits should respect `BranchTransferLimitsType`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36329 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 Nick Clemens changed: What|Removed |Added Depends on||34487 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 Nick Clemens changed: What|Removed |Added Attachment #163362|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 --- Comment #2 from Nick Clemens --- Created attachment 163364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163364=edit Bug 36351: Add CSRF tokens to advanced cataloguing editor POST requests The editor uses ajax post requests to SVC api. Becuase these apis are XML based requests, they must be handled in the simplest way, by embedding the token as a header To test: 1 - Browse to Cataloguing->Advanced editor 2 - Fill out needed values and save 3 - 403 error 4 - Apply patch 5 - Reload and try agian, success! 6 - Edit and save again, success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 Kyle M Hall changed: What|Removed |Added Attachment #163124|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 163363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163363=edit Bug 36309: Make create_superlibrarian.pl output more useful In situations in which you are not familiar with all the Koha settings, and table structure, the fact this script just fails telling there's a broken FK is just not practical. We should capture those exceptions and display a useful message instead. This script does that. It adds some validations and some exception handling too. It prints a nice message about the bad value the user passed, and the valid values too! To test: 1. Run this on a fresh KTD: $ ktd --shell k$ perl misc/devel/create_superlibrarian.pl \ --userid tcohen \ --password tomasito \ --cardnumber 123456789 \ --categorycode POT \ --branchcode ATO => FAIL: It explodes with a MySQL exception message! 2. Apply this patch 3. Repeat 1 => SUCCESS: It tells you which value is wrong and what values you can pick to make the command work 4. Pick a valid value, and repeat => SUCCESS: Now the other value is wrong, a nice message is displayed! 5. Fix with a valid value and repeat => SUCCESS: Patron created! 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36309] create_superlibrarian.pl output could be more helpful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36309 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 --- Comment #1 from Nick Clemens --- Created attachment 163362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163362=edit Bug 36351: [failed] Use APIClient for posting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36351] New: CSRF Adjustments for Cataloguing editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36351 Bug ID: 36351 Summary: CSRF Adjustments for Cataloguing editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl koha-backend.js uses a lot of post requests to the svc api, we need to cover these. This si complicated by the fact that these apis return xml and not json as we usually do -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36334] Unnecessary JS code in member.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36334 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve performance of acquisitions start page when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 --- Comment #15 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve performance of acquisitions start page when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 --- Comment #11 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #81 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35921] Improve performance of acquisitions start page when there are many budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35921 Katrin Fischer changed: What|Removed |Added Summary|Improve perfs of|Improve performance of |acqui-home.pl when there|acquisitions start page |are many budgets|when there are many budgets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #39 from Tomás Cohen Arazi --- Marking NSO again, as I rewrote most of the Vue part of this dev. Some things I'm not comfortable with, but happy to follow the current standard practice for now, and evolve later. I kept the URL rewrite rule we originally submitted. I think requiring the trailing slash (/) if my rewrite avoids it, doesn't make sense. I can submit a bug for redoing the rest of the rewrites this way if required by QA (if this applies, as I'm not familiar with the little details the other modules might have making them requiring this). I also liked it more when the API client was instantiated globally instead on each place it is used. As it is a stateless object it should cause no issues. I moved it to match the current practice and will file a separate bug to restore the original implementation and discuss it in place. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 David Gustafsson changed: What|Removed |Added Attachment #163357|0 |1 is obsolete|| --- Comment #3 from David Gustafsson --- Created attachment 163361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163361=edit Bug 36350: Add caching for Objects::find Add subclass of Koha::Objects that provides caching for find. To test: 1) Ensure tests in t/db_dependend/Koha/Libraries.t passes 2) Ensure tests in t/db_dependent/Koha/ItemTypes.t passes Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Christine changed: What|Removed |Added CC||ch...@pascolibraries.org --- Comment #17 from Christine --- I completely agree with Christopher - we're in the same boat! We've received many preferences regarding the security concern since the initial creation of the thread (like expiring passwords, password expiration by patron category). It would be nice to allow us the flexibility to adjust security to our individual system needs. Also it is misleading to allow us to set minPasswordLength preference to 2 and not have clarification it will not function. It will only clarify the hard coded limit when you attempt to create an account with a 2 character PIN. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi changed: What|Removed |Added Attachment #163355|0 |1 is obsolete|| --- Comment #38 from Tomás Cohen Arazi --- Created attachment 163360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163360=edit Bug 35919: Add superlibrarian permission to Permissions.t Permissions.t was failing when running a jenkins build to another branch with this bug applied. Permissions.t was missing the permission for record sources and is now added in this patch Test plan: 1) prove t/Koha/Auth/Permissions.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 --- Comment #2 from David Gustafsson --- Tests are only added for Libraries and should provide full testing coverage even if used for other classes, but could add a stripped down testing suite also for ItemTypes, but don't know if it would accomplish very much as the caching is also implicitly tested through the other tests for that object type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #35 from Nick Clemens --- Created attachment 163359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163359=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load Add to SCOUserJS: http://localhost:8080/silk/famfamfam.png"/>
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens changed: What|Removed |Added Attachment #154691|0 |1 is obsolete|| Attachment #154692|0 |1 is obsolete|| --- Comment #34 from Nick Clemens --- Created attachment 163358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163358=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff Depends on|33881 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 David Gustafsson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 --- Comment #1 from David Gustafsson --- Created attachment 163357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163357=edit Bug 36350: Add caching for Objects::find Add subclass of Koha::Objects that provides caching for find. To test: 1) Ensure tests in t/db_dependend/Koha/Libraries.t passes Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36102] Protect login forms from CSRF attacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102 Nick Clemens changed: What|Removed |Added Blocks||36349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 [Bug 36349] Login for SCO/SCI broken by CSRF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34478] Full CSRF protection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Nick Clemens changed: What|Removed |Added Blocks||36349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 [Bug 36349] Login for SCO/SCI broken by CSRF -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 Nick Clemens changed: What|Removed |Added Depends on||34478, 36102 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36102 [Bug 36102] Protect login forms from CSRF attacks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 --- Comment #1 from Nick Clemens --- Created attachment 163356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163356=edit Bug 36349: Make sure CSRF token is included for all login scenarios To test: 1 - In KTD visit: http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 2 - Everything should be set for auto self check user etc, just login as a patron If not (or not using KTD) setup a self check user, enable SCO and SCI, set self check patron system preferences, then login with patron 3 - 403 Error 4 - Repeat with sco: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 5 - Apply patch, restart all 6 - Try again, both should be successful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 163355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163355=edit Bug 35919: Add superlibrarian permission to Permissions.t Permissions.t was failing when running a jenkins build to another branch with this bug applied. Permissions.t was missing the permission for record sources and is now added in this patch Test plan: 1) prove t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 163354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163354=edit Bug 35919: Add cypress tests This patch adds Cypress tests for the `record sources` CRUD as required by QA. I tried to cover all the UI interactions and behaviours. To test: 1. Have all the patches applied 2. Run: $ ktd --shell k$ cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 163353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163353=edit Bug 35919: Add Koha::Biblio::Metadata->can_be_edited prove t/db_dependent/Koha/Biblio/Metadata.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 163352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163352=edit Bug 35919: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 163351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163351=edit Bug 35919: Add record sources admin page This patch introduces a Vue.js based record sources managing page. To test it: 1. Apply this patch 2. Build the Vue.js stuff: $ ktd --shell k$ yarn js:build k$ restart_all 3. On the staff interface, go to Administration > Record sources 4. Play with the interface and the offered actions => SUCCESS: Things go well 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 163350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163350=edit Bug 35919: Add /record_sources endpoints This patch introduces endpoints for managing record sources. This is done on top of Koha::RecordSource(s) following the current coding style. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/record_sources.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 163349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163349=edit Bug 35919: Add Koha::RecordSource(s) classes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36350] New: Add subclass of Koha::Objects that provides caching for find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350 Bug ID: 36350 Summary: Add subclass of Koha::Objects that provides caching for find Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org At our library we have traced some performance issues to repeated find calls for a number of object types. To address this patch introduces a subclass for Koha::Object that if extended instead of the former provides a cached version of find. This patch enables caching for ItemTypes and Libraries which I believe are called repeatedly for the same objects much than the others. Other possible candidates are Patrons and Items but will have to do some more digging to find out if it makes much a difference. It's easy to enable/disable by just switching out the base class for the Koha::Object and Koha::Objects derived classes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35919] Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161577|0 |1 is obsolete|| Attachment #161578|0 |1 is obsolete|| Attachment #161579|0 |1 is obsolete|| Attachment #161580|0 |1 is obsolete|| Attachment #161581|0 |1 is obsolete|| Attachment #161582|0 |1 is obsolete|| Attachment #161583|0 |1 is obsolete|| Attachment #162489|0 |1 is obsolete|| Attachment #162594|0 |1 is obsolete|| Attachment #162595|0 |1 is obsolete|| Attachment #162599|0 |1 is obsolete|| --- Comment #30 from Tomás Cohen Arazi --- Created attachment 163348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163348=edit Bug 35919: DB changes This patch adds: * A new table: `record_sources`. * A new user permission: `manage_record_sources`. * A FK on record_sources.recour_source_id on the biblio_metadata tables Record sources will contain a name and (for now) a flag telling if records from the specific source can be manually edited. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36349] New: Login for SCO/SCI broken by CSRF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36349 Bug ID: 36349 Summary: Login for SCO/SCI broken by CSRF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org bug 36102 / bug 34478 added the csrf token to opac-auth for patron login, however, it isn't used for SCO/SCI logins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 --- Comment #32 from Nick Clemens --- Created attachment 163347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163347=edit Bug 34611: Confirm run if pseudonymized transactions found and add verbose feedback Signed-off-by: AFHDubCoLib Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 --- Comment #31 from Nick Clemens --- Created attachment 163346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163346=edit Bug 34611: Add a script to pseudonymize statistics from before a given date This script takes a date parameter in SQL format and pseudonymizes all statistics found before this date. Only values that can be found will be added, i.e. no deleted patron or item info will be present. Additionally - the values stored will be the current values from patrons and items, so some info will be approximate, much as it is when joining from the statistics table for reporting. To test: 1 - Perform some issues/returns/renewals/on-site checkouts 2 - Make sure Pseudonymization is disabled 3 - perl misc/maintenance/pseudonymize_statistics.pl 4 - Script ends and reports that preference is not active 5 - Enable the pref, and choose some borrower and item fields NOTE: See bug 28911 if you need a bcrypt key for your koha-conf.xml 6 - perl misc/maintenance/pseudonymize_statistics.pl 7 - sudo koha-mysql kohadev 8 - SELECT * FROM pseudonymized_transactions 9 - Confirm data is correctly stored 10 - DELETE FROM pseudonymized_transactions; 11 - UPDATE statistics SET datetime = '2023-01-01 00:00:00'; 12 - perl misc/maintenance/pseudonymize_statistics.pl -b "2022-12-31 23:59:59"; 13 - SELECT * FROM pseudonymized_transactions; 14 - Confirm no entries were made 15 - Select different options in Pseudonmyization prefs, including borrower attributes This wil require defining an attribute that can be kept for pseudonymization 16 - Confirm options are correctly pseudonymized Signed-off-by: AFHDubCoLib Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 --- Comment #30 from Nick Clemens --- Created attachment 163345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163345=edit Bug 34611: Add pseudonymize routine to Koha::Statistics This patch adds a new routine to pseudonymize a statistic and adjusts C4::Stats to use this new routine. Additionally Koha::PseudonymizedTransaction->new_from_statistic is updated to check for the existence of objects before using them (in the case of older stats where things may have been deleted) Tests are added and can be run using: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/PseudonymizedTransaction.t \ t/db_dependent/Koha/Pseudonymization.t => SUCCESS: New tests pass, old tests keep passing Signed-off-by: AFHDubCoLib Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 Nick Clemens changed: What|Removed |Added Attachment #159909|0 |1 is obsolete|| Attachment #159910|0 |1 is obsolete|| Attachment #159911|0 |1 is obsolete|| Attachment #159912|0 |1 is obsolete|| --- Comment #29 from Nick Clemens --- Created attachment 163344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163344=edit Bug 34611: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: AFHDubCoLib Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34611] Add a script for pseudonymizing existing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34611 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 163343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163343=edit Bug 35129: Return 400 if _per_page=0 passed This patch adds a safe guard for when consumers pass _per_page=0 to endpoints. This condition is checked for on a centralized place and avoid reaching the controller in such scenarios that would provoke a division by zero exception. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/pagination.t => FAIL: We expect a 400, but get a 500 instead 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No more explosions for this! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35129] REST API: _per_page=0 crashes on Illegal division by zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35129 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 163342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163342=edit Bug 35129: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
