[Koha-bugs] [Bug 36437] Add publication year facet to Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36437 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35138] Elasticsearch - manage facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36422] Triggered holds should not display information about transferring because the item is in a rotating collection.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36422 Lucas Gass changed: What|Removed |Added Summary|Triggered waiting holds |Triggered holds should not |should not display |display information about |information about |transferring because the |transferring because the|item is in a rotating |item is in a rotating |collection. |collection. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36448] New: aqplan showing AV cat starting with "A" (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36448
Bug ID: 36448
Summary: aqplan showing AV cat starting with "A" (?)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: jonathan.dru...@gmail.com
QA Contact: testo...@bugs.koha-community.org
122 my $sth = $dbh->prepare("select distinct category from authorised_values
where category like 'A%' ")
What is that?!
http://localhost:8081/cgi-bin/koha/admin/aqplan.pl?budget_period_id=1=MONTHS
On the left " Select planning type:" you can see "By AR_CANCELLATION". That
does not make any sense!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060 --- Comment #15 from Lucas Gass --- Created attachment 164036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164036=edit Bug 36060: (follow-up) Remove unnessesary code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36060] If issues table includes overdues Renew selected items button is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36060
--- Comment #14 from Lucas Gass ---
(In reply to Victor Grousset/tuxayo from comment #12)
> Found unused variables left:
> var renewchecked
> var checkinchecked
>
> ---
>
> minor thing: I don't get how `$("#RenewChecked").on("click"` works correctly
> without CheckRenewCheckinBoxes() when `$("#CheckinChecked").on("click"`
> needs it.
Neither should actually need it because CheckRenewCheckinBoxes() is called in
RefreshIssuesTable(). We also don't need the following in either of those on
click functions:
$('#RenewChecked, #CheckinChecked').prop('disabled' , true );
Thanks Victor!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@gmail.com, ||kyle.m.h...@gmail.com, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36447] New: Circ rules slow to load when many itemtypes and categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447
Bug ID: 36447
Summary: Circ rules slow to load when many itemtypes and
categories
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Staff interface
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
It seems that we loop all categories and item types to build the circ matrix:
169
170 [% SET row_count = 0 %]
171 [% FOREACH c IN categorycodes %]
172 [% SET c = '' UNLESS c.defined %]
173 [% FOREACH i IN itemtypes %]
This means that when we have a large number of both, the page becomes
increasingly slow:
Try loading the page several times, notings the load time
Then:
perl -e 'use t::lib::TestBuilder; my $builder=t::lib::TestBuilder->new(); for(
my $i=0;$i<50;$i++){ $builder->build({ source=>"Itemtype"}); }'
Note load times, then:
perl -e 'use t::lib::TestBuilder; my $builder=t::lib::TestBuilder->new(); for(
my $i=0;$i<50;$i++){ $builder->build({ source=>"Category"}); }'
Note load times, then run each again
NOte load times, I saw around 15 seconds when I had ~100 of each
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26744] Log changes to extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #12 from David Gustafsson --- I actually don't know since I'm not the original author of this patch, but I guess there is sole technical reasons. My guess would be it's harder to figure out a hood way of representing the change, and especially tricky if you just want one log message when adding multiple instances of a repeatable field since the stores method would be called repeatedly for each existing and added change. If the logging was performed in the extended_attributes method it could be doable, but that might not catch all modifications and think there might be more patrons performing modification that would have to be handled as well. Can ask my collegue tomorrow about this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #16 from Matthias Le Gac --- Would it be possible for you to make the file you import available? Because when I run the test with the file provided by Hammat, it works correctly. I agree with you, I'll see if I can improve the display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36446] New: Library specific shelving locations disappear when logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36446 Bug ID: 36446 Summary: Library specific shelving locations disappear when logged in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org If a shelving location is associated with specific branches, when you go to advanced search in the OPAC, and then on the shelving location tab, you can see all shelving locations when not logged in, but if you are logged in, and your branch is not associated with that shelving location, it disappears from the list. Should there be a setting to determine how this works? It seems that shelving locations should not disappear from this list at all, especially if you are allowed to borrow from that library. For the sake of simplicity, I think that all shelving locations should show here, regardless of what branch is associated with it. If there are borrowing or hold restrictions, you will find out at the appropriate place. But this should not act in this manner, in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36445] New: Removing email address has no effect on clubs that require an email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36445 Bug ID: 36445 Summary: Removing email address has no effect on clubs that require an email address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a patron is enrolled in a club that requires an email address, and then the email address is completely remove from the patron account, nothing changes with the club. There should be some kind of warning that the patron is enrolled in clubs that require an email address. Maybe the clubs tab needs to turn red, and then a message next to enrolled clubs that require an email address needs to have text in red next to it saying "Email address required". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36444] Place Holds for Patrons Purchase Suggestion when not using Acquisitions Process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36444 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26744] Log changes to extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass changed: What|Removed |Added Attachment #163959|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 164035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164035=edit Bug 26744: Only log if BorrowersLog syspref is enabled Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26744] Log changes to extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass changed: What|Removed |Added Attachment #163958|0 |1 is obsolete|| --- Comment #10 from Lucas Gass --- Created attachment 164034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164034=edit Bug 26744: Log changes to extended patron attributes Log non-repeatable attributes and only log changes and creations, not deletions. When changed, attributes are first all deleted, then the relevant ones are recreated. This patch catches all deletions, and checks against them in the creation phase, logging only the attributes that have changed (with before/after content). This makes it impossible to log actual deletions. To test: 1) Ensure tests in t/db_dependent/Koha/Patron/Attribute.t passes Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26744] Log changes to extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26744] Log changes to extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 --- Comment #9 from Lucas Gass --- This works as described so I will sign-off. Why not log repeatable attributes as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34291] Clubs requiring email just don't show if there is no email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34291 --- Comment #2 from Christopher Brannon --- 1. Create a club that requires an email address to enroll. a. Go to tools --> Patron clubs b. Create a template (New club template): c. Name: Book Club Template d. Require valid email address: enabled e. Save f. Create a club (New club --> Book Club Template): g. Name: Test Club h. Save 2. Go to patron that has an email address. a. Look at the clubs tab. b. Verify the Test Club shows. 3. Remove email address from patron account. a. Look at the clubs tab. b. Verify that the Test Club is no longer visible. This is a confusing aspect of clubs that one of our staff members just got hung up on. There is nothing to indicate that the club isn't showing because the patron doesn't have an email address. AT THE VERY LEAST, the club should show, but be greyed out, and instead of an enroll button, it should say "Patron needs and email address in order to enroll" or something along those lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36444] New: Place Holds for Patrons Purchase Suggestion when not using Acquisitions Process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36444 Bug ID: 36444 Summary: Place Holds for Patrons Purchase Suggestion when not using Acquisitions Process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com With the passing of the bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595, holds can now be placed on purchase suggestions, however, this only applies to purchase suggestions that are ordered through Acquisitions. It would be nice if this process could work without using the Acquisitions Module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434 --- Comment #6 from Aleisha Amohia --- In our case we have a library wanting to use their OPAC just for their archives collection. They use VuFind on top of Koha for searching their regular collection. By default, we want the OPAC to exclude the regular collection from searches. This isn't as simple as using OpacHiddenItems because if the record doesn't have holdings then it won't be used. We can't filter based on item types and collection codes because archives items still use these, just like the normal collection. We also can't use OpacSuppression or the 942$n on the regular holdings or they'll be excluded from the VuFind harvest. Hopefully that explains the use case. Open to ideas on better ways to do this, for e.g. we could put the OPACAlwaysSearchKeyword back in the search history so the user knows about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34823] Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 --- Comment #6 from Lucas Gass --- (In reply to Emily Lamancusa from comment #5) > There's also an edge case when a record has item groups defined, but all of > the item groups are empty. Could this fix be adjusted to cover that case > too? Maybe by filtering the search itself to exclude empty item groups, and > bumping it up in the code a bit? I must be missing something because I thought that is what this patch is correcting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 --- Comment #2 from Aleisha Amohia --- This fix did not work unfortunately, will propose an alternative -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 --- Comment #1 from Laura Escamilla --- Created attachment 164033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164033=edit Bug 36443: Add a fax field / column to the batch patron modification tool To test: 1. Create or modify an existing patron account so that they have a value in their fax number field. 2. Go to Tools > Batch patron modification 1. Add the patron card number, or borrower number into the modification tool and click on continue. There is no option for modifying fax numbers, nor are fax numbers visible in the modification table. 3. Apply the patch and restart_all 4. Repeat step 2 1. A column for ‘Fax’ is now visible after ‘Other phone’ 2. Test the ‘Fax’ field by clearing out the field with the checkbox. ‘Checking the box right next to the label will disable the entry and delete the values of that field on all selected patrons.’ 3. Test the ‘Fax’ field by updating the value with a new number 5. Sign off and have a wonderful day :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Laura Escamilla changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34823] Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #5 from Emily Lamancusa --- There's also an edge case when a record has item groups defined, but all of the item groups are empty. Could this fix be adjusted to cover that case too? Maybe by filtering the search itself to exclude empty item groups, and bumping it up in the code a bit? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Lucas Gass changed: What|Removed |Added Attachment #164028|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 164032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164032=edit Bug 36442: Fix typo in edifact list To test: 1) Create an edifact message 2) Go to the acquisition EDIFACT messages page and verify the basket link is broken 3) Apply patch 4) Verify the link now works Sponsored-by: Gothenburg University Library Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Laura Escamilla changed: What|Removed |Added Status|REOPENED|ASSIGNED Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Laura Escamilla changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] Add 'Fax' to Batch patron modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Laura Escamilla changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Summary|Add |Add 'Fax' to Batch patron ||modification tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- Can you explain the use case for this a bit more? Personally Im not a fan of "secertly" doing things that effect patron's searches. I think this hurts findability/disoverability for patrons. Maybe outlining a use case for us will help understand why this is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36443] New: Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36443 Bug ID: 36443 Summary: Add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Maude changed: What|Removed |Added CC||maude.boudr...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36434] Use a keyword that will be secretly included in all OPAC bibliographic and authority searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36434 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #4 from Donna --- Why couldn't the term just be included as a very specific subject heading or authority? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa changed: What|Removed |Added Attachment #164020|0 |1 is obsolete|| --- Comment #10 from Emily Lamancusa --- Created attachment 164031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164031=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Emily Lamancusa changed: What|Removed |Added Attachment #164019|0 |1 is obsolete|| --- Comment #9 from Emily Lamancusa --- Created attachment 164030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164030=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #12 from Lucas Gass ---
Lots of issues here.
1. renew.pl now fails with this error:
Could not compile /kohadevbox/koha/circ/renew.pl: Global symbol "$borrower"
requires explicit package name (did you forget to declare "my $borrower"?) at
/kohadevbox/koha/circ/renew.pl line 67.
2. Looks like some debugging code is leftover
3. request.pl has a whole block of code commented out starting with:
# elsif ( C4::Context->preference('AllowHoldPolicyOverride') ){
4. Why remove the check for "unless( $skip_record_index )" in AddRenewal? I
think there are times when we want to skip indexing.
5. FAILC4/Circulation.pm
FAIL pod coverage
POD is missing for CanBookBeReturned
6. FAILcirc/renew.pl
WARN tidiness
The file is less tidy than before (bad/messy lines before: 28,
now: 44)
FAIL valid
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$issue" requires explicit package name (did you
forget to declare "my $issue"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
Global symbol "$borrower" requires explicit package name (did
you forget to declare "my $borrower"?)
circ/renew.pl had compilation errors.
7. Changes to CanBookBeIssued and AddRenewal probably need test coverage.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Matthias Le Gac changed: What|Removed |Added Attachment #163876|0 |1 is obsolete|| --- Comment #18 from Matthias Le Gac --- Created attachment 164029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164029=edit Bug 36111: removes display of fields 856y3z if not 856u Test plan: 1. Add 856$h to MARC editor 1.1. Go to Administration > MARC bibliographic frameworks 1.2. Next to Default framework, click Actions > MARC structure 1.3. Search for field 856 1.4. Click Actions > Edit subfields 1.5. Click h 1.6. Check the Editor box 1.7. Click Save changes 2. Catalog a new record with a random URL in 856$h 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c, 245$a, 942$c) 2.4. Go to tab 8 and enter a value in 856$h 2.5. Click Save (No need to add an item) 3. Search for the title in the staff interface (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 3.1. Try to click the link --> Blank page 4. Access the detailed record in the staff interface --> Notice it says "Online resources: Click here to access online" 4.1. Try to click the link --> Blank page 5. Search for the title in the opac (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 5.1. Try to click the link --> Blank page 6. Access the detailed record in the opac --> Notice it says "Online resources: Click here to access online" 6.1. Try to click the link --> Blank page 7. Edit the item and add a text in field 856$y 8. Access the detailed record in the staff interface --> Notice it says what you put in 856$y field 9. Apply the patch 10. Replay steps 3 through 6, but this time, the "Online resources" field should not be present. 11. Replay steps 7 through 8, but this time, what you put in 856$y field should not be present. 12. Edit the item and add a url in field 856$u 13. Replay steps 3 through 6, but this time, clicking on the link should take you to the URL specified in the 856$u field. 14. Replay steps 7 through 8, but this time, what you put in 856$y field should be present and clicking on the link should take you to the URL specified in the 856$u field. Before the second patch, if you put something in the 856$y field and there was nothing in the 856$u field, the text was displayed. Now, with the second patch, the problem has been solved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 David Gustafsson changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 David Gustafsson changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff --- Comment #2 from David Gustafsson --- Attached a test case, but don't know if its really necessary to test since a very trivial patch and should be obvious just looking at the code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 --- Comment #1 from David Gustafsson --- Created attachment 164028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164028=edit Bug 36442: Fix typo in edifact list To test: 1) Create an edifact message 2) Go to the acquisition EDIFACT messages page and verify the basket link is broken 3) Apply patch 4) Verify the link now works Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36442] New: Fix typo in edifact list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36442 Bug ID: 36442 Summary: Fix typo in edifact list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org This patch fixes a typo in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt for the basketno get parameter resulting in a broken link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 --- Comment #5 from David Gustafsson --- Created attachment 164027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164027=edit Bug 36441: Add comment explaining why replacing the DBIx call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 David Gustafsson changed: What|Removed |Added Attachment #164025|0 |1 is obsolete|| --- Comment #4 from David Gustafsson --- Created attachment 164026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164026=edit Bug 36441: Improve performance of Item::is_bundle Perform count using DBI-query in Item::is_bundle to significantly improve performance. To test: 1) Go to the details page of a bibio with a large number of holdings holdings, preferably more than a hundred, and take note of page load time. 3) Apply patch 4) Reload the page and take note of page load time. 5) There should be an improvement of about 10-15% 6) Ensure tests in t/db_dependent/Koha/Item.t pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 David Gustafsson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #17 from Matthias Le Gac --- Ok I understand I will change the plan test to test the fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 --- Comment #3 from David Gustafsson --- Created attachment 164025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164025=edit Bug 36441: Improve performance of Item::is_bundle Perform count using DBI-query in Item::is_bundle to significantly improve performance. To test: 1) Go to the details page of a bibio with a large number of holdings holdings, preferably more than a hundred, and take note of page load time. 3) Apply patch 4) Reload the page and take note of page load time. 5) There should be an improvement of about 10-15% 6) Ensure tests in t/db_dependent/Koha/Item.t pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 --- Comment #2 from David Gustafsson --- Created attachment 164024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164024=edit After -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 --- Comment #1 from David Gustafsson --- Created attachment 164023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164023=edit Before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36441] New: Improve performance of Item::is_bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36441 Bug ID: 36441 Summary: Improve performance of Item::is_bundle Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org For a biblio with a large number of holdings (which could be the case for serials for example) Item::is_bundle is one of the main culprits in terms of performance. I know it's usually frowned upon substituting DBIx queries with the DBI-equivalent, but think there are few other option in this case and should be very unlikely to cause any future regressions. Attached before and after flamegraphs to illustrate the difference in performance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #11 from Matthias Le Gac --- Created attachment 164022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164022=edit Bug 9762: fix log for test 10 13 14 15 16 17 To test: --After each step, a message will be displayed in the action_logs table and in Tools > Log viewer -- Circulation -- Checking out 1) Check out an item that is age-restricted (AgeRestrictionOverride syspref) 2) Check out an item that has a “not for loan” status (AllowNotForLoanOverride syspref) 3) Check out an item that has a “lost” status (IssueLostItem syspref) 4) Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) 5) Check out an item to a patron who is not allowed to borrow this item type 6) Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) 7) Check out an item on hold for someone else 8) Check out an item on hold ready for pickup by someone else 9) Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) 10) Check out to a patron who has restrictions Circulation -- Checking in 11) Ignore a hold upon check in 12) Ignore a hold and transfer upon check in Circulation – Renewing 13) Renew an item on hold for someone else (AllowRenewalOnHoldOverride syspref) 14) Renew an item that has reached the maximum number of renewals (AllowRenewalLimitOverride syspref) Holds 15) Place a hold for a patron who is not allowed to place this item type on hold (AllowHoldPolicyOverride syspref) 16) Place a hold for a patron who has reached the maximum number of holds 17) Place an item-level hold when rules dictate that this is not allowed (In circulation rules put "On shelf holds allowed" to "If any unavailable") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9762] Log circulation overrides
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36439] Column settings are missing on holds-to-pull table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36439 Lucas Gass changed: What|Removed |Added Attachment #164007|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 164021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164021=edit Bug 36439: Remove duplicate section in columns_settings The patch for bug 33575 was carelessely applied so the holds section was overwritten by a duplicated section which cause the table configuration for the holds-to-pull table to be missing. Test plan: * Place a hold on a record that has items (so there is at least one hold to pull) * Go to the page "holds to pull" and verify that the column settings are present to the left above the table ( Columns). NOTE: the column settings are cached, so you need to reset memcached between tests if you want to test with and without the patch. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36439] Column settings are missing on holds-to-pull table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36439 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35345] Pass custom SQL to rebuild_elasticsearch.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35345 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Failed QA Assignee|koha-b...@lists.koha-commun |d...@plix.at |ity.org | --- Comment #9 from Emily Lamancusa --- This is a great idea! However, the patch contains many Perltidy/formatting changes that are unrelated to the enhancement. Please separate out your code changes into one patch, and the Perltidy/formatting changes into a second patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34823] Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Lucas Gass changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 --- Comment #8 from Lucas Gass --- Rebased for current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass changed: What|Removed |Added Attachment #162852|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 164020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164020=edit Bug 36227: Remove item group option if there are no items To test: 1. Test from OPAC. Any item group without items in it should not display as an option in the "Request specific item group:" dropdown Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36227] No warning if placing hold on item group with no items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36227 Lucas Gass changed: What|Removed |Added Attachment #162851|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 164019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164019=edit Bug 36227: Add warning when item group has no holdable items To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Find a bib and add an item group but do not attach any items to the item group. 3. Place a hold from the staff interface. 4. Under Hold next available item from an item group you see the option for your item group, select it and place the hold. 5. It's a hold that can not be filled 6. APPLY PATCH 7. How on the hold page under Hold next available item from an item group there is a 3rd column called 'Holdable items'. 8. Your item group, without any items, should have a disabled radio button and a warning "No holdable items in this item group." 9. Add items to your item group. 10. Now on the hold page in the new 'Holdable items' you should see links for each item, make sure those links work. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 Lucas Gass changed: What|Removed |Added Attachment #164017|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 164018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164018=edit Bug 36440: Add edit buttons for patron flags in attention box Add edit buttons for patron flags in attention box and show flag status in detail view To test: 1) Go to patron details for a patron with address in doubt and card lost flags set and verify these are highlighted under "Library use" and the patron messages has edit buttons that links to the modfiy patron page. Sponsored-by: Gothenburg University Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from David Gustafsson --- Yes, you are right. This has now been fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 David Gustafsson changed: What|Removed |Added Attachment #164012|0 |1 is obsolete|| --- Comment #5 from David Gustafsson --- Created attachment 164017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164017=edit Bug 36440: Add edit buttons for patron flags in attention box Add edit buttons for patron flags in attention box and show flag status in detail view To test: 1) Go to patron details for a patron with address in doubt and card lost flags set and verify these are highlighted under "Library use" and the patron messages has edit buttons that links to the modfiy patron page. Sponsored-by: Gothenburg University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35812] Should specify canonical URLs to help search indexers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35812 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- This conflicts a bit with Bug 33317, which allows librarians to set the `meta name="robots"` tag via system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34823] Do not show item group drop-down if there are no item groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34823 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |BLOCKED CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #4 from Emily Lamancusa --- Moving this to BLOCKED for now, since the dependent patch does not apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36294] Replace inaccurate use of "book" in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36294 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Passed QA CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36294] Replace inaccurate use of "book" in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36294 Emily Lamancusa changed: What|Removed |Added Attachment #163632|0 |1 is obsolete|| --- Comment #3 from Emily Lamancusa --- Created attachment 164016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164016=edit Bug 36294: Replace 'book' in system preference descriptions Some system preference descriptions have been updated in order to replace "books" with items, checkouts or bibliographic records. To test: * Check system preference descriptions for following system preferences with and without the patch applied: * virtualshelves * AutoSwitchPatron * SyndeticsSeries * OPACFineNoRenewals * OpacRenewalAllowed * If they read better than before, sign off :) Signed-off-by: Laura Escamilla Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36439] Column settings are missing on holds-to-pull table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36439 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se |ity.org | Version|23.11 |master CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass --- David, The links for each button lead to a 404 error. You need the full path I think: /cgi-bin/koha/members/memberentry.pl? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 David Gustafsson changed: What|Removed |Added Attachment #164010|0 |1 is obsolete|| --- Comment #3 from David Gustafsson --- Created attachment 164015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164015=edit Patron details -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Lucas Gass changed: What|Removed |Added Attachment #164009|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 164014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164014=edit Bug 36409: Fix capitalization for AcquisitionsDefaultEMailAddress and SerialsDefaultEMailAddress Replace all instances in files with correct capitalization for the sysprefs: SerialsDefaultEMailAddress AcquisitionsDefaultEMailAddress Test plan: 1. Apply patch 2. Run database update 3. Go to Administration > System Preferences > Acquisitions -> Confirm correct capitalization for AcquisitionsDefaultEmailAddress (should be "Email", not "EMail") 4. Go to Administration > System Preferences > Serials -> Confirm correct capitalization for SerialsDefaultEmailAddress (should be "Email", not "EMail") 5. Use git grep to confirm no remaining instances of "EMail" in the code (other than the new dbrev, original dbrev and original release notes) e.g. git grep --files-with-matches "EMail" 6. Confirm the test plan for Bug 20755 still works Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Lucas Gass changed: What|Removed |Added Attachment #164008|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 164013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164013=edit Bug 36409: Dbrev for existing installations Dbrev to change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Lucas Gass changed: What|Removed |Added QA Contact|emily.lamancusa@montgomeryc |testo...@bugs.koha-communit |ountymd.gov |y.org Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 David Gustafsson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 --- Comment #2 from David Gustafsson --- Created attachment 164012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164012=edit Bug 36440: Add edit buttons for patron flags in attention box Add edit buttons for patron flags in attention box and show flag status in detail view To test: 1) Go to patron details for a patron with address in doubt and card lost flags set and verify these are highlighted under "Library use" and the patron messages has edit buttons that links to the modfiy patron page. Sponsored-by: Gothenburg University -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35599] Pronouns and HidePersonalPatronDetailOnCirculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass changed: What|Removed |Added Attachment #164006|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 164011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164011=edit Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35599] Pronouns and HidePersonalPatronDetailOnCirculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35599] Pronouns and HidePersonalPatronDetailOnCirculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- Trivial change that looks good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 --- Comment #1 from David Gustafsson --- Created attachment 164010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164010=edit Patron details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36440] New: Add edit buttons for patron flags in attention box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36440 Bug ID: 36440 Summary: Add edit buttons for patron flags in attention box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: glask...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This patch adds edit buttons for patron flags in attention box and show flag status in detail view. See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36431] SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #4 from Kyle M Hall --- > We are not talking about the same situation. You describe a valid case where > a transfer exists. But I am looking at the situation where the item is in > another branch and has been checked out and checked in again. In that case > WasTransfered can be set also (depending on AutomaticItemReturn): Would you be able to write up a test plan demonstrating the incorrect behavior and what should be happening instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35334] Give ability to add context to custom Pages in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35334 Chris Rowlands changed: What|Removed |Added CC||chris.rowlan...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34863] Allow definition of custom url for pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34863 Chris Rowlands changed: What|Removed |Added CC||chris.rowlan...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34867] Select multiple libraries in Tools (News, HTML customizations and Pages)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34867 Chris Rowlands changed: What|Removed |Added CC||chris.rowlan...@nhs.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Michelle Spinney changed: What|Removed |Added CC||mspin...@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com --- Comment #3 from Marie-Luce Laflamme --- This feature would be a huge plus! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC Modification Templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Emily Lamancusa changed: What|Removed |Added Severity|normal |trivial Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 Emily Lamancusa changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 --- Comment #2 from Emily Lamancusa --- Created attachment 164009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164009=edit Bug 36409: Fix capitalization for AcquisitionsDefaultEMailAddress and SerialsDefaultEMailAddress Replace all instances in files with correct capitalization for the sysprefs: SerialsDefaultEMailAddress AcquisitionsDefaultEMailAddress Test plan: 1. Apply patch 2. Run database update 3. Go to Administration > System Preferences > Acquisitions -> Confirm correct capitalization for AcquisitionsDefaultEmailAddress (should be "Email", not "EMail") 4. Go to Administration > System Preferences > Serials -> Confirm correct capitalization for SerialsDefaultEmailAddress (should be "Email", not "EMail") 5. Use git grep to confirm no remaining instances of "EMail" in the code (other than the new dbrev, original dbrev and original release notes) e.g. git grep --files-with-matches "EMail" 6. Confirm the test plan for Bug 20755 still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36409] System preference name consistency - change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36409 --- Comment #1 from Emily Lamancusa --- Created attachment 164008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164008=edit Bug 36409: Dbrev for existing installations Dbrev to change EMail to Email for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31988] manager.pl is only user for "Catalog by item type" report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31988 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00,23.11.04 |24.05.00,23.11.04,23.05.10, released in||22.11.16,22.05.20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
