[Koha-bugs] [Bug 37857] Unable to select type "Geo point" or "Call number" when adding a search field

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37857 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com

[Koha-bugs] [Bug 37914] Forms for budget planning filters and export should GET rather than POST

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37914 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com

[Koha-bugs] [Bug 37767] Fix forms that POST without an op in Authority types

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37767 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com

[Koha-bugs] [Bug 37769] Fix forms that POST without an op in currency administration

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37769 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com

[Koha-bugs] [Bug 37887] OPAC password recovery needs to use a cud- op while POSTing new password

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37887 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com

[Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 --- Comment #51 from Katrin Fischer --- Hi everyone, first of all thanks for the work you put into resolving this. After some back and forth and discussion I have decided to push Jonathan's patch which is the smaller change in a way.

[Koha-bugs] [Bug 37903] Timezone ignored when passing rfc3339 formatted date (POST, PUT, PATCH)

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37903 --- Comment #8 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #6) > Hi, I'm a bit confused here. I understand where this is coming from, but > POST /checkouts doesn't have any datetime parameter that would get p

[Koha-bugs] [Bug 37903] Timezone ignored when passing rfc3339 formatted date (POST, PUT, PATCH)

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37903 Jonathan Druart changed: What|Removed |Added Depends on||37902 --- Comment #7 from

[Koha-bugs] [Bug 37902] Timezone ignored when passing rfc3339 formatted date (search 'q')

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37902 Jonathan Druart changed: What|Removed |Added Blocks||37903 Referenced Bugs:

[Koha-bugs] [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 --- Comment #9 from Katrin Fischer --- I have kept the wiki changes, but added the use statement on the second. I think it's just a bit work in progress now and good to get more eyes on it to find a good new best practice. -- You a

[Koha-bugs] [Bug 23415] Notify patron fines when renewing

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #102 from Katrin Fischer --- I am sorry to hear this Emmi, I hope we didn't make it harder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-

[Koha-bugs] [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 --- Comment #8 from Julian Maurice --- I generally write the "happy path" in the try block, like this: try { $dbh->do(q{}); say_success( $out, "Database modification was successful!" ); } catch { say_failure( $out, "Data

[Koha-bugs] [Bug 23415] Notify patron fines when renewing

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 --- Comment #101 from Emmi Takkinen --- Code, especially in checkouts.js, has changed so much since last rebase that it's kinda tricky to sort out where everything goes. So this probably needs a lot of rework. I'll probably need to p

[Koha-bugs] [Bug 37930] Change how we handle authorised values in Vue

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37930 --- Comment #5 from Jonathan Druart --- I think we should keep one file per app. Otherwise we will end up with a big ugly and hard-to-maintain authorisedValues/avMatrix.js. Why not simply have the av list in the store of the app (eg

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 --- Comment #17 from Katrin Fischer --- I'll have another look before pushing this as you are in principle right about adding inconsistencies. Maybe Raphael can weigh in here as he might have a better idea having looked at the code m

[Koha-bugs] [Bug 37198] POD for GetPreparedLetter doesn't include 'objects'

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37198 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to oldstable |Pushed to

[Koha-bugs] [Bug 36141] Add classes to CAS text on OPAC login page

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 36128] Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36128 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 30372] Patron self registration: Extended patron attributes are emptied on submit when mandatory field isn't filled in

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30372 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37157] Error 500 when loading identity provider list

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37157 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37016] SIP2 renew shows old/wrong date due

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37016 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37345] Remember for session checkbox on checkout page not sticking

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37345 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37933] No space between title and medium

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37933 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org ---

[Koha-bugs] [Bug 36527] Patron category or item type not changing when editing another circulation rule

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Victor Grousset/tuxayo changed: What|Removed |Added Severity|trivial |normal

[Koha-bugs] [Bug 36982] Collections facet does not get alphabetized based on collection descriptions

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36982 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37163] Fix the redirect after deleting a tag from an authority framework to load the right page

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37163 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37162] Remove dead confirmation code when deleting tags from authority frameworks

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162 Phil Ringnalda changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolutio

[Koha-bugs] [Bug 37162] Remove dead confirmation code when deleting tags from authority frameworks

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37162 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwiti

[Koha-bugs] [Bug 37937] Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 --- Comment #3 from Victor Grousset/tuxayo --- > "Total tax exc. (USD)" is using Koha::Number::Price->round() and "Budgeted > cost tax exc." isn't. Likely it shouldn't. And instead should just use "Total tax exc. (USD)" and sum it

[Koha-bugs] [Bug 37938] Budgeted cost in new order form isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37938 --- Comment #1 from Victor Grousset/tuxayo --- This is calculated in JS so the fix is different from bug 36049 which is why it's better to do it separately. See bug 36049 comment 0 and bug 36049 comment 6 for leads. -- You are rec

[Koha-bugs] [Bug 35114] Calculation around basket details and basketgroup not correct

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 37937] Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||37937 Se

[Koha-bugs] [Bug 37937] Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||36049 Se

[Koha-bugs] [Bug 37937] Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 --- Comment #1 from Victor Grousset/tuxayo --- "Total tax exc. (USD)" is using Koha::Number::Price->round() and "Budgeted cost tax exc." isn't. -- You are receiving this mail because: You are the assignee for the bug. You are watch

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 37938] Budgeted cost in new order form isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37938 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 37938] New: Budgeted cost in new order form isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37938 Bug ID: 37938 Summary: Budgeted cost in new order form isn't honoring OrderPriceRounding Change sponsored?: --- Product: Koha Version: Main Hardware: All

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 37937] Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 37937] New: Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37937 Bug ID: 37937 Summary: Budgeted cost tax exc. in basket page isn't honoring OrderPriceRounding Change sponsored?: --- Product: Koha Version: Main Hardware: Al

[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|24.11.00,24.05.02,23.11.07 |24.11.00,2

[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #38 from wainuiwitikap...@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #37) > Could I please have a more detailed test plan for 23.05? For KTD -- You are receiving this mail because: You are watching a

[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #37 from wainuiwitikap...@catalyst.net.nz --- Could I please have a more detailed test plan for 23.05? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 37928] "Upload image" item not correctly styled

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37928 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --

[Koha-bugs] [Bug 37928] "Upload image" item not correctly styled

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37928 Phil Ringnalda changed: What|Removed |Added Attachment #171525|0 |1 is obsolete|

[Koha-bugs] [Bug 37928] "Upload image" item not correctly styled

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37928 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 34444] Statistic 1/2 not saving when updating fund after receipt

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|24.11.00,24.05.02,23.11.07 |24.11.00,2

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added Status|Failed QA |Passed QA --- Comm

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162701|0 |1 is obsole

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162699|0 |1 is obsole

[Koha-bugs] [Bug 36049] Rounding prices sometimes leads to incorrect results

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049 --- Comment #13 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #12) > (In reply to Victor Grousset/tuxayo from comment #11) > > In basket view, shouldn't "Budgeted cost tax exc." also honor > > OrderPriceRou

[Koha-bugs] [Bug 37936] Misleading message about AnonymousPatron in batch anonymization tool

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37936 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Commen

[Koha-bugs] [Bug 37936] New: Misleading message about AnonymousPatron in batch anonymization tool

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37936 Bug ID: 37936 Summary: Misleading message about AnonymousPatron in batch anonymization tool Change sponsored?: --- Product: Koha Version: Main Hardware: All

[Koha-bugs] [Bug 35191] Make entries per page configurable for items table on staff detail page

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35191 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --

[Koha-bugs] [Bug 35704] Add hold limits to Parent Child Item Types

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35704 Lisette Scheer changed: What|Removed |Added Change sponsored?|--- |Seeking sponsor

[Koha-bugs] [Bug 37360] Add 'Protected Status' as one of the things that can be updated via Batch Patron Modification tool

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Nick Clemens (kidclamp) changed: What|Removed |Added CC||n...@bywatersoluti

[Koha-bugs] [Bug 37857] Unable to select type "Geo point" or "Call number" when adding a search field

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37857 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171251|0 |1 is obsol

[Koha-bugs] [Bug 37857] Unable to select type "Geo point" or "Call number" when adding a search field

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37857 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You

[Koha-bugs] [Bug 37807] "Export today's checked in barcodes" not disabled when needed

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37807 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #170975|0 |1 is obsol

[Koha-bugs] [Bug 37807] "Export today's checked in barcodes" not disabled when needed

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37807 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You

[Koha-bugs] [Bug 35087] Discount rate should only allow valid input formats

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171198|0 |1 is obsol

[Koha-bugs] [Bug 35087] Discount rate should only allow valid input formats

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171197|0 |1 is obsol

[Koha-bugs] [Bug 35087] Discount rate should only allow valid input formats

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35087 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You

[Koha-bugs] [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 --- Comment #7 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > Hi, I had a go at updating the wiki page, but got a bit stuck on the second > example: If the column already exists, we might want to do a say_info >

[Koha-bugs] [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 --- Comment #6 from Kyle M Hall --- I feel like that is somewhat less readable than what was been proposed in the patch but I am open to changes you feel that is better. should read as I feel like that is somewhat less readable tha

[Koha-bugs] [Bug 37895] Update skeleton.pl to show an example use of coding guideline SQL14

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895 --- Comment #5 from Kyle M Hall --- (In reply to Julian Maurice from comment #3) > Shouldn't we add `use Try::Tiny` at the beginning ? It doesn't seem to be needed as we include it farther upstream from where we execute atomic updat

[Koha-bugs] [Bug 37334] Cannot order/sort holdings table by status

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37334 Kris changed: What|Removed |Added CC||kbec...@jcls.org -- You are receivi

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #117 from Kyle M Hall --- Patches squashed for readability. Final tidy kept separate to prevent future rebase issues. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #116 from Kyle M Hall --- Created attachment 171593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171593&action=edit Bug 26282: (QA follow-up) Tidy code for qa script -- You are receiving this mail b

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Attachment #171577|0 |1 is obsolete|

[Koha-bugs] [Bug 37330] LocalCoverImages for items don't show after 33526

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171523|0 |1 is obsol

[Koha-bugs] [Bug 37330] LocalCoverImages for items don't show after 33526

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #114 from Kyle M Hall --- Created attachment 171590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171590&action=edit Bug 26282: (QA follow-up) Fix typo cancelation -- You are receiving this mail beca

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #113 from Kyle M Hall --- Created attachment 171589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171589&action=edit Bug 26282: (QA follow-up) Tidy code for qa script -- You are receiving this mail b

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #112 from Kyle M Hall --- Created attachment 171588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171588&action=edit Bug 26282: (QA follow-up) Fix typo recieve -- You are receiving this mail because:

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #111 from Kyle M Hall --- Created attachment 171587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171587&action=edit Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #110 from Kyle M Hall --- Created attachment 171586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171586&action=edit Bug 26282: Update Holds to pull Rebased-by: Victor Grousset/tuxayo -- You are re

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #109 from Kyle M Hall --- Created attachment 171585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171585&action=edit Bug 26282: Show reason only if notice exists Rebased-by: Victor Grousset/tuxayo -

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #108 from Kyle M Hall --- Created attachment 171584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171584&action=edit Bug 26282: (QA follow-up) Restore default notice Rebased-by: Victor Grousset/tuxayo

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #107 from Kyle M Hall --- Created attachment 171583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171583&action=edit Bug 26282: (QA follow-up) Update test Signed-off-by: Josef Moravec Signed-off-by:

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #106 from Kyle M Hall --- Created attachment 171582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171582&action=edit Bug 26282: (QA follow-up) Unit tests This patch adds tests for the behaviour change

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #105 from Kyle M Hall --- Created attachment 171581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171581&action=edit Bug 26282: (QA follow-up) Update POD Signed-off-by: Martin Renvoize Signed-off-by:

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #104 from Kyle M Hall --- Created attachment 171580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171580&action=edit Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds Signed-off-by

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #103 from Kyle M Hall --- Created attachment 171579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171579&action=edit Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked Signed

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #102 from Kyle M Hall --- Created attachment 171578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171578&action=edit Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl Signed-off

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Attachment #138410|0 |1 is obsolete|

[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are rec

[Koha-bugs] [Bug 37446] Home/holding library facets missing user friendly label

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171238|0 |1 is obsol

[Koha-bugs] [Bug 37446] Home/holding library facets missing user friendly label

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You

[Koha-bugs] [Bug 37446] Home/holding library facets missing user friendly label

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446 Nick Clemens (kidclamp) changed: What|Removed |Added CC||n...@bywatersoluti

[Koha-bugs] [Bug 37480] Make C4::Serials::addroutingmember use Koha::Objects

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37480 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > I've tested the feature. This test plan is cheating :D I forgot about the test plan IMHO. -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 --- Comment #55 from Nick Clemens (kidclamp) --- Old links to ODS exports will fail with a 500 if the pref is off, would be nice to have a warning, even just in the logs, of what happened, but not a blocker here. The patch to exclud

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added CC||n...@bywatersoluti

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171175|0 |1 is obsol

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171174|0 |1 is obsol

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171173|0 |1 is obsol

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171172|0 |1 is obsol

[Koha-bugs] [Bug 23685] Exporting report may consume unlimited memory

2024-09-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #171171|0 |1 is obsol

<    3   4   5   6   7   8   9   10   11   12   >