[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 --- Comment #11 from Andrew Nugged --- Created Bug 29056 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Andrew Nugged changed: What|Removed |Added Blocks||29056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 [Bug 29056] Remove demo functionality remnants -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com --- Comment #10 from Andrew Nugged --- (above comment re-posted from my words by JD, we had some antispam issues) found some remnants of "C4::Context->config('demo')": in /svc/config/systempreferences line 68: `unless ( C4::Context->config('demo') ) { ... ` it's never failing because it returns _REFERENCE_TO_HASH_, even the hash is empty: ``` sub set_preferences { warn C4::Context->config( 'demo' ); warn C4::Context->config( 'demo' ) ? 'TRUTH' : 'FALSE'; warn Dumper(C4::Context->config( 'demo' )); unless ( C4::Context->config('demo') ) { ... ``` Gives: [2021/09/20 10:42:56] [WARN] HASH(0x5646ead56e00) [2021/09/20 10:42:56] [WARN] TRUTH [2021/09/20 10:42:56] [WARN] $VAR1 = {}; and despite this "hash truth" issue also, by the way, as I see, this "demo" was removed everywhere so should be in svc/config/systempreferences too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 --- Comment #9 from Jonathan Druart --- found some remnants: https://git.koha-community.org/Koha-community/Koha/search?q=C4%3A%3AContext+config+demo https://git.koha-community.org/Koha-community/Koha/src/branch/master/svc/config/systempreferences#L98 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druartchanged: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] Remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Katrin Fischerchanged: What|Removed |Added Summary|remove demo user|Remove demo user |functionality |functionality CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #8 from Nick Clemens --- Awesome work all! Skipping for 17.11, enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Kyle M Hallchanged: What|Removed |Added Attachment #67617|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 68837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68837=edit Bug 12227: Remove the demo functionality This is a legacy mode that did not really work. Test plan: Play with frameworks and sysprefs and confirm the changes (add/del/update) are taken into account. Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Kyle M Hallchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Alex Buckleychanged: What|Removed |Added Attachment #67407|0 |1 is obsolete|| --- Comment #5 from Alex Buckley --- Created attachment 67617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67617=edit Bug 12227: Remove the demo functionality This is a legacy mode that did not really work. Test plan: Play with frameworks and sysprefs and confirm the changes (add/del/update) are taken into account. Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Alex Buckleychanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 --- Comment #4 from Jonathan Druart--- (In reply to Alex Buckley from comment #3) > What is the demo setting in koha-conf.xml that needs to be enabled? I cannot > find the string 'demo' in the aforementioned file This patch removes the demo functionality. It has never been implemented fully, it is expected not to see it in the config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Alex Buckleychanged: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #3 from Alex Buckley --- What is the demo setting in koha-conf.xml that needs to be enabled? I cannot find the string 'demo' in the aforementioned file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druartchanged: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 --- Comment #2 from Jonathan Druart--- Created attachment 67407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67407=edit Bug 12227: Remove the demo functionality This is a legacy mode that did not really work. Test plan: Play with frameworks and sysprefs and confirm the changes (add/del/update) are taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druartchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19131 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize martin.renvo...@ptfs-europe.com --- I spotted this code recently and can only agree that it's a nasty case, with agreement I'de be more than happy to strip it out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12227] remove demo user functionality
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/