subject:"\[Koha\-bugs\] \[Bug 14385\] Extend OpacHiddenItems to allow specifying exempt borrower categories"

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2021-01-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2020-01-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #198 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #197)
> From this commit 70651422a7517338a68e22321d9918757746ef33
> Bug 14385: (QA follow-up) Additional changes and fixes
> 
> @ Biblio.pm:1551 @ sub GetAuthorisedValueDesc {
> 
>  # branch
>  if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq
> "branches" ) {
> -return Koha::Libraries->find($value)->branchname;
> +my $branch = Koha::Libraries->find($value);
> +return $branch? $branch->branchname: q{};
>  }
> 
> 
> We are actually hiding a data inconsistency. I would recommend to revert
> that change and fix the failing test properly instead.

I think this got lost here - should we file a new bug report? Not sure how to
phrase it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-12-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #197 from Jonathan Druart  
---
From this commit 70651422a7517338a68e22321d9918757746ef33
Bug 14385: (QA follow-up) Additional changes and fixes

@ Biblio.pm:1551 @ sub GetAuthorisedValueDesc {

 # branch
 if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches"
) {
-return Koha::Libraries->find($value)->branchname;
+my $branch = Koha::Libraries->find($value);
+return $branch? $branch->branchname: q{};
 }


We are actually hiding a data inconsistency. I would recommend to revert that
change and fix the failing test properly instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-12-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||24198


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24198
[Bug 24198] itemtype image not displayed in search results anymore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-11-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121
[Bug 24121] Item types icons in intra search results are requesting icons from
opac images path if item-level_itypes syspref is set to biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-09-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Mason James  changed:

   What|Removed |Added

 Blocks||23530


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530
[Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancement allows for
  release notes||specifying specific
   ||borrower categories in the
   ||preference
   ||OpacHiddenItemsExceptions
   ||who, when signed in to the
   ||opac, will be able to see
   ||items hidden by the
   ||OpacHiddenItems system
   ||preference.
   ||
   ||This is
   ||intended to allow
   ||staff/privileged users to
   ||view records that the
   ||general public cannot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Nick Clemens  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #196 from Nick Clemens  ---
Last follow-up pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #195 from Martin Renvoize  ---
Followup looks solid, go forth and push :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89963|0   |1
is obsolete||

--- Comment #194 from Martin Renvoize  ---
Created attachment 90038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90038=edit
Bug 14385: (RM follow-up) Remove line from bad rebase

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #193 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #190)
> Note: The routine C4::Biblio::get_biblio_authorised_values does not longer
> exist!

Can you confirm the supplied patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-05-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #192 from Nick Clemens  ---
Created attachment 89963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89963=edit
Bug 14385: (RM follow-up) Remove line from bad rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #191 from Jonathan Druart  
---
And the 2 prefs (AuthorisedValueImages and StaffAuthorisedValueImages) have
been removed by bug 16167, that's why we never call the non-existing routine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #189 from Jonathan Druart  
---
I suspect a wrong resolution conflict here, see
  commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7
  Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

The following line has been removed for years, and re-added by this patchset:

+$oldbiblio->{'authorised_value_images'}  =
($search_context->{'interface'} eq 'opac' &&
C4::Context->preference('AuthorisedValueImages')) ||
($search_context->{'interface'} eq 'intranet' &&
C4::Context->preference('StaffAuthorisedValueImages')) ?
C4::Items::get_authorised_value_images(
C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'},
$marcrecord ) ) : [];

At first glance I'd say we just need a patch removing the line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #190 from Jonathan Druart  
---
Note: The routine C4::Biblio::get_biblio_authorised_values does not longer
exist!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22766


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766
[Bug 22766] Tags cloud link in OPAC does not work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-02-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22420


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
[Bug 22420] Tag cloud feature broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-11-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #188 from Martin Renvoize  ---
Enhancement will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #187 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #186 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #185)
> Regarding the leak via counting being off. This counting problem already
> leaks and is an issue. Fixing the counting problem is a complex problem,
> which has had recent comments on the mailing list. Given the size and scope
> of testing for this patch, I did not want to keep coding for perfection.
> Perfection is the enemy of good, or some variation thereof. :)

Not sure if we talk about the same counting problem. There is the problem of
leaving a search result out (having 19 hits on a page instead of 20 etc.) but I
was referring to the listing of 2 items where one is hidden. At least we know
that there is one hidden :) But no need to address that here.

> ::: opac/opac-search.pl
> @@ +125,4 @@
> >  authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
> >  }
> >  );
> > +my $patron = Koha::Patrons->find( $borrowernumber );
> 
> Not an exact copy of 658 during the optimization. Will this affect things?

Not a problem. We could test on borrowernumber again, but find(undef) will
return nothing either and this is consistent with the common approach.
The line using $patron is testing on $patron. So should be fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #185 from M. Tompsett  ---
Comment on attachment 80467
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467
Bug 14385: (QA follow-up) Additional changes and fixes

Review of attachment 80467:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14385=80467)
-

Thank you very much for a Passed QA. Just had one question about one
optimization you made in opac/opac-search.pl as I eyeball'd through the patch.
The other things are just comments as I was looking through it.

Regarding the leak via counting being off. This counting problem already leaks
and is an issue. Fixing the counting problem is a complex problem, which has
had recent comments on the mailing list. Given the size and scope of testing
for this patch, I did not want to keep coding for perfection. Perfection is the
enemy of good, or some variation thereof. :)

::: C4/Search.pm
@@ +2215,5 @@
>  else {
>  $can_place_holds = 1;
>  $available_count++;
> +$available_items->{$prefix}->{count}++ if 
> $item->{$hbranch};
> +foreach (qw(branchname itemcallnumber description)) {

White space fix.

::: opac/opac-ISBDdetail.pl
@@ +82,3 @@
>  my $borcat = q{};
> +if ( $patron && C4::Context->preference('OpacHiddenItemsExceptions') ) {
> +$borcat = $patron->categorycode;

Nice optimization.

::: opac/opac-basket.pl
@@ -59,4 @@
>  my $borcat = q{};
>  if ( C4::Context->preference('OpacHiddenItemsExceptions') ) {
>  # we need to fetch the borrower info here, so we can pass the category
> -my $borrower = Koha::Patron->find( { borrowernumber -> $borrowernumber } 
> );

Oops... should have been => good catch.

::: opac/opac-detail.pl
@@ +85,4 @@
>  my @all_items = GetItemsInfo($biblionumber);
>  my @hiddenitems;
>  my $patron = Koha::Patrons->find( $borrowernumber );
> +our $borcat= q{};

I would have preferred passing, rather than changing to our.

::: opac/opac-search.pl
@@ +125,4 @@
>  authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
>  }
>  );
> +my $patron = Koha::Patrons->find( $borrowernumber );

Not an exact copy of 658 during the optimization. Will this affect things?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #184 from Marcel de Rooy  ---
QA Comment:

Great work. Spent whole morning on it so there will be comments (see also
follow-up):

Since you adjust EmbedItemsInMarcBiblio more fundamentally and add a borcat
parameter, I would have at least expected the borcat parameter in the subtest
for this routine. Bad luck however.
Considering the history of this report, and the demonstrated attention for
other tests here, I will not be too strict on that. Knowing that you will
submit them on a new report :)

No blocker but something worth fixing / feature extending ?
Have a book with two items. One item must be hidden. In the OPAC I see:
Availability: Items available for loan: RMA [Call number: 200 P 1] (2). 
This line on opac-search or opac-shelves.pl shows me (in this case) the call
number of the hidden item ! Also the number 2 reveals that there are more items
than shown on opac-detail.
Could imagine that these "hidden books" may stand on a shelf number that you do
not want to display either.. 
When I put the book in the cart and email the cart, I will see both items in
the cart. How about hiding that one ?

Similar point.
Although you could argue that you have a special circ rule for these hidden
items, without such a rule opac-reserve shows me the hidden items if I allow
item holds. Which it should not imo.
Not a blocker for me now, but it feels even a bit more serious than the former
point.

And thinking further: In the staff client the hidden item pops up even if I do
not put the staff category in the new pref. OK, I understand that. But if I
export a biblio with Save to marcxml or export data under tools etc. the item
also pops up everywhere. Certainly not a blocker, but should the feature of
hiding items not have some impact in such things too ? Same for SRU/Z39.50
output (item just there). Etc.

In conclusion: This patch set looks good enough to me. The feature has been
developed (before) picking mostly low fruit. Looking a bit further, items are
not that hidden after all..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #183 from Marcel de Rooy  ---
Just a few minor question written down during code review without exploring
them further:

TODO why change for $oldbiblio->{'authorised_value_images'}
TODO $search_context->{category} => ADD to POD
TODO Waarom addbooks: if ( not exists $line->{'size'} ) { $line->{'size'} = ""
}
TODO Why add use Koha::Libraries; to opac-search ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #78827|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #78826|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #80411|0   |1
is obsolete||

--- Comment #181 from Marcel de Rooy  ---
Created attachment 80466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80466=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!
- Rebased t/db_dependent/Items.t conflict.

The test plan is in comment #112 last I checked.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #182 from Marcel de Rooy  ---
Created attachment 80467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467=edit
Bug 14385: (QA follow-up) Additional changes and fixes

[1] searchResults: second my $interface can be removed: unused
[2] call of getitemtypeimagelocation on L2119 needs interface key
[3] ISBDdetail: No need to find patron again (line 182 vs 84)
[4] opac-search: No need to find patron twice (657 and 631)
[5] tabs on line 2220 of C4/Search.pm (qa tools warn)
[6] Ugly hack to overcome "Undefined subroutine ::Items::ModZebra"
by loading C4::Items before C4::Biblio when running tests
Koha/BiblioUtils/Iterator.t and Labels/t_Label.t.
This is a more general problem that needs attention somewhere else.
It seems that Biblio.pm is one of the suspects.
[7] This patch set makes Search.t crash/fail with me. Note that without
these patches Search.t still passed! Why o why..
A little debugging pointed me to a missing MPL branch (aarg).
Adding the simple test on the result of Libraries->find in
C4::Biblio::GetAuthorisedValueDesc made the test continue.
[8] Resolve: Variable "$borcat" is not available at opac-detail.pl line 246
Lexical $borcat cannot be used in sub searchAgain in opac-detail.pl
under Plack. Must be defined with our (or passed as argument).
[9] Resolve crash on TWO serious typos in opac-basket on ONE line:
Koha::Patron->find({ borrowernumber -> $borrowernumber })
Yeah: find is in Koha::Patrons and we need => !!
No need to pass a hash to find method btw for a pk value.
[10] Serious bugfixing here. Add List::Util to opac-basket.
Can't locate object method "none" via package "1".
You can't test everything :)

Signed-off-by: Marcel de Rooy 
After this longer list I renamed Final to Additional in the patch title :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #78825|0   |1
is obsolete||

--- Comment #178 from Marcel de Rooy  ---
Created attachment 80463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80463=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #180 from Marcel de Rooy  ---
Created attachment 80465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80465=edit
Bug 14385: (follow-up) Changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #179 from Marcel de Rooy  ---
Created attachment 80464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80464=edit
Bug 14385: (follow-up) C4::Borrowers not found

GetMember is in C4::Members, not C4::Borrowers

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #177 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #176 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #175)
> (In reply to Katrin Fischer from comment #173)
> > Please rebase.
> > 
> > Apply? [(y)es, (n)o, (i)nteractive] y
> > Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt
> > borrower categories
> > Applying: Bug 14385 Followup: C4::Borrowers not found
> > Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate
> > Applying: Bug 14385: Squash of a lot of patches rebased
> > fatal: sha1 information is lacking or useless (C4/Search.pm).
> > Repository lacks necessary blobs to fall back on 3-way merge.
> > Cannot fall back to three-way merge.
> > Patch failed at 0001 Bug 14385: Squash of a lot of patches rebased
> > The copy of the patch that failed is found in:
> >/home/vagrant/kohaclone/.git/rebase-apply/patch
> > When you have resolved this problem run "git bz apply --continue".
> > If you would prefer to skip this patch, instead run "git bz apply --skip".
> > To restore the original branch and stop patching run "git bz apply --abort".
> > Patch left in /tmp/Bug-14385-Squash-of-a-lot-of-patches-rebased-PmRtSL.patch
> 
> cait: Are you working on this one ?

Haven't started yet to look beyong applying, happy to hand over!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #175 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #173)
> Please rebase.
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt
> borrower categories
> Applying: Bug 14385 Followup: C4::Borrowers not found
> Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate
> Applying: Bug 14385: Squash of a lot of patches rebased
> fatal: sha1 information is lacking or useless (C4/Search.pm).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 Bug 14385: Squash of a lot of patches rebased
> The copy of the patch that failed is found in:
>/home/vagrant/kohaclone/.git/rebase-apply/patch
> When you have resolved this problem run "git bz apply --continue".
> If you would prefer to skip this patch, instead run "git bz apply --skip".
> To restore the original branch and stop patching run "git bz apply --abort".
> Patch left in /tmp/Bug-14385-Squash-of-a-lot-of-patches-rebased-PmRtSL.patch

cait: Are you working on this one ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #78828|0   |1
is obsolete||

--- Comment #174 from M. Tompsett  ---
Created attachment 80411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80411=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!
- Rebased t/db_dependent/Items.t conflict.

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-10-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #173 from Katrin Fischer  ---
Please rebase.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories
Applying: Bug 14385 Followup: C4::Borrowers not found
Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate
Applying: Bug 14385: Squash of a lot of patches rebased
fatal: sha1 information is lacking or useless (C4/Search.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 14385: Squash of a lot of patches rebased
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14385-Squash-of-a-lot-of-patches-rebased-PmRtSL.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Ere Maijala  changed:

   What|Removed |Added

 Blocks||20664


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
[Bug 20664] Optimize retrieval of biblio and item data
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Joy Nelson  changed:

   What|Removed |Added

  Attachment #78655|0   |1
is obsolete||

--- Comment #170 from Joy Nelson  ---
Created attachment 78826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78826=edit
Bug 14385 Followup: C4::Borrowers not found

GetMember is in C4::Members, not C4::Borrowers

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Joy Nelson  changed:

   What|Removed |Added

  Attachment #78657|0   |1
is obsolete||

--- Comment #172 from Joy Nelson  ---
Created attachment 78828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78828=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Joy Nelson  changed:

   What|Removed |Added

  Attachment #78656|0   |1
is obsolete||

--- Comment #171 from Joy Nelson  ---
Created attachment 78827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78827=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Joy Nelson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Joy Nelson  changed:

   What|Removed |Added

  Attachment #78654|0   |1
is obsolete||

--- Comment #169 from Joy Nelson  ---
Created attachment 78825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78825=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

DEVINIM  changed:

   What|Removed |Added

 CC||kohadevi...@devinim.com.tr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #74001|0   |1
is obsolete||

--- Comment #168 from M. Tompsett  ---
Created attachment 78657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78657=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72447|0   |1
is obsolete||

--- Comment #167 from M. Tompsett  ---
Created attachment 78656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78656=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72446|0   |1
is obsolete||

--- Comment #166 from M. Tompsett  ---
Created attachment 78655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78655=edit
Bug 14385 Followup: C4::Borrowers not found

GetMember is in C4::Members, not C4::Borrowers

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-09-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72445|0   |1
is obsolete||

--- Comment #165 from M. Tompsett  ---
Created attachment 78654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78654=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-05-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #164 from M. Tompsett  ---
This is too huge, my mental energy keeps being too low, and I need this in
sooner rather than later. Follow the test plan in comment #112.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-04-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72454|0   |1
is obsolete||

--- Comment #163 from M. Tompsett  ---
Created attachment 74001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74001=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again! Rebased again -- my fault for being slow on this.

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #162 from M. Tompsett  ---
Today was massive rebase, and confirm changes. Still to do: test and confirm
that comment #112 is the exhaustive test plan. Sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70259|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70256|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72453|0   |1
is obsolete||

--- Comment #161 from M. Tompsett  ---
Created attachment 72454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72454=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72452|0   |1
is obsolete||

--- Comment #160 from M. Tompsett  ---
Created attachment 72453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72453=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72451|0   |1
is obsolete||

--- Comment #159 from M. Tompsett  ---
Created attachment 72452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72452=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72450|0   |1
is obsolete||

--- Comment #158 from M. Tompsett  ---
Created attachment 72451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72451=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72449|0   |1
is obsolete||

--- Comment #157 from M. Tompsett  ---
Created attachment 72450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72450=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #72448|0   |1
is obsolete||

--- Comment #156 from M. Tompsett  ---
Created attachment 72449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72449=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #155 from M. Tompsett  ---
Created attachment 72448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72448=edit
Bug 14385: Squash of a lot of patches rebased

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70258|0   |1
is obsolete||

--- Comment #154 from M. Tompsett  ---
Created attachment 72447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72447=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #152 from M. Tompsett  ---
Created attachment 72445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72445=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70257|0   |1
is obsolete||

--- Comment #153 from M. Tompsett  ---
Created attachment 72446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72446=edit
Bug 14385 Followup: C4::Borrowers not found

GetMember is in C4::Members, not C4::Borrowers

Signed-off-by: Claire Gravely 

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #151 from M. Tompsett  ---
Comment on attachment 70259
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259
Bug 14385: A lot of patches

Review of attachment 70259:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14385=70259)
-

::: opac/opac-tags.pl
@@ +310,5 @@
> +if (grep { $_->{term} eq $my_tag->{term} } @$results) {
> +if (! $my_tag->{visible} ) {
> +my $check_biblio = GetMarcBiblio({
> +biblionumber => $my_tag->{biblionumber},
> +embed_itesm  => 1,

Always good idea to re-check over and over. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-03-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #150 from M. Tompsett  ---
Currently does not apply, reworking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #149 from M. Tompsett  ---
Still in the midst of retesting after squash. Once I'm happy, I'll post back up
a full test plan, and change to needs sign off, just to make sure I didn't miss
something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66544|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66543|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66539|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66545|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66542|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66541|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66535|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66538|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66536|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66534|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66540|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66530|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66532|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66537|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66533|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66531|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66523|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66525|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66527|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66529|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66528|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66526|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66520|0   |1
is obsolete||
  Attachment #66521|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66524|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66522|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66520|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #147 from M. Tompsett  ---
Created attachment 70258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70258=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate

Run updatedatabase.pl when testing

Sponsored-by: Catalyst IT

Signed-off-by: Mark Tompsett 

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #148 from M. Tompsett  ---
Created attachment 70259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259=edit
Bug 14385: A lot of patches

- Added missing GetHiddenItems parameter change case
 Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
 There was a typo botcat vs borcat and borrowernumber was never
 defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
 This will test all the if structures fully in GetHiddenItemnumbers.
 prove t/db_dependent/Items.t

- Tweak borrower category code
 $borrower->{categorycode} on a Koha::Patron is not the
 same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
 There was one search context place wrong. Changed it to $is_opac
 as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
 When a user isn't logged in, $borrower is undef and causes error
 when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
 C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
 prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
 These files generally add borcat parameter to GetMarcBiblio.
 Others might include correction of filtering of items
 (opac-basket), or a comment as to why no changes were done
 (opac-search).

 In the case of opac-search, correcting the first FIXME will
 likely correct the OpacHiddenItems issues on tags. As such,
 that is beyond this bugs scope.

 Some code had loop optimizations and fixes made, like a
 'next unless $record' when the biblio shouldn't even be in
 the list.

- Modify opac-ISBDdetail and opac-MARCdetail
 Both files had similar logic. They were rearranged and
 optimized, so that both files would have practically identical
 initial blocks of code.

 Optimizations were possible, because GetMarcBiblio
 returns a filtered record, so that there is no double call
 (once in the opac-### file and once in GetMarcBiblio) to
 GetHiddenItemnumbers.

- Fix hiding in opac-tags
 opac/opac-tags.pl was not properly hiding.

 There is currently one known bug associated with tags left.
 If you have two biblios tagged by different people with the
 same tag, the opac-search will show the one you tagged that
 is supposed to be hidden, because tag searches work differently
 than regular searches. This is beyond the scope of this bug.
 See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
 prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased!

The test plan is in comment #112 last I checked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 261 matches

Mail list logo