[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||30472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30472
[Bug 30472] Field borrower_relationships.guarantor_id should be marked as NOT
NULL
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #251 from Jonathan Druart  ---
It seems that the following occurrences of "guarantorid" should have been
removed:

koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc: [%- CASE
'guarantorid' -%]Guarantor ID

koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: 
   Edit

t/db_dependent/Koha/Patrons.t:guarantorid =>
$guarantor->borrowernumber

t/db_dependent/Koha/Patrons.t:guarantorid =>
$guarantor->borrowernumber

t/lib/TestBuilder.pm:# skip when FK points to itself: e.g.
borrowers:guarantorid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||30534


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
[Bug 30534] borrowers.guarantorid not present on database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

David Cook  changed:

   What|Removed |Added

 Blocks||26995


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995
[Bug 26995] Drop column relationship from borrower tables
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #250 from David Cook  ---
(In reply to Jonathan Druart from comment #249)
> Hum yes, I am coming to the same conclusion. Can someone deal with on a
> separate bug report please?

I'll raise the bug report. Cheers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #249 from Jonathan Druart  
---
(In reply to David Cook from comment #248)
> As for borrower_relationships.relationship vs borrowers.relationship, it
> looks like borrowers.relationship is no longer used? Why don't we just
> delete that column then?


Hum yes, I am coming to the same conclusion. Can someone deal with on a
separate bug report please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #248 from David Cook  ---
Ok guarantor search broken due to local changes... I'll fix that.

As for borrower_relationships.relationship vs borrowers.relationship, it looks
like borrowers.relationship is no longer used? Why don't we just delete that
column then?

And with borrower_relationships it's the relationship that the guarantor has to
the guarantee... all right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #247 from David Cook  ---
(In reply to David Cook from comment #246)
> Trying to fix this via the UI isn't possible as the AJAX call is getting 500
> errors.
> 
Of course, it could be that the problem is local, so I'm just going to stop
posting for the time being...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #246 from David Cook  ---
(In reply to David Cook from comment #245)
> (In reply to Tomás Cohen Arazi from comment #238)
> > Created attachment 92350 [details] [review] [review]
> > Bug 14570: Add about.pl entry for wrong relationship data
> > 
> > This patch adds a check and an entry to the about.pl, for bad
> > relationship data. The checks are:
> > 
> > - 'relationship' containing '_bad_data' (generated by the atomicupdate
> >   on undef relationships.
> > - 'relationship' values that are not in the borrowerRelationship
> > syspref.
> > 
> > Signed-off-by: Tomas Cohen Arazi 
> 
> Unfortunately, this doesn't give sysadmins any idea about how to fix this
> problem.

For instance, I see a borrower_relationships.relationship column, but then
there's also a borrowers.relationship column in the database. There are no
constraints indicating the relationship between these two columns.

Trying to fix this via the UI isn't possible as the AJAX call is getting 500
errors.

I know I'll resolve it, but I've also been working on Koha for nearly 10 years
now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #245 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #238)
> Created attachment 92350 [details] [review]
> Bug 14570: Add about.pl entry for wrong relationship data
> 
> This patch adds a check and an entry to the about.pl, for bad
> relationship data. The checks are:
> 
> - 'relationship' containing '_bad_data' (generated by the atomicupdate
>   on undef relationships.
> - 'relationship' values that are not in the borrowerRelationship
> syspref.
> 
> Signed-off-by: Tomas Cohen Arazi 

Unfortunately, this doesn't give sysadmins any idea about how to fix this
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||25645


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25645
[Bug 25645] When adding a new guarantee from a guarantor account, the Guarantor
must be attached
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=25645   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||26059


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26059
[Bug 26059] Create guarantor/guarantee links on patron import
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25914


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25914
[Bug 25914] Relative's checkouts have empty title in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25654


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
[Bug 25654] Make the contact and non-patron guarantor sections separate on
patron entry form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Nick Clemens  changed:

   What|Removed |Added

 Blocks||25854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25854
[Bug 25854] Ability to add multiple guarantors affected ability to make
guarantor fields mandatory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||25742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25742
[Bug 25742] Non-member guarantor fields show in non minor accounts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kelly McElligott  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25645

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kelly McElligott  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25161

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Lisette Scheer  changed:

   What|Removed |Added

 Blocks||24666


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24666
[Bug 24666] Non Koha Guarantors should be able to be seen from the Patron
Detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #244 from Katrin Fischer  ---
It looks like guarantorid still appears in Koha/REST/V1/Patrons.pm although we
state that it cannot be updated with the API now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #243 from Katrin Fischer  ---
It looks like this broke the non-English installers. Can we please get a fix?
Filed as bug 24317.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||24317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24317
[Bug 24317] Sample patron data not loading for non-English installations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24263


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263
[Bug 24263] borrowers.relationship should not contain an empty string
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24215


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215
[Bug 24215] Warnings about guarantor relationships show ARRAY errors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #242 from Martin Renvoize  ---
Sponsorship lines moved into git commit for release notes and about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This development adds the   |This development adds the
  release notes|ability for a patron to |ability for a patron to
   |have an unlimited number of |have an unlimited number of
   |guarantors in any   |guarantors in any
   |combination of existing |combination of existing
   |Koha patrons and manually   |Koha patrons and manually
   |added guarantors ( e.g. the |added guarantors ( e.g. the
   |guarantor has no patron |guarantor has no patron
   |record in Koha ).
  |record in Koha ).
   |
   |
   |This|This
   |feature retains the |feature retains the
   |existing behaviour for  |existing behaviour for
   |importing guarantors during |importing guarantors during
   |patron imports; However,|patron imports; However,
   |guarantors can no longer be |guarantors can no longer be
   |viewed, added or updated|viewed, added or updated
   |via the REST API.
  |via the REST API.
   |
   |
   |Reports |Reports
   |that utilize|that utilize
   |`borrowers.guarantorid` |`borrowers.guarantorid`
   |will need to be updated.
   |will need to be updated.
   ||
   |Sponsored by: Northeast |
   |Kansas Library System   |
   |  |
   |Vermont Organization of |
   |Koha Automated Libraries|
   |  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This development adds the   |This development adds the
  release notes|ability for a patron to |ability for a patron to
   |have an unlimited number of |have an unlimited number of
   |guarantors in any   |guarantors in any
   |combination of existing |combination of existing
   |Koha patrons and manually   |Koha patrons and manually
   |added guarantors ( e.g. the |added guarantors ( e.g. the
   |person has no patron record |guarantor has no patron
   |in Koha ).
 |record in Koha ).
   |
   |
   |This feature|This
   |retains the existing|feature retains the
   |behavior for importing  |existing behaviour for
   |guarantors during patron|importing guarantors during
   |imports.
   |patron imports; However,
   |
   |guarantors can no longer be
   |Guarantors can no   |viewed, added or updated
   |longer be   |via the REST API.
   |viewed/added/updated from   |
   |the REST API.
  |Reports
   |
   |that utilize
   |Reports that|`borrowers.guarantorid`
   |utilize |will need to be updated.
   |borrowers.guarantorid will  |
   |need to be updated.
|Sponsored by: Northeast
   ||Kansas Library System
   |Sponsored by: Northeast |
   |Kansas Library System   |Vermont Organization of
   |  |Koha Automated Libraries
   |Vermont Organization of |
   |  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #241 from Jonathan Druart  
---
Something wrong happening on the about page:

https://snipboard.io/QmBPeJ.jpg

MariaDB [koha_kohadev]> select * from systempreferences where
variable="borrowerRelationship";
+--+---+-++--+
| variable | value | options | explanation 
  | type |
+--+---+-++--+
| borrowerRelationship | father|mother | | Define valid relationships
between a guarantor & a guarantee (separated by | or ,) | free |
+--+---+-++--+
1 row in set (0.00 sec)

MariaDB [koha_kohadev]> select distinct relationship from borrowers;
+--+
| relationship |
+--+
| NULL |
+--+
1 row in set (0.01 sec)

MariaDB [koha_kohadev]> select * from borrower_relationships;
Empty set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This features adds the  |This development adds the
  release notes|ability for a patron to |ability for a patron to
   |have an unlimited number of |have an unlimited number of
   |guarantors in any   |guarantors in any
   |combination of existing |combination of existing
   |Koha patrons and manually   |Koha patrons and manually
   |added guarantors ( e.g. the |added guarantors ( e.g. the
   |person has no patron record |person has no patron record
   |in Koha ).
 |in Koha ).
   |
   |
   |This feature|This feature
   |retains the existing|retains the existing
   |behavior for importing  |behavior for importing
   |guarantors during patron|guarantors during patron
   |imports.
   |imports.
   |
   |
   |Guarantors can no   |Guarantors can no
   |longer be   |longer be
   |viewed/added/updated from   |viewed/added/updated from
   |the REST API.
  |the REST API.
   |
   |
   |Reports that|Reports that
   |utilize |utilize
   |borrowers.guarantorid will  |borrowers.guarantorid will
   |need to be updated.
|need to be updated.
   ||
   |Sponsored by: Northeast |Sponsored by: Northeast
   |Kansas Library System   |Kansas Library System
   |  |
   |Vermont Organization of |Vermont Organization of
   |Koha Automated Libraries|Koha Automated Libraries
   |  |vokal>

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Margaret  changed:

   What|Removed |Added

  Text to go in the|This features adds the  |This features adds the
  release notes|ability for a patron to |ability for a patron to
   |have an unlimited number of |have an unlimited number of
   |guarantors in any   |guarantors in any
   |combination of existing |combination of existing
   |Koha patrons and manually   |Koha patrons and manually
   |added guarantors ( e.g. the |added guarantors ( e.g. the
   |person has no patron record |person has no patron record
   |in Koha ).
 |in Koha ).
   |
   |
   |This feature|This feature
   |retains the existing|retains the existing
   |behavior for importing  |behavior for importing
   |guarantors during patron|guarantors during patron
   |imports.
   |imports.
   |
   |
   |Guarantors can no   |Guarantors can no
   |longer be   |longer be
   |viewed/added/updated from   |viewed/added/updated from
   |the REST API.
  |the REST API.
   |
   |
   |Reports that|Reports that
   |utilize |utilize
   |borrowers.guarantorid will  |borrowers.guarantorid will
   |need to be updated. |need to be updated.
   ||
   ||Sponsored by: Northeast
   ||Kansas Library System
   ||
   ||Vermont Organization of
   ||Koha Automated Libraries
   ||
 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24113


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113
[Bug 24113] guarantor info lost when a duplicate is found
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23905


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905
[Bug 23905] Button "Search to add" doesn't work on Quick add new patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||23655


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655
[Bug 23655] Debian jessie no longer supported
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||12446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778
[Bug 23778] Regression: Guarantor entry section no longer has a unique id
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #240 from Fridolin SOMERS  ---
Enhancement not pushed to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #239 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #238 from Tomás Cohen Arazi  ---
Created attachment 92350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92350&action=edit
Bug 14570: Add about.pl entry for wrong relationship data

This patch adds a check and an entry to the about.pl, for bad
relationship data. The checks are:

- 'relationship' containing '_bad_data' (generated by the atomicupdate
  on undef relationships.
- 'relationship' values that are not in the borrowerRelationship
syspref.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #237 from Tomás Cohen Arazi  ---
Created attachment 92349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92349&action=edit
Bug 14570: (QA follow-up) Call Koha::Patron->find in scalar context

This patch prevents opac/opac-memberentry.pl from exploding.

To test:
- Login with a known user in the OPAC
- Open the opac/opac-memberentry.pl page
=> FAIL: It explodes
- Apply this patch
- Restart all the things just in case:
  $ restart_all
- Reload the page
=> SUCCESS: Things work!

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #236 from Tomás Cohen Arazi  ---
Created attachment 92348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92348&action=edit
Bug 14570: Handle missing 'relationship' in atomicupdate (bad data)

This patch adds two steps to the upgrade process:
- Handle the pathologic case in which there's a guarantorid and no
'relationship'.
- Performs a cleanup on the relevant columns when the guarantor data
contains a guarantorid, and is then migrated into the
borrower_relationships table. The original code left the information
in the borrowers table, so no clear separation between guarantors as
patrons and the virtual ones.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #235 from Tomás Cohen Arazi  ---
Created attachment 92347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92347&action=edit
Bug 14570: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #234 from Tomás Cohen Arazi  ---
Created attachment 92346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92346&action=edit
Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92325|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92324|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #233 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #232)
> I'm afraid the DB update fails for a few test runs I've tried.
> 
> borrowers.relationship has no constraints to it so it's very possible we
> have guarantor_relationships without a valid relationship and so the db
> update fails.
> 
> We need to come up with a solution for this before I can push the patch
> series.. I'm not sure whether to reduce the 'NOT NULL' constraint on the new
> table or set a default or note the issue as an error somewhere and populate
> the table with some sort of placeholder relationship whilst libraries work
> through fixing up the bad data..
> 
> Thoughts?

There's no semantic on the relationship field ATM, so I think it being just a
label, we should not fail because of it.

If we were to add some semantics, we would have a separate table, with the
relationship description and probably some columns for describing rules. If
such was the situation, I would pick a placeholder as you say, so we don't
fail, and even have an entry in about.pl about those problematic cases (maybe a
note field with the original value).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #232 from Martin Renvoize  ---
I'm afraid the DB update fails for a few test runs I've tried.

borrowers.relationship has no constraints to it so it's very possible we have
guarantor_relationships without a valid relationship and so the db update
fails.

We need to come up with a solution for this before I can push the patch
series.. I'm not sure whether to reduce the 'NOT NULL' constraint on the new
table or set a default or note the issue as an error somewhere and populate the
table with some sort of placeholder relationship whilst libraries work through
fixing up the bad data..

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #230 from Tomás Cohen Arazi  ---
Created attachment 92324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92324&action=edit
Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #229 from Tomás Cohen Arazi  ---
Created attachment 92323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92323&action=edit
Bug 14570: Remove wrong parameter in add_guarantor call

This patch just removes an unused parameter.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #231 from Tomás Cohen Arazi  ---
Created attachment 92325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92325&action=edit
Bug 14570: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #228 from Tomás Cohen Arazi  ---
Created attachment 92322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92322&action=edit
Bug 14570: Add error handling to Koha::Patron::Relationship->store

This patch adds checks on the values for the 'relationship'. This is
done to avoid future problems when migrating relationships from the
plain text syspref into (why not) a proper table. And to preserve
consistency.

There's also catching on possible broken constraints and throwing a new
exception

Tests are added for both the new exceptions and the changes to
Koha::Patron::Relationship.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t \
  t/db_dependent/Koha/Patron.t \
  t/db_dependent/Koha/Patron/Relationship.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #227 from Tomás Cohen Arazi  ---
Created attachment 92321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92321&action=edit
Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #226 from Tomás Cohen Arazi  ---
Created attachment 92320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92320&action=edit
Bug 14570: (QA follow-up) Fix issues in Guarantor context

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #225 from Tomás Cohen Arazi  ---
Created attachment 92319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92319&action=edit
Bug 14570: (QA follow-up) Fix issues in Guarantee context

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #224 from Tomás Cohen Arazi  ---
Created attachment 92318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92318&action=edit
Bug 14570: Update schema files [Do Not Push]

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #222 from Tomás Cohen Arazi  ---
Created attachment 92316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92316&action=edit
Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid)

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #223 from Tomás Cohen Arazi  ---
Created attachment 92317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92317&action=edit
Bug 14570: (follow-up) Fix patron type when "add child" button is pressed

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #220 from Tomás Cohen Arazi  ---
Created attachment 92314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92314&action=edit
Bug 14570: (follow-up) fix qa FAIL tests

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #221 from Tomás Cohen Arazi  ---
Created attachment 92315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92315&action=edit
Bug 14570: (follow-up) Fix tests

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #219 from Tomás Cohen Arazi  ---
Created attachment 92313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92313&action=edit
Bug 14570: (follow-up) fix table name in j2a.pl

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #218 from Tomás Cohen Arazi  ---
Created attachment 92312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92312&action=edit
Bug 14570: Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

Signed-off-by: Kim Peine 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92311|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92310|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92309|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92308|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92306|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92307|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92301|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92302|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92303|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92304|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92305|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92300|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92299|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #92298|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #217 from Liz Rea  ---
Created attachment 92311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92311&action=edit
Bug 14570: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #216 from Liz Rea  ---
Created attachment 92310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92310&action=edit
Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #215 from Liz Rea  ---
Created attachment 92309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92309&action=edit
Bug 14570: Remove wrong parameter in add_guarantor call

This patch just removes an unused parameter.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #212 from Liz Rea  ---
Created attachment 92306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92306&action=edit
Bug 14570: (QA follow-up) Fix issues in Guarantor context

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #213 from Liz Rea  ---
Created attachment 92307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92307&action=edit
Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #211 from Liz Rea  ---
Created attachment 92305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92305&action=edit
Bug 14570: (QA follow-up) Fix issues in Guarantee context

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #214 from Liz Rea  ---
Created attachment 92308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92308&action=edit
Bug 14570: Add error handling to Koha::Patron::Relationship->store

This patch adds checks on the values for the 'relationship'. This is
done to avoid future problems when migrating relationships from the
plain text syspref into (why not) a proper table. And to preserve
consistency.

There's also catching on possible broken constraints and throwing a new
exception

Tests are added for both the new exceptions and the changes to
Koha::Patron::Relationship.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t \
  t/db_dependent/Koha/Patron.t \
  t/db_dependent/Koha/Patron/Relationship.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #208 from Liz Rea  ---
Created attachment 92302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92302&action=edit
Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid)

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #210 from Liz Rea  ---
Created attachment 92304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92304&action=edit
Bug 14570: Update schema files [Do Not Push]

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #207 from Liz Rea  ---
Created attachment 92301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92301&action=edit
Bug 14570: (follow-up) Fix tests

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #209 from Liz Rea  ---
Created attachment 92303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92303&action=edit
Bug 14570: (follow-up) Fix patron type when "add child" button is pressed

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #206 from Liz Rea  ---
Created attachment 92300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92300&action=edit
Bug 14570: (follow-up) fix qa FAIL tests

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #205 from Liz Rea  ---
Created attachment 92299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92299&action=edit
Bug 14570: (follow-up) fix table name in j2a.pl

Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Liz Rea  changed:

   What|Removed |Added

  Attachment #92279|0   |1
is obsolete||
  Attachment #92280|0   |1
is obsolete||
  Attachment #92281|0   |1
is obsolete||
  Attachment #92282|0   |1
is obsolete||
  Attachment #92283|0   |1
is obsolete||
  Attachment #92284|0   |1
is obsolete||
  Attachment #92285|0   |1
is obsolete||
  Attachment #92286|0   |1
is obsolete||
  Attachment #92287|0   |1
is obsolete||
  Attachment #92288|0   |1
is obsolete||
  Attachment #92289|0   |1
is obsolete||
  Attachment #92290|0   |1
is obsolete||
  Attachment #92291|0   |1
is obsolete||
  Attachment #92292|0   |1
is obsolete||

--- Comment #204 from Liz Rea  ---
Created attachment 92298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92298&action=edit
Bug 14570: Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

Signed-off-by: Kim Peine 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Agustín Moyano  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #203 from Agustín Moyano  ---
Created attachment 92292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92292&action=edit
Bug 14570: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #200 from Agustín Moyano  ---
Created attachment 92289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92289&action=edit
Bug 14570: Add error handling to Koha::Patron::Relationship->store

This patch adds checks on the values for the 'relationship'. This is
done to avoid future problems when migrating relationships from the
plain text syspref into (why not) a proper table. And to preserve
consistency.

There's also catching on possible broken constraints and throwing a new
exception

Tests are added for both the new exceptions and the changes to
Koha::Patron::Relationship.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t \
  t/db_dependent/Koha/Patron.t \
  t/db_dependent/Koha/Patron/Relationship.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #199 from Agustín Moyano  ---
Created attachment 92288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92288&action=edit
Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #202 from Agustín Moyano  ---
Created attachment 92291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92291&action=edit
Bug 14570: (QA follow-up) Consistency displaying the list of guarantors

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Agustin Moyano 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/