[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jesse Weaver changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #23 from Jonathan Druart --- I have not tested this patch, just fixed the conflict. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #22 from Jonathan Druart --- Created attachment 49448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49448=edit [3.20.x] Bug 15163: Do not erase patron

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Frédéric Demians changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Julian Maurice changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Brendan Gallagher changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Katrin Fischer changed: What|Removed |Added Attachment #48322|0

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jesse Weaver changed: What|Removed |Added Attachment #45260|0

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jesse Weaver changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #16 from Jonathan Druart --- Created attachment 48269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48269=edit Bug 15163: Do not erase patron attributes if

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #15 from Jesse Weaver --- (In reply to Jonathan Druart from comment #11) > Jesse, yes it should be the way to go but.. > I have already tried something and was stuck. I have a wip branch but

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #14 from Heather Braum --- Thanks Jonathan and Jesse for working on this. I understand the privacy concerns of some of the ways this could be resolved. The issue really does need to be resolved. I am

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #11 from Jonathan Druart --- Jesse, yes it should be the way to go but.. I have already tried something and was stuck. I have a wip branch but I don't remember what was wrong.

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #12 from Jonathan Druart --- Created attachment 46416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46416=edit Bug 15163: Wip - stuck -- You are receiving

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Created attachment 46416 [details] [review] > Bug 15163: Wip - stuck Jesse, here is my start. --

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #10 from Jesse Weaver --- Started working on this; Jonathan, what do you think of passing a $branchcode_limit parameter to SetBorrowerAttributes so it only deletes the correct attributes?

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > This works as described. > > With the proposed solution the values of the hidden patron attribute are

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #9 from Katrin Fischer --- I am not sure there is a valid answer to this. Would it be possible to teach it not to update/change attributes not sent with the form at all? -- You are receiving

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Marc Véron changed: What|Removed |Added Attachment #45258|0 |1 is

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #4 from Jonathan Druart --- Created attachment 45258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45258=edit Bug 15163: Do not erase patron attributes if

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #2 from Jesse Weaver --- Steps to reproduce: 1) Log in at library "A". 2) Create a patron attribute type that is limited to only library "A". 3) Edit a patron, and add data for that

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #3 from Heather Braum --- Jonathan, Jesse's description is the behavior that I have seen also happen on my system. Additionally, I have seen this same behavior happen with patron categories that are

[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What|Removed |Added CC|