[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253
Bug 17253 depends on bug 17294, which changed state.

Bug 17294 Summary: reserves_stats.pl is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #15 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Attachment #56371|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #14 from Martin Renvoize  ---
End of tree.. passed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #56370|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 56404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56404=edit
[PASSED QA] Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

Signed-off-by: Claire Gravely 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #13 from Martin Renvoize  ---
Created attachment 56405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56405=edit
[PASSED QA] Bug 17253: Fetch all the columns instead of only authorised_value

Signed-off-by: Claire Gravely 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56336|0   |1
is obsolete||

--- Comment #11 from Claire Gravely  ---
Created attachment 56371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56371=edit
Bug 17253: Fetch all the columns instead of only authorised_value

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56306|0   |1
is obsolete||

--- Comment #10 from Claire Gravely  ---
Created attachment 56370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56370=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #9 from Claire Gravely  ---

(In reply to Jonathan Druart from comment #5)
> Created attachment 56306 [details] [review]
> Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues
> 
> This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
> Koha::AuthorisedValues->search_by_koha_field
> 
> Test plan:
> AV descriptions should be displayed on the following pages:
> - XSLT view - location and ccode
> - Bibliographic detail, moredetail and OPAC pages - location, ccode,
> copynumber

[BIB Details page OK with XSLT and without XSLT] 
[BIB Moredetails page missing location with XSLT and without XSLT - also not
displayed on master] 
[OPAC pages ok with XSLT and without XSLT]


> - returns - location

[ALL OK]

> - opac-basket - ccode, location

[ccode not displayed - also not displayed on master]

> - The 3 reports: catalogue_stats.pl, issues_stats.pl and
>   reserves_stats.pl - location, ccode

[ALL OK]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #8 from Jonathan Druart  
---
Created attachment 56336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56336=edit
Bug 17253: Fetch all the columns instead of only authorised_value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #7 from Claire Gravely  ---
(In reply to Claire Gravely from comment #6)
> I am not seeing location and ccode in Bibliographic detail, more detail,
> OPAC pages and OPAC basket. 
> 
> Copynumber is displaying in Bibliographic detail and more detail.
> 
> Returns page: there is a column for location but no value is displayed
> despite one being set.

Also, from the 3 reports:

catalogue_stats.pl - both location and ccode missing AVs from drop down list

issues_stats.pl and  reserves_stats.pl - ccode missing AVs from list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #6 from Claire Gravely  ---
I am not seeing location and ccode in Bibliographic detail, more detail, OPAC
pages and OPAC basket. 

Copynumber is displaying in Bibliographic detail and more detail.

Returns page: there is a column for location but no value is displayed despite
one being set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55522|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 56306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56306=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||claire_grav...@hotmail.com

--- Comment #4 from Claire Gravely  ---
fatal: sha1 information is lacking or useless (C4/Koha.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55520|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 55522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55522=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55189|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 55520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55520=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17294


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17294
[Bug 17294] reserves_stats.pl is not plack safe
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #1 from Jonathan Druart  
---
Created attachment 55189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55189=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252
[Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/