[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #50 from Fridolin SOMERS  ---
Pushed to 17.05.x for 17.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #49 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #48 from Martin Renvoize  ---
This patch has been pushed to 18.05.x and will be in 18.05.01

Be nice to see this performance improvement :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #47 from Nick Clemens  ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75729|0   |1
is obsolete||

--- Comment #46 from Kyle M Hall  ---
Created attachment 75733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75733=edit
Bug 18821: (QA follow-up) Last tweaks for performance

[1] passing unsafe has no use since it is a scalar, removed it to unconfuse
[2] remove caching when pref is disabled
[3] caching userid removes the need for calling Patron->find each time
[4] subsequent changes in unit test
[5] cosmetic renames to move from session to daily basis (changed dev angle)

Signed-off-by: Marcel de Rooy 
First call going thru Koha::Patron takes about 0.0150 sec.
Subsequent calls only use caching and take about 0.0006 sec.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #45 from Marcel de Rooy  ---
Created attachment 75729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75729=edit
Bug 18821: (QA follow-up) Last tweaks for performance

[1] passing unsafe has no use since it is a scalar, removed it to unconfuse
[2] remove caching when pref is disabled
[3] caching userid removes the need for calling Patron->find each time
[4] subsequent changes in unit test
[5] cosmetic renames to move from session to daily basis (changed dev angle)

Signed-off-by: Marcel de Rooy 
First call going thru Koha::Patron takes about 0.0150 sec.
Subsequent calls only use caching and take about 0.0006 sec.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75634|0   |1
is obsolete||
  Attachment #75635|0   |1
is obsolete||

--- Comment #43 from Marcel de Rooy  ---
Created attachment 75727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75727=edit
Bug 18821: TrackLastPatronActivity is a performance killer

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Auth.t

Signed-off-by: Charles Farmer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #44 from Marcel de Rooy  ---
Created attachment 75728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75728=edit
Bug 18821: Convert to using cache with date checking

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #42 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #35)
> I actually think a hybrid of your first and second suggestions is the best
> solution. We should use cache *and* test a date! Why do you think we will
> use too much memory? Let's assume we have 1000 simultaneous users. That's
> still a minuscule amount of memory compared to caching the marc frameworks,
> for example.

On second thought, the consumed cache may be very limited indeed.
Nice!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-06-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #41 from Marcel de Rooy  ---
QA: Having another look here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75634|Switched description from   |Bug 18821:
description|using dash to using a colon |TrackLastPatronActivity is
   ||a performance killer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75632|0   |1
is obsolete||
  Attachment #75633|0   |1
is obsolete||

--- Comment #39 from Kyle M Hall  ---
Created attachment 75634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75634=edit
Switched description from using dash to using a colon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #40 from Kyle M Hall  ---
Created attachment 75635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75635=edit
Bug 18821: Convert to using cache with date checking

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #75288|0   |1
is obsolete||
  Attachment #75289|0   |1
is obsolete||
  Attachment #75427|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall  ---
Created attachment 75632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75632=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Auth.t

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #38 from Kyle M Hall  ---
Created attachment 75633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75633=edit
Bug 18821: Convert to using cache with date checking

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #36 from Kyle M Hall  ---
I forgot to add that this will be the fastest variation as well, since it is
guaranteed to be only in memory as opposed to both session and direct db which
would read and write to database or filesystem for everything ( except session
=> memcached which would still be slower with its added abstraction ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #35 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #34)
> I think we should not use the cache here. We will just dump too much in
> memory.
> Should we change lastseen to a date and check if NOW> lastseen ? This would
> skip a lot of writes ?

I actually think a hybrid of your first and second suggestions is the best
solution. We should use cache *and* test a date! Why do you think we will use
too much memory? Let's assume we have 1000 simultaneous users. That's still a
minuscule amount of memory compared to caching the marc frameworks, for
example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #34 from Marcel de Rooy  ---
I think we should not use the cache here. We will just dump too much in memory.
Should we change lastseen to a date and check if NOW> lastseen ? This would
skip a lot of writes ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #33 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #32)
> Before continuing here I think we should first confirm that the code is the
> cause of the problem.
> 
> I have talked with Nick last month and it seemed that it came from somewhere
> else:
> 
> """
> Errors in the logs "DBD::mysql::db begin_work failed: Already in a
> transaction" - it seemed to increase during heavy circ periods - DB was
> slowed by constant hits and then clashes
> """
> 
> It does not sound related to this code, but more to rebuild_zebra.pl that
> uses AutoCommit instead of a DBIC transaction.

While that may be true, it does not change the fact that this feature *is* a
performance killer. We've seen multiple instances of slow servers that having a
immediate speed improvement simply by disabling this feature!

Nothing about transactions has been mentioned on this bug previously, are you
sure you are commenting on the correct bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #32 from Jonathan Druart  
---
Before continuing here I think we should first confirm that the code is the
cause of the problem.

I have talked with Nick last month and it seemed that it came from somewhere
else:

"""
Errors in the logs "DBD::mysql::db begin_work failed: Already in a transaction"
- it seemed to increase during heavy circ periods - DB was slowed by constant
hits and then clashes
"""

It does not sound related to this code, but more to rebuild_zebra.pl that uses
AutoCommit instead of a DBIC transaction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #31 from Kyle M Hall  ---
> What happens? Somehow $session is already undef when you call track. If we
> need to call CGI::Session->new($sessionID) each time, we do not really
> benefit in terms of db access (well: 1 lookup in sessions instead of 1 in
> borrowers).

That would at least be changing from 1 write to 1 read, which is definitely an
improvement, right?

> Is there a different approach? What about using a cache key? (Do we want to
> pollute the cache with keys for every session..)

So you're suggesting storing something like

--
my $cache = Koha::Caches->get_instance();
my $cache_key = "seen-for-session-$borrowernumber";
my $cached = $cache->get_from_cache($cache_key, { unsafe => 1});
unless ( $cached ) {
  $patron->track_login;
  $cache->set_in_cache($cache_key, 1);
}
--

If so, I think that works! Let me know and I'll submit a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #30 from Marcel de Rooy  ---
This unfortunately is not enough. We have to deal here with the wonderous
CGI::Session object ;)

Test this:
Remove all sessions.
Login.
Now check sessions again. You have 5 entries. 1 entry contains the info about
the logged in user. You should expect the new track param here too. But it is
not there.

What happens? Somehow $session is already undef when you call track. If we need
to call CGI::Session->new($sessionID) each time, we do not really benefit in
terms of db access (well: 1 lookup in sessions instead of 1 in borrowers).

Is there a different approach? What about using a cache key? (Do we want to
pollute the cache with keys for every session..)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #29 from Kyle M Hall  ---
Created attachment 75427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75427=edit
Bug 18821 - Flush session after setting tracked_for_session

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

   Keywords|Academy |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #28 from Marcel de Rooy  ---
Are we trusting on autoflush to save the session data?
I saw that the date was updated a second time while being in the same session.
Do we need a specific session flush (especially under Plack)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #27 from Kyle M Hall  ---
Thanks for the followup Charles!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #26 from Charles Farmer  ---
Never mind my last comment, it wouldn't be testable at the function level under
t/ otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #25 from Charles Farmer  ---
Forgot to post a question in my last message: how come
track_login_for_session's inside EXPORTER_OK? Does it make sense to use it
anywhere else than inside C4/Auth.pm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #24 from Charles Farmer  ---
The patch does as described in the test plan, that is to only update the
lastseen field on login, but when looking at the Apache log, the time taken to
serve a page is pretty much the same.

Could more information be provided on the techniques used to bench the code?
Are you running a mysql_general_log alongside to better compare? Using ab
(apache benchmarks)?

Otherwise, now that there's an additional (follow-up) patch, it should pass `qa
-c 2`, prove, and as Julian said, it makes TrackLastPatronActivity behave more
closely the 'common sense' interpretation of its description. I feel confident
signing this off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Charles Farmer  changed:

   What|Removed |Added

  Attachment #75139|0   |1
is obsolete||

--- Comment #22 from Charles Farmer  ---
Created attachment 75288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75288=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Auth.t

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #23 from Charles Farmer  ---
Created attachment 75289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75289=edit
Bug 18821 - (follow-up) adds POD to track_login_for_session, removes tab in
Auth.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #21 from Kyle M Hall  ---
> However, I don't like the way it is done. Passing the CGI::Session object to
> a Koha::Patron method so it can read it and write to it. I think
> "Koha::Object"s methods shouldn't be aware of what we use to manage the
> session.


That seems like a reasonable request. Please take a look at the new edition of
the patch and sign off if you can!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #73891|0   |1
is obsolete||
  Attachment #73893|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall  ---
Created attachment 75139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75139=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Auth.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #19 from Katrin Fischer  ---
Please take a look at the last comment!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #18 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #15)
> I am not against the patch, but it's hard to imagine that 1 update query by
> request can be a  "performance killer".
For me the patch saves approximately 4ms per request. Not the huge performance
boost I expected by reading the bug title but it does save some time.

It should be noted that in the syspref description we can read
> Everytime a patron will connect, the borrowers.lastseen will be updated with 
> the current time
"connect" might be interpreted in different ways but I think what most people
understand is that a connection is when a user types their credentials in order
to be logged in the application, and not when the user is automatically logged
in by a session cookie. So the patch actually makes Koha behaviour closer to
the syspref description.

However, I don't like the way it is done. Passing the CGI::Session object to a
Koha::Patron method so it can read it and write to it. I think "Koha::Object"s
methods shouldn't be aware of what we use to manage the session.
Instead we should call track_login only when needed, like for example just
after a successful login :
https://gitlab.com/koha-community/Koha/blob/e5d5038fa3a1fbfaf81f4b01d319b00af5a7c46c/C4/Auth.pm#L1161

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #17 from Kyle M Hall  ---
(In reply to M. Tompsett from comment #16)
> (In reply to Jonathan Druart from comment #15)
> > I am not against the patch, but it's hard to imagine that 1 update query by
> > request can be a  "performance killer".
> 
> I think it may be because the value wasn't persistent, so it was always
> being queried.

Indeed, on a busy system we've seen this slow down servers quite dramatically!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #16 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #15)
> I am not against the patch, but it's hard to imagine that 1 update query by
> request can be a  "performance killer".

I think it may be because the value wasn't persistent, so it was always being
queried.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #15 from Jonathan Druart  
---
I am not against the patch, but it's hard to imagine that 1 update query by
request can be a  "performance killer".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #14 from Kyle M Hall  ---
(In reply to M. Tompsett from comment #13)
> Tests trigger all changed code. Thanks, Kyle. :)

Thanks for the catch! I think we can deprecate your scaffolding patch now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #73892|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #13 from M. Tompsett  ---
Tests trigger all changed code. Thanks, Kyle. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73706|0   |1
is obsolete||

--- Comment #11 from M. Tompsett  ---
Created attachment 73892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73892=edit
Bug 18821: [DO NOT PUSH] Print STDERR Scaffolding

Tests must trigger all STDERRs added.
prove t/db_dependent/Members.t
prove t/db_dependent/Auth.t

Patrons 3 and 4 not triggered.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73863|0   |1
is obsolete||

--- Comment #12 from M. Tompsett  ---
Created attachment 73893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73893=edit
Bug 18821 [QA Followup]: Add additional unit tests for completeness

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73175|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Created attachment 73891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73891=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Enabling TrackLastPatronActivity can cause an extreme performance hit,
especially on the staff side during checkin and checkout. It makes more sense
to only update the last activity timestamp on the first access of a given
session. This will greatly improve performance while retaining the same basic
information.

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Members.t

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #9 from Kyle M Hall  ---
Created attachment 73863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73863=edit
Bug 18821 [QA Followup]: Add additional unit tests for completeness

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

--- Comment #8 from M. Tompsett  ---
Created attachment 73706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73706=edit
Bug 18821: [DO NOT PUSH] Print STDERR Scaffolding

Tests must trigger all STDERRs added.
prove t/db_dependent/Members.t
prove t/db_dependent/Auth.t

Patrons 3 and 4 not triggered.


Current status: Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #7 from M. Tompsett  ---
Fails to trigger changed code. Attaching print STDERR scaffolding. Auth 3 and
Auth 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65687|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 73175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73175=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Enabling TrackLastPatronActivity can cause an extreme performance hit,
especially on the staff side during checkin and checkout. It makes more sense
to only update the last activity timestamp on the first access of a given
session. This will greatly improve performance while retaining the same basic
information.

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2018-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA
 Depends on||16276
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276
[Bug 16276] When automatically deleting expired borrowers, make sure they
didn't log in recently
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

--- Comment #5 from Alex Buckley  ---
Hi Kyle

Testing your patch on kohadevbox I am finding that the lastseen column is
updated everytime I browse a page even though the test plan says it shouldn't

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64426|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 65687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65687=edit
Bug 18821 - TrackLastPatronActivity is a performance killer

Enabling TrackLastPatronActivity can cause an extreme performance hit,
especially on the staff side during checkin and checkout. It makes more sense
to only update the last activity timestamp on the first access of a given
session. This will greatly improve performance while retaining the same basic
information.

Test Plan:
1) Apply this patch
2) Start a new session ( a private browser window works well )
3) Note the lastseen column in the borrowers table is updated
4) Browse a few pages, not the lastseen column is not updated again
5) Close the browser window and repeat steps 2-4
6) prove t/db_dependent/Members.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

2017-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Kyle M Hall  changed:

   What|Removed |Added

Summary|GetPatronLastActivity is a  |TrackLastPatronActivity is
   |performance killer  |a performance killer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/