[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|EDIFACT receipting of items |EDIFACT receipting of items
  release notes|should now respect the  |should now respect the
   |AcqItemSetSubfieldsWhenRece |`AcqItemSetSubfieldsWhenRec
   |ived systempreference   |eived` system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

--- Comment #12 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

--- Comment #11 from Katrin Fischer  ---
Passing QA on this as agreed with RM - both parties heavily using EDIFACT have
been involved in the QA process. Tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

--- Comment #10 from Katrin Fischer  ---
Created attachment 93947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93947=edit
Bug 20780: (follow-up) Use Koha::Object

Signed-off-by: Brendan Gallagher 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93672|0   |1
is obsolete||
  Attachment #93673|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 93946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93946=edit
Bug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI

Signed-off-by: Brendan Gallagher 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|Edifact reciepting of items |EDIFACT receipting of items
  release notes|should now respect the  |should now respect the
   |AcqItemSetSubfieldsWhenRece |AcqItemSetSubfieldsWhenRece
   |ived systempreference   |ived systempreference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #81730|0   |1
is obsolete||

--- Comment #7 from Brendan Gallagher  ---
Created attachment 93672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93672=edit
Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #81731|0   |1
is obsolete||

--- Comment #8 from Brendan Gallagher  ---
Created attachment 93673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93673=edit
Bug 20780: (follow-up) Use Koha::Object

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22348


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22348
[Bug 22348] Koha::EDI has no tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

--- Comment #6 from Martin Renvoize  ---
Moved to Koha::Object (reason for not doing so before was consistency.. the
rest of Koha::EDI uses dbic directly)

No tests.. yup.. because it would entail writing tests for all of Koha::EDI
which currently don't exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

--- Comment #5 from Martin Renvoize  ---
Created attachment 81731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81731=edit
Bug 20780: (follow-up) Use Koha::Object

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #75440|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 81730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81730=edit
Bug 20780 - Add handling for AcqItemSetSubfieldsWhenRecieved in EDI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
* + $schema->resultset('Aqorder') [...]

=> We have Koha::Acquisition::Order

* Tests?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |colin.campbell@ptfs-europe.
   |y.org   |com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|Edifact reciepting of items |Edifact reciepting of items
  release notes|should now respect the  |should now respect the
   |AcqItemSetSubfieldsWhenReci |AcqItemSetSubfieldsWhenRece
   |eved systempreference   |ived systempreference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|EDI: Add support for|EDI: Add support for
   |'AcqItemSetSubfieldsWhenRec |'AcqItemSetSubfieldsWhenRec
   |ieved'  |eived'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/