[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #13 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #10) > Thanks, Owen, for the sign-off and retesting. > Article slips still work for me. Thx Katrin for QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #10 from Katrin Fischer --- Thanks, Owen, for the sign-off and retesting. Article slips still work for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Katrin Fischer changed: What|Removed |Added Attachment #75764|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 75792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75792=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #8 from Owen Leonard --- This indeed fixes the error I was getting in my devbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Owen Leonard changed: What|Removed |Added Attachment #75719|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 75764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75764=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > If you think my request is so silly, maybe you should epxlain it anyway. Sure :) As mentioned in comment1 Owen got an error. And you and I did not (see also commit message). The error comes from a missing module; might be a devbox config issue for Owen. But the script itself calls C4::Letters but does not load it. So it depends on implicit loading by one of the other modules or deeper down the chain. We should not assume it will be loaded. If one day Letters is removed elsewhere, the script does not compile. So what does this oneliner do: add the missing module for that reason. Which is indeed stated ultra compact in the commit msg. No test plan needed. Back to SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #5 from Katrin Fischer --- If you think my request is so silly, maybe you should epxlain it anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #4 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > I don't see a sign off or a test plan. What is this supposed to fix? > > Printing article request slips works without problems for me. > Can you please explain and reset to needs signoff? LOL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I don't see a sign off or a test plan. What is this supposed to fix? Printing article request slips works without problems for me. Can you please explain and reset to needs signoff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #1 from Marcel de Rooy --- Created attachment 75719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75719=edit Bug 20851: Add module to circ/article-request-slip.pl See bug 20468, comment7. Although the script seems to compile well, we better add the module here. Trivial change. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Moving trivial fix to SO rightaway -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |trivial Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
