[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #13 from Martin Renvoize  ---
Not pushing to 18.05.x as it could surprise unsuspecting librarians during a
minor update having this permission disappear (even though it effectively does
nothing at present).

Nice fix for 18.11, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Nick Clemens  ---
Pushed to master for 18.11, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75476|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 75562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75562=edit
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

Signed-off-by: Owen Leonard 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 CC||m.de.r...@rijksmuseum.nl

--- Comment #10 from Marcel de Rooy  ---
> Bonus:
> borrowers.flags is recalculated for patrons with management
> permission.

No bonus imo.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Owen Leonard  changed:

   What|Removed |Added

  Attachment #75349|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 75476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75476=edit
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75348|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 75349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75349=edit
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management permissions is deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer  changed:

   What|Removed |Added

Summary|Management Permissions  |Management permissions is
   |Deprecated  |deprecated
   Severity|major   |normal
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/