[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #114 from David Nind --- Patch no longer applies 8-(: root@9512ab8ec1bb:koha(bz4461)$ git bz apply 4461 Bug 4461 - Context-sensitive report a problem screen 100506 - Bug 4461: Database and syspref changes 100507 - Bug 4461: Problem Report Koha objects 100508 - Bug 4461: Submit a problem report 100509 - Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled 100510 - Bug 4461: (follow-up) Creating sample notice and other fixes 100511 - Bug 4461: Rename report date with created_on 100512 - Bug 4461: Use KohaAdminEmailAddress pref as 'from' 100513 - Bug 4461: Use our local_referer instead of HTTP_REFERER 100514 - Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined 100515 - Bug 4461: Simplify recipients code 100516 - Bug 4461: Better error handling 100517 - Bug 4461: Remove hard requirement on OpacKohaUrl 100518 - Bug 4461: Drop 'from_address' use 'reply_address' 100519 - Bug 4461: Use get_effective_email from bug 22823 100520 - Bug 4461: Adding user flags for managing OPAC problem reports 100521 - Bug 4461: Add problem reports link to mainpage and admin home 100522 - Bug 4461: Manage problem reports on the staff client 100523 - Bug 4461: (follow-up) Add missing relationship accessor 100524 - Bug 4461: DBIC Schema Files 100619 - Bug 4461: Update license statements 100989 - Bug 4461: Fix status and borrowernumber fields in problem_reports and more 100990 - Bug 4461: Checks on library email before enqueuing letter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 4461: Database and syspref changes error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 4461: Database and syspref changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #113 from Aleisha Amohia --- Created attachment 100990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100990=edit Bug 4461: Checks on library email before enqueuing letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #112 from Aleisha Amohia --- Created attachment 100989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100989=edit Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #111 from Jonathan Druart --- - I would prefer status to be a varchar and have a readable status, instead of N, V, C - The "hide viewed" and "hide closed" filters does not work if the page is not reloaded - Why do not we see the recipient of the report in the table? We see the reports sent to the administrator, is that expected? - I think there is a missing test in the controller (minor) If recipient is forced to "librarian" but the library does not have an email address defined, then the message will be enqueued anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #110 from Jonathan Druart --- When the form is sent, the success message appears but with the form bellow. Should not we hide it? https://snipboard.io/HJKtdp.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #109 from Jonathan Druart --- report_problems.borrowernumber defaults to NULL. Should not it be NOT NULL instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #108 from Jonathan Druart --- Created attachment 100619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100619=edit Bug 4461: Update license statements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #107 from Aleisha Amohia --- (In reply to Martin Renvoize from comment #106) > This is looking great now Aliesha, thankyou for the addition of a UI, it > makes is significantly easier to test and more of a complete feature. > > I feel we've hit minimum viable product here now and would love to get this > go through.. I added a couple of followups simply to aid in testing.. > firstly I think you just missed adding the file to the commit for the patron > relationships accessor and then I added a commit with the dbic schema > changes so this can be tested on sandboxes and the likes. > > Signing off. Thanks I did forget to attach that file! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added URL|https://gitlab.com/mrenvoiz | |e/Koha/-/tree/bug_24131 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added URL||https://gitlab.com/mrenvoiz ||e/Koha/-/tree/bug_24131 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #106 from Martin Renvoize --- This is looking great now Aliesha, thankyou for the addition of a UI, it makes is significantly easier to test and more of a complete feature. I feel we've hit minimum viable product here now and would love to get this go through.. I added a couple of followups simply to aid in testing.. firstly I think you just missed adding the file to the commit for the patron relationships accessor and then I added a commit with the dbic schema changes so this can be tested on sandboxes and the likes. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #105 from Martin Renvoize --- Created attachment 100524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100524=edit Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #104 from Martin Renvoize --- Created attachment 100523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100523=edit Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100498|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 100520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100520=edit Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100499|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 100521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100521=edit Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100500|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 100522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100522=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100497|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 100519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100519=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100496|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 100518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100518=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100494|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 100516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100516=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100492|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 100514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100514=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100495|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 100517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100517=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100491|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 100513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100513=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100493|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 100515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100515=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100490|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 100512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100512=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100489|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 100511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100511=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99931|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 100508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100508=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #100488|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 100510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100510=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99932|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 100509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100509=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99930|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 100507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100507=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99929|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 100506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100506=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added QA Contact|n...@bywatersolutions.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Depends on||22823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 [Bug 22823] Koha::Library needs a method for obtaining the inbound email address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Depends on||10269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 [Bug 10269] add a way to define a specific replyto email address for some notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #85 from Aleisha Amohia --- Created attachment 100499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100499=edit Bug 4461: Add problem reports link to mainpage and admin home -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #86 from Aleisha Amohia --- Created attachment 100500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100500=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99938|0 |1 is obsolete|| --- Comment #79 from Aleisha Amohia --- Created attachment 100493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100493=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99939|0 |1 is obsolete|| --- Comment #80 from Aleisha Amohia --- Created attachment 100494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100494=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99940|0 |1 is obsolete|| --- Comment #81 from Aleisha Amohia --- Created attachment 100495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100495=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #84 from Aleisha Amohia --- Created attachment 100498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100498=edit Bug 4461: Adding user flags for managing OPAC problem reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99942|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 100497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100497=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99941|0 |1 is obsolete|| --- Comment #82 from Aleisha Amohia --- Created attachment 100496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100496=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99937|0 |1 is obsolete|| --- Comment #78 from Aleisha Amohia --- Created attachment 100492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100492=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99934|0 |1 is obsolete|| --- Comment #75 from Aleisha Amohia --- Created attachment 100489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100489=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99936|0 |1 is obsolete|| --- Comment #77 from Aleisha Amohia --- Created attachment 100491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100491=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99933|0 |1 is obsolete|| --- Comment #74 from Aleisha Amohia --- Created attachment 100488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100488=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Attachment #99935|0 |1 is obsolete|| --- Comment #76 from Aleisha Amohia --- Created attachment 100490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100490=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #73 from Aleisha Amohia --- We keep getting stuck on the lack of GUI. I understand. I'll write the GUI for this now so it can all go through in one go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #72 from Martin Renvoize --- I'm reasonably happy with the followups here.. it feels like this was written with a GUI and a process in mind but without submitting the GUI half and as such the code is a little confusing.. why not just send emails and skip the table element entirely ;) Still.. I like the feature and at this point, the code seems to work reasonably well.. I'd love to see a GUI including a process for moving reports through various states added this cycle if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #71 from Martin Renvoize --- Created attachment 99942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99942=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #69 from Martin Renvoize --- Created attachment 99940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99940=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #70 from Martin Renvoize --- Created attachment 99941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99941=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99639|0 |1 is obsolete|| --- Comment #68 from Martin Renvoize --- Created attachment 99939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99939=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99638|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 99938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99938=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99637|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 99937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99937=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99603|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 99933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99933=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99636|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 99936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99936=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99602|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 99932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99932=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99601|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 99931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99931=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99635|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 99935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99935=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99633|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 99934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99934=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99600|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 99930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99930=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99599|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 99929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99929=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #57 from Martin Renvoize --- Followups coming.. this has turned into a todo list for myself to help get this past the line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #56 from Martin Renvoize --- It also requires 'OpacKohaUrl' to be enabled.. that feels like an error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #55 from Katrin Fischer --- (In reply to Jonathan Druart from comment #49) > (In reply to Katrin Fischer from comment #47) > > If Aleisha says the GUI will be next, I am not so worried about the status > > and such. It would be nice to see the code, but I feel this was just > > planning ahead and would not cause harm for now. > > For now no. But when the GUI will be there the message will be marked as > "new" even if they have been processed already. If we mark them all as > "processed" when the GUI is added, that will also be wrong: some may have > not still been processed. But that problem will be the same when we add the status column later on - if it's there now or not. I'd just aim for having the GUI same release if possible? I don't see the big issue here I'd rather spent the time to build the GUI then to make it work perfectly without now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #54 from Martin Renvoize --- Bug say's it's sponsored.. can we add a Sponsored-by line to at least one of the patches ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #53 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #50)
> Comment on attachment 99637 [details] [review]
> Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
>
> Review of attachment 99637 [details] [review]:
> -
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> @@ +376,5 @@
> >yes: Allow
> >no: "Don't allow"
> > - patrons to submit problem reports for OPAC pages to the
> > library or Koha Administrator.
> > +- ""
> > +- "NOTE: You must have KohaAdminEmailAddress
> > enabled."
>
> This isn't actually true is it?.. we use branch email in preference to
> KohaAdminEmailAddress so it's just a fallback not a hard requirement.
With the 404 redirect in opac-reportproblem.pl it is a hard requirement.
Original code was assuming the pref was filled IIRC.
> ::: opac/opac-reportproblem.pl
> @@ +41,5 @@
> > );
> >
> > +if ( !C4::Context->preference('OPACReportProblem')
> > +|| !C4::Context->preference('KohaAdminEmailAddress') )
> > +{
>
> Don't we actually use branchemail in preference to KohaAdminEmailAddress so
> this isn't actually a hard requirement?
Not what the code is actually doing. Maybe it needs to be adjusted.
105 to_address =>
C4::Context->preference('KohaAdminEmailAddress'),
(In reply to Martin Renvoize from comment #51)
> Comment on attachment 99638 [details] [review]
> Bug 4461: Simplify recipients code
>
> Review of attachment 99638 [details] [review]:
> -
>
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt
> @@ +32,5 @@
> > +[% IF recipient == 'admin' %]
> > +Your problem report has been sent to the Koha
> > administrator.
> > +[% ELSE %]
> > +Your problem report has been sent to the
> > library.
> > +[% END %]
>
> Do we really need to get this specific in the OPAC?
>
> I'd say we just need to say whether the email was successfully sent or not
> and not worry so much whether it's KohaAdminEmail or Library Branch Email..
> the end user doesn't have a way to select who it goes to anyway.
>
> If we remove this we could simplify the code a little
Feel free to submit any follow-ups you wish ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #52 from Martin Renvoize --- (In reply to Jonathan Druart from comment #49) > (In reply to Katrin Fischer from comment #47) > > If Aleisha says the GUI will be next, I am not so worried about the status > > and such. It would be nice to see the code, but I feel this was just > > planning ahead and would not cause harm for now. > > For now no. But when the GUI will be there the message will be marked as > "new" even if they have been processed already. If we mark them all as > "processed" when the GUI is added, that will also be wrong: some may have > not still been processed. Agreed, without any way of maintaining the status, I think we should remove it from this bug.. I like the idea of having a UI with Koha for progressing and tracking reported issues but until that time we shouldn't record incorrect status's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #51 from Martin Renvoize --- Comment on attachment 99638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99638 Bug 4461: Simplify recipients code Review of attachment 99638: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=4461=99638) - ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt @@ +32,5 @@ > +[% IF recipient == 'admin' %] > +Your problem report has been sent to the Koha > administrator. > +[% ELSE %] > +Your problem report has been sent to the library. > +[% END %] Do we really need to get this specific in the OPAC? I'd say we just need to say whether the email was successfully sent or not and not worry so much whether it's KohaAdminEmail or Library Branch Email.. the end user doesn't have a way to select who it goes to anyway. If we remove this we could simplify the code a little -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #50 from Martin Renvoize ---
Comment on attachment 99637
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99637
Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined
Review of attachment 99637:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=4461=99637)
-
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ +376,5 @@
>yes: Allow
>no: "Don't allow"
> - patrons to submit problem reports for OPAC pages to the
> library or Koha Administrator.
> +- ""
> +- "NOTE: You must have KohaAdminEmailAddress
> enabled."
This isn't actually true is it?.. we use branch email in preference to
KohaAdminEmailAddress so it's just a fallback not a hard requirement.
::: opac/opac-reportproblem.pl
@@ +41,5 @@
> );
>
> +if ( !C4::Context->preference('OPACReportProblem')
> +|| !C4::Context->preference('KohaAdminEmailAddress') )
> +{
Don't we actually use branchemail in preference to KohaAdminEmailAddress so
this isn't actually a hard requirement?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #49 from Jonathan Druart --- (In reply to Katrin Fischer from comment #47) > If Aleisha says the GUI will be next, I am not so worried about the status > and such. It would be nice to see the code, but I feel this was just > planning ahead and would not cause harm for now. For now no. But when the GUI will be there the message will be marked as "new" even if they have been processed already. If we mark them all as "processed" when the GUI is added, that will also be wrong: some may have not still been processed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #48 from Martin Renvoize --- I documented some of the ReplyTo stuff back when it was first introduced as a feature in bug 9530.. Jonathan is correct, we should not spoof user address in the from address is it's very likely you'll end up in a spam list that way. https://wiki.koha-community.org/wiki/MRenvoize/Email roughly explains it and I have a feeling that was lifted and put in our own manual somewhere but I can't see it right now. In bug 22821 I add some handling to allow specifying reply-to address at the EnqueuLetter stage.. it is my feeling if you want to send email 'from' a patron 'to' a library you should use a combination of not supplying a 'from' address (as it'll pick an appropriate one in _send_message_by_email), setting the 'to' using Koha::Library->get_effective_email (perhaps I should rename that get_inbound_email_address) which will do an appropriate fallback through replyto addresses and finally add a reply-to address of the patron so whoever receives the email can reply to the actual user. See bug 22821 and bug 22823 for some further details around email handling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #47 from Katrin Fischer --- If Aleisha says the GUI will be next, I am not so worried about the status and such. It would be nice to see the code, but I feel this was just planning ahead and would not cause harm for now. > > In this case I think we could set it as: > > $patron->notice_email_address || $koha_admin; > > I do not think so, as said in the commit message "I do not think it's a good > idea, we should not send an email with "from" if not really sent by the > user." I think it's bad practice to do that, I may be wrong however. I agree here. To avoid being rejected as spam you can use the reporting patron's email as replyto, but not as From. So it's more than a bad practice as a lot of mail servers got a lot stricter in the last years - it will be real trouble (been there). From and Return-path needs to be from the mail servers domain. See also: https://wiki.koha-community.org/wiki/MRenvoize/Email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #46 from Jonathan Druart --- (In reply to Nick Clemens from comment #45) > (In reply to Jonathan Druart from comment #44) > > What do others think? Could we get your opinions? > > I think having option to get email notices as well as having the staff > interface is useful - I don't think we need to pick only one - but once > there is a GUI the notices should be optional The problem with having the GUI after is that we do not deal with some of the already created fields. See comment 42: "the status will never be updated, what will happen when we will have the UI?" > >Bug 4461: Use KohaAdminEmailAddress pref as 'from' > I don't understand that followup - 'from_address' is just picked form the > message in C4/Letters - it is 'to_address' that usually gets filled at send > - to be to the borrowernumber > > In this case I think we could set it as: > $patron->notice_email_address || $koha_admin; I do not think so, as said in the commit message "I do not think it's a good idea, we should not send an email with "from" if not really sent by the user." I think it's bad practice to do that, I may be wrong however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #45 from Nick Clemens --- (In reply to Jonathan Druart from comment #44) > What do others think? Could we get your opinions? I think having option to get email notices as well as having the staff interface is useful - I don't think we need to pick only one - but once there is a GUI the notices should be optional >Bug 4461: Use KohaAdminEmailAddress pref as 'from' I don't understand that followup - 'from_address' is just picked form the message in C4/Letters - it is 'to_address' that usually gets filled at send - to be to the borrowernumber In this case I think we could set it as: $patron->notice_email_address || $koha_admin; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #44 from Jonathan Druart --- What do others think? Could we get your opinions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #43 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #42) > I have attached few follow-ups, pick the ones you need/want. > > However I am a bit at lost here. > > There is no UI so far, but we have such things: > +status varchar(1) NOT NULL default 'N', -- status of the report. > N=new, V=viewed, C=closed > > so the status will never be updated, what will happen when we will have the > UI? > > IMO we should bring the UI with that patchset, and remove the notice. Do we > really want the notice to be sent? If yes, do we really want the new table? > :) As mentioned in multiple earlier comments, once this is pushed I want to add a follow-up feature where staff can manage problem reports on the intranet. The original report for this feature asked for an email to be sent so that's what I implemented. Up to the community if they would prefer the email notice version or the staff-side management version, but I don't see any harm in having both. > > Also, do we really need the problem_reports.recipient DB field if we have > the email? > Same for username? We have the borrowernumber. > > About the DB structure again, it seems that status should be an ENUM. Agreed that some of these fields are redundant, and status can be an ENUM. Happy to make these changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #42 from Jonathan Druart --- I have attached few follow-ups, pick the ones you need/want. However I am a bit at lost here. There is no UI so far, but we have such things: +status varchar(1) NOT NULL default 'N', -- status of the report. N=new, V=viewed, C=closed so the status will never be updated, what will happen when we will have the UI? IMO we should bring the UI with that patchset, and remove the notice. Do we really want the notice to be sent? If yes, do we really want the new table? :) Also, do we really need the problem_reports.recipient DB field if we have the email? Same for username? We have the borrowernumber. About the DB structure again, it seems that status should be an ENUM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |alei...@catalyst.net.nz |ommunity.org| Status|ASSIGNED|In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #39 from Jonathan Druart --- Created attachment 99637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99637=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #41 from Jonathan Druart --- Created attachment 99639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99639=edit Bug 4461: Better error handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #40 from Jonathan Druart --- Created attachment 99638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99638=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #38 from Jonathan Druart --- Created attachment 99636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99636=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #37 from Jonathan Druart --- Created attachment 99635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99635=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |jonathan.dru...@bugs.koha-c ||ommunity.org Status|Failed QA |ASSIGNED --- Comment #36 from Jonathan Druart --- I am trying to submit follow-ups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #35 from Jonathan Druart --- Some notes: 1. reportdate must be created_on, with a type "timestamp". 2. opac/opac-reportproblem.pl 112 my $from_address = $member->email || $member->emailpro || $member->B_email || $koha_admin; We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #34 from Jonathan Druart --- Created attachment 99633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99633=edit Bug 4461: Rename report date with created_on And make it a timestamp type column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #98725|0 |1 is obsolete|| --- Comment #32 from David Nind --- Created attachment 99602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99602=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #99551|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 99603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99603=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #98689|0 |1 is obsolete|| --- Comment #31 from David Nind --- Created attachment 99601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99601=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #98688|0 |1 is obsolete|| --- Comment #30 from David Nind --- Created attachment 99600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99600=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #98687|0 |1 is obsolete|| --- Comment #29 from David Nind --- Created attachment 99599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99599=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #28 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #27) > (In reply to Katrin Fischer from comment #24) > > Hi Aleisha, > > > > starting with review and QA tools here: > > > > 1) Can you check if this is a real one or a false positive? > > FAIL Koha/ProblemReport.pm > >FAIL pod coverage > > POD coverage was greater before, try perl > > -MPod::Coverage=PackageName -e666 > > > > i dont really know how i could expand on the documentation i've already done! That's ok, we get those as false positives sometimes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #27 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #24) > Hi Aleisha, > > starting with review and QA tools here: > > 1) Can you check if this is a real one or a false positive? > FAIL Koha/ProblemReport.pm >FAIL pod coverage > POD coverage was greater before, try perl > -MPod::Coverage=PackageName -e666 > i dont really know how i could expand on the documentation i've already done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
