[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |DUPLICATE

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105390|0 |1 is

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #51 from Andrew Fuerste-Henry --- Test plan: 1: Apply patch, updatedatabase, restart all 2: Set AllowOnOrderOnShelfHolds to Allow 3: Set relevant circ rule to allow onshelf holds If Any Unavailable 4: Find a bib with 2

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103179|0 |1 is

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #50 from Kyle M Hall --- Created attachment 105390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105390=edit Bug 6918: Add syspref -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #49 from Katrin Fischer --- Personally I think this is a bug that hasn't been fixed in an awfully long time - maybe because use of "AllowOnShelfHolds = yes" is the more common choice. But I'd be ok with a preference if

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Marcel de Rooy changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #103175|0 |1 is

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #46 from Andrew Fuerste-Henry --- Test plan: 1 find a record with two items 2 set one item to On Order (or any other negative Not For Loan value) 3 set circ rule to On Shelf Holds = Yes 4 confirm bib and either item can

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #103021|0 |1 is obsolete|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #103020|0 |1 is obsolete|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #103016|0 |1 is obsolete|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #41 from Kyle M Hall --- (In reply to Andrew Fuerste-Henry from comment #40) > With On Shelf Holds set to If Any Unavailable, I'm seeing the correct > behavior. I can place holds on items with a negative NotForLoan value

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #102998|0 |1 is obsolete|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #70232|0 |1 is obsolete|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Niamh changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 jmbroust changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer changed: What|Removed |Added Summary|can't place holds on 'on

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #36 from Katrin Fischer --- Ordered should be -1 if the sample data was used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #35 from Kyle M Hall --- (In reply to Zoe Bennett from comment #34) > I tested the patch by setting On Shelf Holds to "If all unavailable" and > then "If any unavailable". I set 7-Not for Loan

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Zoe Bennett changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Aleisha Amohia changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Attachment #68934|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Alex Buckley changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart changed: What|Removed |Added Attachment #68898|0

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Dominic Pichette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #29 from Jonathan Druart --- Simon, make sure your branch is up-to-date with origin/master -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #28 from Simon Pouchol --- Hey Jonathan, It seems to me the patch isn't applying : Applying: Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off fatal: sha1 information

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Simon Pouchol changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #27 from Jonathan Druart --- Patch rebased and rewritten, please test. Srdjan's concern is not valid IMO. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart changed: What|Removed |Added Attachment #19087|0

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Janet McGowan changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Patrick Robitaille changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #25 from Katrin Fischer --- I seem to remember that I had tested it at some point and the system had allowed holds on the negative notforloan values. Wondering now if it something changed. --

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #24 from Jessie Zairo --- If a library sets their On Shelf Holds to "If all unavailable" or "If any unavailable" patrons cannot place holds on items that are marked 'on order' (not for

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #23 from Katrin Fischer --- This is still a desirable feature, but the existing patch is quite old and possibly needs a more or less complete rewrite: Falling back to patching base and 3-way

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Christopher Brannon cbran...@cdalibrary.org changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Christopher Brannon cbran...@cdalibrary.org changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added When did the bot|2013-09-29 00:00:00

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 I'm just a bot git...@bugs.koha-community.org changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC|

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15077|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14451|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #13 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #12) 4) Attempt to place a hold on the item, you should now be able to do so I see that this patch affects several scripts. Should one test placing a hold

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- I changed the prototype for CountItemsIssued, so I had to update all calls to it. Still, it wouldn't hurt to test in multiple ways. Kyle (In reply to comment #13) (In

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14390|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14158|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Passed

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #14152|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14004|0 |1

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Priority|P5 - low|P3

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|Trivial patch |Small

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14004action=edit Bug 6918 - can't place holds on 'on order' items with

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs