[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |MOVED --- Comment #31 from Jonathan Druart --- Please see bug 10723, bug 10724 and bug 10725. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Depends on||10725 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Depends on||10724 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Depends on||10723 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #30 from Jonathan Druart --- (In reply to Katrin Fischer from comment #29) > I have spent some time looking at those patches and I am worried that they > try to do too many things. I think i have identified what they do, but I am > not sure (which is not a good sign :) ). I think we have 3 things here, that > ideally should be broken up into 3 different bugs to make this easier > testable: > > - Merging GetPendingOrders and GetOrders + regression tests > - Adding basket group name search > - Adding datatables to the pending oders page > > Jonathan, do you think you could break it up on different bugs with test > plans for each? The 3 patchs can be tested together so I don't think it is relevant, but I will do that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- I have spent some time looking at those patches and I am worried that they try to do too many things. I think i have identified what they do, but I am not sure (which is not a good sign :) ). I think we have 3 things here, that ideally should be broken up into 3 different bugs to make this easier testable: - Merging GetPendingOrders and GetOrders + regression tests - Adding basket group name search - Adding datatables to the pending oders page Jonathan, do you think you could break it up on different bugs with test plans for each? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Patch complexity|Medium patch|Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #18501|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 19636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19636&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #18502|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 19637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19637&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #22) > Patches no longer apply cleanly for a conflict in Acquisitions.pm. > Jonathan, could you double check those lines here, rebase and switch back to > signed off? > > -&NewOrder &DelOrder &ModOrder &GetPendingOrders &GetOrder > &GetOrders &GetOrdersByBiblionumber > +&NewOrder &DelOrder &ModOrder &GetOrder &GetOrders > &GetOrdersByBiblionumber > +&NewOrder &DelOrder &ModOrder &GetOrder &GetOrders Rebased. I added a little followup, I find a js error on reloading the page. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #27 from Jonathan Druart --- Created attachment 19640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19640&action=edit Bug 10124: Fix a js error : YAHOO is not defined json.min.js is not used in this page. The js include is useless. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #18503|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 19638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19638&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #19309|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 19639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19639&action=edit Bug 10124: QA followup - Remame the t/.../GetPendingOrders.pm to t/.../SearchOrders.pm according to the package name. - Rename IndependantBranches with IndependentBranches - FIX levels in pod Note that 1 qa issue still exists (not introduced by this development): FAIL t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm OK pod OK forbidden patterns FAIL valid Invalid CODE attribute: Test( 1 ) OK critic These tests are never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Patches no longer apply cleanly for a conflict in Acquisitions.pm. Jonathan, could you double check those lines here, rebase and switch back to signed off? -&NewOrder &DelOrder &ModOrder &GetPendingOrders &GetOrder &GetOrders &GetOrdersByBiblionumber +&NewOrder &DelOrder &ModOrder &GetOrder &GetOrders &GetOrdersByBiblionumber +&NewOrder &DelOrder &ModOrder &GetOrder &GetOrders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Bug 10124 depends on bug 10044, which changed state. Bug 10044 Summary: Doubled up paging on order receive http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 What|Removed |Added Status|Pushed to Stable|CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #21 from Jonathan Druart --- Created attachment 19309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19309&action=edit Bug 10124: QA followup - Remame the t/.../GetPendingOrders.pm to t/.../SearchOrders.pm according to the package name. - Rename IndependantBranches with IndependentBranches - FIX levels in pod Note that 1 qa issue still exists (not introduced by this development): FAIL t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm OK pod OK forbidden patterns FAIL valid Invalid CODE attribute: Test( 1 ) OK critic These tests are never used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- This fails the QA script in 2 places, can you please take a look? FAILC4/Acquisition.pm OK pod FAIL forbidden patterns forbidden pattern: IndependantBranches is now known as IndependentBranches (line 1553) FAILt/db_dependent/lib/KohaTest/Acquisition/GetPendingOrders.pm OK pod OK forbidden patterns OK valid FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Pierre Angot changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #19 from Pierre Angot --- Test on sandbox. Signed off. I've created 2 baskets, and add them to a basketgroup. Then, I've made a receive to test filters. - Authors, ... : ok - Basket : ok - Basket group name : ok - Order line : ok I've also tested column filter. Everything is fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #18 from Jonathan Druart --- Created attachment 18503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18503&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #17 from Jonathan Druart --- Created attachment 18502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18502&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #18493|0 |1 is obsolete|| Attachment #18494|0 |1 is obsolete|| Attachment #18495|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 18501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18501&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #15 from Jonathan Druart --- Created attachment 18495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18495&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #14 from Jonathan Druart --- Created attachment 18494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18494&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #17691|0 |1 is obsolete|| Attachment #17692|0 |1 is obsolete|| Attachment #17701|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 18493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18493&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Pierre Angot changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||tredok.pie...@gmail.com --- Comment #12 from Pierre Angot --- Sandbox setup by tredok.pie...@gmail.com with database 2 and bug 10124 on Thu May 30 08:42:02 2013 Something went wrong ! Applying: Bug 10124: Merge GetPendingOrders and SearchOrders routines Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging acqui/orderreceive.pl Auto-merging t/db_dependent/Acquisition.t Applying: Bug 10124: Add basket group name in filters Applying: Bug 10124: Add filters on the pending orders table Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10124: Add filters on the pending orders table When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 10124 - Pending orders: ergonomic improvement Bug 10124: Merge GetPendingOrders and SearchOrders routines Apply? [yn] Bug 10124: Add basket group name in filters Apply? [yn] Bug 10124: Add filters on the pending orders table Apply? [yn] Patch left in /tmp/Bug-10124-Add-filters-on-the-pending-orders-table-GhyXZs.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #11 from mathieu saby --- Your patch is better and larger, so I put mine "in discussion". I will see if it deserves to be reopened after 10124 is pushed. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #10 from mathieu saby --- I think searching by basketgroup number could be a good option too. For example, it is needed in Rennes 2, because we classify printed basketgroups using there number, and we use this number in our relations with vendors ;-) But I am ok with your patch. I could rewrite mine later, only to add a filter by bg number, and we will see if the community agrees. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #9 from Jonathan Druart --- (In reply to comment #8) > Hello Jonathan. > I signed off 10044. > For the improvement of filters, I think your patch is a duplicate of a patch > I wrote some weeks ago : > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 > Could you take a look at it please? > > Mathieu Mathieu, My patch adds a filter for the basket group *name*, not number. So it is not really the same filter. I think it is more useful to search by name instead of number. Moreover, my patches add filter on the table itself too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #8 from mathieu saby --- Hello Jonathan. I signed off 10044. For the improvement of filters, I think your patch is a duplicate of a patch I wrote some weeks ago : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 Could you take a look at it please? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Depends on||10044 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Attachment #17693|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 17701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17701&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > Hi Jonathan, I believe this was a duplicate to 10044, but now I seethis is > marked enhancement. Could we extract a fix for the doubled up pagination? Done on bug 10044 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #5 from Katrin Fischer --- Hi Jonathan, I believe this was a duplicate to 10044, but now I seethis is marked enhancement. Could we extract a fix for the doubled up pagination? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- *** Bug 10044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #3 from Jonathan Druart --- Created attachment 17693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17693&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #2 from Jonathan Druart --- Created attachment 17692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17692&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #1 from Jonathan Druart --- Created attachment 17691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17691&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
