[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-09-13 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Sophie!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-09-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-09-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55385|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 55513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55513=edit
Bug 10227 : Fix GetMessagingPreferences when digest is possible

This bug is a bit tricky to test, as the result is somehow  random, depending
on the order of rows returned by sql request. You've got to change the
preferences several times to see bad results.

Enable EnhancedMessaging preferences
Set preferences for a borrower or a category.
run misc/cronjobs/advance_notices.pl and look in message_queue table the
letter_code of the generated messages.
Change digest selection and do the test again several times

Without patch, for message where digest is allowed (Advance_Notice, Item_Due),
for a borrower or a category with 'wants_digest' selected,
GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and
sometimes not.

With the patch, letter_code returned is always correct depending on digest
selected or not

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-09-08 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-09-08 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Chris Cormack  changed:

   What|Removed |Added

  Attachment #54826|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 55385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55385=edit
Bug 10227 : Fix GetMessagingPreferences when digest is possible

This bug is a bit tricky to test, as the result is somehow  random, depending
on the order of rows returned by sql request. You've got to change the
preferences several times to see bad results.

Enable EnhancedMessaging preferences
Set preferences for a borrower or a category.
run misc/cronjobs/advance_notices.pl and look in message_queue table the
letter_code of the generated messages.
Change digest selection and do the test again several times

Without patch, for message where digest is allowed (Advance_Notice, Item_Due),
for a borrower or a category with 'wants_digest' selected,
GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and
sometimes not.

With the patch, letter_code returned is always correct depending on digest
selected or not

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-08-24 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

--- Comment #2 from Sophie MEYNIEUX  ---
This bug is a bit tricky to test, as the result is somehow  random, depending
on the order of rows returned by sql request. You've got to change the
preferences several times to see bad results.

Enable EnhancedMessaging preferences
Set preferences for a borrower or a category. 
run misc/cronjobs/advance_notices.pl and look in message_queue table the
letter_code of the generated messages.
Change digest selection and do the test again several times 

Without patch, for message where digest is allowed (Advance_Notice, Item_Due),
for a borrower or a category with 'wants_digest' selected,
GetBorrowerMessagingPreferences returns sometimes letter_code with DGST and
sometimes not.

With the patch, letter_code returned is always correct depending on digest
selected or not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-08-24 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Sophie MEYNIEUX  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-08-24 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

Sophie MEYNIEUX  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10227] GetMessagingPreferences does not return correct Digest preferences

2016-08-24 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 54826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54826=edit
Bug 10227 : Fix GetMessagingPreferences when digest is possible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/