[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17949

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Suzanne Fayle  changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #91 from Jonathan Druart  
---
We need to fix these tests ASAP, a bug may be hidden.
I have managed to reproduce the failure on my local install once, but cannot
anymore.
It would be good to see several fellow trying to:
1. backup the DB
2. prove t/db_dependent/Members.t
If the tests fail, keep the backup safe! Reinsert the data and try to recreate
the failure. And then debug :)

I don't understand the following lines:
295 $builder->build({
296 source => 'OldIssue',
297 value  => {
298 borrowernumber => $bor2inlist,
299 timestamp => '2016-01-01',
300 },
301 });

Why do we need an entry in the old_issues table? I have commented them but the
tests keep passing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #90 from Katrin Fischer  ---
Tests are failing on Jenkins, but passing when I run them locally:
http://jenkins.koha-community.org/job/Koha_master_D7/lastCompletedBuild/testReport/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #89 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #85 from Katrin Fischer  ---
Created attachment 49767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49767=edit
[PASSED QA] Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #88 from Katrin Fischer  ---
Created attachment 49770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49770=edit
[PASSED QA] Bug 10612: (QA followup)

Rename not_borrowered_since to not_borrowed_since

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #87 from Katrin Fischer  ---
Created attachment 49769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49769=edit
[PASSED QA] Bug 10612 - Unit tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #86 from Katrin Fischer  ---
Created attachment 49768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49768=edit
[PASSED QA] Bug 10612: Follow-up - correcting icon to be Font Awesome

- check print icon on the patron list summary page is correct

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49596|0   |1
is obsolete||
  Attachment #49597|0   |1
is obsolete||
  Attachment #49607|0   |1
is obsolete||
  Attachment #49740|0   |1
is obsolete||
  Attachment #49741|0   |1
is obsolete||

--- Comment #84 from Katrin Fischer  ---
Created attachment 49766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49766=edit
[PASSED QA] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

Signed-off-by: Owen Leonard 

Patron batches are correctly passed to the edit and delete pages.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #83 from Nick Clemens  ---
Created attachment 49741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49741=edit
Bug 10612: (QA followup)

Rename not_borrowered_since to not_borrowed_since

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49694|0   |1
is obsolete||

--- Comment #82 from Nick Clemens  ---
Created attachment 49740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49740=edit
Bug 10612 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #81 from Katrin Fischer  ---
Tested:
- patron with fines - not deleted
- patron with issues - not deleted
- patron who is a guarantor - not deleted
- patron who has none of that and is not a guarantor - deleted

This looks good now! 

Tests all pass and are nicely documented. Nick, could you add just one more
thing? A test to ensure a patron being a guarantor is not deleted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #80 from Nick Clemens  ---
Created attachment 49694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49694=edit
Bug 10612 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #79 from Katrin Fischer  ---
Repeated my test from comment#45 - this looks much better now.
Fixed a FA icon that got undone by the patch set in a tiny follow-up.

Please provide tests for the changes made to Members.pm in order for this to
move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #78 from Katrin Fischer  ---
Created attachment 49607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49607=edit
Bug 10612: Follow-up - correcting icon to be Font Awesome

- check print icon on the patron list summary page is correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48890|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #77 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #74)
> > +use Koha::Database;
> Not used.
Removed

> @@ +128,5 @@
> I don't understand this line, GetBorrowersToExpunge won't return a
> DBIx::Class object, so the ||
> $patrons_to_delete->[$i]->get_column('borrowernumber'); part is not
> necessary.

> @@ +179,4 @@
> Same here.

Both removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #75 from Nick Clemens  ---
Created attachment 49596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49596=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

Signed-off-by: Owen Leonard 

Patron batches are correctly passed to the edit and delete pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48892|0   |1
is obsolete||

--- Comment #76 from Nick Clemens  ---
Created attachment 49597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49597=edit
Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #74 from Jonathan Druart  
---
Comment on attachment 48890
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48890
[SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

Review of attachment 48890:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10612=48890)
-

::: tools/cleanborrowers.pl
@@ +40,4 @@
>  use C4::Members;# GetBorrowersWhoHavexxxBorrowed.
>  use C4::Circulation;# AnonymiseIssueHistory.
>  use Koha::DateUtils qw( dt_from_string output_pref );
> +use Koha::Database;

Not used.

@@ +128,5 @@
>  $radio= $params->{'radio'};
>  for ( my $i = 0 ; $i < $totalDel ; $i++ ) {
>  $radio eq 'testrun' && last;
> +my $borrowernumber = $patrons_to_delete->[$i]->{'borrowernumber'}
> +  || $patrons_to_delete->[$i]->get_column('borrowernumber');

I don't understand this line, GetBorrowersToExpunge won't return a DBIx::Class
object, so the || $patrons_to_delete->[$i]->get_column('borrowernumber'); part
is not necessary.

@@ +179,4 @@
>  my $borrowers = shift;
>  my $balance;
>  @$borrowers = map {
> +(undef, undef, $balance) = GetMemberIssuesAndFines( 
> $_->{borrowernumber} || $_->get_column('borrowernumber') );

Same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48891|0   |1
is obsolete||

--- Comment #73 from Nick Clemens  ---
Created attachment 48892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48892=edit
Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #72 from Owen Leonard  ---
Created attachment 48891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48891=edit
Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Owen Leonard  changed:

   What|Removed |Added

  Attachment #4|0   |1
is obsolete||

--- Comment #71 from Owen Leonard  ---
Created attachment 48890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48890=edit
[SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

Signed-off-by: Owen Leonard 

Patron batches are correctly passed to the edit and delete pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48881|0   |1
is obsolete||

--- Comment #70 from Nick Clemens  ---
Created attachment 4
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48833|0   |1
is obsolete||

--- Comment #69 from Nick Clemens  ---
Created attachment 48881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48881=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47478|0   |1
is obsolete||

--- Comment #68 from Nick Clemens  ---
Created attachment 48833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48833=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #67 from Jonathan Druart  
---
Nick, it's much more better, but there is something wrong.
The change to C4::Members::GetBorrowersToExpunge is not consistent: we expect
the subroutine behaves the same for patron list than for other params.
For instance, the category_code != 'S' and the guarantor tests are not done if
patron list is passed.
Moreover, it's not obvious that the patron_list_id is independent from other
params.
I'd say you should join the patron_list_patrons when the param is given.
There is also a lack of tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47393|0   |1
is obsolete||
  Attachment #47394|0   |1
is obsolete||
  Attachment #47395|0   |1
is obsolete||
  Attachment #47396|0   |1
is obsolete||

--- Comment #66 from Nick Clemens  ---
Created attachment 47478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47478=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |n...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Depends on|15642   |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15642


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642
[Bug 15642] Batch patron deletion should not delete patrons with issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #65 from Nick Clemens  ---
Created attachment 47396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47396=edit
Bug 10612 - Change _skip_borrowers_with_fines to
_skip_borrowers_with_fines_or_issues

Restore code that was moved to bug 15642

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47259|0   |1
is obsolete||

--- Comment #64 from Nick Clemens  ---
Created attachment 47395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47395=edit
Bug 10612 [QA Followup] - fix issues

1 - Use Koha::List::Patron
2 - Return only non-empty lists for deletion selection
3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix
_skip_borrowers_with_fines_or_issues to
accept patro_list_patrons3
4 - Fix missed closing quote in cleanborrowers.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47224|0   |1
is obsolete||

--- Comment #62 from Nick Clemens  ---
Created attachment 47393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47393=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches with a check added for issues
before deleting borrowers.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Jesse Weaver 

ByWater internal signoff, still needs signoff from community.

Patch seems kosher, passes QA tools. Needs followup to fix one small
issue: squished patch undoes switch to FontAwesome icons in lists.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47225|0   |1
is obsolete||

--- Comment #63 from Nick Clemens  ---
Created attachment 47394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47394=edit
Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt

Signed-off-by: Natasha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #61 from Jonathan Druart  
---
Blocked by bug 15642.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #60 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #57)
> Undefined subroutine ::_skip_borrowers_with_nonzero_balance_or_issues
> called at /home/koha/src/tools/cleanborrowers.pl line 103.
I don't get this one, did you apply 15642?

> Can't call method "patron_list_patrons" on an undefined value at
> /home/koha/src/tools/cleanborrowers.pl line 128.
Fixed missing closing quote on patron_list_id value which caused this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47255|0   |1
is obsolete||

--- Comment #59 from Nick Clemens  ---
Created attachment 47259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47259=edit
Bug 10612 [QA Followup] - fix issues

1 - Use Koha::List::Patron
2 - Return only non-empty lists for deletion selection
3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix
_skip_borrowers_with_fines_or_issues to
accept patro_list_patrons3
4 - Fix missed closing quote in cleanborrowers.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47226|0   |1
is obsolete||

--- Comment #58 from Nick Clemens  ---
Created attachment 47255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47255=edit
Bug 10612 [QA Followup]

1 - Use Koha::List::Patron
2 - Return only non-empty lists for deletion selection
3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_bo... to
accept patro_list_patrons3 - Fix _skip_bo... to accept
patro_list_patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #57 from Jonathan Druart  
---
I get 

Undefined subroutine ::_skip_borrowers_with_nonzero_balance_or_issues
called at /home/koha/src/tools/cleanborrowers.pl line 103.

then, afer renaming the subroutine correctly:

Can't call method "patron_list_patrons" on an undefined value at
/home/koha/src/tools/cleanborrowers.pl line 128.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46279|0   |1
is obsolete||

--- Comment #53 from Nick Clemens  ---
Created attachment 47224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47224=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches with a check added for issues
before deleting borrowers.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Jesse Weaver 

ByWater internal signoff, still needs signoff from community.

Patch seems kosher, passes QA tools. Needs followup to fix one small
issue: squished patch undoes switch to FontAwesome icons in lists.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #46834|0   |1
is obsolete||

--- Comment #54 from Nick Clemens  ---
Created attachment 47225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47225=edit
Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt

Signed-off-by: Natasha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #47153|0   |1
is obsolete||

--- Comment #55 from Nick Clemens  ---
Created attachment 47226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47226=edit
Bug 10612 [QA Followup]

1 - Use Koha::List::Patron
2 - Return only non-empty lists for deletion selection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #56 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #51)
> It would be better to use Koha::List::Patron instead.
Done

> I'd make more sense to pass the non empty patron lists only.
Done

> You are modifying the behavior of the tool.
> This change should be moved to another bug report
> (misc/cronjobs/delete_patrons.pl will need the change too).
Done, moved to bug 15642 as a dependency.  

However, looking over the code again I noted that while the tool did use this
subroutine initially, it used it in conjunction with C4::Members
GetBorrowersToExpunge which checks for borrowers w/issues in the SQl query it
builds and eliminates those borrowers from consideration. 

The new deletion by list feature doesn't use GetBorrowersToExpunge (since it is
basing from a list) so needs to make a check for issues.  It seems logical
enough to add the check in this sub since we are already calling
GetMemberIssuesAndFines and really I just pickup the return value instead of
ignoring it.

So, I can either leave dependent and wait on 15642, close the other bug and
replace the code here, or create a new separate sub to check for issues. 
Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #52 from Nick Clemens  ---
Created attachment 47153
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47153=edit
Bug 10612 [QA Followup]

1 - Use Koha::List::Patron
2 - Return only non-empty lists for deletion selection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Depends on|10565   |15642


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
[Bug 10565] Add a "Patron List" feature for storing and manipulating
collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642
[Bug 15642] Batch patron deletion should not delete patrons with issues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #51 from Jonathan Druart  
---
Comment on attachment 46279
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

Review of attachment 46279:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10612=46279)
-

::: tools/cleanborrowers.pl
@@ +85,5 @@
>  
> +my $patrons_to_delete;
> +if ($patron_list_id) {
> +my @patron_list_patrons =
> +  Koha::Database->new()->schema()->resultset('PatronListPatron')

It would be better to use Koha::List::Patron instead.

@@ +169,5 @@
>  trash => ( $radio eq "trash" ) ? (1) : (0),
>  testrun => ( $radio eq "testrun" ) ? 1: 0,
>  );
> +} else { # $step == 1
> +$template->param( patron_lists => [ GetPatronLists() ] );

I'd make more sense to pass the non empty patron lists only.

@@ +185,4 @@
>  #writing the template
>  output_html_with_http_headers $cgi, $cookie, $template->output;
>  
> +sub _skip_borrowers_with_nonzero_balance_or_issues {

You are modifying the behavior of the tool.
This change should be moved to another bug report
(misc/cronjobs/delete_patrons.pl will need the change too).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

natasha  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

natasha  changed:

   What|Removed |Added

  Attachment #46280|0   |1
is obsolete||

--- Comment #50 from natasha  ---
Created attachment 46834
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46834=edit
Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt

Signed-off-by: Natasha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46239|0   |1
is obsolete||

--- Comment #48 from Jesse Weaver  ---
Created attachment 46279
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches with a check added for issues
before deleting borrowers.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Jesse Weaver 

ByWater internal signoff, still needs signoff from community.

Patch seems kosher, passes QA tools. Needs followup to fix one small
issue: squished patch undoes switch to FontAwesome icons in lists.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #49 from Nick Clemens  ---
Created attachment 46280
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46280=edit
Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #41363|0   |1
is obsolete||
  Attachment #41364|0   |1
is obsolete||
  Attachment #41365|0   |1
is obsolete||

--- Comment #46 from Nick Clemens  ---
Created attachment 46239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46239=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches with a check added for issues
before deleting borrowers.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #47 from Nick Clemens  ---
I squashed patches, rebased, and added a check for issues to the subroutine:
_skip_borrowers_with_nonzero_balance
making it:
_skip_borrowers_with_nonzero_balance_or_issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Katrin Fischer  ---
I retested, this still has issues for me :(

Trying again with a test plan, hoping someone can find out what's going on:
- Created a patron list "Delete" with 2 borrowers from the sample data:
  Nicole Schneider - has 1 checkout
  Keith Hendrix
- Chose Delete and checked the checkbox, no other changes
- Chose "mose to trash"
- Tool reports: 2 patrons have been successfully moved to trash
- Nicole Schneider now exists in both borrowers and deletedborrowers

The logs show:
[Thu Oct 22 00:47:50.410257 2015] [cgi:error] [pid 11589] [client
127.0.0.1:36610] AH01215: [Thu Oct 22 00:47:50 2015] cleanborrowers.pl:
DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign
key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE)
at /home/katrin/kohaclone/C4/Members.pm line 1813., referer:
http://localhost:8080/cgi-bin/koha/tools/cleanborrowers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #44 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #43)
> Hm, it seems I tested the same as you but with very different results...
> what could be the difference? My results look worrysome, especially the
> double existance of borrower data in borrowers and deletedborrowers.

Tested again right now, and it works for me.
Nothing in the logs?
What happen if you use the tool using the 2 other criteria (not borrowed since,
expiration date)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #43 from Katrin Fischer  ---
Hm, it seems I tested the same as you but with very different results... what
could be the difference? My results look worrysome, especially the double
existance of borrower data in borrowers and deletedborrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #42 from Katrin Fischer  ---
- Add 4 patrons to a patron list, one has a checkout
- Select patron list in batch tool
- Reports: 4 patrons will be deleted (misleading, only 3 should)
- Choose test run:
  4 patrons would have been removed (if it wasn't a test run)

In my eyes, if a test run doesn't reflect what would be happening, it's
useless.

- Go back, change to "move to trash"
  4 patrons have been successfully moved to trash
- The user with the checkout has NOT been deleted (thankfully)

Now the next strange thing:

- Checking the deletedborrowers table - there is my user with the checkout.
So it actually moved all the borrowers to deletedborrowers and I have ended up
with the same borrowernumber in borrowers and deletedborrowers.

I know this is not related directly to the feature, but this tool gives me a
headache as it is. I don't trust it at all. In my opinion it's very buggy and
shouldn't be promoted before fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #37 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Katrin Fischer from comment #36)
 Hi Kyle, 
 
 could you do me a favour and try the test case I described? I feel if we
 push this without checking the basic functionality of the tool is correct,
 we will just end up with unhappy feedback on a good new feature.
 
  Example: Argh? I created a patron list with 6 patrons, I checked out a book
  to one of the patrons. The test run on the patron delete tells me the that 6
  patrons would have been deleted.

Katrin,
I have tried and it works:
Create patrons A and B
Check an item out to B
Add A and B to a patron list
Use the tool to delete patrons from this list
Test tun tells me 1 patron will be deleted
Permanently delete the patrons delete only 1 patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #40 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41365
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41365action=edit
Bug 10612 [QA Followup] - Remove user icons from buttons

Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

  Attachment #36313|0   |1
is obsolete||
  Attachment #36315|0   |1
is obsolete||
  Attachment #41289|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41363
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41363action=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Nicole nic...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #39 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41364
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41364action=edit
Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =
patrons, reserves = holds, etc ).

Signed-off-by: Nicole nic...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan, thx for testing! - I will rerun my test and see if I did something
differently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, 

could you do me a favour and try the test case I described? I feel if we push
this without checking the basic functionality of the tool is correct, we will
just end up with unhappy feedback on a good new feature.

 Example: Argh? I created a patron list with 6 patrons, I checked out a book
 to one of the patrons. The test run on the patron delete tells me the that 6
 patrons would have been deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41289
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41289action=edit
Bug 10612 [QA Followup] - Remove user icons from buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off
 CC||kyle.m.h...@gmail.com

--- Comment #35 from Kyle M Hall kyle.m.h...@gmail.com ---
 1) I know it's outside the scope of this bug, but we are about to make the
 feature much more prominent and easier to use with this patch.
 
 I am worried about the lack of good error messages and possible missing
 checks in the patron deletion tool (see also comment#27). In general we
 always need to check at least for:
   - checkouts
   - fines
   - guarantor relationships
 
 Example: Argh? I created a patron list with 6 patrons, I checked out a book
 to one of the patrons. The test run on the patron delete tells me the that 6
 patrons would have been deleted.

I agree this is out of the scope of this bug. Can you file a separate bug for
that?

 2) Patron list page: I don't like the 2 symbol concept on the buttons,
 because that won't work well for translations. You can't assume safely that
 the Verb is always on the left side and the subject on the right. For
 example in the German translations we could have both: Lösche Benutzer and
 Benutzer löschen.

I've removed the double icons and just kept the left most icon for each!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |jwea...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Some notes about this:

1) I know it's outside the scope of this bug, but we are about to make the
feature much more prominent and easier to use with this patch.

I am worried about the lack of good error messages and possible missing checks
in the patron deletion tool (see also comment#27). In general we always need to
check at least for:
  - checkouts
  - fines
  - guarantor relationships

Example: Argh? I created a patron list with 6 patrons, I checked out a book to
one of the patrons. The test run on the patron delete tells me the that 6
patrons would have been deleted.

I feel like we need to get the base feature working well, before we can extend
it's use like that.

2) Patron list page: I don't like the 2 symbol concept on the buttons,
because that won't work well for translations. You can't assume safely that the
Verb is always on the left side and the subject on the right. For example in
the German translations we could have both: Lösche Benutzer and Benutzer
löschen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #31 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36314
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36314action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =
patrons, reserves = holds, etc ).

Signed-off-by: Nicole nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

  Attachment #36314|0   |1
is obsolete||

--- Comment #32 from Nicole C. Engard neng...@gmail.com ---
Created attachment 36315
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36315action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =
patrons, reserves = holds, etc ).

Signed-off-by: Nicole nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #28779|0   |1
is obsolete||
  Attachment #28780|0   |1
is obsolete||
  Attachment #36311|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36313
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36313action=edit
[SIGNED-OFF] Bug 10612 - Add ability to delete patrons with batch patron
deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

Signed-off-by: Nicole nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36311
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36311action=edit
[SIGNED-OFF] Bug 10612 [Code cleanup] - Rename some variables

To move towards a more consistent codebase, I have changed some
variables from being camelCased or onelongname to the more standard
convention of words_separated_with_underscores. In addition, this
changes the use of the word 'member' to the word 'patron' to move
towards unification of our terminology. Our internal terminology should
move towards matching our external terminology ( members, borrowers =
patrons, reserves = holds, etc ).

Signed-off-by: Nicole nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #27 from Jacek Ablewicz a...@biblos.pk.edu.pl ---
(In reply to Owen Leonard from comment #26)
 Are patron automatically excluded from deletion for some reason? I tried to
 delete based on a patron list that contains 82 patrons and the tool offers
 to delete 2 patrons.

Only patrons with non-zero account balance (with unpaid fines/charges) are
explicitly excluded when deleting from a list.

Batch deleting (from a list) patrons with active check-outs really needs some
thought, IMO (apart from the somehow missleading count mentioned in comment
#25). While such patron records would not get actually deleted (due to the
foreign key constraint in issues table):

- their reserves and lists/virtual shelves (if any) would be deleted,
- if the choosen action is 'Move these patrons to the trash', I think that the
surplus record would be created in the deletedborrowers table, with original
patron record still remaining in borrowers table.

Also, when deleting from a list, it's possible to (accidentally) delete a staff
patron, and a patron which is a guarantor for some other patron[s]. 

On an unrelated subject: 'patron category' filter in batch patron
deletion/anonymization tool seems to be badly broken in the current master
(different issue, encountered while testing this patch - I will file separate
bug report for it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #28 from Owen Leonard oleon...@myacpl.org ---
(In reply to Jacek Ablewicz from comment #27)
 Only patrons with non-zero account balance (with unpaid fines/charges) are
 explicitly excluded when deleting from a list.

Thanks that's what was blocking the deletions. It would be nice if one could
get an error report on records which were not deleted (out of scope for this
bug of course).

 Batch deleting (from a list) patrons with active check-outs really needs
 some thought, IMO

Is this issue separate from batch deleting patrons using the other options
(inactivity, expiration, or category) ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #26 from Owen Leonard oleon...@myacpl.org ---
Are patron automatically excluded from deletion for some reason? I tried to
delete based on a patron list that contains 82 patrons and the tool offers to
delete 2 patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #25 from Nick Clemens n...@quecheelibrary.org ---
Understood on all, I was unclear in my comment though, sorry for that

I checked off all 4 patrons for deletion, the deletion tool said it would
delete 3, and that it had deleted 3, but only 2 were actually deleted.  

It seemed to work as expected, not deleting patrons with fines or checkouts,
but the message to the user was unclear

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Nick Clemens from comment #23)
 I got some odd results when testing:
 
 1 Added four patrons to the list:
 One with a checkout
 One with a fine
 Two with empty accounts
 
 Patron modification link seemed to work as expected

Excellent!

 Patron deletion link said 3 patrons would be deleted, I deleted, it said 3
 were gone, 2 were left in list (one with checkout, one with fine)
 
 I would be nice on the deletion screen to know who was going to be
 deleted/who was deleted, I can't tell from my results which patron (issue or
 fine) it was planning to delete.  If not a list before deletion, maybe a
 results list after the action.

Those would be great features, but are general enhancements to the batch patron
deletion tool and are outside the scope of this bug report.

 I also found that I had two identical lists, both affected by deletion, but
 don't know if that is from this patch

Any deleted patrons would disappear from all patron lists, so that is to be
expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||n...@quecheelibrary.org

--- Comment #23 from Nick Clemens n...@quecheelibrary.org ---
I got some odd results when testing:

1 Added four patrons to the list:
One with a checkout
One with a fine
Two with empty accounts

Patron modification link seemed to work as expected

Patron deletion link said 3 patrons would be deleted, I deleted, it said 3 were
gone, 2 were left in list (one with checkout, one with fine)

I would be nice on the deletion screen to know who was going to be deleted/who
was deleted, I can't tell from my results which patron (issue or fine) it was
planning to delete.  If not a list before deletion, maybe a results list after
the action.

I also found that I had two identical lists, both affected by deletion, but
don't know if that is from this patch



(In reply to Kyle M Hall from comment #1)
 Created attachment 19766 [details] [review]
 Bug 10612 - Add ability to delete patrons with batch patron modification tool
 
 The batch patron deletion/anonymization does not allow for batch
 deletion of arbitrary lists of patrons. The batch patron modification
 tool allows for modification of arbitrary lists of patrons, but not
 deletion. If would be highly beneficial to add patron deletion to the
 batch patron modification tool.
 
 Test Plan:
 1) Apply all dependencies for this patch
 2) Apply this patch
 3) Create a list of patrons with the new Patron Lists feature
a) Include at least one patron owing fines
b) Include at least one patron with items currently checked out
c) Include at least one patron not falling into a) or b)
 4) Browse to the batch patron modifications tool
 5) Select your list from the pulldown, and submit
 6) Check the Delete patrons checkbox, the click the submit button
 7) You should a list of errors for the patrons with fines or issues
and a table of patrons that were deleted successfully.
 8) Click the link for a deleted patron, you should get a patron not
found message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

Summary|Add ability to delete   |Add ability to delete
   |patrons with batch patron   |patrons with batch patron
   |modification tool   |deletion tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22837|0   |1
is obsolete||
  Attachment #22838|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28779
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28779action=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/