[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #37 from Kyle M Hall  ---
Pushed to master for the May 2016 release! Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #36 from Katrin Fischer  ---
Created attachment 50829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50829=edit
[PASSED QA] Bug 11565 [QA Followup] - Only hide options when none are in use

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50821|0   |1
is obsolete||
  Attachment #50822|0   |1
is obsolete||

--- Comment #35 from Katrin Fischer  ---
Created attachment 50828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50828=edit
[PASSED QA] Bug 11565 [QA Followup] - Hide checkout options when not in use

This follow-up reformats the checkout screen so that checkout settings
like specify due date, on-site checkout, and override high holds are
grouped in a panel which is hidden by default. Clicking a link shows all
the available settings.

Also modified in this patch: The default color for div.hint has been
made a little darker for readability.

To test, apply the patch and clear your browser cache if necessary.

- Check out to a patron who is not blocked from checking out.
- Click the "Checkout settings" link and confirm that the settings panel
  is displayed.
- Test that the settings in the panel behave as expected.
- Test with preferences on and off: decreaseLoanHighHolds,
  OnSiteCheckouts, SpecifyDueDate.

NOTE: This patch is a work in progress. It does not address the issue of
checkout setting being hidden even if they are active.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #34 from Kyle M Hall  ---
Created attachment 50822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50822=edit
Bug 11565 [QA Followup] - Only hide options when none are in use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50817|0   |1
is obsolete||
  Attachment #50820|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 50821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50821=edit
Bug 11565 [QA Followup] - Hide checkout options when not in use

This follow-up reformats the checkout screen so that checkout settings
like specify due date, on-site checkout, and override high holds are
grouped in a panel which is hidden by default. Clicking a link shows all
the available settings.

Also modified in this patch: The default color for div.hint has been
made a little darker for readability.

To test, apply the patch and clear your browser cache if necessary.

- Check out to a patron who is not blocked from checking out.
- Click the "Checkout settings" link and confirm that the settings panel
  is displayed.
- Test that the settings in the panel behave as expected.
- Test with preferences on and off: decreaseLoanHighHolds,
  OnSiteCheckouts, SpecifyDueDate.

NOTE: This patch is a work in progress. It does not address the issue of
checkout setting being hidden even if they are active.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50818|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall  ---
Created attachment 50820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50820=edit
Bug 11565 [QA Followup] - Only hide options when none are in use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50815|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 50817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50817=edit
Bug 11565 [QA Followup] - Hide checkout options when not in use

This follow-up reformats the checkout screen so that checkout settings
like specify due date, on-site checkout, and override high holds are
grouped in a panel which is hidden by default. Clicking a link shows all
the available settings.

Also modified in this patch: The default color for div.hint has been
made a little darker for readability.

To test, apply the patch and clear your browser cache if necessary.

- Check out to a patron who is not blocked from checking out.
- Click the "Checkout settings" link and confirm that the settings panel
  is displayed.
- Test that the settings in the panel behave as expected.
- Test with preferences on and off: decreaseLoanHighHolds,
  OnSiteCheckouts, SpecifyDueDate.

NOTE: This patch is a work in progress. It does not address the issue of
checkout setting being hidden even if they are active.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #31 from Kyle M Hall  ---
Created attachment 50818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50818=edit
Bug 11565 [QA Followup] - Only hide options when none are in use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #29 from Owen Leonard  ---
I have attached my patch for proposed interface changes in case it is of
interest to others. I do not mean for it to be considered in the QA process at
this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #28 from Owen Leonard  ---
Created attachment 50815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50815=edit
Bug 11565 [Work in progress] decreaseLoanHighHolds needs Override

This follow-up reformats the checkout screen so that checkout settings
like specify due date, on-site checkout, and override high holds are
grouped in a panel which is hidden by default. Clicking a link shows all
the available settings.

Also modified in this patch: The default color for div.hint has been
made a little darker for readability.

To test, apply the patch and clear your browser cache if necessary.

- Check out to a patron who is not blocked from checking out.
- Click the "Checkout settings" link and confirm that the settings panel
  is displayed.
- Test that the settings in the panel behave as expected.
- Test with preferences on and off: decreaseLoanHighHolds,
  OnSiteCheckouts, SpecifyDueDate.

NOTE: This patch is a work in progress. It does not address the issue of
checkout setting being hidden even if they are active.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #26 from Katrin Fischer  ---
Created attachment 50799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50799=edit
[PASSED QA] Bug 11565: (QA followup) add class to allow feature to be easily
hidden

This wraps both checkboxes (in the confirmation dialog and checkout
interface) in a class of "circ-override-high-holds" so they can be
easily hidden.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #27 from Katrin Fischer  ---
Created attachment 50800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50800=edit
Bug 11565: QA Follo-up: Improve translatability of 'not shortened' message

Mark-up inside sentences splits them of up for translation, so it's better
to only highlight full sentences for easier translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48679|0   |1
is obsolete||
  Attachment #49937|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 50798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50798=edit
[PASSED QA] Bug 11565 - decreaseLoanHighHolds needs Override

This patch allows the high holds loan length decrease to be overridden
either by a checkbox that remembers its setting during a series of
checkouts, or by a one time use override checkbox that will show
in the warning popup if a checkout is affected by high holds.

Test Plan:
1) Set up a checkout that will be affected by decreaseLoanHighHolds
2) Attempt to check out an item
3) Check the override checkbox
4) Note the checkout date is not reduced
5) Return the item
6) Start a new checkout for the patron
7) Check the "Don't decrease lean length based on holds" checkbox
8) Check out the item
9) Note you are not warned about the high holds decrease
   and that the checkout length is not reduced

Signed-off-by: Kyle M Hall 
Signed-off-by: Christopher Brannon 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #24 from Jesse Weaver  ---
Created attachment 49937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49937=edit
Bug 11565: (QA followup) add class to allow feature to be easily hidden

This wraps both checkboxes (in the confirmation dialog and checkout
interface) in a class of "circ-override-high-holds" so they can be
easily hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #23 from Katrin Fischer  ---
I may regret it, but please keep in mind that while everyone can understand
about schedules and budgets... this isn't important here. The whole process for
integrating changes into Koha is about what's in the best interest of Koha and
all those very different libraries using it.

I personally liked Owen's suggestion a lot and would have liked to see it move
forward. We owe a lot of Koha's 'prettiness' and 'easy-to-use-ness' to Owen's
ongoing work and the hundreds of patches he has submitted to the project.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #22 from Christopher Brannon  ---
Awesome.  Then I hope someone will be able to QA soon.  :)  Thanks for your
input!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #21 from Owen Leonard  ---
(In reply to Christopher Brannon from comment #20)
> Should we change the status until we have the addition to test?

No, I won't be submitting a patch for the interface change at this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #20 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #19)
> (In reply to Christopher Brannon from comment #18)
> 
> > Again, as long as it doesn't drive up the cost of this
> > project
> 
> I promise not to charge you for the time I volunteered to the project when I
> created a fully-functional test interface as a proposal.

:) That is kind of you.  I wasn't sure if Kyle would have to redo his work on
this.  I didn't know you could join in.  Thanks, Owen!

Should we change the status until we have the addition to test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #19 from Owen Leonard  ---
(In reply to Christopher Brannon from comment #18)

> Again, as long as it doesn't drive up the cost of this
> project

I promise not to charge you for the time I volunteered to the project when I
created a fully-functional test interface as a proposal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #18 from Christopher Brannon  ---
(In reply to Katrin Fischer from comment #17)
> How about having the options visible once one of the options was activated? 
> Or maybe just have the active one visible.
> 
> I agree that 'decluttering' the display should be moved to a different
> report. But I think it's increasingly necessary, because this is a really
> important area.
> 
> Also, to be more clear - if you have been using the feature already, this
> patch will make the new option show up and you have no good way of hiding
> it. I think the least we need to do is make it easy to hide.

I'm all for having the dropdown choices, and an indicator to show the feature
is active.  Again, as long as it doesn't drive up the cost of this project, or
prolong it.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #17 from Katrin Fischer  ---
How about having the options visible once one of the options was activated? 
Or maybe just have the active one visible.

I agree that 'decluttering' the display should be moved to a different report.
But I think it's increasingly necessary, because this is a really important
area.

Also, to be more clear - if you have been using the feature already, this patch
will make the new option show up and you have no good way of hiding it. I think
the least we need to do is make it easy to hide.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #16 from Christopher Brannon  ---
Another approach would be to have greyed out icons with no words.  They would
be colored if active, and when you hover over the icon, it reminds you what it
is in a tip (in the proper language).  Just a thought.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #15 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #14)
> I agree that the checkout form is getting too cluttered. What if we hide all
> those settings by default?
> 
> http://zivotdesign.com/p/#1/14586558299862
> 
> Shown by clicking the settings link:
> 
> http://zivotdesign.com/p/#1/14586558297113
> 
> Libraries could still choose to have the panel shown by default by adding
> some CSS to  IntranetUserCSS.

I'm all for simplifying the screen, but there needs to be some indicator
showing that features are applied.  Too easy to forget.  Perhaps a marker (red
initial or icon) next to the link?

I also question if this feature is beyond the scope of the enhancement.  Maybe
another enhancement should be opened to address this concern?  I'm fine with
adding it to this if it doesn't drive up the cost of the project or delay it
too much longer.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #14 from Owen Leonard  ---
I agree that the checkout form is getting too cluttered. What if we hide all
those settings by default?

http://zivotdesign.com/p/#1/14586558299862

Shown by clicking the settings link:

http://zivotdesign.com/p/#1/14586558297113

Libraries could still choose to have the panel shown by default by adding some
CSS to  IntranetUserCSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #13 from Katrin Fischer  ---
Created attachment 49409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49409=edit
Screenshot of the suggested addition to the checkout screen

We have been adding a lot of elements to the once simple checkout area - I'd
like to get Owen's and possible others opinions on how to handle this.

A German translation of the text for example would also be longer than the
English one and break the display a bit. This might also happen for other
languages, that need more words/characters.

The new checkbox will only show up when the preference is enabled, which is
good. But it currently can't be hidden easily, as the label is missing an
id/class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #12 from Katrin Fischer  ---
Comment on attachment 48679
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48679
Bug 11565 - decreaseLoanHighHolds needs Override

Review of attachment 48679:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11565=48679)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +207,5 @@
>  The patron has unpaid charges for holds, 
> rentals etc of [% alert.OTHER_CHARGES %]
>  [% END %]
>  
> +[% IF alert.HIGHHOLDS %]
> +High demand item. Loan period not 
> shortened to [% alert.HIGHHOLDS.duration %] days (due [% 
> alert.HIGHHOLDS.returndate %]) due to override.

Please avoid the  mark-up as this will split the string into several parts
in translation and cause issues for translators. Variables are handled with
placeholders, so those are no problem.

If that remains the only issue, I can fix it in a quick QA follow-up by
removing the . Will continue testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #11 from Christopher Brannon  ---
(In reply to Nicole C. Engard from comment #10)
> Christopher, 
> 
> We're waiting on QA on this one.
> 
> Nicole

Yes.  This was my attempt to politely nudge.  :)  I know people are busy.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #10 from Nicole C. Engard  ---
Christopher, 

We're waiting on QA on this one.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #9 from Christopher Brannon  ---
Would love to see this in the May release as well.  Will it make it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43600|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 48679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48679=edit
Bug 11565 - decreaseLoanHighHolds needs Override

This patch allows the high holds loan length decrease to be overridden
either by a checkbox that remembers its setting during a series of
checkouts, or by a one time use override checkbox that will show
in the warning popup if a checkout is affected by high holds.

Test Plan:
1) Set up a checkout that will be affected by decreaseLoanHighHolds
2) Attempt to check out an item
3) Check the override checkbox
4) Note the checkout date is not reduced
5) Return the item
6) Start a new checkout for the patron
7) Check the "Don't decrease lean length based on holds" checkbox
8) Check out the item
9) Note you are not warned about the high holds decrease
   and that the checkout length is not reduced

Signed-off-by: Kyle M Hall 
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #7 from Jonathan Druart  
---
I cannot apply this patch, bug 14694 needs a rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Christopher Brannon  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

--- Comment #6 from Christopher Brannon  ---
Bug 14694 has passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|unspecified |master
 Status|Signed Off  |BLOCKED

--- Comment #5 from Katrin Fischer  ---
Blocked for now as we are waiting for bug 14694 to move.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #4 from Christopher Brannon  ---
We've been waiting a while for this enhancement.  Would love it if someone
could run it through QA ASAP.  :)

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43160|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 43600
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43600=edit
[SIGNED-OFF] Bug 11565 - decreaseLoanHighHolds needs Override

This patch allows the high holds loan length decrease to be overridden
either by a checkbox that remembers its setting during a series of
checkouts, or by a one time use override checkbox that will show
in the warning popup if a checkout is affected by high holds.

Test Plan:
1) Set up a checkout that will be affected by decreaseLoanHighHolds
2) Attempt to check out an item
3) Check the override checkbox
4) Note the checkout date is not reduced
5) Return the item
6) Start a new checkout for the patron
7) Check the "Don't decrease lean length based on holds" checkbox
8) Check out the item
9) Note you are not warned about the high holds decrease
   and that the checkout length is not reduced

Signed-off-by: Kyle M Hall 
Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42976|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 43160
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43160=edit
Bug 11565 - decreaseLoanHighHolds needs Override

This patch allows the high holds loan length decrease to be overridden
either by a checkbox that remembers its setting during a series of
checkouts, or by a one time use override checkbox that will show
in the warning popup if a checkout is affected by high holds.

Test Plan:
1) Set up a checkout that will be affected by decreaseLoanHighHolds
2) Attempt to check out an item
3) Check the override checkbox
4) Note the checkout date is not reduced
5) Return the item
6) Start a new checkout for the patron
7) Check the "Don't decrease lean length based on holds" checkbox
8) Check out the item
9) Note you are not warned about the high holds decrease
   and that the checkout length is not reduced

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||14694


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694
[Bug 14694] Make decreaseloanHighHolds more flexible
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

--- Comment #1 from Kyle M Hall  ---
Created attachment 42976
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42976=edit
Bug 11565 - decreaseLoanHighHolds needs Override

This patch allows the high holds loan length decrease to be overridden
either by a checkbox that remembers its setting during a series of
checkouts, or by a one time use override checkbox that will show
in the warning popup if a checkout is affected by high holds.

Test Plan:
1) Set up a checkout that will be affected by decreaseLoanHighHolds
2) Attempt to check out an item
3) Check the override checkbox
4) Note the checkout date is not reduced
5) Return the item
6) Start a new checkout for the patron
7) Check the "Don't decrease lean length based on holds" checkbox
8) Check out the item
9) Note you are not warned about the high holds decrease
   and that the checkout length is not reduced

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Nicole C. Engard  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 Status|NEW |ASSIGNED
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10067

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/