[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #23 from Jonathan Druart --- Created attachment 66888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66888=edit Bug 11580: Add one more test and clear the

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Alex Arnaud changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #21 from Alex Arnaud --- Created attachment 66886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66886=edit Bug 11580 - Fix expiry calculation and rewrite tests -- You are

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #20 from Jonathan Druart --- I think the correct change is: +my $calendar = Koha::Calendar->new( branchcode => $branch ); +if (

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #19 from Jonathan Druart --- This change breaks test, please fix ASAP: t/db_dependent/Circulation/CalcDateDue.t .. 1/5 # Failed test 'date expiry' # at

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Patrick Robitaille changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #17 from Kyle M Hall --- Created attachment 66707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66707=edit Bug 11580 [QA Followup] Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #16 from Kyle M Hall --- Created attachment 66706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66706=edit BUG 11580 : Added unit test Added one unit test when the syspref

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What|Removed |Added Attachment #65779|0 |1

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #14 from Katrin Fischer --- Created attachment 65780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65780=edit [SIGNED OFF] BUG 11580 : Added unit test Added one unit test

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Katrin Fischer changed: What|Removed |Added Attachment #58740|0

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Baptiste changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Baptiste changed: What|Removed |Added Attachment #60621|0

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #10 from Baptiste --- I don't quite understand what is supposed to be done. Shall we move the whole fonction in which this code is added toward Koha::Calendar ? -- You are receiving

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Srdjan Jankovic changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Sophie MEYNIEUX changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #7 from Baptiste --- Created attachment 60621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60621=edit BUG 11580 : Added unit test Added one unit test when the

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #6 from Katrin Fischer --- Hi Baptiste, I think all three options should have a specific behaviour for calculating due dates when the patron _doesn't_ expire before the calculated due date: -

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Baptiste changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Claire Gravely changed: What|Removed |Added Attachment #57562|0

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Claire Gravely changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Sophie MEYNIEUX changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 57562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57562=edit Bug 11580 - If returnBeforeExpiry is ON, use calendar to

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added Version|3.12