[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolyn.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #27077|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27120 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27120action=edit Bug 11797 - Odd number of elements in hash - UNIMARC I got the same warning for my UNIMARC DB. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |In Discussion CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Double-checking: was the MARC21 variant of this patch marked obsolete by mistake? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27134 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27134action=edit Bug 11797 - Odd number of elements in hash - UNIMARC I got the same warning for my UNIMARC DB. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #27120|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27133 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27133action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN - 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home - Cataloging - + New record - Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Could generate the warning with a missing 151$a with both methods. No warning anymore after applying this patch. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Can we reset the status of this report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- I agree it should be changed. I don't think Jonathan's patch has been signed off, hence the 'Needs Signoff' status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with a follow-up to normalize the two approaches taken to remove the warning and a patch that adds unit tests and regression tests. Thanks, Mark and Jonathan! Jonathan: I would be interested in seeing an example of a valid UNIMARC authority that triggers the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #25884|0 |1 is obsolete|| --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 27077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27077action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN - 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home - Cataloging - + New record - Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Could generate the warning with a missing 151$a with both methods. No warning anymore after applying this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #25478|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25882 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25882action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN - 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home - Cataloging - + New record - Click the 'Tag Editor' on 100$a ... 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) Error log entry is not generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #25882|0 |1 is obsolete|| --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25884 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25884action=edit Bug 11797 - Odd number of elements in hash This was discovered when someone triggered an authority search on an authority record that was missing what is assumed the default subfield for a given field. It, however, also can be triggered in an OPAC authority search by looking at the record that lacks the default subfield for a given field. TEST PLAN - 1) Create an authority record with 180$x and NOT 180$v. See C4::AuthoritiesMarc::BuildSummary in the 1.. foreach loop for known tags and default values. The default subfields are the first letter of the $subfields_to_report string. 2) Trigger the bug: Method 1: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=# Where # is the authority id of your tweaked record. The error occurs in Normal view. Method 2: Home - Cataloging - + New record - Click the 'Tag Editor' on 100$a Editing of $a to $b and back may be required. 3) Notice there is an error log entry. 4) Apply the patch 5) Attempt to trigger the bug again 6) That specific error log entry is not generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 25478 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25478action=edit Bug 11797 - auth_finder.pl: Odd number of elements in anonymous hash Added missing 162 MARC authorities tag and missing else case. If the records are not in a given order the first substring of the previous tag could be not 'a', but only 'a' exists for 162, so the hash would have hemain = which triggers the error. That's my theory anyways. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11797] auth_finder.pl: Odd number of elements in anonymous hash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11797 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
