[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Blocks|32751 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Blocks||35451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35451 [Bug 35451] Add tablename field to additional_field_values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9540 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com Status|Pushed to master|Needs documenting --- Comment #125 from Matt Blenkinsop --- New feature - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/692 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose changed: What|Removed |Added Text to go in the|This adds the option to add |This adds the option to add release notes|additional user defined |additional user defined |fields to the order lines |fields to the order lines |in the acquisition module. |in the acquisition module. |The fields can be yet up as |The fields can be set up as |free text fields or pull|free text fields or pull |down lists driven by|down lists driven by |authorised values. They can |authorised values. They can |also pull information from |also pull information from |the MARC record or allow|the MARC record or allow |you to create and edit a|you to create and edit a |field in the MARC record. |field in the MARC record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Caroline Cyr La Rose changed: What|Removed |Added Documentation||Caroline Cyr La Rose contact|| CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Text to go in the||This adds the option to add release notes||additional user defined ||fields to the order lines ||in the acquisition module. ||The fields can be yet up as ||free text fields or pull ||down lists driven by ||authorised values. They can ||also pull information from ||the MARC record or allow ||you to create and edit a ||field in the MARC record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #124 from Tomás Cohen Arazi --- Created attachment 151366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151366=edit Bug 11844: Only display 'Additional fields' section if they are defined Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #123 from Tomás Cohen Arazi --- Thanks for the research and follow-up, Katrina. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master Keywords|rel_23_05_candidate | --- Comment #122 from Jonathan Druart --- Patches pushed for 23.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #121 from Katrin Fischer --- Created attachment 151230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151230=edit Bug 11844: (follow-up) Fix tests Moves the test from 999 which already exists in record to 998 as the feature only matches on the first field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #120 from Katrin Fischer --- Created attachment 151229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151229=edit Bug 11844: DBIC schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #119 from Katrin Fischer --- Created attachment 151228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151228=edit Bug 11844: Add tests Tests added for: - Koha::AdditionalField - TransferOrder - marcfield_mode Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #118 from Katrin Fischer --- Created attachment 151227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151227=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #117 from Katrin Fischer --- Created attachment 151226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151226=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #116 from Katrin Fischer --- Created attachment 151225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151225=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #115 from Katrin Fischer --- Created attachment 151224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151224=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #114 from Katrin Fischer --- Created attachment 151223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151223=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #113 from Katrin Fischer --- Created attachment 151222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151222=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #150537|0 |1 is obsolete|| Attachment #150538|0 |1 is obsolete|| Attachment #150539|0 |1 is obsolete|| Attachment #150540|0 |1 is obsolete|| Attachment #150541|0 |1 is obsolete|| Attachment #150542|0 |1 is obsolete|| Attachment #150543|0 |1 is obsolete|| Attachment #150544|0 |1 is obsolete|| Attachment #150545|0 |1 is obsolete|| Attachment #150546|0 |1 is obsolete|| Attachment #150547|0 |1 is obsolete|| Attachment #150548|0 |1 is obsolete|| --- Comment #112 from Katrin Fischer --- Created attachment 151221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151221=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #151220|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #111 from Katrin Fischer --- Created attachment 151220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151220=edit k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844
--- Comment #110 from Katrin Fischer ---
I can fix the test. I think what happens is:
If the field is a repeatable one, we are only looking at the first occurence.
The test was using 999, but this field is already present in the created
biblio, before another 999 is added with $Z.
So when trying to set the field, no $Z was found and the additional_field was
not set.
This can be fixed by:
1) Using another field than 999 that doesn't already exist in the record.
2) appending Z to the already existing 999
3) Making sure that set_additional_fields loops through repeatable subfields,
using the first subfield found.
1) is done easily, 3) is harder. I tried to determine how it worked before this
patch set, as the 'set' functionality was already there:
https://git.koha-community.org/Koha-community/Koha/src/commit/f891156f424a466aadb5ab85c445fcdbae4f3536/serials/subscription-add.pl#L370
my $value = $query->param('additional_field_' . $field->id);
if ($field->marcfield) {
my ($field, $subfield) = split /\$/, $field->marcfield;
if ( $record and $field and $subfield ) {
$value = $record->subfield( $field, $subfield );
}
}
It appears it never dealt 'cleverly' with repeated subfields. So we might move
this to a separate bug and go with 1) for now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Failed QA Keywords||rel_23_05_candidate --- Comment #109 from Tomás Cohen Arazi --- Hi Julian et al, there's a failing test. Please fix against this branch: https://gitlab.com/thekesolutions/Koha/-/commits/qa_11844 # Failed test 'No tests run for subtest "set_additional_fields with marcfield_mode = "get""' # at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 54. Can't call method "value" on an undefined value at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 51. # Looks like your test exited with 255 just after 1. /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report --- /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.66 cusr 0.38 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #108 from Katrin Fischer --- (In reply to Jonathan Druart from comment #95) > (In reply to Martin Renvoize from comment #94) > > RM note.. the QA tool threw two issues.. POD coverage which is a false > > positive here I believe and a permissions issue.. but the permissions all > > look correct to me.. not sure what's going on there. > > FAIL t/db_dependent/Koha/AdditionalField.pm >FAIL file permissions > File must not have the exec flag > > Well, this is valid: > -rwxr-xr-x 1 jonathan jonathan 2506 mai2 11:51 > t/db_dependent/Koha/AdditionalField.pm > > Actually I guess it should be renamed to .t Small rebase (conflicts in the USE statements, not hard), fixed the test, unit and QA tests pass now. Also did some tests in the GUI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #107 from Katrin Fischer --- Created attachment 150548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150548=edit Bug 11844: (QA follow-up) Fix unit test file ending t/db_dependent/Koha/AdditionalField.pm -> t/db_dependent/Koha/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149692|0 |1 is obsolete|| --- Comment #106 from Katrin Fischer --- Created attachment 150547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150547=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149691|0 |1 is obsolete|| --- Comment #105 from Katrin Fischer --- Created attachment 150546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150546=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149690|0 |1 is obsolete|| --- Comment #104 from Katrin Fischer --- Created attachment 150545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150545=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149689|0 |1 is obsolete|| --- Comment #103 from Katrin Fischer --- Created attachment 150544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150544=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149688|0 |1 is obsolete|| --- Comment #102 from Katrin Fischer --- Created attachment 150543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150543=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149687|0 |1 is obsolete|| --- Comment #101 from Katrin Fischer --- Created attachment 150542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150542=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149686|0 |1 is obsolete|| --- Comment #100 from Katrin Fischer --- Created attachment 150541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150541=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149685|0 |1 is obsolete|| --- Comment #99 from Katrin Fischer --- Created attachment 150540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150540=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149684|0 |1 is obsolete|| --- Comment #98 from Katrin Fischer --- Created attachment 150539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150539=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149683|0 |1 is obsolete|| --- Comment #97 from Katrin Fischer --- Created attachment 150538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150538=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #149682|0 |1 is obsolete|| --- Comment #96 from Katrin Fischer --- Created attachment 150537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150537=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #95 from Jonathan Druart --- (In reply to Martin Renvoize from comment #94) > RM note.. the QA tool threw two issues.. POD coverage which is a false > positive here I believe and a permissions issue.. but the permissions all > look correct to me.. not sure what's going on there. FAIL t/db_dependent/Koha/AdditionalField.pm FAIL file permissions File must not have the exec flag Well, this is valid: -rwxr-xr-x 1 jonathan jonathan 2506 mai2 11:51 t/db_dependent/Koha/AdditionalField.pm Actually I guess it should be renamed to .t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #94 from Martin Renvoize --- Thanks for adding all the tests.. this works great and is now covered nicely. Passing QA RM note.. the QA tool threw two issues.. POD coverage which is a false positive here I believe and a permissions issue.. but the permissions all look correct to me.. not sure what's going on there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149091|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 149692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149692=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149090|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 149691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149691=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149089|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 149690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149690=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149088|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 149689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149689=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149087|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 149688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149688=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149086|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 149687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149687=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149085|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 149686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149686=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149084|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 149685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149685=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149083|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 149684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149684=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149082|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize --- Created attachment 149683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149683=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Attachment #149081|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 149682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149682=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #148897|0 |1 is obsolete|| --- Comment #82 from Biblibre Sandboxes --- Created attachment 149091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149091=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #148895|0 |1 is obsolete|| --- Comment #81 from Biblibre Sandboxes --- Created attachment 149090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149090=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #148889|0 |1 is obsolete|| --- Comment #80 from Biblibre Sandboxes --- Created attachment 149089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149089=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146506|0 |1 is obsolete|| --- Comment #79 from Biblibre Sandboxes --- Created attachment 149088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149088=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146505|0 |1 is obsolete|| --- Comment #78 from Biblibre Sandboxes --- Created attachment 149087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149087=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146504|0 |1 is obsolete|| --- Comment #77 from Biblibre Sandboxes --- Created attachment 149086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149086=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146503|0 |1 is obsolete|| --- Comment #76 from Biblibre Sandboxes --- Created attachment 149085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149085=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146502|0 |1 is obsolete|| --- Comment #75 from Biblibre Sandboxes --- Created attachment 149084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149084=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146501|0 |1 is obsolete|| --- Comment #74 from Biblibre Sandboxes --- Created attachment 149083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149083=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146500|0 |1 is obsolete|| --- Comment #73 from Biblibre Sandboxes --- Created attachment 149082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149082=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Biblibre Sandboxes changed: What|Removed |Added Attachment #146497|0 |1 is obsolete|| --- Comment #72 from Biblibre Sandboxes --- Created attachment 149081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149081=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #71 from Julian Maurice --- I think I covered everything... Back to signed off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #70 from Julian Maurice --- Created attachment 148897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148897=edit Bug 11844: Add tests for marcfield_mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #69 from Julian Maurice --- Created attachment 148895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148895=edit Bug 11844: Add tests for TransferOrder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #68 from Julian Maurice --- Created attachment 148889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148889=edit Bug 11844: Add tests for Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #67 from Katrin Fischer --- I get your point, Martin. Sadly, I think writing those tests is a bit too much for me. :( Hope Julian will be able to spend some more time on this, it would be sad, as you said, to see it stuck again. We are so close! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #66 from Martin Renvoize --- This generally looks great.. but there's a few last unit tests missing. Could we have some tests for the new Koha::AdditionalField::effective_authorised_value_category method please. I'm afraid I'm also not seeing any additions for the C4::Acquisition::TransferOrder changes either. Finally, the changes in Koha/Object/Mixin/AdditionalFields.pm don't appear to be tested either. Sorry Julian, this is great work and I wouldn't want it accidentally undone in a future change. Failing QA for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #65 from Katrin Fischer --- I've run some more tests here: * Applied patches * Ran dbic * Ran restart_all 1) Administration > Additional fields * Can add edit and delete additional fields for order lines. * Additional fields for baskets don't have the MARC options, which is correct. * Additional fields for subscriptions offer the MARC option and have the save/display selection now. In difference to orders existing MARC information is not displayed when a new subscription is added, only when you edit. This was already the case before and I think we should improve it separately. Saving values works as expected. > And I think the entry in the left menu is missing, see testplan > 2/ In the left menu, click on "Add order line fields" Fixed this in a follow-up. 2) Functionality in acquisitions I have added 4 different additional fields: * Text field, no auth value or MARC * MARC field with get: 245$a * MARC field with set and link to a pseudo AV in the frameworks: 942$c itemtypes * Pull down, AV controlled All fields have behaved as expected when adding or modifying an order. I think maybe Michaela was missing the $ in configuration from the error message she saw: > "Tag "942h" is not a valid tag. I am proposing adding a hint to the field with the proper format in a follow-up. I've also filed bug 32944. 3) Follow-ups I have done several really small follow-ups. Please feel free to drop or squash in QA as needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #64 from Katrin Fischer --- Created attachment 146506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146506=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #63 from Katrin Fischer --- Created attachment 146505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146505=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #62 from Katrin Fischer --- Created attachment 146504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146504=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #61 from Katrin Fischer --- Created attachment 146503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146503=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #60 from Katrin Fischer --- Created attachment 146502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146502=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #145540|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 146501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146501=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #145536|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 146500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146500=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Attachment #145535|0 |1 is obsolete|| --- Comment #57 from Katrin Fischer --- Created attachment 146497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146497=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32944 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #56 from Katrin Fischer --- Trying to see if I can help out here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Blocks||32751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #55 from Michaela Sieber --- I did some tests in biblibre and ptfs sandboxes Test results: Case 1: no AV category and no MARC field --> works perfect Case 2: AV category and no MARC field --> works perfect Unfortunately Additional Fields with MARC fields did not work: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set In get mode nothing happens, the values are not displayed In set mode an error message appears: "Tag "942h" is not a valid tag. at /kohadevbox/koha/Koha/Object/Mixin/AdditionalFields.pm line 72. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289" . And I think the entry in the left menu is missing, see testplan 2/ In the left menu, click on "Add order line fields" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #54 from Katrin Fischer --- (In reply to Julian Maurice from comment #53) > I don't know what's wrong on sandboxes, but I just retried it locally: I > reproduced the error, then updatedbix + restart starman worked. > marcfield_mode column exist on the sandbox so updatedabase was correctly run. Yes, that's odd, the output of the "refresh schema" looked like it finished ok. Could you maybe attach the 'DBIC don't push' patch here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #53 from Julian Maurice --- I don't know what's wrong on sandboxes, but I just retried it locally: I reproduced the error, then updatedbix + restart starman worked. marcfield_mode column exist on the sandbox so updatedabase was correctly run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #52 from Katrin Fischer --- (In reply to Julian Maurice from comment #38) > I had the same issue. After applying the patch, you need to run > updatedatabase.pl, update_dbix_class_files.pl, and then restart Koha. I tried that on the sandboxes running "Refresh schema" and "Restart services", but the problem remained. See: http://sandboxes.ptfs-europe.co.uk/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #51 from Julian Maurice --- (In reply to Michaela Sieber from comment #50) > When trying to add a new Additional Field an error message appears : "The > field could not be inserted. Perhaps the name already exists?" See comment 38 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #50 from Michaela Sieber --- (In reply to Julian Maurice from comment #49) > (In reply to Katrin Fischer from comment #43) > > I was wondering, could the problem stem from the itemtypes being not a > > 'real' AV? You set it up like one, but it's actually drawn from the > > itemtypes table. > > Yes, that was it. > It should be ok now. When trying to add a new Additional Field an error message appears : "The field could not be inserted. Perhaps the name already exists?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #49 from Julian Maurice --- (In reply to Katrin Fischer from comment #43) > I was wondering, could the problem stem from the itemtypes being not a > 'real' AV? You set it up like one, but it's actually drawn from the > itemtypes table. Yes, that was it. It should be ok now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #48 from Julian Maurice --- Created attachment 145540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145540=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #47 from Julian Maurice --- Created attachment 145536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145536=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice changed: What|Removed |Added Attachment #145517|0 |1 is obsolete|| --- Comment #46 from Julian Maurice --- Created attachment 145535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145535=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11844] Additional fields for order lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #45 from Katrin Fischer --- I rebased, there are also some not too hard looking QA script fails: FAIL Koha/AdditionalField.pm FAIL pod coverage POD is missing for 'effective_authorised_value_category' OK Koha/Object/Mixin/AdditionalFields.pm OK Koha/Schema/Result/Aqorder.pm OK acqui/addorder.pl OK acqui/neworderempty.pl OK admin/additional-fields.pl FAIL installer/data/mysql/atomicupdate/bug-11844.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/kohastructure.sql FAIL koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc FAIL filters missing_filter at line 35 (This value will be saved to the [% field.marcfield %] subfield of the selected biblio.) OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 127) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
