[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolyn.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Marcel and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26436action=edit Bug 11855: remove unused template file members/search.tt seems not to be in use anymore. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25716|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #1) Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). It looks useless, I submitted a followup to remove the template file. Galen, feel free not to push it if you have a doubt. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26435 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26435action=edit Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 25716 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25716action=edit [Signed-off] Bug 11855: Tiny code cleanup in members [1] Template var actionname is not used in the associated template. This could be a copy-paste from serials/member-search.pl. Consequently, the module is no longer needed in member.pl. Template members/search.tt still contains actionname; it seems that this template is not used too (but I did not fully check that; so leaving that for now). [2] $template_name not used in members-home.pl. Test plan: [1] Go to Patrons. If you reach that page, you tested members-home.pl [2] Add a new patron. [3] Search for a patron. Edit one. Followed test plan. No problems found. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #25685|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Coming up |Tiny code cleanup in ||members -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11855] Tiny code cleanup in members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
