[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Matthias Meusburger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19625

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #93 from Katrin Fischer  ---
Hi Ehsan, please open a new bug report or ask on the mailing list. Bugs with
patches already released should not be reopened, but you can link bugs together
using 'depends on'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Ehsna  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||eh...@iub.edu.bd
 Resolution|FIXED   |---

--- Comment #92 from Ehsna  ---
My Shibboleth and ADFS is working if I manually created the user. it's not
creating the user automatically. here is my koha-conf.xml 

  
userid

  
  
  
  


  

What I am missing ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This patch was only ever|This feature allows it to
  release notes|intended to 'add new' user  |add new patron records from
   |record from Shibboleth into |Shibboleth into Koha
   |Koha ('provision') and not  |('provision'). It is
   |to 'sync' Shibboleth with   |possible to map
   |an existing Koha user. It   |Sbibboleth's attributes
   |is possible to map  |with Koha fields, the
   |Sbibboleth's attributes |configuration is done in
   |with Koha fields, the   |koha-conf.xml. Syncing
   |configuration is done in|existing Koha users with
   |koha-conf.xml   |Shibboleth is not
   ||implemented yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||This patch was only ever
  release notes||intended to 'add new' user
   ||record from Shibboleth into
   ||Koha ('provision') and not
   ||to 'sync' Shibboleth with
   ||an existing Koha user. It
   ||is possible to map
   ||Sbibboleth's attributes
   ||with Koha fields, the
   ||configuration is done in
   ||koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

Summary|Shibboleth  |Shibboleth
   |auto-provisioning   |auto-provisioning - Create

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||18507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507
[Bug 18507] Shibboleth auto-provisioning
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62521|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #62522|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #90 from Martin Renvoize  ---
Created attachment 62521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62521=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

http://bugs.koha-community.org/show_bug.cgi?id=12026

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #91 from Martin Renvoize  ---
Created attachment 62522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62522=edit
BUG 12027 [Followup]: Added missing documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #89 from Martin Renvoize  ---
You're totally right Katrin, I should expand the documentation a bit here.

This patch was only ever intended to 'add new' user record (i.e to 'provision')
and not to 'sync'.

To be honest, I'd love to also submit a 'sync' patch and include an option to
only sync certain fields but I'd likely need a bit of sponsorship to get that
through.  I'm happy to code it up, but it's a nightmare to get these patches
through signoff and qa ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #88 from Zeno Tajoli  ---
Hi Katrin,

in fact to answer your question you need to read also the code.
I do some answers:

>Is there documentation about this new feature available somewhere?
The documentation is inside C4/Auth_with_shibboleth.pm in POD format.
To see it:
perldoc C4/Auth_with_shibboleth.pm

>Is it possible to choose if you want to add a new user and update existing 
>users like it is with LDAP?

No. The system only adds a new user, it does not update an existing user. And
it adds a new user only when, inside login process, it finds that there isn't
an existing user with userid = the shibboleth attribure defined with this XML
in koha-conf.xml:
userid

   


>Do the attributes have to match exactly to what Koha expects (branchcode, 
>categorycode specifically) or is there a way to do a mapping?

You can mapping using koha-conf.xml. This is an example:

userid

   
   
   
   
   
   

The  ...  and the connected attribute are clearly
mandatory.
Also attributes for categorycode and branchcode are mandatory, I think.
Ohters are optional.

Bye

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #87 from Katrin Fischer  ---
Actually, after looking at the POD, I am still not sure what is the answer to
my questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #86 from Katrin Fischer  ---
Thx Zeno - I looked at the patches, but didn't spot it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #85 from Zeno Tajoli  ---
Hi Katrin,

the setup info are inside C4/Auth_with_shibboleth.pm in POD format:


Map shibboleth attributes to koha fields, and configure authentication match
point in koha-conf.xml.


userid 

   



Note: The minimum you need here is a  block, containing a valid
column name from the koha borrowers table, and a  block containing a
relation between the chosen matchpoint and the shibboleth attribute name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #84 from Katrin Fischer  ---
Is there documentation about this new feature available somewhere? Is it
possible to choose if you want to add a new user and update existing users like
it is with LDAP? Do the attributes have to match exactly to what Koha expects
(branchcode, categorycode specifically) or is there a way to do a mapping?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #83 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #82 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jesse, Martin, Mirko, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61522|0   |1
is obsolete||

--- Comment #74 from Olli-Antti Kivilahti  ---
Created attachment 61676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61676=edit
Bug 12026: [Follow up] Added Documentation

Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #81 from Olli-Antti Kivilahti  ---
Fixes failing test in t/Auth_with_shibboleth.t

Thanks for the fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61527|0   |1
is obsolete||

--- Comment #79 from Olli-Antti Kivilahti  ---
Created attachment 61683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61683=edit
Bug 12026: [QA Follow-up] Fix a POD line

Still refers to a removed parameter of _autocreate.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61599|0   |1
is obsolete||

--- Comment #80 from Olli-Antti Kivilahti  ---
Created attachment 61684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61684=edit
Bug 12026: [QA Follow-up] Add Tests for autocreate

https://bugs.koha-community.org/show_bug.cgi?id=12026
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61526|0   |1
is obsolete||

--- Comment #78 from Olli-Antti Kivilahti  ---
Created attachment 61680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61680=edit
Bug 12026: [Rebase Follow-up] - Fix Test

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61525|0   |1
is obsolete||

--- Comment #77 from Olli-Antti Kivilahti  ---
Created attachment 61679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61679=edit
Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac

[1] Correct xml error in POD
Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml
did not work. We need a closing tag ;)
[2] If AddMember_Opac calls AddMember_Auto, there is no need to call
fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61524|0   |1
is obsolete||

--- Comment #76 from Olli-Antti Kivilahti  ---
Created attachment 61678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61678=edit
Bug 12026: Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61523|0   |1
is obsolete||

--- Comment #75 from Olli-Antti Kivilahti  ---
Created attachment 61677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61677=edit
Bug 12026: [Followup] Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #61521|0   |1
is obsolete||

--- Comment #73 from Olli-Antti Kivilahti  ---
Created attachment 61675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61675=edit
Bug 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61598|0   |1
is obsolete||

--- Comment #72 from Martin Renvoize  ---
Created attachment 61599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61599=edit
Bug 12026: [QA Follow-up] Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61596|0   |1
is obsolete||

--- Comment #71 from Martin Renvoize  ---
Created attachment 61598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61598=edit
Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #70 from Martin Renvoize  ---
I'll do the switch from find to search single in another bug as it affects
actual function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #69 from Martin Renvoize  ---
In the name of doing it properly.. I've added the tests here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #68 from Martin Renvoize  ---
Created attachment 61596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61596=edit
Add Tests for autocreate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #67 from Martin Renvoize  ---
Thanks Marcel, I'll certainly take a look at adding the requisite tests.. as
you say the original work goes back so far that the tests were just not thought
of at the time and not added in any of my follow-ups :(.

As for the call to find.. I agree, I'll add a further patch for that along with
the tests (And include in those tests a case for a double matching matchpoint)

Glad to see this groundwork set passed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #66 from Marcel de Rooy  ---
QA Comment:
Code looks good to me.
This smaller change has mostly been code reviewed by me. I tested some
constructs on itself, but I do not have a shibboleth server.
Since most QAers do not and it has been tested by Martin and Mirko, I take the
liberty to pass QA on it now.
But not without a few remarks :)

Koha::Database->new()->schema()->resultset('Borrower')
  ->find( { $config->{matchpoint} => $match } );
Strictly speaking, you should use find with primary keys/unique constraints.
It might fallback to search here depending on your matchpoint (userid has a
unique constraint).

=head2 _autocreate
  my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match );
Given a database handle [...]
=> Where is that database handle? It got removed after the second patch..
Fixed in a followup.

checkpw_shib
The change to this routine should normally be accompanied by changes in the
tests.
Perhaps you should add autocreate => 0 explicitly to mockedConfig in this test.
I wonder if testing autocreate => 1 should be done better in a db_dependent
test.
Since this patch goes such a long way, I do not want to block it now. But
please add a small test on a new report.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #65 from Marcel de Rooy  ---
Created attachment 61527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61527=edit
Bug 12026: [QA Follow-up] Fix a POD line

Still refers to a removed parameter of _autocreate.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61448|0   |1
is obsolete||

--- Comment #63 from Marcel de Rooy  ---
Created attachment 61525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61525=edit
Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac

[1] Correct xml error in POD
Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml
did not work. We need a closing tag ;)
[2] If AddMember_Opac calls AddMember_Auto, there is no need to call
fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61449|0   |1
is obsolete||

--- Comment #64 from Marcel de Rooy  ---
Created attachment 61526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61526=edit
Bug 12026: [Rebase Follow-up] - Fix Test

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61447|0   |1
is obsolete||

--- Comment #62 from Marcel de Rooy  ---
Created attachment 61524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61524=edit
Bug 12026: Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61445|0   |1
is obsolete||

--- Comment #60 from Marcel de Rooy  ---
Created attachment 61522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61522=edit
Bug 12026: [Follow up] Added Documentation

Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61444|0   |1
is obsolete||

--- Comment #59 from Marcel de Rooy  ---
Created attachment 61521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61521=edit
Bug 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61446|0   |1
is obsolete||

--- Comment #61 from Marcel de Rooy  ---
Created attachment 61523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61523=edit
Bug 12026: [Followup] Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #58 from Marcel de Rooy  ---
QA: Looking here again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #57 from Martin Renvoize  ---
I've added the fix for the test as a follow-up and it also includes a tiny fix
to Mirko's rebased code which I had overlooked.

Not sure if we need Mirko to retest for signoff or whether we can go back to QA
?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #56 from Martin Renvoize  ---
Created attachment 61449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61449=edit
Bug 12026: [Rebase Follow-up] - Fix Test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61367|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize  ---
Created attachment 61448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61448=edit
Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac

[1] Correct xml error in POD
Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml
did not work. We need a closing tag ;)
[2] If AddMember_Opac calls AddMember_Auto, there is no need to call
fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61365|0   |1
is obsolete||

--- Comment #53 from Martin Renvoize  ---
Created attachment 61446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61446=edit
Bug 12026: [Followup] Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61366|0   |1
is obsolete||

--- Comment #54 from Martin Renvoize  ---
Created attachment 61447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61447=edit
Bug 12026: Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61363|0   |1
is obsolete||

--- Comment #51 from Martin Renvoize  ---
Created attachment 61444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61444=edit
Bug 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61364|0   |1
is obsolete||

--- Comment #52 from Martin Renvoize  ---
Created attachment 61445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61445=edit
Bug 12026: [Follow up] Added Documentation

Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #50 from Jonathan Druart  
---
-use_ok('C4::Auth_with_shibboleth');
+use C4::Auth_with_shibboleth;
+require_ok('C4::Auth_with_shibboleth');

This will fix the tests.
Do not ask me why and prefer to signoff on bug 17600 to avoid, maybe, such
craziness...

See also t/db_dependent/Circulation.t, commit
3660c451a36db128c143b6388d0d1f34babff4ac for a similar issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #49 from Marcel de Rooy  ---
Output of the test starts with:
1..11
not ok 1 - use C4::Auth_with_shibboleth;
#   Failed test 'use C4::Auth_with_shibboleth;'
#   at t/Auth_with_shibboleth.t line 100.
# Tried to use 'C4::Auth_with_shibboleth'.
# Error:  No ldapserver "hostname" defined in KOHA_CONF:
/etc/koha/sites/master/koha-conf.xml at
/usr/share/koha/masterclone/C4/Auth_with_ldap.pm line 59,  line 751.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61363|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61435|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61436|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61364|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61437|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61365|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61438|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61366|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #48 from Marcel de Rooy  ---
You changed the order of the patches.
And you obsoleted my corrections of the commit messages.
Could you restore them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #47 from Martin Renvoize  ---
I'm investigating those test failures today.. I'm totally baffled as to why
ldap appears to be getting loaded by the tests after these patches, but not
before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61364|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize  ---
Created attachment 61436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61436=edit
BUG 12026, Follow up: Added Documentation

BUG 12026, Follow up: Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61365|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 61437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61437=edit
BUG 12026: Followup Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61366|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 61438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61438=edit
Bug 12026 Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #61363|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 61435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61435=edit
BUG 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Marcel de Rooy  ---
After the first patch, test t/Auth_with_shibboleth.t fails.
Without it, it passes with me.
Please check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61268|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61269|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61271|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61270|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #39 from Marcel de Rooy  ---
Created attachment 61365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61365=edit
Bug 12026: [Followup] Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #40 from Marcel de Rooy  ---
Created attachment 61366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61366=edit
Bug 12026: Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #41 from Marcel de Rooy  ---
Created attachment 61367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61367=edit
Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac

[1] Correct xml error in POD
Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml
did not work. We need a closing tag ;)
[2] If AddMember_Opac calls AddMember_Auto, there is no need to call
fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #38 from Marcel de Rooy  ---
Created attachment 61364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61364=edit
Bug 12026: [Follow up] Added Documentation

Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #37 from Marcel de Rooy  ---
Created attachment 61363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61363=edit
Bug 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #36 from Marcel de Rooy  ---
QA: Looking here now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #35 from Martin Renvoize  ---
Added signoff line to signify that I've checked the rebase and followup added
by Mirko :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #57566|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 61271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61271=edit
Bug 12026 Fix small errors

When running tests I got two errors. Do these changes make sense?

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #57565|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 61270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61270=edit
BUG 12026: Followup Rebasing

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #57564|0   |1
is obsolete||

--- Comment #32 from Martin Renvoize  ---
Created attachment 61269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61269=edit
BUG 12026, Follow up: Added Documentation

BUG 12026, Follow up: Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #57563|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 61268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61268=edit
BUG 12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #30 from Martin Renvoize  ---
Just to clarify.. seems I've even been running Mirko's follow-up in production
here on a couple of systems since they were done.. sorry for not having signed
them off.. must have slipped through the net :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #29 from Martin Renvoize  ---
Perfect Mirko, thanks for cleaning up the rebase.

Setting back to SO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #28 from Mirko Tietgen  ---
(In reply to Marcel de Rooy from comment #27)
> Martin: Please answer Mirko's question on the last patch and signoff on that
> one. After that set status back to SO. Thanks !
> 
> Temporarily moving out of the SO queue.

Martin replied on IRC saying they make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #27 from Marcel de Rooy  ---
Martin: Please answer Mirko's question on the last patch and signoff on that
one. After that set status back to SO. Thanks !

Temporarily moving out of the SO queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #56241|0   |1
is obsolete||

--- Comment #23 from Mirko Tietgen  ---
Created attachment 57563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57563=edit
BUG12026: Adds auto-provisioning to shibboleth

- Adds the option to map shibboleth attributes to koha user columns
  and allows mapping to auto create non-existant users

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #56243|0   |1
is obsolete||

--- Comment #25 from Mirko Tietgen  ---
Created attachment 57565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57565=edit
BUG 12026: Followup Rebasing

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #56242|0   |1
is obsolete||

--- Comment #24 from Mirko Tietgen  ---
Created attachment 57564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57564=edit
BUG 12026, Follow up: Added Documentation

BUG 12026, Follow up: Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #57486|0   |1
is obsolete||

--- Comment #26 from Mirko Tietgen  ---
Created attachment 57566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57566=edit
Bug 12026 Fix small errors

When running tests I got two errors. Do these changes make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #22 from Martin Renvoize  ---
They make perfect sense.. look like mostly rebaseing errors to me.. oops :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #21 from Mirko Tietgen  ---
Created attachment 57486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57486=edit
Bug 12026 Fix small errors

When running tests I got two errors. Do these changes make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #20 from Martin Renvoize  ---
Created attachment 56243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56243=edit
BUG 12026: Followup Rebasing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #35552|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 56242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56242=edit
BUG 12026, Follow up: Added Documentation

BUG 12026, Follow up: Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/