[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #112 from Jonathan Druart --- QA tests added: commit 42ce839b1a61e5fef1836b4525bf942c6b53d878 Bug 12904: Add [% KOHA_VERSION %] for .js and .css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #111 from Jonathan Druart --- (In reply to Jonathan Druart from comment #110) > Created attachment 71822 [details] [review] > Bug 12904: Add KOHA_VERSION to few more .css Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #110 from Jonathan Druart --- Created attachment 71822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71822&action=edit Bug 12904: Add KOHA_VERSION to few more .css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #109 from Katrin Fischer --- > By the way, is this the right place to ask/post an updated Nginx > configuration? > (or any other web server) I think we don't officially support Nginx and not a lot of people read here apart from the Bug CC, so probably better on the mailing list or in IRC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Victor Grousset/tuxayo changed: What|Removed |Added Text to go in the|For non-package |For non-package release notes|installations, the |installations, the |following rewrite rules |following rewrite rules |will need to be added to|will need to be added to |the apache config file: |the apache config file: |RewriteRule ^(.*)_(.*).js$ | |$1.js [N,L] |RewriteRule |RewriteRule |^(.*)_[0-9][0-9]\.[0-9][0-9 |^(.*)_(.*).css$ $1.css |][0-9][0-9][0-9][0-9][0-9]. |[N,L] |js$ $1.js [L] ||RewriteRule ||^(.*)_[0-9][0-9]\.[0-9][0-9 ||][0-9][0-9][0-9][0-9][0-9]. ||css$ $1.css [L] --- Comment #108 from Victor Grousset/tuxayo --- Updated «Text to go in the release notes» with bug 20187 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #107 from Victor Grousset/tuxayo --- Indeed, that's kind of a non-backward compatible change. So that would be a bad surprise for a minor upgrade. (In reply to Katrin Fischer from comment #106) > [...] it requires changing > your Apache configuration By the way, is this the right place to ask/post an updated Nginx configuration? (or any other web server) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #106 from Katrin Fischer --- As we've found quite a few issues with it so far and it requires changing your Apache configuration I think it's not a good candidate for backporting right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #105 from Victor Grousset/tuxayo --- Thanks all, less cache cleaning for users! :D (In reply to Nick Clemens from comment #104) > [...] Enhancement, not backported to stable. Doesn't this fix bugs actually? Anyway, this would be a pain to backport right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #104 from Nick Clemens --- Awesome work all! Enhancement, not backported to stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Owen Leonard changed: What|Removed |Added Blocks||20193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 [Bug 20193] Label export displaying on never-ending webpage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Blocks||20190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 [Bug 20190] TinyMCE is broken and not displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Blocks||20189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 [Bug 20189] No style on authentication and installer pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #103 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #98) > [N,L]? > it looks like L shouldn't be there? or N? > L = Last > N = Next > using N is very tricky N,L is wrong imo N would give other rules a chance to make further rewrites looks to me that normally L would be fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Julian Maurice changed: What|Removed |Added Blocks||20188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20188 [Bug 20188] New rewrite rules break web installer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #102 from Jonathan Druart --- (In reply to Katrin Fischer from comment #101) > It seems to break other functionality too, like the modal on translating > itemtype descriptions: Loading failed for the
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Blocks||20187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 [Bug 20187] New rewrite rules can break custom css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #101 from Katrin Fischer --- It seems to break other functionality too, like the modal on translating itemtype descriptions: Loading failed for the
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #100 from Jonathan Druart --- We should improve the rewrite rule, it fails for few files (for instance editor_plugin.js on admin/branches.pl?op=add_form&branchcode=CPL) Could anyone take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate,| |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #99 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #98 from Jonathan Druart --- 1. Must misc4dev deal with apache *-git.conf files? If so, how? I think we will have to ask devs to add these 2 lines to /etc/koha/apache-shared-*-git.conf 2. 20 RewriteRule ^(.*)_(.*).js$ $1.js [N,L]. [N,L]? it looks like L shouldn't be there? or N? L = Last N = Next using N is very tricky and need to have a perfect understanding of how all defined rules make sense together Does someone know? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #97 from Josef Moravec --- (In reply to Jonathan Druart from comment #90) > Created attachment 71250 [details] [review] > Bug 12904: Fix occurrences not caught by script Thanks for quick reaction! Passed QA. I just fixed the first patch, which was made as fix of apache configuration, which was part of original patch. Now should apply cleanly on current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #95 from Josef Moravec --- Created attachment 71254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71254&action=edit Bug 12904: Force browser to load new javascript files after upgrade This patch has been automatically generated using: perl kv.pl **/*.tt **/*.inc Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #96 from Josef Moravec --- Created attachment 71255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71255&action=edit Bug 12904: Fix occurrences not caught by script Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #94 from Josef Moravec --- Created attachment 71253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71253&action=edit Bug 12904: Pass KOHA_VERSION in C4::Auth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec changed: What|Removed |Added Attachment #70831|0 |1 is obsolete|| Attachment #70832|0 |1 is obsolete|| Attachment #70833|0 |1 is obsolete|| Attachment #70834|0 |1 is obsolete|| Attachment #71250|0 |1 is obsolete|| --- Comment #92 from Josef Moravec --- Created attachment 71251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71251&action=edit Bug 12904: Apache configuration Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #93 from Josef Moravec --- Created attachment 71252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71252&action=edit Bug 12904: Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #91 from Jonathan Druart --- Great catches Josef, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #90 from Jonathan Druart --- Created attachment 71250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71250&action=edit Bug 12904: Fix occurrences not caught by script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #89 from Josef Moravec --- (In reply to Owen Leonard from comment #88) > (In reply to Josef Moravec from comment #87) > > > reset-fonts-grids.css is using through @import in staff-global.css, but > > could be leaved as is, it probably never change and I believe it will be > > removed in the future as it is part of yui library. > > That is my goal. Great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #88 from Owen Leonard --- (In reply to Josef Moravec from comment #87) > reset-fonts-grids.css is using through @import in staff-global.css, but > could be leaved as is, it probably never change and I believe it will be > removed in the future as it is part of yui library. That is my goal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #87 from Josef Moravec --- Looks good, just small issues: the staff-global.css and reset-fonts-grids.css in intranet are not versioned The staff-global.css needs to be adressed in file koha-tmpl/intranet-tmpl/prog/en/includes/intranetstylesheet.inc reset-fonts-grids.css is using through @import in staff-global.css, but could be leaved as is, it probably never change and I believe it will be removed in the future as it is part of yui library. in opac the opac.css is needs to be addressed in file koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc script.js and enquiry.min.js needs to be addressed in file koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec changed: What|Removed |Added Text to go in the|For non-package |For non-package release notes|installations, the |installations, the |following rewrite rules |following rewrite rules |will need to be added to|will need to be added to |the apache config file: |the apache config file: |RewriteRule ^(.*)_(.*).js$ |RewriteRule ^(.*)_(.*).js$ |$1.js [R=301,N,L] |$1.js [N,L] |RewriteRule ^(.*)_(.*).css$ |RewriteRule |$1.css [R=301,N,L] |^(.*)_(.*).css$ $1.css ||[N,L] QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Attachment #48742|0 |1 is obsolete|| --- Comment #86 from Jonathan Druart --- Created attachment 70835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70835&action=edit script to update tt & inc files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Attachment #70830|0 |1 is obsolete|| --- Comment #84 from Jonathan Druart --- Created attachment 70833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70833&action=edit Bug 12904: Force browser to load new javascript files after upgrade This patch has been automatically generated using: perl kv.pl **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #85 from Jonathan Druart --- Created attachment 70834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70834&action=edit Bug 12904: Pass KOHA_VERSION in C4::Auth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #83 from Jonathan Druart --- Created attachment 70832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70832&action=edit Bug 12904: Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #82 from Jonathan Druart --- Created attachment 70831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70831&action=edit Bug 12904: (QA follow-up) Don't send 301 status Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #81 from Jonathan Druart --- (In reply to Katrin Fischer from comment #78) > > >For non-package installations, the following rewrite rules will need to be > >>added to the apache config file: > >RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > >RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L] > > Wonder if this might not get lost - would there be a way to automate it? > What happens if you don't? We will have to highlight that in the release notes. People will quickly now that something is wrong if all JS and CSS files return 404 (In reply to Fridolin SOMERS from comment #79) > > RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > This rewrite rules are quite large, what about files that already contain an > underscore ? > I think we should use a more explicit separator like "_kohav" with rewrite : > RewriteRule ^(.*)_kohav(.*).js. > > > + > The syspref "Version" contains a dot (ie 16.1200037) meaning that files will > have 2 dots, ie : > ../datatables_16.1200037.js > This may be a problem for some web-browsers like IE ? I am going to push these patches soon. Developers will have time to catch the issues before 18.05. If someone disagrees with these patches, tell us why. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Attachment #63692|0 |1 is obsolete|| Attachment #63693|0 |1 is obsolete|| Attachment #63694|0 |1 is obsolete|| Attachment #63695|0 |1 is obsolete|| Attachment #63696|0 |1 is obsolete|| --- Comment #80 from Jonathan Druart --- Created attachment 70830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70830&action=edit Bug 12904: Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #79 from Fridolin SOMERS --- > RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] This rewrite rules are quite large, what about files that already contain an underscore ? I think we should use a more explicit separator like "_kohav" with rewrite : RewriteRule ^(.*)_kohav(.*).js. > + The syspref "Version" contains a dot (ie 16.1200037) meaning that files will have 2 dots, ie : ../datatables_16.1200037.js This may be a problem for some web-browsers like IE ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #78 from Katrin Fischer --- >For non-package installations, the following rewrite rules will need to be >>added to the apache config file: >RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] >RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L] Wonder if this might not get lost - would there be a way to automate it? What happens if you don't? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Text to go in the||For non-package release notes||installations, the ||following rewrite rules ||will need to be added to ||the apache config file: ||RewriteRule ^(.*)_(.*).js$ ||$1.js [R=301,N,L] ||RewriteRule ^(.*)_(.*).css$ ||$1.css [R=301,N,L] Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #77 from Kyle M Hall --- Created attachment 63696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63696&action=edit Bug 12904 [QA Followup] - Look up the Koha version once Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #76 from Kyle M Hall --- Created attachment 63695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63695&action=edit Bug 12904 - Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #75 from Kyle M Hall --- Created attachment 63694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63694&action=edit Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #74 from Kyle M Hall --- Created attachment 63693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63693&action=edit Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Attachment #60826|0 |1 is obsolete|| Attachment #60827|0 |1 is obsolete|| Attachment #60830|0 |1 is obsolete|| Attachment #60831|0 |1 is obsolete|| --- Comment #73 from Kyle M Hall --- Created attachment 63692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63692&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #72 from Olli-Antti Kivilahti --- (In reply to Martin Renvoize from comment #71) > I came here to QA this, then realised I wrote a bunch of the original code > that was eventually rebased. > > This is still a great thing to have and we've been using it in production in > a few places so I'm happy it works. > > I'll try to find a friendly QAer. Just QA this plix? PM when you plan to do so. This is a big moving target and it is hard to keep it applying to master. We have a rebased version from two-three weeks ago I guess. No point in wasting time applying it here because it will just get stale. While doing that I can rebase our fork on top of master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #71 from Martin Renvoize --- I came here to QA this, then realised I wrote a bunch of the original code that was eventually rebased. This is still a great thing to have and we've been using it in production in a few places so I'm happy it works. I'll try to find a friendly QAer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #70 from Olli-Antti Kivilahti --- Rebased to master. (In reply to Jonathan Druart from comment #65) > Can you explain this patch? Yes. Without this bad things will happen when caching is used. Our page load times drop at best 2-4 seconds depending on the env we run Koha. Better than plack :) When the Koha-version changes, the urls for all static web-assets dynamically change to point at the new Koha-version. This forces the browser to reload new versions of javascript-code. You cannot really cache static web-content without a way of invalidating the user's cache, because then after version upgrades, some browsers would use old javascript code and bad things would happen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #69 from Olli-Antti Kivilahti --- Created attachment 60831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60831&action=edit Bug 12904 - Add mod_expire to etc/koha-httpd.conf Has a positive effect on page loads for crazy dev-installs as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #58395|0 |1 is obsolete|| --- Comment #68 from Olli-Antti Kivilahti --- Created attachment 60830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60830&action=edit Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #58394|0 |1 is obsolete|| --- Comment #67 from Olli-Antti Kivilahti --- Created attachment 60827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60827&action=edit Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #58393|0 |1 is obsolete|| --- Comment #66 from Olli-Antti Kivilahti --- Created attachment 60826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60826&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #65 from Jonathan Druart --- (In reply to Nick Clemens from comment #64) > Created attachment 58395 [details] [review] > Bug 12904 [QA Followup] - Don't send 301 status > > Signed-off-by: Nick Clemens Can you explain this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Nick Clemens changed: What|Removed |Added Attachment #58379|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 58394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58394&action=edit Bug 12904 - Update template css and js file references Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Nick Clemens changed: What|Removed |Added Attachment #58392|0 |1 is obsolete|| --- Comment #64 from Nick Clemens --- Created attachment 58395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58395&action=edit Bug 12904 [QA Followup] - Don't send 301 status Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Nick Clemens changed: What|Removed |Added Attachment #58378|0 |1 is obsolete|| --- Comment #62 from Nick Clemens --- Created attachment 58393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58393&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #61 from Kyle M Hall --- Created attachment 58392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58392&action=edit Bug 12904 [QA Followup] - Don't send 301 status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Attachment #54488|0 |1 is obsolete|| Attachment #54489|0 |1 is obsolete|| --- Comment #59 from Kyle M Hall --- Created attachment 58378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58378&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #60 from Kyle M Hall --- Created attachment 58379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58379&action=edit Bug 12904 - Update template css and js file references -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #58 from Jonathan Druart --- Nobody to signoff on this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #57 from Jonathan Druart --- Back to NSO... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #56 from Jonathan Druart --- (In reply to Kyle M Hall from comment #54) > I'm at a loss. I just rebased and squashed/split all these patches for > readability. Everything is working, but the browser continues to indicate > it's grabbing cached files even when the filename has changed! > > At first I thought it was because the rewrite was doing a 301 redirect, so I > removed that, and still had the same thing. Next I tried a 307, but again, > the same results ( though chrome decided not to cache some files at all with > a 307 ). > > Here is a video demonstration: http://screencast.com/t/JfFonhkWax > > Martin, Jonathan, any ideas on what is going on? > > Kyle Using firebug (network tab) that sounds ok for me: (reload mainpage) mainpage_16.0600014.css 301 (moved permanentely) mainpage.css 200 (click on mainpage) nothing # from cached (change version using the interface, so the page reload and will hit some .css and .js files, that's why we are focusing on mainpage.css) (click on mainpage) mainpage_16.0600014.css 301 (moved permanentely) mainpage.css 200 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #55 from Kyle M Hall --- Created attachment 54489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54489&action=edit Bug 12904 - Update template css and js file references -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #54 from Kyle M Hall --- I'm at a loss. I just rebased and squashed/split all these patches for readability. Everything is working, but the browser continues to indicate it's grabbing cached files even when the filename has changed! At first I thought it was because the rewrite was doing a 301 redirect, so I removed that, and still had the same thing. Next I tried a 307, but again, the same results ( though chrome decided not to cache some files at all with a 307 ). Here is a video demonstration: http://screencast.com/t/JfFonhkWax Martin, Jonathan, any ideas on what is going on? Kyle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Attachment #54484|0 |1 is obsolete|| Attachment #54485|0 |1 is obsolete|| --- Comment #53 from Kyle M Hall --- Created attachment 54488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54488&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #52 from Kyle M Hall --- Created attachment 54485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54485&action=edit Bug 12904 - Update template css and js file references -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Attachment #48735|0 |1 is obsolete|| Attachment #48736|0 |1 is obsolete|| Attachment #48737|0 |1 is obsolete|| Attachment #48738|0 |1 is obsolete|| Attachment #48739|0 |1 is obsolete|| Attachment #48740|0 |1 is obsolete|| Attachment #48741|0 |1 is obsolete|| --- Comment #51 from Kyle M Hall --- Created attachment 54484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54484&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #50 from Mirko Tietgen --- Created attachment 49572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49572&action=edit screenshot Tried again with updated Apache config. No 404 anymore, but it does not seem like the files are reloaded. It looks like a redirect to me and the files used are the ones in the cache, see attached screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #49 from Jonathan Druart --- Could you confirm you have updated your apache config? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #48 from Mirko Tietgen --- I tried this, and I see the scripts having version numbers, but they are part of the file name and so they all throw 404s. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #47 from Jonathan Druart --- (In reply to Jonathan Druart from comment #46) > Created attachment 48742 [details] > script to update tt & inc files Usage: perl kv.pl **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #46 from Jonathan Druart --- Created attachment 48742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48742&action=edit script to update tt & inc files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #45 from Jonathan Druart --- Patches rebased (it was a nightmare...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #39 from Jonathan Druart --- Created attachment 48736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48736&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #41 from Jonathan Druart --- Created attachment 48738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48738&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #40 from Jonathan Druart --- Created attachment 48737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48737&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #43 from Jonathan Druart --- Created attachment 48740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48740&action=edit Bug 12904 [Followup] - Add to Intranet for Dev Install I managed to miss the intranet vhost directive first time around.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #44 from Jonathan Druart --- Created attachment 48741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48741&action=edit Bug 12904: Update new occurrences of .js|.css This has been generated using the script attached to the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #42 from Jonathan Druart --- Created attachment 48739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48739&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What|Removed |Added Attachment #33323|0 |1 is obsolete|| Attachment #33324|0 |1 is obsolete|| Attachment #33325|0 |1 is obsolete|| Attachment #33326|0 |1 is obsolete|| Attachment #33327|0 |1 is obsolete|| Attachment #33328|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 48735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48735&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||kyle.m.h...@gmail.com --- Comment #37 from Kyle M Hall --- Doesn't apply. I'd *really* like to sign off on this. Martin, can you rebase? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #36 from Olli-Antti Kivilahti --- What a great idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/