https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Master|Pushed to Stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #27 from Jonathan Druart
---
Created attachment 79623
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79623=edit
Bug 13272: (follow-up) fix concerns from comment #5
Correct the two issues I pointed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #28 from Jonathan Druart
---
Created attachment 79624
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79624=edit
Bug 13272: (follow-up) Replace tabs with spaces
Cleaned up whitespace issues tab vs.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #29 from Jonathan Druart
---
Created attachment 79625
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79625=edit
Bug 13272: (follow-up) add missing type="text"
This addresses comment #13.
This also
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Jonathan Druart changed:
What|Removed |Added
Attachment #79593|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #23 from Owen Leonard ---
Created attachment 79594
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79594=edit
Bug 13272: Followup on comment #5
Correct the two issues I pointed out.
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #24 from Owen Leonard ---
Created attachment 79595
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79595=edit
Bug 13272: Followup on tab issues
Cleaned up whitespace issues tab vs. space in template.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #25 from Owen Leonard ---
Created attachment 79596
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79596=edit
Bug 13272: Follow up add missing type="text"
This addresses comment #13.
This also applies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Attachment #79162|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #21 from M. Tompsett ---
(In reply to Christopher Brannon from comment #20)
> (In reply to M. Tompsett from comment #19)
> > Sorry if I stepped on anyone's toes.
>
> I was trying to figure out what was going on, since I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Christopher Brannon changed:
What|Removed |Added
Assignee|cbran...@cdalibrary.org |mtomp...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #20 from Christopher Brannon ---
(In reply to M. Tompsett from comment #19)
> Sorry if I stepped on anyone's toes.
I was trying to figure out what was going on, since I was working on this. :)
I'm just going to assign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #19 from M. Tompsett ---
Sorry if I stepped on anyone's toes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
Attachment #79333|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #17 from M. Tompsett ---
Created attachment 79333
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79333=edit
Bug 13272: Follow-up adding other missing types
barcodes are clearly type="text".
datepicker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #16 from Christopher Brannon ---
I will assign it to myself then. Thanks for getting back to me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Christopher Brannon changed:
What|Removed |Added
Assignee|oleon...@myacpl.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #15 from Owen Leonard ---
I didn't claim it. I'm the default assignee for the template component. Since
it was never marked "assigned" to anyone it was free for the taking.
As a rule, though, you should assign bugs to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #14 from Christopher Brannon ---
Owen, I owe you an apology. I know I posted the bug, but I just noticed you
had claimed this one. I didn't mean to hijack this. Do you want to continue
with it, or do you want me to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #12 from Owen Leonard ---
Created attachment 79164
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79164=edit
Bug 13272: Followup on tab issues
Cleaned up whitespace issues tab vs. space in template.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Attachment #79018|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #11 from Owen Leonard ---
Created attachment 79163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79163=edit
Bug 13272: Followup on comment #5
Correct the two issues I pointed out.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #9 from M. Tompsett ---
Created attachment 79123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79123=edit
Bug 13272: Followup on tab issues
Cleaned up whitespace issues tab vs. space in template.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #7 from M. Tompsett ---
Created attachment 79120
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79120=edit
Bug 13272: Followup on comment #5
Correct the two issues I pointed out.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #6 from Owen Leonard ---
(In reply to M. Tompsett from comment #5)
> Oops... type="text" /> -- Though I don't think it is necessary (HTML5 vs XML
> thing, I believe)
FYI, Current practice is to follow XHTML rules for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #5 from M. Tompsett ---
Comment on attachment 79018
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79018
Bug 13272: Adds type="text" to inputs missing it
Review of attachment 79018:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #4 from Christopher Brannon ---
Sorry, didn't include the test plan.
TEST PLAN
1) Install the patch.
2) Track the changes in the patch and confirm that the change doesn't alter the
behavior of the box or page.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #3 from Christopher Brannon ---
Comment on attachment 79018
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79018
Bug 13272: Adds type="text" to inputs missing it
>From
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Christopher Brannon changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
--- Comment #2 from Christopher Brannon ---
Created attachment 79018
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79018=edit
Bug 13272: Adds type="text" to inputs missing it
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Component|Staff Client|Templates
45 matches
Mail list logo