[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #19 from Fridolin SOMERS --- I prefer not to impact 17.11.x database structure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #18 from Fridolin SOMERS --- Pushed to 18.05.x for 18.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #17 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22368 CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy changed: What|Removed |Added Attachment #85138|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy changed: What|Removed |Added Attachment #83509|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 85155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85155=edit Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted Signed-off-by: Nazlı Çetin Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy changed: What|Removed |Added QA Contact|alex.arn...@biblibre.com|m.de.r...@rijksmuseum.nl CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #15 from Marcel de Rooy --- Created attachment 85157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85157=edit Bug 13515: Fix constraint name before deleting it Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Marcel de Rooy changed: What|Removed |Added Attachment #83510|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 85156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85156=edit Bug 13515: Add unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #12 from Jonathan Druart --- Created attachment 85138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85138=edit Bug 13515: Fix contrainst name before deleting it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #11 from Alex Arnaud --- (In reply to Nick Clemens from comment #10) > The update doe snot appear to be idempotent - can you check the condition? > Yep. Constraint nameis wrong in foreign_key_exists call. Need a follow-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- The update doe snot appear to be idempotent - can you check the condition? The tests seem to cover the basic case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #9 from Alex Arnaud --- QA is ok for the patch. I'd like a second QA point of view for the unit tests i wrote. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Attachment #83508|0 |1 is obsolete|| --- Comment #8 from Alex Arnaud --- Created attachment 83510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83510=edit Bug 13515: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added Attachment #83463|0 |1 is obsolete|| --- Comment #7 from Alex Arnaud --- Created attachment 83509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83509=edit Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted Signed-off-by: Nazlı Çetin Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #6 from Alex Arnaud --- Created attachment 83508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83508=edit Bug 13515: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Devinim changed: What|Removed |Added Attachment #83367|0 |1 is obsolete|| --- Comment #5 from Devinim --- Created attachment 83463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83463=edit Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #4 from Jonathan Druart --- This will need tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #3 from Jonathan Druart --- Created attachment 83367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83367=edit Bug 13515: Add a foreign key constraint to messages.borrowernumber This patch adds a missing foreign key constraint to mesages.borrowernumber. To create it sucessfully the entries from the messages table that are not linked with an existing patron will be removed. Test plan: 0/ Do not apply the patch 1/ Add messages to different patrons 2/ Delete one of the patron's record 3/ Have a look at the messages table and notice that the messages for the deleted patron's record still appear 4/ Apply the patch and execute the update DB entry 5/ Have a look again at the messages table and notice that the messages for the deleted patron's record have been removed 6/ Delete a patron that have messages 7/ Notice that now the messages are deleted when the patron's record is deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Katrin Fischer changed: What|Removed |Added Severity|normal |major --- Comment #2 from Katrin Fischer --- Upping severity a bit - keeping potential sensitive data about patrons with no way to delete them aside from SQL is not good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Axelle Aix-Marseille Universitéchanged: What|Removed |Added CC||axelle.clari...@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Katrin Fischerchanged: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #1 from Katrin Fischer --- *** Bug 19699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Blocks||5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Tom Misilochanged: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/