[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #15 from Jonathan Druart --- Thanks Frédéric for you reactivity! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Jonathan Druart changed: What|Removed |Added Attachment #40269|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 40313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40313&action=edit Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Frédéric Demians changed: What|Removed |Added Attachment #39772|0 |1 is obsolete|| --- Comment #13 from Frédéric Demians --- Created attachment 40269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40269&action=edit Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904
--- Comment #12 from Jonathan Druart ---
commit c4095f55ad98cad41a546654fdc8829110599575
Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt
-
[% resul.title |html %]<
-[% resul.author %]
-[% IF (
resul.publishercode ) %]- [% resul.publishercode %][% END %]
-[% IF ( resul.place ) %] ;
[% resul.place %][% END %]
-[% IF ( resul.pages ) %] -
[% resul.pages %][% END %]
-[% IF ( resul.notes ) %] :
[% resul.notes %][% END %]
-[% IF ( resul.size ) %] ;
[% resul.size %][% END %]
+
[% resul.title |html %]<
+[% resul.author |html
%]
+[% IF (
resul.publishercode ) %]- [% resul.publishercode |html %][% END %]
+[% IF ( resul.place ) %] ;
[% resul.place |html %][% END %]
+[% IF ( resul.pages ) %] -
[% resul.pages |html %][% END %]
+[% IF ( resul.notes ) %] :
[% resul.notes |html %][% END %]
+[% IF ( resul.item('size')
) %] ; [% resul.item('size') |html %][% END %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #11 from Frédéric Demians --- (In reply to Jonathan Druart from comment #10) > Comment on attachment 39772 [details] [review] > [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield > data > > Review of attachment 39772 [details] [review]: > - > > ::: > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ > unimarc_field_4XX.tt > @@ +174,5 @@ > > +[% IF ( > > resul.publishercode ) %]- [% resul.publishercode %][% END %] > > +[% IF ( resul.place ) > > %] ; [% resul.place %][% END %] > > +[% IF ( resul.pages ) > > %] - [% resul.pages %][% END %] > > +[% IF ( resul.notes ) > > %] : [% resul.notes %][% END %] > > +[% IF ( resul.size ) > > %] ; [% resul.size %][% END %] > > These lines remove the changes introduced by bug 13129, is it expected? Do you mean the last line? => result.size -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #10 from Jonathan Druart --- Comment on attachment 39772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39772 [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data Review of attachment 39772: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13904&attachment=39772) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt @@ +174,5 @@ > +[% IF ( > resul.publishercode ) %]- [% resul.publishercode %][% END %] > +[% IF ( resul.place ) %] > ; [% resul.place %][% END %] > +[% IF ( resul.pages ) %] > - [% resul.pages %][% END %] > +[% IF ( resul.notes ) %] > : [% resul.notes %][% END %] > +[% IF ( resul.size ) %] > ; [% resul.size %][% END %] These lines remove the changes introduced by bug 13129, is it expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #39539|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 39772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39772&action=edit [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Frédéric Demians changed: What|Removed |Added Attachment #39241|0 |1 is obsolete|| --- Comment #8 from Frédéric Demians --- Created attachment 39539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39539&action=edit Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Frédéric Demians changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #7 from Jonathan Druart --- So please provide a valid test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #6 from Frédéric Demians --- > From the test plan: > "- You get a result list, with two issues: > 1. $h & $i aren't displayed" > Is this wrong? If not, I don't understand how I could see them displayed. It's wrong. See my above comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #5 from Jonathan Druart --- (In reply to Frédéric Demians from comment #4) > (In reply to Jonathan Druart from comment #3) > > Frédéric, > > I get the link, but not 200$h$i > > Could you please detail where volume is mapped with them? > > It isn't... And, as you know, it can't be mapped to 2 distinct biblio record > subfields. I just tried to understand your patch :) It only adds "resul.volume" to the TT, and I don't see any places where 200$h or $i could be assigned to resul.volume. From the test plan: "- You get a result list, with two issues: 1. $h & $i aren't displayed" Is this wrong? If not, I don't understand how I could see them displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #4 from Frédéric Demians --- (In reply to Jonathan Druart from comment #3) > Frédéric, > I get the link, but not 200$h$i > Could you please detail where volume is mapped with them? It isn't... And, as you know, it can't be mapped to 2 distinct biblio record subfields. With this patch, biblioitems.volume is displayed after title. The goal is to disambiguate search results. By default, biblioitems.volume is mapped to 200$e (complément du titre). But in some installations, it can be mapped to $h or $i at convenience. If you think it's limiting, I could propose a counter patch displaying $a, $h, and $i. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart --- Frédéric, I get the link, but not 200$h$i Could you please detail where volume is mapped with them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #37212|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 39241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39241&action=edit [SIGNED-OFF] Bug 13904: unimarc_field_4XX plugin doesn't display volume info, neither link to biblio When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel I can see 200$h and 200$i on search results, but not on result list from 4XX plugin, but they are copied into 46X. The title is now a link, so I think could be my example record. At last one of the problems is fixed :) No koha-qa errors Tested on UNIMARC setup, french files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Frédéric Demians changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Frédéric Demians changed: What|Removed |Added Assignee|gmcha...@gmail.com |frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #1 from Frédéric Demians --- Created attachment 37212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37212&action=edit Bug 13904 unimarc_field_4XX plugin doesn't display volume info, neither link to biblio When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
