[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #41

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #39 from Kyle M Hall --- I'm wondering if this is really necessary given the solution provided by Josef. If we implement this, it means adding yet another database query that will only be used in a few cases. That

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #38 from Emmi Takkinen --- (In reply to Salman Ali from comment #37) > Test needs fixing but patch is working Do mean tests aren't working? At least for me running prove t/db_dependent/Letters.t returns "All tests

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Salman Ali changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Salman Ali changed: What|Removed |Added Attachment #116635|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #106624|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #106623|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #106194|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #106193|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #106192|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Mazen Khallaf changed: What|Removed |Added CC||mazen.i.khal...@gmail.com

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #28 from Emmi Takkinen --- Created attachment 106624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106624=edit Bug 13961: Check that borrowernumber isn't a reference Some SendAlerts() tests in

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #27 from Emmi Takkinen --- Created attachment 106623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106623=edit Bug 13961: Fix QA issues This patch fixes following QA issues: FAIL C4/Letters.pm

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Katrin Fischer changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes changed: What|Removed |Added Attachment #98821|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes changed: What|Removed |Added Attachment #98820|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 ByWater Sandboxes changed: What|Removed |Added Attachment #98819|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Assignee|j.kylm...@gmail.com |emmi.takki...@outlook.com

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #21 from Emmi Takkinen --- Created attachment 98820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98820=edit Bug 13961: Add currency format handling Added currency format handling proposed in

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #22 from Emmi Takkinen --- Created attachment 98821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98821=edit Bug 13961: Add unit test -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen changed: What|Removed |Added Attachment #50517|0 |1 is obsolete|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #18 from Katrin Fischer --- Btw: you can use and leave the <> out too! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #17 from Katrin Fischer --- Hi, this bug is about a different feature, so it would be good to open a separate bug report, maybe with a 'see also' link to this one if you want to. We have been

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Ray Delahunty changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #15 from Katrin Fischer --- I was also looking into this and have another note: Please take a look in Overdues.pm at how items.fine is formatted: $item->{'fine'} =

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #13 from Katrin Fischer --- Testing this on top of bug 16378 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Attachment #42089|0 |1 is

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Attachment #41872|0 |1 is

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 jdem...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Zeno Tajoli changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Zeno Tajoli changed: What|Removed |Added CC|z.taj...@cineca.it | -- You

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #6 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Marc Véron from comment #5) Works as expected. However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). I don't see any in that line. --

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #9 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Joonas Kylmälä from comment #8) (In reply to Marc Véron from comment #7) Created attachment 42077 [details] Screenshot from diff view - white chars in empty

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #8 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Marc Véron from comment #7) Created attachment 42077 [details] Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #7 from Marc Véron ve...@veron.ch --- Created attachment 42077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42077action=edit Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #10 from Marc Véron ve...@veron.ch --- Created attachment 42089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089action=edit [Follow-up] Remove whitespace from line 648 in C4/Letters.pm White space in

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #42077|0 |1 is

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41872 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41872action=edit Bug 13961: Option to include patron's total amount of fines in

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Katrin Fischer from comment #2) Just looking for a new placeholder. We got items.fine to display the fine per item. And we have something like today to display

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Just looking for a new placeholder. We got items.fine to display the fine per item. And we have something like today to display today's date. The suggestion would be to

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Cab Vinton direc...@plaistowlibrary.com changed: What|Removed |Added CC|