https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Blocks||21654
--- Comment #98 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #97 from Jonathan Druart
---
There is one occurrence left:
C4/Installer.pm:push @fnames, C4::Context->config('intranetdir') .
"/installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql";
Please fix!
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
J Schmidt changed:
What|Removed |Added
CC||jschm...@switchinc.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
CC||a...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jesse Weaver changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52883|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52876|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52843|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52844|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52841|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52839|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52842|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52838|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52840|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52836|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Attachment #52835|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #82 from Kyle M Hall ---
(In reply to Tomás Cohen Arazi from comment #81)
> (In reply to Jonathan Druart from comment #80)
> > Could I get this follow-up before passing it?
> > As Kyle suggest, it may be better to use
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #81 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #80)
> Could I get this follow-up before passing it?
> As Kyle suggest, it may be better to use
> Koha::Circulation::Rules::LostItemFeeRule instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #80 from Jonathan Druart
---
Could I get this follow-up before passing it?
As Kyle suggest, it may be better to use
Koha::Circulation::Rules::LostItemFeeRule instead of
Koha::Circulation::Rules::RefundLostItemFeeRule but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Kyle M Hall changed:
What|Removed |Added
Whiteboard||Note to RM/Kyle - Change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #79 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #77)
> I have a small request, could we move Koha::RefundLostItemFeeRule to a more
> refined namespace? I think it would be better long term. I'm thinki
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #78 from Tomás Cohen Arazi ---
Created attachment 52894
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52894&action=edit
Bug 14048: (QA followup) Default to 1 if no default rule
This patch answers Jona
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #77 from Kyle M Hall ---
I have a small request, could we move Koha::RefundLostItemFeeRule to a more
refined namespace? I think it would be better long term. I'm thinking
Koha::Circulation::Rules::LostItemFeeRule but am o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #76 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #73)
> (In reply to Jonathan Druart from comment #72)
> > I have squashed the patches for the review, so I won't use the splinter:
> >
> > 1/ my $
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #75 from Jonathan Druart
---
Created attachment 52883
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52883&action=edit
Bug 14048: Use mock_preference in tests
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #74 from Tomás Cohen Arazi ---
Created attachment 52876
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52876&action=edit
Bug 14048: (QA folloup) C4::Context->preference should be used
Signed-off-by: To
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #73 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #72)
> I have squashed the patches for the review, so I won't use the splinter:
>
> 1/ my $item_holding_branch = $item->{ holdingbranch };
> => wou
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #72
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52756|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52757|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52753|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52755|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52754|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52752|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52750|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52751|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52667|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52664|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52665|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52666|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52662|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52663|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52659|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52660|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nicole C. Engard changed:
What|Removed |Added
Attachment #52661|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52482|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52658|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52451|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52450|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52449|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52448|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52447|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52445|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Attachment #52444|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #39 from Tomás Cohen Arazi ---
Created attachment 52658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52658&action=edit
Bug 14048: (followup) Use the original holding branch
This patch picks the item'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #38 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #37 from Tomás Cohen Arazi ---
(In reply to Nick Clemens from comment #35)
> Tested well for syspref RefundLostOnReturnControl with values "homebranch"
> and "check-in library"
>
> When using "item holding branch" I rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #36 from Tomás Cohen Arazi ---
Created attachment 52482
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52482&action=edit
Bug 14048: (QA followup) Fix typo on syspref value
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #34 from Tomás Cohen Arazi ---
Created attachment 52451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52451&action=edit
Bug 14048: (QA followup) Update syspref name for HEA
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #33 from Tomás Cohen Arazi ---
Created attachment 52450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52450&action=edit
Bug 14048 [QA Followup] - Delete only the removed system preference
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #32 from Tomás Cohen Arazi ---
Created attachment 52449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52449&action=edit
Bug 14048: Add syspref and atomic update
This patch introduces the changes to th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #31 from Tomás Cohen Arazi ---
Created attachment 52448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52448&action=edit
Bug 14048: [QA Followup]
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 52446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52446&action=edit
Bug 14048: Add a refund rules setting form in smart-rules
This patch introduces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #30 from Tomás Cohen Arazi ---
Created attachment 52447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52447&action=edit
Bug 14048: Hook new rules into C4::Circulation
This patch makes AddIssue and Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #28 from Tomás Cohen Arazi ---
Created attachment 52445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52445&action=edit
Bug 14048: Unit tests
This patch introduces unit tests for the feature.
To test:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #27 from Tomás Cohen Arazi ---
Created attachment 52444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52444&action=edit
Bug 14048: Add RefundLostItemFeeRule table and classes
This patch introduces new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52291|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52292|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52287|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52293|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52286|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52290|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52289|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #26 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #25)
> Created attachment 52306 [details] [review]
> Bug 14048 [QA Followup] - Delete only the removed system preference
Hehe, I don't know why I didn'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #25 from Kyle M Hall ---
Created attachment 52306
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52306&action=edit
Bug 14048 [QA Followup] - Delete only the removed system preference
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52288|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #20 from Tomás Cohen Arazi ---
Created attachment 52289
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52289&action=edit
Bug 14048: Add a refund rules setting form in smart-rules
This patch introduces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #17 from Tomás Cohen Arazi ---
Created attachment 52286
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52286&action=edit
Bug 14048: Add RefundLostItemFeeRule table and classes
This patch introduces new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #18 from Tomás Cohen Arazi ---
Created attachment 52287
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52287&action=edit
Bug 14048: Unit tests
This patch introduces unit tests for the feature.
To test:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #22 from Tomás Cohen Arazi ---
Created attachment 52291
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52291&action=edit
Bug 14048: [QA Followup]
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #21 from Tomás Cohen Arazi ---
Created attachment 52290
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52290&action=edit
Bug 14048: Hook new rules into C4::Circulation
This patch makes AddIssue and Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 52292
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52292&action=edit
Bug 14048: (QA followup) Fix for TooMany.t
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
--- Comment #19 from Tomás Cohen Arazi ---
Created attachment 52288
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52288&action=edit
Bug 14048: Add syspref and atomic update
This patch introduces the changes to th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #52019|0 |1
is obsolete|
1 - 100 of 132 matches
Mail list logo
