[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Tomás Cohen Arazichanged: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #17 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #13 from Kyle M Hall--- Created attachment 42341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42341=edit Bug 14297 [QA Followup] - Remove unnecessary line -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hallchanged: What|Removed |Added Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druartchanged: What|Removed |Added Attachment #42341|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 42350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42350=edit Bug 14297 [QA Followup] - Remove unnecessary line Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druartchanged: What|Removed |Added Attachment #42028|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 42348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42348=edit Bug 14297 - Unit Tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druartchanged: What|Removed |Added Attachment #42029|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 42349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42349=edit Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #12 from Jonathan Druart--- Shouldn't you change the version to master (instead of 3.18)?; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #11 from Jonathan Druart--- Comment on attachment 42029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42029 Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch Review of attachment 42029: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14297=42029) - ::: C4/HoldsQueue.pm @@ +492,5 @@ > +foreach my $branch (@$pull_branches) { > +my $holding_branch_items = $items_by_branch{$branch} > + or next; > + > +$holdingbranch ||= $branch; I am not sure to understand this line, in which case it's needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #42026|0 |1 is obsolete|| Attachment #42027|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 42028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42028action=edit Bug 14297 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 42029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42029action=edit Bug 14297 - Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake nbl...@masslibsystem.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41110|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 42026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42026action=edit Bug 14297 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 42027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42027action=edit Bug 14297 - Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake nbl...@masslibsystem.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Jonathan Druart from comment #5) Any chances to get some tests to highlight this change? I'll see what I can do! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Any chances to get some tests to highlight this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #39668|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41110action=edit [SIGNED-OFF] Bug 14297 - Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake nbl...@masslibsystem.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Christopher Bloomfield c_bloomfie...@hotmail.com changed: What|Removed |Added CC||c_bloomfie...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39668 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39668action=edit Bug 14297 - Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Video Demonstration: http://www.screencast.com/users/kylemhall/folders/Default/media/efa52594-e81b-4672-aa57-e59f8952ea6e -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- It appears that my audio narration in the video did not record, but it's pretty self explanatory without it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/